From unknown Sat Aug 09 13:06:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#76683 <76683@debbugs.gnu.org> To: bug#76683 <76683@debbugs.gnu.org> Subject: Status: [PATCH] Eglot: Implement additionalPropertiesSupport for showMessage Reply-To: bug#76683 <76683@debbugs.gnu.org> Date: Sat, 09 Aug 2025 20:06:21 +0000 retitle 76683 [PATCH] Eglot: Implement additionalPropertiesSupport for show= Message reassign 76683 emacs submitter 76683 Felician Nemeth severity 76683 normal tag 76683 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 02 08:39:37 2025 Received: (at submit) by debbugs.gnu.org; 2 Mar 2025 13:39:37 +0000 Received: from localhost ([127.0.0.1]:56001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tojXd-0002Zu-BG for submit@debbugs.gnu.org; Sun, 02 Mar 2025 08:39:37 -0500 Received: from lists.gnu.org ([2001:470:142::17]:57732) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tojXa-0002ZK-KV for submit@debbugs.gnu.org; Sun, 02 Mar 2025 08:39:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tojXR-00062E-9w for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2025 08:39:26 -0500 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tojXP-00065x-GX for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2025 08:39:25 -0500 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-abf48293ad0so236546766b.0 for ; Sun, 02 Mar 2025 05:39:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740922760; x=1741527560; darn=gnu.org; h=mime-version:face:user-agent:message-id:date:subject:to:from:from :to:cc:subject:date:message-id:reply-to; bh=KDpmDsUZrvUPURjWk3X9LB/6LOudN5VunLTz9aWJ8W0=; b=D4DjfuswHcucqrC/i5KTnqHKILAbo49FrJTWjqvzB9p+DEIsjSbGkItnbRnWKi1Pld zAu+DcJaOYDaIEETvRGj7mHOUFSBrMibw1pnwTBh8k2GWRP2AMCK2Zl0m+3kTsYeSliR kXqUWg2nYNv63/FCRLPPcTN/rl56JPTHMNN6pkfYRlKw15vQyYWbpOQVUmSFOjKAJD6I KxSnxhh8Mqgnqw24D4w9UmcXX43SE178ty7/sqwrmVd+3yCxk2uSuPgbxocn+w6+SlcG 9BQZiqXTVFg7Y8jhhAFUj/9xewZg8wJp3TD9+/ZCw8p9pnrxcxzKk3TD86NpFxrmi8Ss hOFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740922760; x=1741527560; h=mime-version:face:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KDpmDsUZrvUPURjWk3X9LB/6LOudN5VunLTz9aWJ8W0=; b=CCI9IftYEEwRRyoAhKQXIMzWLBdBXb9hWEmCs3Ga5H6jfsi2tguC3ydnQ+q3ubsaCN RFFBppzY8GNg/8ymC9KAtDjklOcwb2/0KC+GGMkfgHYK3Z/Gzt94XuCsqLoOVAArkaHr l5SgqqJvS5V8nvA/I9bPPmKENuSk7jZDIDyPB+KsRa0TZLfvPagaQp3WIYN/Oi75X2Bw PEPitU2S/+xqKqKli51/c6mUt5Ujk66bRD1V67iDWVwsQ8au8ztW9JQsHyAlIvOl/XVf mw/60fteIHMkL0kslo2fRAkTW2QpAd5V/d7W4Km42FMeb4up5DyrQRL51tlWrMzV+z0L 99kA== X-Gm-Message-State: AOJu0YyoNR8bZHX54B+yymTDx27CAhQt97vlz+BfHauX/QLTkfhTZXbJ hIqzzUt8dYI+2vOqAPyVDYQ8QW8g0nYZYMxVw3fdaXdBceayGp4yDVhSjw== X-Gm-Gg: ASbGnctRybBpb64dlWVtJdy86Ewy+pyiMugYRD9yvQg9YbzKZGpn3fb98+YFssyreMz IueAEpwYxS2SFcUVAX14XxCfHkDxcKX2ofbNS2zMq2pQGQEIHo4Pi2ZLG+K4Q2g+qwHSTcLQCXE Kp34wU6xiZxTb8HBwXI3c+90ziBMfifawxI/JzoUuSVrZonaAg7TGiSwdxNajryCjp9jWn1d2pK LORc5SkLUf9f9AdzhpzUG1xIxH5yiCgwJFmY+1vIPq0N3ghcjsJ+xDP7HjUjdEvnwZt1JIe3mab L/eplC+XoUckDFFSV3MjGuG16NcUY/P5mkVodBAAT2htcEuvmlZoggGTkKQlU4lDNQB0ZlsY8kH jRFvpHi46Bvbb7S0V7i3fE+RypA== X-Google-Smtp-Source: AGHT+IGv6dRjtg7KWTw+Fm5gphnW3VSmFEzjqB5NHpCtlPphbLtezCjmq1zSR5tqocIeiYbc1BQ2mA== X-Received: by 2002:a17:907:7faa:b0:abf:74d6:e2a5 with SMTP id a640c23a62f3a-abf74d6e404mr152813166b.6.1740922760175; Sun, 02 Mar 2025 05:39:20 -0800 (PST) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.one.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf7a3ea634sm23505366b.174.2025.03.02.05.39.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Mar 2025 05:39:19 -0800 (PST) From: Felician Nemeth To: bug-gnu-emacs@gnu.org Subject: [PATCH] Eglot: Implement additionalPropertiesSupport for showMessage X-Debbugs-Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 02 Mar 2025 14:39:18 +0100 Message-ID: <87cyez1ri1.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUMBwgHAgMFAAGPjY7/ //80MDHq6eqJt3pKAAABr0lEQVQ4jX2UzZKDIAzHqR177q7TPbtx2HMr6guQcrbY9txZ0fd/hA0f onXazcEJ/CD8E4Js8/HS9mwjXtqeMRxHXJkakTEm4b4GPVQW8PU8ov4fQCqeThlF60MBWdo1IXzd 2nEEZE7CEAZLwI0N/gJAhTj7ESQAX4gPgO8lyI+cvgViSVPlNomAj2M9gW40eg7VWY3cATjUcyiO Z+i03cFruGLYoUR7VyU3HihdmCEVhoDN65FXkpbSxkomOzsTQN/gySaodGb9Gdi1oSRXP46gdBWh LcUKJNdeGCWac74GKakmne0aHCFvyqJPYLsCFAVlhRTvGdzMdLHqtgRyUulyXIAH7CYQ3AB0Nody JQhAkq/qtOnbjhxdzYDkXPxlH5y4WdUAeUcX1NVJ6GR7UQEYPGWoAnA36OQNn5lRRp38vHTAp9Br LoTmvlPPDoRCKzpjG1SXT89AaT5l456BamJuMcs+NIOMzJ/s5dI6yUVcrARlruwOebfdv6gunTn4 ww3+QjGBEn5suVyLHoSGvAqREuDLN+iqZ+VcFg+HBbsJUU9+FZthbez9T+bdb+kPv2Ls6ct3hTkA AAAASUVORK5CYII= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=felician.nemeth@gmail.com; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi João, This small patch implements a harmless feature introduced in LSP version 3.16: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#window_showMessageRequest Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (felician.nemeth[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.1 URIBL_SBL_A Contains URL's A record listed in the Spamhaus SBL blocklist [URIs: microsoft.github.io] 0.6 URIBL_SBL Contains an URL's NS IP listed in the Spamhaus SBL blocklist [URIs: microsoft.github.io] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Jo=C3=A3o, This small patch implements a harmless feature introduced in LSP version 3.16: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.1= 8/specification/#window_showMessageRequest It allows me to implement a rust-analyzer feautre in a simple, stateless manner. Thank you, Felici=C3=A1n --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Eglot-Implement-additionalPropertiesSupport-for-show.patch >From 2829d1e98336d5588d2552b27d169f1674a99874 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felici=C3=A1n=20N=C3=A9meth?= Date: Sun, 2 Mar 2025 14:18:48 +0100 Subject: [PATCH] Eglot: Implement additionalPropertiesSupport for showMessage This feature was introduced in LSP v3.16. https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#window_showMessageRequest * lisp/progmodes/eglot.el (eglot-client-capabilities): Set window/showMessage/messageActionItem/additionalPropertiesSupport to t. (eglot-handle-request window/showMessageRequest): Return the whole selected ActionItem, not just its title. --- lisp/progmodes/eglot.el | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 1920d835cc3..c7e0a83f04e 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -1089,6 +1089,8 @@ eglot-client-capabilities [,@(mapcar #'car eglot--tag-faces)]))) :window `(:showDocument (:support t) + :showMessage (:messageActionItem + (:additionalPropertiesSupport t)) :workDoneProgress ,(if eglot-report-progress t :json-false)) :general (list :positionEncodings ["utf-32" "utf-8" "utf-16"]) :experimental eglot--{}))) @@ -2594,17 +2596,16 @@ eglot-handle-request (_server (_method (eql window/showMessageRequest)) &key type message actions &allow-other-keys) "Handle server request window/showMessageRequest." - (let* ((actions (append actions nil)) ;; gh#627 + (let* ((actions (mapcar (lambda (a) (cons (plist-get a :title) a)) actions)) (label (completing-read (concat (format (propertize "[eglot] Server reports (type=%s): %s" 'face (if (or (not type) (<= type 1)) 'error)) type message) "\nChoose an option: ") - (or (mapcar (lambda (obj) (plist-get obj :title)) actions) - '("OK")) - nil t (plist-get (elt actions 0) :title)))) - (if label `(:title ,label) :null))) + (or actions '("OK")) + nil t (caar actions)))) + (if label (cdr (assoc label actions)) :null))) (cl-defmethod eglot-handle-notification (_server (_method (eql window/logMessage)) &key _type _message) -- 2.39.5 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 02 08:59:46 2025 Received: (at 76683) by debbugs.gnu.org; 2 Mar 2025 13:59:46 +0000 Received: from localhost ([127.0.0.1]:56252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tojr8-0007To-3Z for submit@debbugs.gnu.org; Sun, 02 Mar 2025 08:59:46 -0500 Received: from mail-oo1-xc32.google.com ([2607:f8b0:4864:20::c32]:47117) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tojr5-0007TC-0x for 76683@debbugs.gnu.org; Sun, 02 Mar 2025 08:59:43 -0500 Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-5fcd665af4eso863074eaf.2 for <76683@debbugs.gnu.org>; Sun, 02 Mar 2025 05:59:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740923977; x=1741528777; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fTjpsqbp4bgJc0TrZ9XX5aLsF+u+mnbUUtsEGwvaQfI=; b=E1MQKOo0qJrP0qgz75J1dbTOeGzTyFJx0AWnHJ1V319FnFwhkJIutJrTYCvb30V6+i Rv9OjVG8zbpukr+2f5/ZidqYCyDtn4hmS2E5gJXcursatuWa9QFAXrE+3SccoYpD2K3G um8TZ2aHs+ZNqSgUCINvBAEiB1R/yOX7g1AVZtZ1QxmgKQ9sxhzcx256GgNDvwN5KLHx MstyBy14e9dA1WnmVjJSpdbEkzAG3M//Zn04B5mC8ouCdEZRNaxH5t0suUHdEvSJrRal rKqgk7sr5NKbkUQxJitnIceVLezto3xXSaRg1U7bmT0mlQsNDJNOZJ4rrqxEhxxyZ3gN LGcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740923977; x=1741528777; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fTjpsqbp4bgJc0TrZ9XX5aLsF+u+mnbUUtsEGwvaQfI=; b=wSL8WW5UQJGjJH0sOKwp8flgBmpxSxGGS/G3bNmCvgk+H/i3T87gj7TH7TQQFJa3lD uyCJ/2iAsY4IT2/19RAyirSO/Xx3aT5VwnaLkiIHGwrUXqWoy2JoWb4a5tZHNonqZlvG qGWewQS8NZZaY2A9T6+cDccHLSJavC0YLnmztKinlZ0CDtVtw9nM0f1r93XfcOH6urd5 PsFlRGNfbgdhndiRjZtUPaWWLab8lEUqZ+OsBFMLeaFlID5uSaMW486Sx0aywMZHZeQ7 j+R7crD6AHmqy1c3IZ7Vht1YrN+rgg5See0x0hzZ5WKVE+/xyzREmkizqI2T27Ul6ReJ iEOg== X-Gm-Message-State: AOJu0YwXzsS7r21v4UZRwx0Vltzm/YfNYXFFhB5+TyFWdc4jcqHsnnSk NbW1DTgLE7Wai4MIrcOURXNAHyfqM/P136QG5I9gue7LK7sksNKy2uWypGZtwco3zyO5mWhCgpz Y+QH/nADEX1TYGJgEZyzfEezffyo= X-Gm-Gg: ASbGnctOAeULd/9zyuIOtRX4Hiu0xAcbw5UfwYhTlhC/8UenNVyVKsxTSSRFclhh97+ CWQ6OcfDOAcgvUCVOLCL7mHMxvPGKQ8zWvZTJxqCIvr2qRc+IxOa+RXKcKjaWfGCZbcwj3T9guF rR00ZkzJgIg3S0GwhxnWpGbGQMrA== X-Google-Smtp-Source: AGHT+IEm5VBfPmHuZfA8lE9bXk25wbo7x+BsD1Oro1HIWspn3eQSzYGOyFGriiO4tW47rbf+O4lUhk7aGhfNyY06m7Q= X-Received: by 2002:a05:6870:6b96:b0:29d:c832:8422 with SMTP id 586e51a60fabf-2c1784454d7mr5434277fac.18.1740923976687; Sun, 02 Mar 2025 05:59:36 -0800 (PST) MIME-Version: 1.0 References: <87cyez1ri1.fsf@betli.tmit.bme.hu> In-Reply-To: <87cyez1ri1.fsf@betli.tmit.bme.hu> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 2 Mar 2025 13:59:44 +0000 X-Gm-Features: AQ5f1JpneDB6m5v6xEJeYXdFUQ8n_oSnqqoA4bu0ko-MztZDN4_FzuYJ30PfqPE Message-ID: Subject: Re: bug#76683: [PATCH] Eglot: Implement additionalPropertiesSupport for showMessage To: Felician Nemeth Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 76683 Cc: 76683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Looks good. Minor comments. * Why did you remove the gh#627 reference? Not relevant anymore? * Could eglot--lambda be used for simplicity (I know it wasn't used before) * Are you 100% we'll return an 'equal' object for servers that don't make use of this feature? * In the original version it was obvious the structure returned, now not so much. Maybe a very short comment showing what the typical object looks like. After evaluating this, and doing changes (if any), feel free to push. Jo=C3=A3o On Sun, Mar 2, 2025 at 1:40=E2=80=AFPM Felician Nemeth wrote: > > Hi Jo=C3=A3o, > > This small patch implements a harmless feature introduced in LSP version > 3.16: > https://microsoft.github.io/language-server-protocol/specifications/lsp/3= .18/specification/#window_showMessageRequest > > It allows me to implement a rust-analyzer feautre in a simple, stateless > manner. > > Thank you, > Felici=C3=A1n > --=20 Jo=C3=A3o T=C3=A1vora From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 02 10:17:04 2025 Received: (at 76683) by debbugs.gnu.org; 2 Mar 2025 15:17:04 +0000 Received: from localhost ([127.0.0.1]:60735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tol3v-0007Mh-Mm for submit@debbugs.gnu.org; Sun, 02 Mar 2025 10:17:04 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:49336) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tol3r-0007Le-K8 for 76683@debbugs.gnu.org; Sun, 02 Mar 2025 10:17:02 -0500 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5e53b3fa7daso721021a12.2 for <76683@debbugs.gnu.org>; Sun, 02 Mar 2025 07:16:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740928612; x=1741533412; darn=debbugs.gnu.org; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/G4BKETI+CwuU9jOdqSexX9Hg4JMFswbVjpwg9Y/yFQ=; b=JBbQ8haIqm80cSw/m4W0Mf1qq75su0ORHtD5C70NF2hENFQGNQTaP78+HWHVwBVqxl T9Ynq9DgPDO/9g9G5d5vT94IoWlLAU7LROQC+7uF4cG4/X+W47n/gueRmmyDc0fF7iZF lGuvL4vg7wjl4lSjSiEVJFjnCBiCW52u0As9pH/14EGh6cGKMH7QJwGnF2KQRV6cRcD9 4B1eOvpXzAgF7FoOTGtWkXL+4O6eRjhgDrVCdMC8LYB9eW2BFBK8hpr7c9yzoBtd+E3W Lew/z1v4MXpf/W7LMRMhwbbgU2xlfgYy8k739g5ivz4VAHAfMt7DJaBHx4k+GaqND9yQ cACQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740928612; x=1741533412; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/G4BKETI+CwuU9jOdqSexX9Hg4JMFswbVjpwg9Y/yFQ=; b=r2pLLytAemnt2i+TCUWX9DwmP1f2EtK+LBH7WcchurZYsyYkWxMlUWCbtz/3Ba5CLS D0ZdInXMHPL0Vqqd+m6dMOfHj+sC6xK5pUNykjnPn3oajugtX5QOkQ6zwX8zyqN+vU6F 6HadXrOHtX76xNnI4VpbOzPTHmMcro3Efoe/uc0gd1a4c3Rwkdt5+ZEhpDpHLBQMbgg1 gUH4t6GU9ZB7Xh4icQ0zIoAPrKD7MfjWYApOPs8/+pFSupe1sNvQU5MJ9aCWhCXLQ2aa kBZ1OFMh/hulTzx5WVYETBlwWYvhdgaf535ig3Oe6WeqmrDSA7IEV+ze+GXQSeD/wVLg F63g== X-Gm-Message-State: AOJu0YzVPXfFwqcN3tm0Gl+wumxfS7YZWJnFUJngRMoU0H5emUY3A5Oy VN1lmdzMAoQBk/oF/UhuQgxH2z/xY6rU3EwjY0GNjulQ9G8cMN9QCdK9kg== X-Gm-Gg: ASbGnct4z3m5NFbkArClv/h4ZLvS2DOTg7beKX8h40dwBI94TTiQkKU0vra/20/qJQq ubfO6A44ZFEQ6ll16ddyPDUkAJ4yRuTRS/rFXfeknBud/VEC5qSKIgVTmrVMFeFnf4ubE8fwzdb nOlX31ZLgJsaPSu2X5o0WaxdXQSVFPKP1afMeCK+qhyNIP3u9iv0TeqMhfOKiABTAPHYOrpvyoK ApeKNxmDBkW3rMPTaszs3YS0m9+62KnBP39TUhlpCoT6e34p265y8pFO6Y8aD5z7n+BxfxmUOw/ 8Ub4ApSWiyj27fyceZgvVMiDQjCT++R0VqkvNYzmcLXBcs2TsZMY37YkcRQJpf89NTbpArGHt/c 9xCn1TOl7LCyk1nHRHuDmhp/wZw== X-Google-Smtp-Source: AGHT+IGegtr/jR4E6Ek2s9ZhIFzwVPcBCh3Qts53Vt3c+GtjQO9rAk1w3Xb1+LIokoyPmJezXRfhPg== X-Received: by 2002:a05:6402:5190:b0:5dc:1289:7f1c with SMTP id 4fb4d7f45d1cf-5e4d6b853a7mr12884748a12.29.1740928612169; Sun, 02 Mar 2025 07:16:52 -0800 (PST) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.one.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c43a61d5sm5592872a12.65.2025.03.02.07.16.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Mar 2025 07:16:51 -0800 (PST) From: Felician Nemeth To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#76683: [PATCH] Eglot: Implement additionalPropertiesSupport for showMessage References: <87cyez1ri1.fsf@betli.tmit.bme.hu> Date: Sun, 02 Mar 2025 16:16:50 +0100 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Sun, 2 Mar 2025 13:59:44 +0000") Message-ID: <87tt8bzcm5.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEWOdXElERN7LDLZs6/l 0dDQq6TepMcqAAACW0lEQVQ4jWWSzY7bMAyEaSm6mypylxjkroTRvUW8d9lavf+r7NDOZotWQHzg lyGHP0Sn5ed9qKrLWWIWos9/QJWIeCSywPNTd/AE0LtwFj7A+3WT5PwfeBrQKcsBnkfwVcNySWQr 3i34XN6gRNgis/v4uwSKHCD9lPitB0Aq9BHfHX4cgsI7cJJfLdZg/4bbCzoRmkD9MsagQSBDedZi CgNxkVSJmSOStTBUBKkywEnEoZzbwWj+ACiVJkF6pOpak2PMCqkMYDpaw+gatLR8atMOrB3JGzmm 3rSQo+tkxU+UAbhQSgtslULhsXKk6+IyQ1QTzeQB0MzjlpkCEUCeUdviWrwBcxVqpZjP+v0MYPA0 aq2rvIEZe4GRM0v+9QIB03rsABVSk5y+Mz3LSzExtJLlCCO6dV1uzDQFTBad+gO0TqqL9XE8x4ek +orvYiMJgzC8e+r6TqaPaK6QyqVNvoHtsRrooQ6tTi4vgaSkd8wIikodB3B0iIk58avsDdYNajpS bSKJ+mQnipGszB6zW4lGgsOkKHE2RWVcBpwhaIv3BYIAu3WsnC7YYKLRchp6w8fRGZIWiZuFsVai 7gbcUcJEhiDZ3K1+uzZvBlfaEO8oH4MLu6/hrKVM7QpQcIXJFuC1XjfbfKRxNslk94l9cYcEihV2 HWyNDQAXaLsvnrSyp7HaQhrAn13V6/XW11nh0XINBOEAV+tHK4EvAGNGvEwc0eZw8Vyr56imYEsV sOW9jxm/yb9AH1ufqGMviIK7A0Tc/723oM3tJ4HTOu9gDr3ftbdkxfdjsUv5AqWKwyfCYo5WAAAA AElFTkSuQmCC MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 76683 Cc: 76683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable > * Why did you remove the gh#627 reference? Not relevant anymore? I think the note about gh#627 warned the reader that a "vector to list conversion" was necessary. However, mapcar can work with vectors, so the reference is not relevant anymore. > * Could eglot--lambda be used for simplicity (I know it wasn't used > before) I think it won't be simpler, but it might be easier to understand the intent of the code. However, I don't know how it is possible to rewrite the lambda. How can we access the original object from the body of eglot--lambda? The patch has this: (lambda (a) (cons (plist-get a :title) a)) It should be turned into something like this: (eglot--lambda ((MessageActionItem) title) (cons title orignal-object)) > * Are you 100% we'll return an 'equal' object for servers that don't > make use of this feature? The specification says: "result: the selected MessageActionItem". If the server does not send additional properties, the new version will return what the original one returns: an object with a single title property. So this patch should not cause any trouble to servers following the specification. Although, there is a corner case when the new version gives different result. The original version can return (:title "OK") for an empty action list, which is not in line with the specification. The updated patch returns :null in this case. > * In the original version it was obvious the structure returned, now > not so much. Maybe > a very short comment showing what the typical object looks like. I added a comment and extended the docstring. > After evaluating this, and doing changes (if any), feel free to push. After your last email, I requested inclusion for the emacs group at savannah three weeks ago. Nothing happened since then, which I interpret as polite rejection. I've attached the updated patch. Thanks again, Felici=E1n --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Eglot-Implement-additionalPropertiesSupport-for-show.patch >From dbf47c6cb2be29842d0bcb6852f1365cd401a1e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felici=C3=A1n=20N=C3=A9meth?= Date: Sun, 2 Mar 2025 14:18:48 +0100 Subject: [PATCH] Eglot: Implement additionalPropertiesSupport for showMessage This feature was introduced in LSP v3.16. https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#window_showMessageRequest * lisp/progmodes/eglot.el (eglot-client-capabilities): Set window/showMessage/messageActionItem/additionalPropertiesSupport to t. (eglot-handle-request window/showMessageRequest): Return the whole selected ActionItem, not just its title. --- lisp/progmodes/eglot.el | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 1920d835cc3..1fac26be302 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -1089,6 +1089,8 @@ eglot-client-capabilities [,@(mapcar #'car eglot--tag-faces)]))) :window `(:showDocument (:support t) + :showMessage (:messageActionItem + (:additionalPropertiesSupport t)) :workDoneProgress ,(if eglot-report-progress t :json-false)) :general (list :positionEncodings ["utf-32" "utf-8" "utf-16"]) :experimental eglot--{}))) @@ -2593,18 +2595,23 @@ eglot-handle-notification (cl-defmethod eglot-handle-request (_server (_method (eql window/showMessageRequest)) &key type message actions &allow-other-keys) - "Handle server request window/showMessageRequest." - (let* ((actions (append actions nil)) ;; gh#627 + "Handle server request window/showMessageRequest. +Make the user select from a list of action items, and return the +selected item to the server. +" + ;; Argument `actions' is a list of MessageActionItems. A + ;; MessageActionItem must have a :title property, but it can have + ;; additional properties as well. + (let* ((actions (mapcar (lambda (a) (cons (plist-get a :title) a)) actions)) (label (completing-read (concat (format (propertize "[eglot] Server reports (type=%s): %s" 'face (if (or (not type) (<= type 1)) 'error)) type message) "\nChoose an option: ") - (or (mapcar (lambda (obj) (plist-get obj :title)) actions) - '("OK")) - nil t (plist-get (elt actions 0) :title)))) - (if label `(:title ,label) :null))) + (or actions '("OK")) + nil t (caar actions)))) + (if label (or (cdr (assoc label actions)) :null) :null))) (cl-defmethod eglot-handle-notification (_server (_method (eql window/logMessage)) &key _type _message) -- 2.39.5 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > Jo=C3=A3o > > On Sun, Mar 2, 2025 at 1:40=E2=80=AFPM Felician Nemeth > wrote: >> >> Hi Jo=C3=A3o, >> >> This small patch implements a harmless feature introduced in LSP version >> 3.16: >> https://microsoft.github.io/language-server-protocol/specifications/lsp/= 3.18/specification/#window_showMessageRequest >> >> It allows me to implement a rust-analyzer feautre in a simple, stateless >> manner. >> >> Thank you, >> Felici=C3=A1n >> --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 02 17:24:44 2025 Received: (at 76683) by debbugs.gnu.org; 2 Mar 2025 22:24:44 +0000 Received: from localhost ([127.0.0.1]:38213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1torjo-0006p1-9t for submit@debbugs.gnu.org; Sun, 02 Mar 2025 17:24:44 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:44457) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1torjk-0006oF-W1 for 76683@debbugs.gnu.org; Sun, 02 Mar 2025 17:24:42 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-43bc30adad5so1008195e9.1 for <76683@debbugs.gnu.org>; Sun, 02 Mar 2025 14:24:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740954274; x=1741559074; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8n+/Lr0+6jkc2JtKOg/m4AFMjFRV54qw66q6XwCLWxs=; b=RFLIhTun4v/QZYNFldBRvobnbWEMNevCCTSTr10dW9nvh2eh+AuScnB3cWjo/rNsww jBaY8ABD3NvbDIgXFAEnffibR9iAnTyl1S+vudh4N5j9sbE+DXzmt+j+BLA0EZAyn0qY sK0qU5GD6TGu0zd6yPUqACZO2PEaFdorxaD7hP2yvvWYys6YSyVVDQDcaLqEPB1iR++R WRmUt8Rqcjftyv7aQOXjYee5+x1ZBHy9SaBFJDZU8tjyRhAqbnLdDEMMdkLHTSBK2gub DQ9mR7tI3KO5swguZOh46qC50alcoLTYaHsvYMu2o6soYGCendZadeBk/kwQ7NnDUpIN oqyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740954274; x=1741559074; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8n+/Lr0+6jkc2JtKOg/m4AFMjFRV54qw66q6XwCLWxs=; b=Wor6+Im2rtdNJvq02B4DAn6Rg/+eC1uNlayQ7cTHT1WOFVsqN0QftgCKbO2AMYvTi8 MiOVZNHm+Fh4aCwIdhHM+/nPdZj2FLxaVj7XhJUCOcktqjnyEOTfYKugkmFvGXkYm6VD 2KJEJ0xckeNBwdffHi8Tj6dcpx8CfYU3gxaNb7Q5BB5Aed2Z99LY+G8udmvWaGuk67b8 Uk9boSK22xSTq7wQgwTWHeg7fAPcI8FbvATdoSDwd+9JccC8XFHTNAuUnIu05huSbJqa Jb3EKBXQPO2mAXa7x44Oa9dtoJMj5nx8BBI6hkFUvuMWxFeEFaEZmQyD7n2Q9nBtvCQ+ 6XbQ== X-Gm-Message-State: AOJu0YzGE48KQJzkYw8ITHAIQeNJKX1RNqk50EdqGE38zWs3A6SvbWAi AHp9M7d98rRqEtY150nxbddFM7QESNf65P5CEUolPhXjdrOs4ZAH2pud8A== X-Gm-Gg: ASbGncuhlkDICv4O+k7znDBfwRm8PK37ZvOcUfW5LjuE7b7ELBz8yALorSbX2ha+zjT xlqfk/KlzH06ZO9noKaF8cKBQwjm5n9oP5TA9outm0gfuxBsZKvN1WIN0cW3OuHvkTaWEvswR9x Zz6jxoHItsGmaux8I28OZavxX0ugCPJDw0FQ4vqjYJ0MroUTh5WjYJdmVW1+i7kCkydvgklNyxy YUjunwrV1yNicdGW2/vZSQDi1GNUSnsDiEQmf+ANrFikbC83OkFnUwXucTGdOh4MvsnfNtzI8pP WP858/F0Tkgo2F8gWM7uGVsky56HwznCUiI+KSre3N51ToWtdBuhDHptGkBVVg== X-Google-Smtp-Source: AGHT+IEaDRuKRHXW8lENojgA9QQt0Z/MmDD1i8MyFmhMUSLAAt0ZBwuZtda6hse+ttNpvbxtD5K4hg== X-Received: by 2002:a05:600c:502b:b0:439:9828:c447 with SMTP id 5b1f17b1804b1-43ba7d6635cmr90141335e9.17.1740954273870; Sun, 02 Mar 2025 14:24:33 -0800 (PST) Received: from krug (87-196-72-230.net.novis.pt. [87.196.72.230]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bbed8b26asm25443315e9.22.2025.03.02.14.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Mar 2025 14:24:33 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Felician Nemeth Subject: Re: bug#76683: [PATCH] Eglot: Implement additionalPropertiesSupport for showMessage In-Reply-To: <87tt8bzcm5.fsf@betli.tmit.bme.hu> References: <87cyez1ri1.fsf@betli.tmit.bme.hu> <87tt8bzcm5.fsf@betli.tmit.bme.hu> Date: Sun, 02 Mar 2025 22:24:49 +0000 Message-ID: <874j0b2hqm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76683 Cc: 76683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Felician Nemeth writes: >> * Why did you remove the gh#627 reference? Not relevant anymore? > > I think the note about gh#627 warned the reader that a "vector to list > conversion" was necessary. However, mapcar can work with vectors, so > the reference is not relevant anymore. Can't see that reference in github#627, but can't see the relevance either, so OK to erase. >> * Could eglot--lambda be used for simplicity (I know it wasn't used >> before) > > I think it won't be simpler, but it might be easier to understand the > intent of the code. However, I don't know how it is possible to rewrite > the lambda. How can we access the original object from the body of > eglot--lambda? Ah. You can't, indeed. eglot--lambda doesn't have some like &whole arg support (because cl-destructuring-bind also doesn't, unfortunatley). I have a patch for that, but could only find one place to use it so I held it back. But it seems there are at least two, so I'll attach the patch after my sig and you tell me if you think it's worth it. Possibly it's not, at least not yet. Unless you have things in eglot-x.el that could take advantage. > The patch has this: (lambda (a) (cons (plist-get a :title) a)) > > It should be turned into something like this: > > (eglot--lambda ((MessageActionItem) title) > (cons title orignal-object)) > >> * Are you 100% we'll return an 'equal' object for servers that don't >> make use of this feature? > > The specification says: "result: the selected MessageActionItem". If > the server does not send additional properties, the new version will > return what the original one returns: an object with a single title > property. So this patch should not cause any trouble to servers > following the specification. Makes sense. > Although, there is a corner case when the new version gives different > result. The original version can return (:title "OK") for an empty > action list, which is not in line with the specification. The updated > patch returns :null in this case. Alright. >> * In the original version it was obvious the structure returned, now >> not so much. Maybe >> a very short comment showing what the typical object looks like. > > I added a comment and extended the docstring. > >> After evaluating this, and doing changes (if any), feel free to push. > > After your last email, I requested inclusion for the emacs group at > savannah three weeks ago. Nothing happened since then, which I > interpret as polite rejection. Hmm, not sure about the rejection (or the polite, tbh). I'd ping them again. I pushed a very slightly simplified version of the patch. Check if it is OK (I didn't test). We can fixup later if I introduced a bug. Jo=C3=A3o Here's the patch I was talkng about: commit f6df4e9154f6ba1b4c9358d7da4470fdd8fc73d8 Author: Jo=C3=A3o T=C3=A1vora Date: Wed Feb 5 12:14:43 2025 +0000 Eglot: add &whole support to eglot--lambda =20=20=20=20 * lisp/progmodes/eglot.el (eglot--lambda): Add &whole support. (eglot--workspace-symbols): Use it. diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 7b1c174c4d7..17ad47ab64a 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -870,8 +870,17 @@ eglot--lambda "Function of args CL-LAMBDA-LIST for processing INTERFACE objects. Honor `eglot-strict-mode'." (declare (indent 1) (debug (sexp &rest form))) - (let ((e (cl-gensym "jsonrpc-lambda-elem"))) - `(lambda (,e) (cl-block nil (eglot--dbind ,cl-lambda-list ,e ,@body)))= )) + (let ((e (cl-gensym "jsonrpc-lambda-elem")) + whole) + (when-let* ((whole-pos (cl-position '&whole cl-lambda-list))) + (setq whole (nth (1+ whole-pos) cl-lambda-list) + cl-lambda-list (cl-subseq cl-lambda-list 0 whole-pos))) + `(lambda (,e) + ,(if whole + `(cl-block nil + (let ((,whole ,e)) + (eglot--dbind ,cl-lambda-list ,e ,@body))) + `(cl-block nil (eglot--dbind ,cl-lambda-list ,e ,@body)))))) =20 (cl-defmacro eglot--dcase (obj &rest clauses) "Like `pcase', but for the LSP object OBJ. @@ -3107,16 +3116,15 @@ eglot--workspace-symbols (with-current-buffer (or buffer (current-buffer)) (eglot-server-capable-or-lose :workspaceSymbolProvider) (mapcar - (lambda (wss) - (eglot--dbind ((WorkspaceSymbol) name containerName kind) wss - (propertize - (format "%s%s %s" - (if (zerop (length containerName)) "" - (concat (propertize containerName 'face 'shadow) " ")) - name - (propertize (alist-get kind eglot--symbol-kind-names "Un= known") - 'face 'shadow)) - 'eglot--lsp-workspaceSymbol wss))) + (eglot--lambda ((WorkspaceSymbol) name containerName kind &whole wss) + (propertize + (format "%s%s %s" + (if (zerop (length containerName)) "" + (concat (propertize containerName 'face 'shadow) " ")) + name + (propertize (alist-get kind eglot--symbol-kind-names "Unkn= own") + 'face 'shadow)) + 'eglot--lsp-workspaceSymbol wss)) (eglot--request (eglot--current-server-or-lose) :workspace/symbol `(:query ,pat))))) =20 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 08 11:40:55 2025 Received: (at 76683) by debbugs.gnu.org; 8 Mar 2025 16:40:55 +0000 Received: from localhost ([127.0.0.1]:56340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqxEN-0002PZ-9C for submit@debbugs.gnu.org; Sat, 08 Mar 2025 11:40:55 -0500 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:53455) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tqxEK-0002PL-GL for 76683@debbugs.gnu.org; Sat, 08 Mar 2025 11:40:53 -0500 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5e5e1a38c1aso2125781a12.2 for <76683@debbugs.gnu.org>; Sat, 08 Mar 2025 08:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741452045; x=1742056845; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=qVOo6uf2TY4YIa/obVr8CycZq0L5sAhnJJD18QFIzQw=; b=TtRMxk1gzEpxvW3NzMZVBtwAvKonn8+O8idnI2W39emy9bEhtROGnVVQujiHMewKtm 6QNvqscKhXnyov6+ohXPSQHo3UHm/8vcA3pR83BxuqmcSt6/70Svfu0TtzSFrMnfSnEG V2nZTzzYPK7SAi9y51RMz/q5qUnMDU3Q3A5E76/Em5N4x/QpM1oU912ddNfO0Saghi+6 80o+eVo+FPZufukFp/T7g+tGpUpqbd6F9maaUtcLJDiwkB2K+Q7H9pHdEATBHTFwGejk ly9A5WfyO84NpDzPdpjuSLqiylsgbqXMdpTS40b/xnDGl+m5iNO7DsNNK8yykg2cEA8i BTpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741452045; x=1742056845; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qVOo6uf2TY4YIa/obVr8CycZq0L5sAhnJJD18QFIzQw=; b=hp2Ys3OC2BCZQYgBw+wAarECaaBryby5P0HIlkPBUqdvfYOpxc8V7D7XRBLSvyAk95 pZgXclLMchSAFZDbFoS2XTm0ShX6ahLH1aOov82208q2uauvyWNO6Qo23ivzml5C2e/L bm+842v+YG7bh17eGkT8aCU0CYC+ECzrykLgp/i21TSli6D+tZGpwuriAGUfJ6btkhQD DPmNCudhivimKSqI3fzT86EyIxuxXD2n+gvcxV5b61dXfI77cTPvPjg3KXXZ3gRm+7/J yOD/Z10ydOJ0iiMa9OiATOE/ib0xVdV3SUUe8qBbjawb24xs+vRM4EJLjnuNQ5mx704V w6bg== X-Gm-Message-State: AOJu0YwDO2PPjKVG6LNRl+Ge/Om8Poaxm1v0apz524GJm400pntBlvZW T1/O6V6IBNgn6vx8D/p7kSQVpR3nKFTCWrikTIBEJFLAuNIQ6OmA5XPHxQ== X-Gm-Gg: ASbGnctJ8RibZZsQg6dUzVAoc+5xYAPOvczWMQ0bnvAnRteUE8Xr0ii2/uJkENex1mS jTwpLac+Hj/O7TdosdlEGydf89arDsfnI9NYsgoYh9Zx6JR125R4Q/uMu5kmdmmqNH/DQaeJi9j rWIoEA2LTo+8xKlDa9We2JewpUSc9dGQk5VYlrmfIjxPa5yHdwb2vaQTZW1Essdctx1Pzu8etzD vFv+lYyG1EmiXRbi0V1mJO7yVUhDa/Ox/zv762etx4HCrkxNadvqbmL0rADNDkBq/pJGcCxi5Di l0KoT/7hkiEDZKozK6IjW+xexY4KKWp2OTjoDjDMgh0N4iaX36qjViu5UMx1Q9PXPYJbJHaicFG /pIMX1SGh6bo+KjemCE3subFXog== X-Google-Smtp-Source: AGHT+IE+f/Qe3RJhCGE1ChAAdZm7R6He4OqhneU14XoDoryZMpa65aUtZLyAKJkod2ffAcACmUdP/A== X-Received: by 2002:a05:6402:2353:b0:5e5:c0e7:f428 with SMTP id 4fb4d7f45d1cf-5e5e210296emr21484275a12.0.1741452045060; Sat, 08 Mar 2025 08:40:45 -0800 (PST) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.one.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac2773e8641sm118015366b.165.2025.03.08.08.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Mar 2025 08:40:44 -0800 (PST) From: Felician Nemeth To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#76683: [PATCH] Eglot: Implement additionalPropertiesSupport for showMessage References: <87cyez1ri1.fsf@betli.tmit.bme.hu> <87tt8bzcm5.fsf@betli.tmit.bme.hu> <874j0b2hqm.fsf@gmail.com> Date: Sat, 08 Mar 2025 17:40:43 +0100 In-Reply-To: <874j0b2hqm.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Sun, 02 Mar 2025 22:24:49 +0000") Message-ID: <87o6yb1nn8.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEWOdXElERN7LDLZs6/l 0dDQq6TepMcqAAACW0lEQVQ4jWWSzY7bMAyEaSm6mypylxjkroTRvUW8d9lavf+r7NDOZotWQHzg lyGHP0Sn5ed9qKrLWWIWos9/QJWIeCSywPNTd/AE0LtwFj7A+3WT5PwfeBrQKcsBnkfwVcNySWQr 3i34XN6gRNgis/v4uwSKHCD9lPitB0Aq9BHfHX4cgsI7cJJfLdZg/4bbCzoRmkD9MsagQSBDedZi CgNxkVSJmSOStTBUBKkywEnEoZzbwWj+ACiVJkF6pOpak2PMCqkMYDpaw+gatLR8atMOrB3JGzmm 3rSQo+tkxU+UAbhQSgtslULhsXKk6+IyQ1QTzeQB0MzjlpkCEUCeUdviWrwBcxVqpZjP+v0MYPA0 aq2rvIEZe4GRM0v+9QIB03rsABVSk5y+Mz3LSzExtJLlCCO6dV1uzDQFTBad+gO0TqqL9XE8x4ek +orvYiMJgzC8e+r6TqaPaK6QyqVNvoHtsRrooQ6tTi4vgaSkd8wIikodB3B0iIk58avsDdYNajpS bSKJ+mQnipGszB6zW4lGgsOkKHE2RWVcBpwhaIv3BYIAu3WsnC7YYKLRchp6w8fRGZIWiZuFsVai 7gbcUcJEhiDZ3K1+uzZvBlfaEO8oH4MLu6/hrKVM7QpQcIXJFuC1XjfbfKRxNslk94l9cYcEihV2 HWyNDQAXaLsvnrSyp7HaQhrAn13V6/XW11nh0XINBOEAV+tHK4EvAGNGvEwc0eZw8Vyr56imYEsV sOW9jxm/yb9AH1ufqGMviIK7A0Tc/723oM3tJ4HTOu9gDr3ftbdkxfdjsUv5AqWKwyfCYo5WAAAA AElFTkSuQmCC MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76683 Cc: 76683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > eglot--lambda doesn't have some like &whole arg support (because > cl-destructuring-bind also doesn't, unfortunatley). I have a patch > for that, but could only find one place to use it so I held it back. > But it seems there are at least two, so I'll attach the patch after my > sig and you tell me if you think it's worth it. Possibly it's not, at > least not yet. Unless you have things in eglot-x.el that could take > advantage. I don't see use cases for it at the moment, but I keep this in mind and let you know when something comes up. > I pushed a very slightly simplified version of the patch. Check if it > is OK (I didn't test). We can fixup later if I introduced a bug. The pushed version works for me. Thank you, Felici=C3=A1n