Subject: bug#76683: [PATCH] Eglot: Implement additionalPropertiesSupport for showMessage

From: João Távora <[email-masked]>
Date: Sun, 2 Mar 2025 13:59:44 +0000

Looks good.  Minor comments.

* Why did you remove the gh#627 reference?  Not relevant anymore?
* Could eglot--lambda be used for simplicity (I know it wasn't used before)
* Are you 100% we'll return an 'equal' object for servers that don't
make use of this feature?
* In the original version it was obvious the structure returned, now
not so much.   Maybe
a very short comment showing what the typical object looks like.

After evaluating this, and doing changes (if any), feel free to push.

João

On Sun, Mar 2, 2025 at 1:40 PM Felician Nemeth
<[email-masked]> wrote:
>
> Hi João,
>
> This small patch implements a harmless feature introduced in LSP version
> 3.16:
> https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#window_showMessageRequest
>
> It allows me to implement a rust-analyzer feautre in a simple, stateless
> manner.
>
> Thank you,
> Felicián
>

-- 
João Távora