GNU bug report logs - #76663
[PATCH gnome-team] gnu: flatpak: Propagate inputs as required by pkg-config.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: 宋文武 <iyzsong <at> envs.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76663: closed ([PATCH gnome-team] gnu: flatpak: Propagate
 inputs as required by pkg-config.)
Date: Wed, 05 Mar 2025 09:15:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 05 Mar 2025 17:18:54 +0800
with message-id <87y0xjkf7l.fsf_-_ <at> envs.net>
and subject line Re: bug#76663: [PATCH gnome-team] gnu: flatpak: Propagate inputs as required by pkg-config.
has caused the debbugs.gnu.org bug report #76663,
regarding [PATCH gnome-team] gnu: flatpak: Propagate inputs as required by pkg-config.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76663: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76663
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH gnome-team] gnu: flatpak: Propagate inputs as required by
 pkg-config.
Date: Sat, 1 Mar 2025 17:52:57 +0100

* gnu/packages/package-management.scm (flatpak)[inputs]: Move dconf, gpgme,
json-glib, libarchive, libseccomp and libxau from here…
[propagated-inputs]: … to here.
---
Hi Guix,

this is a more or less "emergency patch" as gnome transitively requires
flatpak, but flatpak does not propagate enough inputs to let dependent
packages be aware of them.  The alternative would be to add these inputs
to said dependents (or finally fix the way pkg-config handles this, but
that's outside our scope IIUC)

Cheers

 gnu/packages/package-management.scm | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index 7b3756d0aa3..4cc53a2ce3a 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -2138,24 +2138,29 @@ (define-public flatpak
            bash-minimal
            bubblewrap
            curl
-           dconf
            fuse
            gdk-pixbuf
-           gpgme
-           json-glib
-           libarchive
            libcap
            libostree
-           libseccomp
            libsoup-minimal-2
-           libxau
            libxml2
            p11-kit
            polkit
            util-linux
            xdg-dbus-proxy
            zstd))
-    (propagated-inputs (list glib-networking gnupg gsettings-desktop-schemas))
+    (propagated-inputs (list glib-networking
+                             gnupg
+                             gsettings-desktop-schemas
+                             ;; The following are listed in Requires.private of
+                             ;; `flatpak.pc'.
+                             curl
+                             dconf
+                             gpgme
+                             json-glib
+                             libarchive
+                             libseccomp
+                             libxau))
     (home-page "https://flatpak.org")
     (synopsis "System for building, distributing, and running sandboxed desktop
 applications")

base-commit: 87d0295b308f354ec1c25212f6937b39eb8ae8bf
-- 
2.48.1

[Message part 3 (message/rfc822, inline)]

From: 宋文武 <iyzsong <at> envs.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: vivien <at> planete-kraus.eu, Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 76663-done <at> debbugs.gnu.org
Subject: Re: bug#76663: [PATCH gnome-team] gnu: flatpak: Propagate inputs as
 required by pkg-config.
Date: Wed, 05 Mar 2025 17:18:54 +0800

> [...]
>> * gnu/packages/package-management.scm (flatpak)[inputs]: Move dconf, gpgme,
>> json-glib, libarchive, libseccomp and libxau from here…
>> [propagated-inputs]: … to here.

This seems had be merged as commit 174d98e2a6, so close.

Also it may worth to know that those deps in Requires.private are
actually not needed, as meson has a bug:

  https://github.com/mesonbuild/meson/issues/3970

It should only add thoes in Requires.private when build a static
library.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.