Subject: bug#76663: closed (Re: bug#76663: [PATCH gnome-team] gnu: flatpak: Propagate inputs as required by pkg-config.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 05 Mar 2025 09:15:02 +0000

Your bug report

#76663: [PATCH gnome-team] gnu: flatpak: Propagate inputs as required by pkg-config.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
76663: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76663
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#76663: [PATCH gnome-team] gnu: flatpak: Propagate inputs as required by pkg-config.
From: 宋文武 <[email-masked]>
To: Maxim Cournoyer <[email-masked]>
Cc: [email-masked], Liliana Marie Prikler <[email-masked]>, [email-masked]
Date: Wed, 05 Mar 2025 17:18:54 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

> [...]
>> * gnu/packages/package-management.scm (flatpak)[inputs]: Move dconf, gpgme,
>> json-glib, libarchive, libseccomp and libxau from here…
>> [propagated-inputs]: … to here.

This seems had be merged as commit 174d98e2a6, so close.

Also it may worth to know that those deps in Requires.private are
actually not needed, as meson has a bug:

  https://github.com/mesonbuild/meson/issues/3970

It should only add thoes in Requires.private when build a static
library.

Subject: [PATCH gnome-team] gnu: flatpak: Propagate inputs as required by pkg-config.
From: Liliana Marie Prikler <[email-masked]>
To: [email-masked]
Date: Sat, 1 Mar 2025 17:52:57 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/package-management.scm (flatpak)[inputs]: Move dconf, gpgme,
json-glib, libarchive, libseccomp and libxau from here…
[propagated-inputs]: … to here.
---
Hi Guix,

this is a more or less "emergency patch" as gnome transitively requires
flatpak, but flatpak does not propagate enough inputs to let dependent
packages be aware of them.  The alternative would be to add these inputs
to said dependents (or finally fix the way pkg-config handles this, but
that's outside our scope IIUC)

Cheers

 gnu/packages/package-management.scm | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index 7b3756d0aa3..4cc53a2ce3a 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -2138,24 +2138,29 @@ (define-public flatpak
            bash-minimal
            bubblewrap
            curl
-           dconf
            fuse
            gdk-pixbuf
-           gpgme
-           json-glib
-           libarchive
            libcap
            libostree
-           libseccomp
            libsoup-minimal-2
-           libxau
            libxml2
            p11-kit
            polkit
            util-linux
            xdg-dbus-proxy
            zstd))
-    (propagated-inputs (list glib-networking gnupg gsettings-desktop-schemas))
+    (propagated-inputs (list glib-networking
+                             gnupg
+                             gsettings-desktop-schemas
+                             ;; The following are listed in Requires.private of
+                             ;; `flatpak.pc'.
+                             curl
+                             dconf
+                             gpgme
+                             json-glib
+                             libarchive
+                             libseccomp
+                             libxau))
     (home-page "https://flatpak.org")
     (synopsis "System for building, distributing, and running sandboxed desktop
 applications")

base-commit: 87d0295b308f354ec1c25212f6937b39eb8ae8bf
-- 
2.48.1