GNU bug report logs - #76660
Downgrade prevention triggers erroneously with 'guix pull'

Previous Next

Package: guix;

Reported by: Jack Hill <jackhill <at> jackhill.us>

Date: Sat, 1 Mar 2025 16:38:03 UTC

Severity: important

Full log


Message #63 received at 76660 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Jack Hill <jackhill <at> jackhill.us>, 76660 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#76660: current guix pull doesn't authenticate
Date: Tue, 25 Mar 2025 22:01:02 +0100
[Message part 1 (text/plain, inline)]
Simon Tournier <zimon.toutoune <at> gmail.com> writes:

> Hi Ludo,
>
> On Mon, 10 Mar 2025 at 22:57, Ludovic Courtès <ludo <at> gnu.org> wrote:
>> Simon Tournier <zimon.toutoune <at> gmail.com> skribis:
>>
>>> Last cherry on the top, from [1], the implementation relying on “git
>>> merge-base --is-ancestor” is 35x faster.
>>
>> Uh, interesting!  I would still like to avoid shelling out to Git for
>> common operations, but this comparison shows there’s a lot of room to
>> improve the performance of the current implementation.
>
> You mean the current implementation of ligbit2, right?  Because, from my
> poor understanding, it’s part of the performance barrier.

There is git_graph_descendant_of function in libgit2, but it is not
exposed by the guile-git binding.  Maybe we could try to use it to
implement the check instead the current approach (which does it in
Guile).  I wonder how well that would perform compared to --is-ancestor.

Tomas

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 79 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.