GNU bug report logs - #76652
[PATCH] gnu: go-github-com-hodgesds-perf-utils: Skip more tests on arm.

Previous Next

Package: guix-patches;

Reported by: Christopher Baines <mail <at> cbaines.net>

Date: Fri, 28 Feb 2025 18:13:02 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76652: closed ([PATCH] gnu: go-github-com-hodgesds-perf-utils:
 Skip more tests on arm.)
Date: Mon, 03 Mar 2025 14:33:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 03 Mar 2025 14:32:31 +0000
with message-id <87ikoqw5fk.fsf <at> cbaines.net>
and subject line Re: [bug#76652] [PATCH] gnu: go-github-com-hodgesds-perf-utils: Skip more tests on arm.
has caused the debbugs.gnu.org bug report #76652,
regarding [PATCH] gnu: go-github-com-hodgesds-perf-utils: Skip more tests on arm.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76652: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76652
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: go-github-com-hodgesds-perf-utils: Skip more tests on
 arm.
Date: Fri, 28 Feb 2025 18:12:08 +0000
I see these failing when built on Honeycomb build machines:

  === RUN   TestDataTLB
      utils_test.go:234: no such file or directory
  --- FAIL: TestDataTLB (0.00s)
  === RUN   TestInstructionTLB
      utils_test.go:246: no such file or directory
  --- FAIL: TestInstructionTLB (0.00s)

It could be something with the system configuration but just disable the tests
for now. This is working towards getting the prometheus-node-exporter package
building again on aarch64-linux.

Note that there's even more test failures when trying to build with qemu
binfmt emulation.

* gnu/packages/golang-xyz.scm (go-github-com-hodgesds-perf-utils)[arguments]:
Skip a couple more tests on arm.

Change-Id: Ib5bc41679d825a1a727e240e7fffeb336f82db6d
---
 gnu/packages/golang-xyz.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/golang-xyz.scm b/gnu/packages/golang-xyz.scm
index 67957caae0..0b7858e4fe 100644
--- a/gnu/packages/golang-xyz.scm
+++ b/gnu/packages/golang-xyz.scm
@@ -7509,7 +7509,11 @@ (define-public go-github-com-hodgesds-perf-utils
                      "TestNodeCache"
                      "TestProfiler"
                      "TestSoftwareProfiler"
-                     "TestTraceFSMount")
+                     "TestTraceFSMount"
+                     #$@(if (target-arm?)
+                            '("TestDataTLB"
+                              "TestInstructionTLB")
+                            '()))
                "|"))))
     (native-inputs
      (list go-github-com-stretchr-testify))

base-commit: a76708a872e65230931f3c5c3b079d0a39d5cb84
-- 
2.48.1



[Message part 3 (message/rfc822, inline)]
From: Christopher Baines <mail <at> cbaines.net>
To: 76652-done <at> debbugs.gnu.org
Subject: Re: [bug#76652] [PATCH] gnu: go-github-com-hodgesds-perf-utils:
 Skip more tests on arm.
Date: Mon, 03 Mar 2025 14:32:31 +0000
[Message part 4 (text/plain, inline)]
Christopher Baines <mail <at> cbaines.net> writes:

> I see these failing when built on Honeycomb build machines:
>
>   === RUN   TestDataTLB
>       utils_test.go:234: no such file or directory
>   --- FAIL: TestDataTLB (0.00s)
>   === RUN   TestInstructionTLB
>       utils_test.go:246: no such file or directory
>   --- FAIL: TestInstructionTLB (0.00s)
>
> It could be something with the system configuration but just disable the tests
> for now. This is working towards getting the prometheus-node-exporter package
> building again on aarch64-linux.
>
> Note that there's even more test failures when trying to build with qemu
> binfmt emulation.
>
> * gnu/packages/golang-xyz.scm (go-github-com-hodgesds-perf-utils)[arguments]:
> Skip a couple more tests on arm.
>
> Change-Id: Ib5bc41679d825a1a727e240e7fffeb336f82db6d
> ---
>  gnu/packages/golang-xyz.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

I was hoping to wait for QA, but gnome-team has landed so I'm just going
to push this 🤞 as c8f537ac0517f45393c8bf68fc0259f185324cc5.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 81 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.