GNU bug report logs - #76650
31.0.50; Add lua-mode to Emacs

Previous Next

To reply to this bug, email your comments to 76650 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jm <at> pub.pink
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; Add lua-mode to Emacs
Date: Fri, 28 Feb 2025 11:40:18 -0600

I’ve talked with Denis (the current maintainer) about integrating
lua-mode into Emacs and they are in favor of it. If there is
interest on the Emacs side I can send over the list of
contributors for assignment verification. There are about a dozen
authors with contributions over the exempted 15 lines and most of
those I was able to find commits from in emacs.git.

One sticky bit is that the initial commit contains contributions
from unknown authors and I have not audited the code to see what
is left in the current version but can start working on that if
the decision is to include it in Emacs.

Message #10 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: Richard Stallman <rms <at> gnu.org>
To: jm <at> pub.pink
Cc: 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Sun, 02 Mar 2025 23:45:39 -0500

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > One sticky bit is that the initial commit contains contributions
  > from unknown authors

If significant amounts of that remain, one option is to delete them
and write something new to handle those points.

If it is clear there is only one way to write a certain piece of code
then it is ok to use.


-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Message #13 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: jm <at> pub.pink
Cc: Eli Zaretskii <eliz <at> gnu.org>, Andrea Corallo <acorallo <at> gnu.org>,
 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Mon, 3 Mar 2025 18:32:32 -0800

jm <at> pub.pink writes:

> I’ve talked with Denis (the current maintainer) about integrating
> lua-mode into Emacs and they are in favor of it. If there is
> interest on the Emacs side I can send over the list of
> contributors for assignment verification. There are about a dozen
> authors with contributions over the exempted 15 lines and most of
> those I was able to find commits from in emacs.git.

Sounds like a good plan, thank you.  LUA is quite popular, so I think it
would be important to have built-in support for it, also it would help
us develop lua-ts-mode.

I don't know if Eli or Andrea have any further comments, but I'd say go
for it.

Message #16 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: acorallo <at> gnu.org, jm <at> pub.pink, 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Tue, 04 Mar 2025 16:20:25 +0200

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Mon, 3 Mar 2025 18:32:32 -0800
> Cc: 76650 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, Andrea Corallo <acorallo <at> gnu.org>
> 
> jm <at> pub.pink writes:
> 
> > I’ve talked with Denis (the current maintainer) about integrating
> > lua-mode into Emacs and they are in favor of it. If there is
> > interest on the Emacs side I can send over the list of
> > contributors for assignment verification. There are about a dozen
> > authors with contributions over the exempted 15 lines and most of
> > those I was able to find commits from in emacs.git.
> 
> Sounds like a good plan, thank you.  LUA is quite popular, so I think it
> would be important to have built-in support for it, also it would help
> us develop lua-ts-mode.
> 
> I don't know if Eli or Andrea have any further comments, but I'd say go
> for it.

No objections here, of course.

Message #19 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Andrea Corallo <acorallo <at> gnu.org>,
 bug-gnu-emacs <at> gnu.org, 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Tue, 04 Mar 2025 12:50:03 -0600

Stefan Kangas <stefankangas <at> gmail.com> writes:

> jm <at> pub.pink writes:
>
>> I’ve talked with Denis (the current maintainer) about integrating
>> lua-mode into Emacs and they are in favor of it. If there is
>> interest on the Emacs side I can send over the list of
>> contributors for assignment verification. There are about a dozen
>> authors with contributions over the exempted 15 lines and most of
>> those I was able to find commits from in emacs.git.
>
> Sounds like a good plan, thank you.  LUA is quite popular, so I think it
> would be important to have built-in support for it, also it would help
> us develop lua-ts-mode.
>
> I don't know if Eli or Andrea have any further comments, but I'd say go
> for it.

Should I send the list of contributors to anyone in particular to
check on assignment status or just post them here? Should I
include email addresses in the list?

Thanks.

Message #25 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: bug-gnu-emacs <at> gnu.org, acorallo <at> gnu.org, stefankangas <at> gmail.com,
 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Tue, 04 Mar 2025 21:38:32 +0200

> From: john muhl <jm <at> pub.pink>
> Cc: Eli Zaretskii <eliz <at> gnu.org>, Andrea Corallo <acorallo <at> gnu.org>,
>  76650 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
> Date: Tue, 04 Mar 2025 12:50:03 -0600
> 
> 
> Stefan Kangas <stefankangas <at> gmail.com> writes:
> 
> > jm <at> pub.pink writes:
> >
> >> I’ve talked with Denis (the current maintainer) about integrating
> >> lua-mode into Emacs and they are in favor of it. If there is
> >> interest on the Emacs side I can send over the list of
> >> contributors for assignment verification. There are about a dozen
> >> authors with contributions over the exempted 15 lines and most of
> >> those I was able to find commits from in emacs.git.
> >
> > Sounds like a good plan, thank you.  LUA is quite popular, so I think it
> > would be important to have built-in support for it, also it would help
> > us develop lua-ts-mode.
> >
> > I don't know if Eli or Andrea have any further comments, but I'd say go
> > for it.
> 
> Should I send the list of contributors to anyone in particular to
> check on assignment status or just post them here? Should I
> include email addresses in the list?

Please post the list here, including email addresses.

Thanks.

Message #31 received at submit <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: bug-gnu-emacs <at> gnu.org, acorallo <at> gnu.org, stefankangas <at> gmail.com,
 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Tue, 04 Mar 2025 14:17:15 -0600

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: john muhl <jm <at> pub.pink>
>> Cc: Eli Zaretskii <eliz <at> gnu.org>, Andrea Corallo <acorallo <at> gnu.org>,
>>  76650 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
>> Date: Tue, 04 Mar 2025 12:50:03 -0600
>> 
>> 
>> Stefan Kangas <stefankangas <at> gmail.com> writes:
>> 
>> > jm <at> pub.pink writes:
>> >
>> >> I’ve talked with Denis (the current maintainer) about integrating
>> >> lua-mode into Emacs and they are in favor of it. If there is
>> >> interest on the Emacs side I can send over the list of
>> >> contributors for assignment verification. There are about a dozen
>> >> authors with contributions over the exempted 15 lines and most of
>> >> those I was able to find commits from in emacs.git.
>> >
>> > Sounds like a good plan, thank you.  LUA is quite popular, so I think it
>> > would be important to have built-in support for it, also it would help
>> > us develop lua-ts-mode.
>> >
>> > I don't know if Eli or Andrea have any further comments, but I'd say go
>> > for it.
>> 
>> Should I send the list of contributors to anyone in particular to
>> check on assignment status or just post them here? Should I
>> include email addresses in the list?
>
> Please post the list here, including email addresses.
>
> Thanks.

The list is based on the current code in lua-mode.el. The list of
all contributors is somewhat longer but I guessed that copyright
is a non-issue for code that is no longer in use. It also doesn’t
include those who only changed tests. lua-mode doesn’t use ERT for
testing so I don’t think we’ll be importing that code anyway.

The second group of names are those who should be exempt based on
a 15 line limit.

Augusto Stoffel arstoffel <at> gmail.com
Jonas Bernoulli jonas <at> bernoul.li
Juergen Hoetzel juergen <at> hoetzel.info
Julien Danjou julien <at> danjou.info
Mark Oteiza mvoteiza <at> udel.edu
Nikita Bloshchanevich nikblos <at> outlook.com
Philip K philipk <at> posteo.net
Reuben Thomas rrt <at> sc3d.org
Robert Cochran robert-git <at> cochranmail.com
Rolando Pereira rolando_pereira <at> sapo.pt
Stefan Kangas stefan <at> marxist.se
USAMI Kenta tadsan <at> zonu.me
Vedat Hallac vedathallac <at> gmail.com
immerrr immerrr+lua <at> gmail.com

Dmitry Kalinkin dmitry.kalinkin <at> gmail.com c1b60197
Edward Betts edward <at> 4angle.com 5a906553
Joram Schrijver i <at> joram.io dccda192
Leonardo Etcheverry leo <at> kalio.net 91b59745 4a203b9e b9541cef
Libor Čapák capak <at> inputwish.com
Mario Rodas marsam <at> users.noreply.github.com
Peter Vasil mail <at> petervasil.net
Rafael Sanchez rafael <at> cornerdimension.com
Thomas Jost schnouki <at> schnouki.net
edam tim <at> ed.am
paralogismos mailbowling <at> gmail.com
xristos xristos <at> sdf.lonestar.org

Message #37 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: acorallo <at> gnu.org, stefankangas <at> gmail.com, 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Wed, 05 Mar 2025 14:30:28 +0200

> From: john muhl <jm <at> pub.pink>
> Cc: stefankangas <at> gmail.com, acorallo <at> gnu.org, 76650 <at> debbugs.gnu.org,
>  bug-gnu-emacs <at> gnu.org
> Date: Tue, 04 Mar 2025 14:17:15 -0600
> 
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Please post the list here, including email addresses.
> >
> > Thanks.
> 
> The list is based on the current code in lua-mode.el. The list of
> all contributors is somewhat longer but I guessed that copyright
> is a non-issue for code that is no longer in use. It also doesn’t
> include those who only changed tests. lua-mode doesn’t use ERT for
> testing so I don’t think we’ll be importing that code anyway.
> 
> The second group of names are those who should be exempt based on
> a 15 line limit.
> 
> Augusto Stoffel arstoffel <at> gmail.com
> Jonas Bernoulli jonas <at> bernoul.li
> Juergen Hoetzel juergen <at> hoetzel.info
> Julien Danjou julien <at> danjou.info
> Mark Oteiza mvoteiza <at> udel.edu
> Nikita Bloshchanevich nikblos <at> outlook.com
> Philip K philipk <at> posteo.net
> Reuben Thomas rrt <at> sc3d.org
> Robert Cochran robert-git <at> cochranmail.com
> Rolando Pereira rolando_pereira <at> sapo.pt
> Stefan Kangas stefan <at> marxist.se
> USAMI Kenta tadsan <at> zonu.me
> Vedat Hallac vedathallac <at> gmail.com
> immerrr immerrr+lua <at> gmail.com

Out of these, only the following don't already have assignments on
file:

  Nikita Bloshchanevich nikblos <at> outlook.com
  Rolando Pereira rolando_pereira <at> sapo.pt

> Dmitry Kalinkin dmitry.kalinkin <at> gmail.com c1b60197
> Edward Betts edward <at> 4angle.com 5a906553
> Joram Schrijver i <at> joram.io dccda192
> Leonardo Etcheverry leo <at> kalio.net 91b59745 4a203b9e b9541cef
> Libor Čapák capak <at> inputwish.com
> Mario Rodas marsam <at> users.noreply.github.com
> Peter Vasil mail <at> petervasil.net
> Rafael Sanchez rafael <at> cornerdimension.com
> Thomas Jost schnouki <at> schnouki.net
> edam tim <at> ed.am
> paralogismos mailbowling <at> gmail.com
> xristos xristos <at> sdf.lonestar.org

None of these have assignments.

Message #40 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: acorallo <at> gnu.org, stefankangas <at> gmail.com, 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Wed, 05 Mar 2025 09:06:41 -0600

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: john muhl <jm <at> pub.pink>
>> Cc: stefankangas <at> gmail.com, acorallo <at> gnu.org, 76650 <at> debbugs.gnu.org,
>>  bug-gnu-emacs <at> gnu.org
>> Date: Tue, 04 Mar 2025 14:17:15 -0600
>> 
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
> Out of these, only the following don't already have assignments on
> file:

Thanks. We’re in even better shape than I thought. A second check
of the remainer shows:

Leonardo Etcheverry leo <at> kalio.net
13 lines code
 6 lines comments

Nikita Bloshchanevich nikblos <at> outlook.com
15 lines code
 3 lines comments
 3 lines docstrings

edam tim <at> ed.am
12 lines code
 6 lines comments
 6 lines docstrings

 2 Dmitry Kalinkin dmitry.kalinkin <at> gmail.com
 1 Edward Betts edward <at> 4angle.com
 2 Joram Schrijver i <at> joram.io dccda192
 6 Libor Čapák capak <at> inputwish.com
 3 Mario Rodas marsam <at> users.noreply.github.com
 2 Peter Vasil mail <at> petervasil.net
 2 Rafael Sanchez rafael <at> cornerdimension.com
 7 Rolando Pereira rolando_pereira <at> sapo.pt
11 Thomas Jost schnouki <at> schnouki.net
 9 paralogismos mailbowling <at> gmail.com
 6 xristos xristos <at> sdf.lonestar.org

> None of these have assignments.

Do we need assignments for any of these?

Message #43 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: acorallo <at> gnu.org, stefankangas <at> gmail.com, 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Wed, 05 Mar 2025 18:13:01 +0200

> From: john muhl <jm <at> pub.pink>
> Cc: stefankangas <at> gmail.com, acorallo <at> gnu.org, 76650 <at> debbugs.gnu.org
> Date: Wed, 05 Mar 2025 09:06:41 -0600
> 
> 
> > Out of these, only the following don't already have assignments on
> > file:
> 
> Thanks. We’re in even better shape than I thought. A second check
> of the remainer shows:
> 
> Leonardo Etcheverry leo <at> kalio.net
> 13 lines code
>  6 lines comments
> 
> Nikita Bloshchanevich nikblos <at> outlook.com
> 15 lines code
>  3 lines comments
>  3 lines docstrings
> 
> edam tim <at> ed.am
> 12 lines code
>  6 lines comments
>  6 lines docstrings
> 
>  2 Dmitry Kalinkin dmitry.kalinkin <at> gmail.com
>  1 Edward Betts edward <at> 4angle.com
>  2 Joram Schrijver i <at> joram.io dccda192
>  6 Libor Čapák capak <at> inputwish.com
>  3 Mario Rodas marsam <at> users.noreply.github.com
>  2 Peter Vasil mail <at> petervasil.net
>  2 Rafael Sanchez rafael <at> cornerdimension.com
>  7 Rolando Pereira rolando_pereira <at> sapo.pt
> 11 Thomas Jost schnouki <at> schnouki.net
>  9 paralogismos mailbowling <at> gmail.com
>  6 xristos xristos <at> sdf.lonestar.org
> 
> > None of these have assignments.
> 
> Do we need assignments for any of these?

No, we don't.

Message #46 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: acorallo <at> gnu.org, stefankangas <at> gmail.com, 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Wed, 05 Mar 2025 10:33:20 -0600

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: john muhl <jm <at> pub.pink>
>> Cc: stefankangas <at> gmail.com, acorallo <at> gnu.org, 76650 <at> debbugs.gnu.org
>> Date: Wed, 05 Mar 2025 09:06:41 -0600
>> 
>> 
>> > Out of these, only the following don't already have assignments on
>> > file:
>> 
>> Thanks. We’re in even better shape than I thought. A second check
>> of the remainer shows:
>> 
>> Leonardo Etcheverry leo <at> kalio.net
>> 13 lines code
>>  6 lines comments
>> 
>> Nikita Bloshchanevich nikblos <at> outlook.com
>> 15 lines code
>>  3 lines comments
>>  3 lines docstrings
>> 
>> edam tim <at> ed.am
>> 12 lines code
>>  6 lines comments
>>  6 lines docstrings
>> 
>>  2 Dmitry Kalinkin dmitry.kalinkin <at> gmail.com
>>  1 Edward Betts edward <at> 4angle.com
>>  2 Joram Schrijver i <at> joram.io dccda192
>>  6 Libor Čapák capak <at> inputwish.com
>>  3 Mario Rodas marsam <at> users.noreply.github.com
>>  2 Peter Vasil mail <at> petervasil.net
>>  2 Rafael Sanchez rafael <at> cornerdimension.com
>>  7 Rolando Pereira rolando_pereira <at> sapo.pt
>> 11 Thomas Jost schnouki <at> schnouki.net
>>  9 paralogismos mailbowling <at> gmail.com
>>  6 xristos xristos <at> sdf.lonestar.org
>> 
>> > None of these have assignments.
>> 
>> Do we need assignments for any of these?
>
> No, we don't.

Then one last procedural question before I get started on that
initial commit. Do we want to preserve the git history or just
bring it in as if it were new file? If the former should the
commit messages all be cleaned up to conform to Emacs standards?

Anything other requirements or considerations I should keep in
mind while preparing for the import?

Message #49 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: acorallo <at> gnu.org, stefankangas <at> gmail.com, 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Wed, 05 Mar 2025 21:03:53 +0200

> From: john muhl <jm <at> pub.pink>
> Cc: stefankangas <at> gmail.com, acorallo <at> gnu.org, 76650 <at> debbugs.gnu.org
> Date: Wed, 05 Mar 2025 10:33:20 -0600
> 
> Then one last procedural question before I get started on that
> initial commit. Do we want to preserve the git history or just
> bring it in as if it were new file?

It is best to preserve it.

> If the former should the commit messages all be cleaned up to
> conform to Emacs standards?

Is that even practical?

Message #52 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, john muhl <jm <at> pub.pink>
Cc: acorallo <at> gnu.org, 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Wed, 5 Mar 2025 11:31:50 -0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: john muhl <jm <at> pub.pink>
>> Cc: stefankangas <at> gmail.com, acorallo <at> gnu.org, 76650 <at> debbugs.gnu.org
>> Date: Wed, 05 Mar 2025 10:33:20 -0600
>>
>> Then one last procedural question before I get started on that
>> initial commit. Do we want to preserve the git history or just
>> bring it in as if it were new file?
>
> It is best to preserve it.

Indeed.  This is one possible starting point:
https://gist.github.com/joaotavora/2ed97f2ec85958986983d5cb78202770

The idea is to put the changes on a separate branch containing only that
one file in its right location, and then to merge that to master.

>> If the former should the commit messages all be cleaned up to
>> conform to Emacs standards?
>
> Is that even practical?

It's not necessary, and its impractical.  The commit that merges to
master could have a ChangeLog entry like this:

    * lisp/progmodes/lua-mode.ts: New file.

Message #55 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, acorallo <at> gnu.org, 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Wed, 05 Mar 2025 19:09:25 -0600

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> From: john muhl <jm <at> pub.pink>
>>> Cc: stefankangas <at> gmail.com, acorallo <at> gnu.org, 76650 <at> debbugs.gnu.org
>>> Date: Wed, 05 Mar 2025 10:33:20 -0600
>>>
>>> Then one last procedural question before I get started on that
>>> initial commit. Do we want to preserve the git history or just
>>> bring it in as if it were new file?
>>
>> It is best to preserve it.
>
> Indeed.  This is one possible starting point:
> https://gist.github.com/joaotavora/2ed97f2ec85958986983d5cb78202770
>
> The idea is to put the changes on a separate branch containing only that
> one file in its right location, and then to merge that to master.

Ok. I have the history in a branch.

https://git.sr.ht/~johnmuhl/emacs/log/scratch/lua-mode

In the latest commit there I’ve gone through and marked all the
lines remaining from the inital commit. Please correct me if I’m
wrong but the only thing that looks possibly significant
copyright-wise is the function ‘lua-end-of-proc’. Am I too
optimistic?

>>> If the former should the commit messages all be cleaned up to
>>> conform to Emacs standards?
>>
>> Is that even practical?
>
> It's not necessary, and its impractical.  The commit that merges to
> master could have a ChangeLog entry like this:
>
>     * lisp/progmodes/lua-mode.ts: New file.

Great. I was not looking forward to that effort.

Message #58 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: 76650 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>, acorallo <at> gnu.org,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Thu, 13 Mar 2025 16:50:49 -0500

john muhl <jm <at> pub.pink> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>>>> From: john muhl <jm <at> pub.pink>
>>>> Cc: stefankangas <at> gmail.com, acorallo <at> gnu.org, 76650 <at> debbugs.gnu.org
>>>> Date: Wed, 05 Mar 2025 10:33:20 -0600
>>>>
>>>> Then one last procedural question before I get started on that
>>>> initial commit. Do we want to preserve the git history or just
>>>> bring it in as if it were new file?
>>>
>>> It is best to preserve it.
>>
>> Indeed.  This is one possible starting point:
>> https://gist.github.com/joaotavora/2ed97f2ec85958986983d5cb78202770
>>
>> The idea is to put the changes on a separate branch containing only that
>> one file in its right location, and then to merge that to master.
>
> Ok. I have the history in a branch.
>
> https://git.sr.ht/~johnmuhl/emacs/log/scratch/lua-mode
>
> In the latest commit there I’ve gone through and marked all the
> lines remaining from the inital commit. Please correct me if I’m
> wrong but the only thing that looks possibly significant
> copyright-wise is the function ‘lua-end-of-proc’. Am I too
> optimistic?

To update the progress here. I rewrote the lua-end-of-proc
function and a few other places. That got us down to 160 lines
from the original commit:

https://git.sr.ht/~johnmuhl/emacs/tree/79db03ca/item/lisp/progmodes/lua-mode.el

Going through that and unmarking comments, docstrings and lines of
code that obviously fall short of copyright (e.g. save-excursion,
trivial interactive forms, defuns, &c.) gets down to 28 lines:

https://git.sr.ht/~johnmuhl/emacs/tree/8d44ba06/item/lisp/progmodes/lua-mode.el

(search “; 03e991” to check what’s left)

Of those none of them look to me like they’d qualify as original
or substantial enough to matter.

Message #61 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: 76650 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>, acorallo <at> gnu.org,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Fri, 21 Mar 2025 12:31:18 -0500

[Message part 1 (text/plain, inline)]

I think we’re close now. The attached patch should be ready to
install or at least review.

Use of advice has been removed, byte-compiler and checkdoc
warnings are fixed and tests have been added. For the tests I just
copied the lua-ts-mode files and adjusted for the current state of
lua-mode.

Once landed I’ll follow up with some improvements and work out how
to share code between the Lua modes (following the Ruby model
unless there is some other preference).

[0001-Add-lua-mode.patch (text/x-patch, attachment)]

Message #66 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: Vedat Hallac <vedat <at> ml.hallac.net>
To: "76650" <76650 <at> debbugs.gnu.org>
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Thu, 27 Mar 2025 09:34:29 +0300

 
 > There are about a dozen 
 > authors with contributions over the exempted 15 lines and most of 
 > those I was able to find commits from in emacs.git. 

I am one of the unknown authors that have some lines in the file.
  
A long time ago (10+ years or so) I completed the copyright assignment
paperwork. So, feel free to add the code I touched. I am not sure if 
I have code in emacs git, so I wanted to be explicit.

Message #69 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: 76650 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>, acorallo <at> gnu.org,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Sat, 26 Apr 2025 10:06:28 -0500

Is there anything else to do here?

john muhl <jm <at> pub.pink> writes:

> I think we’re close now. The attached patch should be ready to
> install or at least review.
>
> Use of advice has been removed, byte-compiler and checkdoc
> warnings are fixed and tests have been added. For the tests I just
> copied the lua-ts-mode files and adjusted for the current state of
> lua-mode.
>
> Once landed I’ll follow up with some improvements and work out how
> to share code between the Lua modes (following the Ruby model
> unless there is some other preference).

Message #72 received at 76650 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: john muhl <jm <at> pub.pink>
Cc: Eli Zaretskii <eliz <at> gnu.org>, acorallo <at> gnu.org,
 Stefan Kangas <stefankangas <at> gmail.com>, 76650 <at> debbugs.gnu.org
Subject: Re: bug#76650: 31.0.50; Add lua-mode to Emacs
Date: Sun, 27 Apr 2025 10:02:20 +0800

john muhl <jm <at> pub.pink> writes:

> Is there anything else to do here?

If anyone will confirm that all pertinent papers have been collected, I
shall proceed to merge this patch.  As of late I have found myself
writing solid amounts of Lua both professionally and as an amateur, and
it would be plenty helpful if lua-mode were available in Emacs by
default.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.