GNU bug report logs - #76648
Crash trying to parse nilfs2 superblock

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Butenko, Anton" <abutenko <at> akamai.com>
Subject: bug#76648: closed (Re: bug#76648: Crash trying to parse nilfs2
 superblock)
Date: Wed, 28 May 2025 20:55:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#76648: Crash trying to parse nilfs2 superblock

which was filed against the parted package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 76648 <at> debbugs.gnu.org.

-- 
76648: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76648
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Brian C. Lane" <bcl <at> redhat.com>
To: "Butenko, Anton" <abutenko <at> akamai.com>
Cc: 76648-done <at> debbugs.gnu.org
Subject: Re: bug#76648: Crash trying to parse nilfs2 superblock
Date: Wed, 28 May 2025 13:54:40 -0700

On Fri, Feb 28, 2025 at 03:21:00PM +0000, Butenko, Anton via Bug reports for the GNU Parted disk partition editor wrote:
> Hello,
> 
> I was checking how good is fix of
> 
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34392
> “Avoid sigsegv in case 2nd nilfs2 superblock magic accidently found.”
> 
> In systemd, libblkid and parted and found a slight possibility of crash in parted regarding to the changes in the referred bug.
> The parted fix includes a chance to crash in case of nilfs2 superblock having correct magic, but corrupted “bytes” field (value in range from 12 to 20).
> 
> I’ve modified the code to avoid the sigsegv and align implementation with the libblkid implementation:
> https://github.com/util-linux/util-linux/commit/ac681a310c32319423297544833932f4d689a7a2
> And modified t4301-nilfs2-badsb2.sh test code to trigger this case as well as the previously reported one.
> 
> I've attached a patch with my modifications. Can you, please, look at it?

Sorry it took so long to look at this, it looks good to me. I'm posting
it to the parted-devel list and if there are no objections I'll push it
by Friday.

Thanks,

Brian

-- 
Brian C. Lane (PST8PDT) - weldr.io - lorax - parted - pykickstart

[Message part 3 (message/rfc822, inline)]

From: "Butenko, Anton" <abutenko <at> akamai.com>
To: "bug-parted <at> gnu.org" <bug-parted <at> gnu.org>
Subject: Crash trying to parse nilfs2 superblock
Date: Fri, 28 Feb 2025 15:21:00 +0000

[Message part 4 (text/plain, inline)]

Hello,

I was checking how good is fix of

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34392
“Avoid sigsegv in case 2nd nilfs2 superblock magic accidently found.”

In systemd, libblkid and parted and found a slight possibility of crash in parted regarding to the changes in the referred bug.
The parted fix includes a chance to crash in case of nilfs2 superblock having correct magic, but corrupted “bytes” field (value in range from 12 to 20).

I’ve modified the code to avoid the sigsegv and align implementation with the libblkid implementation:
https://github.com/util-linux/util-linux/commit/ac681a310c32319423297544833932f4d689a7a2
And modified t4301-nilfs2-badsb2.sh test code to trigger this case as well as the previously reported one.

I've attached a patch with my modifications. Can you, please, look at it?

Regards,
Anton Butenko

[Message part 5 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.