GNU bug report logs - #76640
Request for merging "games-updates" branch

Previous Next

To reply to this bug, email your comments to 76640 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: bug-guix <at> gnu.org
Subject: Request for merging games-updates branch
Date: Fri, 28 Feb 2025 12:22:35 +0000

Contains:

    - https://issues.guix.gnu.org/58403 - Add sc-controller
    - https://issues.guix.gnu.org/70896 - Add wordwarvi
    - https://issues.guix.gnu.org/69610 - Add superfluous-returnz
    - https://issues.guix.gnu.org/73756 - Add netpanzer

Message #10 received at 76640 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Steve George <steve <at> futurile.net>
Cc: 76640 <at> debbugs.gnu.org
Subject: Re: bug#76640: Request for merging games-updates branch
Date: Sun, 02 Mar 2025 14:32:55 +0900

Hi Steve,

Steve George <steve <at> futurile.net> writes:

> Contains:
>
>     - https://issues.guix.gnu.org/58403 - Add sc-controller
>     - https://issues.guix.gnu.org/70896 - Add wordwarvi
>     - https://issues.guix.gnu.org/69610 - Add superfluous-returnz
>     - https://issues.guix.gnu.org/73756 - Add netpanzer

Have these been reviewed yet?

Since they are leaf packages, if they build and run fine (and ideally
have been reviewed), I'd say go for it!

-- 
Thanks,
Maxim

Message #13 received at 76640 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 76640 <at> debbugs.gnu.org, Steve George <steve <at> futurile.net>
Subject: Re: bug#76640: Request for merging games-updates branch
Date: Tue, 6 May 2025 09:11:40 -0400

On Sun, Mar 2, 2025 at 12:34 AM Maxim Cournoyer
<maxim.cournoyer <at> gmail.com> wrote:
>
> Hi Steve,
>
> Steve George <steve <at> futurile.net> writes:
>
> > Contains:
> >
> >     - https://issues.guix.gnu.org/58403 - Add sc-controller
> >     - https://issues.guix.gnu.org/70896 - Add wordwarvi
> >     - https://issues.guix.gnu.org/69610 - Add superfluous-returnz
> >     - https://issues.guix.gnu.org/73756 - Add netpanzer
>
> Have these been reviewed yet?
>
> Since they are leaf packages, if they build and run fine (and ideally
> have been reviewed), I'd say go for it!
>
> --
> Thanks,
> Maxim

Is QA able to process this branch, which has not been rebased since
the end of February? Also, these patches should have been (and still
could be) applied directly to master. From the manual [0]:

The QA infrastructure recognizes such issues and lists the merge
requests on its main page. The following points apply to managing
these branches:
[...]
2. Any changes that can be made on the master branch, should be made
on the master branch. If a commit can be split to apply part of the
changes on master, this is good to do.
[...]

[0] https://guix.gnu.org/manual/devel/en/html_node/Managing-Patches-and-Branches.html

Message #16 received at 76640 <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: Greg Hogan <code <at> greghogan.com>
Cc: 76640 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: bug#76640: Request for merging games-updates branch
Date: Tue, 6 May 2025 15:48:48 +0100

Hi Greg,

On  6 May, Greg Hogan wrote:
> On Sun, Mar 2, 2025 at 12:34 AM Maxim Cournoyer
> <maxim.cournoyer <at> gmail.com> wrote:
(...)
> > Since they are leaf packages, if they build and run fine (and ideally
> > have been reviewed), I'd say go for it!
(...) 
> Is QA able to process this branch, which has not been rebased since
> the end of February? Also, these patches should have been (and still
> could be) applied directly to master. From the manual [0]:
> 
> The QA infrastructure recognizes such issues and lists the merge
> requests on its main page. The following points apply to managing
> these branches:
> [...]
> 2. Any changes that can be made on the master branch, should be made
> on the master branch. If a commit can be split to apply part of the
> changes on master, this is good to do.
> [...]
> 
> [0] https://guix.gnu.org/manual/devel/en/html_node/Managing-Patches-and-Branches.html

I was hoping QA would process them eventually, but it never gets there due to our hardware constraints. So I'll apply them directly to master and get rid of the branch.

I appreciate the manual says to do things on master, but I personally don't like it - I'd like to build on a feature branch, have QA confirm I haven't messed anything up (plus get substitutes) and then put the successful branch onto master. That feels safer to me - but yeah, our QA/CI infrastructure isn't sufficient.

Thanks for the interest!

Steve / Futurile

Message #19 received at 76640 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Steve George <steve <at> futurile.net>
Cc: 76640 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: bug#76640: Request for merging games-updates branch
Date: Tue, 6 May 2025 11:29:16 -0400

On Tue, May 6, 2025 at 10:49 AM Steve George <steve <at> futurile.net> wrote:
>
> Hi Greg,
>
> On  6 May, Greg Hogan wrote:
> > On Sun, Mar 2, 2025 at 12:34 AM Maxim Cournoyer
> > <maxim.cournoyer <at> gmail.com> wrote:
> (...)
> > > Since they are leaf packages, if they build and run fine (and ideally
> > > have been reviewed), I'd say go for it!
> (...)
> > Is QA able to process this branch, which has not been rebased since
> > the end of February? Also, these patches should have been (and still
> > could be) applied directly to master. From the manual [0]:
> >
> > The QA infrastructure recognizes such issues and lists the merge
> > requests on its main page. The following points apply to managing
> > these branches:
> > [...]
> > 2. Any changes that can be made on the master branch, should be made
> > on the master branch. If a commit can be split to apply part of the
> > changes on master, this is good to do.
> > [...]
> >
> > [0] https://guix.gnu.org/manual/devel/en/html_node/Managing-Patches-and-Branches.html
>
> I was hoping QA would process them eventually, but it never gets there due to our hardware constraints. So I'll apply them directly to master and get rid of the branch.
>
> I appreciate the manual says to do things on master, but I personally don't like it - I'd like to build on a feature branch, have QA confirm I haven't messed anything up (plus get substitutes) and then put the successful branch onto master. That feels safer to me - but yeah, our QA/CI infrastructure isn't sufficient.
>
> Thanks for the interest!
>
> Steve / Futurile

I wholeheartedly agree. Would having a games-team specification on CI
serve a similar purpose? That cluster seems more able to keep up (and
currently mostly idle).

Message #22 received at 76640 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Greg Hogan <code <at> greghogan.com>
Cc: 76640 <at> debbugs.gnu.org, Steve George <steve <at> futurile.net>
Subject: Re: bug#76640: Request for merging games-updates branch
Date: Thu, 08 May 2025 15:51:51 +0900

Hi,

Greg Hogan <code <at> greghogan.com> writes:

[...]

> I wholeheartedly agree. Would having a games-team specification on CI
> serve a similar purpose? That cluster seems more able to keep up (and
> currently mostly idle).

That could be useful I guess!  Steve, let me know if you'd like a TLS
client certificate that would allow you to use the admin features of the
Berlin Cuirass instance.

-- 
Thanks,
Maxim

Message #25 received at 76640 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 76640 <at> debbugs.gnu.org, Steve George <steve <at> futurile.net>,
 Greg Hogan <code <at> greghogan.com>
Subject: Re: bug#76640: Request for merging games-updates branch
Date: Thu, 8 May 2025 13:25:14 +0200

Hello,

while I still think the different patches on this branch could go to
master directly, I have rebased on a recent master commit known to the
data service and pushed, since this branch is getting closer to the top.
I have dropped the freeciv update, as the same is already on master.

And I have added a specification to CI:
   https://ci.guix.gnu.org/jobset/games-updates

Andreas

Message #28 received at 76640 <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 76640 <at> debbugs.gnu.org, Greg Hogan <code <at> greghogan.com>
Subject: Re: bug#76640: Request for merging games-updates branch
Date: Thu, 8 May 2025 12:59:05 +0100

On  8 May, Maxim Cournoyer wrote:
> Hi,
> 
> Greg Hogan <code <at> greghogan.com> writes:
> 
> [...]
> 
> > I wholeheartedly agree. Would having a games-team specification on CI
> > serve a similar purpose? That cluster seems more able to keep up (and
> > currently mostly idle).
> 
> That could be useful I guess!  Steve, let me know if you'd like a TLS
> client certificate that would allow you to use the admin features of the
> Berlin Cuirass instance.
(...)

Hi Maxim - yes please, that would be great!

Steve / Futurile

Message #31 received at 76640 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 76640 <at> debbugs.gnu.org, Steve George <steve <at> futurile.net>,
 Greg Hogan <code <at> greghogan.com>
Subject: Re: bug#76640: Request for merging games-updates branch
Date: Thu, 8 May 2025 19:36:38 +0200

Things look good on x86_64 and i686:
   https://ci.guix.gnu.org/eval/2057155

If that is enough for you and the patches are good, please feel
free to push this branch to master (and close this bug and delete the
branch afterwards).

Andreas

Message #34 received at 76640 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 76640 <at> debbugs.gnu.org, Steve George <steve <at> futurile.net>,
 Greg Hogan <code <at> greghogan.com>
Subject: Re: bug#76640: Request for merging games-updates branch
Date: Mon, 12 May 2025 16:05:44 +0200

Hello,

after an r-team merge, I have rebased and pushed again.

Andreas

Message #39 received at 76640 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 76640 <at> debbugs.gnu.org, Steve George <steve <at> futurile.net>,
 Greg Hogan <code <at> greghogan.com>
Subject: Re: bug#76640: Request for merging games-updates branch
Date: Thu, 15 May 2025 13:57:09 +0200

Hello,

after the kernel-team merge, I have rebased again and pushed.
You are now first in queue to be merged, please keep an eye on
   https://qa.guix.gnu.org/branch/games-updates

Andreas

Message #42 received at 76640 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 76640 <at> debbugs.gnu.org
Cc: Steve George <steve <at> futurile.net>
Subject: Request for merging "games-updates" branch
Date: Tue, 20 May 2025 19:59:50 +0100

[Message part 1 (text/plain, inline)]

Hi,

Would you like to merge the branch?
80%+ build coverage on ci and Bordeaux

VCS: https://github.incerto.xyz/; https://git.sr.ht/~hellseher/
GPG: 9847 81DE 689C 21C2 6418 0867 76D7 27BF F62C D2B5

… наш разум - превосходная объяснительная машина которая способна найти
смысл почти в чем угодно, истолковать любой феномен, но совершенно не в
состоянии принять мысль о непредсказуемости.

[Message part 2 (text/html, inline)]

Message #47 received at 76640-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: Steve George <steve <at> futurile.net>, 73756-done <at> debbugs.gnu.org,
 76640-done <at> debbugs.gnu.org, 70896-done <at> debbugs.gnu.org,
 69610-done <at> debbugs.gnu.org, 58403-done <at> debbugs.gnu.org
Subject: Re: Request for merging "games-updates" branch
Date: Fri, 23 May 2025 08:45:11 +0200

Hello,

I have just pushed the games-updates branch to master.
Closing all the contained issues.

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.