Subject: Re: [bug#76635] [PATCH] gnu: Add dte.

From: 宋文武 <[email-masked]>
Date: Wed, 05 Mar 2025 09:04:37 +0800

Hello,

[email-masked] writes:

> [...]
> +(define-public dte
> +  (package
> +    (name "dte")
> +    (version "1.11.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://gitlab.com/craigbarnes/dte")
> +                    (commit (string-append "v" version))))
> +              (sha256
> +               (base32
> +                "1q43jvhj6r1ws58ngpcq8mzj4di7mj2a4bmigk9zy0f3riagnlv1"))))

When using git-fetch, it's required to also use '(file-name (git-file-name ...))'.

> +    (build-system gnu-build-system)
> +    (native-inputs
> +     (list util-linux))
> +    (arguments
> +     (list
> +      #:make-flags
> +      #~(list (string-append "CC=" #$(cc-for-target))
> +              (string-append "prefix=" #$output))
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (delete 'configure))))
> +    (home-page "https://gitlab.com/craigbarnes/dte/")
Prefer a real home page if existed, so should be: https://craigbarnes.gitlab.io/dte/

> +    (synopsis "Small and easy to use console text editor.")
synopsis should not ends with '.'.

Otherwise looks good, could you send an update patch?  Thanks.