From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 27 18:13:02 2025 Received: (at submit) by debbugs.gnu.org; 27 Feb 2025 23:13:02 +0000 Received: from localhost ([127.0.0.1]:39706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tnn3t-00082Q-9Z for submit@debbugs.gnu.org; Thu, 27 Feb 2025 18:13:02 -0500 Received: from lists.gnu.org ([2001:470:142::17]:34386) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tnn2m-0007vI-CF for submit@debbugs.gnu.org; Thu, 27 Feb 2025 18:11:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnn2e-0002zl-ED for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2025 18:11:44 -0500 Received: from mxout5.mail.janestreet.com ([64.215.233.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnn2c-0000KG-38 for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2025 18:11:44 -0500 From: Spencer Baugh To: bug-gnu-emacs@gnu.org Subject: 30.1.50; mouse-1 mode-line bindings are unusable when point is on a button X-Debbugs-Cc: Jonas Bernoulli Date: Thu, 27 Feb 2025 18:11:36 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1740697898; bh=wa3Dydm0F5gLtVPRAL5kx3VEmP62tppEE/vr2Y4l468=; h=From:To:Subject:Date; b=pvUSi6OsUn2J+Wfncd5+ZeK8dDEir1e9RW9F4KYQmp+oYIjiA0YqX8F8G0uQm1IrQ Izz1AlwHz0BBdBA8T7fIo9wAVOVybTkRiowdn2xOYM+i+a/tXxz2ZXiw5gqkv89bNf FEpINToqHoEIXtVvFd5ro6kGdTms349ZO6dYCjCpQGHlqsDlIPPNevocK8S8ZZnZmy ueJpKrgQnOoLlkh6CYLIMBOc5v2A1NlDnIh1p+Y/FFj3o69A/YdoGRTTWRRuAEYJpi z5U5a3yoBnX9EICn/+Q2tD/PX1zSqPL5EXmj3JhN/heNviySXlqthEn+tZ53wok5w0 F/YQ40HXklfKQ== Received-SPF: pass client-ip=64.215.233.18; envelope-from=sbaugh@janestreet.com; helo=mxout5.mail.janestreet.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) 1. emacs -Q 2. Position point over a button.el button, e.g. (progn (view-emacs-news) (forward-button 1)) 3. mouse-2 anywhere on the mode line. 4. Note that instead of the usual mouse-delete-other-windows binding, the button at point is activated. This is because the local keymap for buttons is button-map, which binds " ". This is confusing, and probably a bug, but not too bad of a bug. Substantially worse is this: 5. mouse-1 on a part of the mode-line with a mouse-1 binding; for example, mouse-1 on the buffer coding system indicator "U" at the start of the mode line. 6. Instead of describing the buffer's coding system, the button at point is activated. This is because mouse-1-click-follows-link translates the mouse-1 into a mouse-2. This makes all mouse-1 bindings on the mode line basically broken while point is on a button. The mode-line (and header-line) binding was added to button.el in 24fc9480399b2d018e8d85f34e9c5d8c327ce3bf to support using buttons in the mode-line and header-line. I suggest that we should remove those bindings, in favor of some other way to use button.el in the mode-line or header-line. Especially because, from grepping through ~400 popular packages (the ones installed at my site), I see no usage of buttons in the mode-line or header-line. In GNU Emacs 30.1.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.15.12, Xaw scroll bars) of 2025-02-24 built on igm-qws-u22796a Repository revision: b3f0c1a30a1fee5a81b7a0c6c7f52ec0ef5bade6 Repository branch: emacs-30 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Rocky Linux 8.10 (Green Obsidian) Configured using: 'configure --config-cache --with-x-toolkit=lucid --without-gpm --without-gconf --without-selinux --without-imagemagick --with-modules --with-gif=no --with-cairo --with-rsvg --without-compress-install --with-tree-sitter' Configured features: CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr compile comint ansi-osc ansi-color ring comp-run bytecomp byte-compile comp-common rx emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 92421 9053) (symbols 48 6739 0) (strings 32 26097 2919) (string-bytes 1 786157) (vectors 16 16424) (vector-slots 8 188776 8192) (floats 8 37 1) (intervals 56 320 0) (buffers 992 11)) From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 28 02:52:28 2025 Received: (at 76620) by debbugs.gnu.org; 28 Feb 2025 07:52:29 +0000 Received: from localhost ([127.0.0.1]:44541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tnvAZ-0002Wn-8S for submit@debbugs.gnu.org; Fri, 28 Feb 2025 02:52:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45134) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tnvAT-0002VW-2h for 76620@debbugs.gnu.org; Fri, 28 Feb 2025 02:52:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnvAK-0006j6-WD; Fri, 28 Feb 2025 02:52:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U3P12pG6p9IR/NS0B/1iy6XIAgvXGMSaCcyZMUZfSAA=; b=jUgocm4w0Rrc Fut7jAPu/czYcmy5yXKLFXf+zvTS7SHI6M15DbuYo3gw3OWO8ovJHjrnakVv5EbW+wyQ7en9CEm3/ TbQpt9w0nIpeEWzbKl6o/cFJJ/nwgRi0exqH6CCGYYgQSs7o5ondzTrVaZymxldGnvkbCO5vuGnQ6 pupgY2Fc2vHVCVIp94PAxHDsdUFnMJnC7DSLPnLAZBcjPFtH06fN/yQJlT9hb8YUmken0HP/bUMGD b8174MkuZh28tUz1OTc55tXD2mOITUfA4rYiHbuh/f0GTCMv6d4uzZBVlF2LcJojKpK7HwtRSejM5 B7tUgKTypx66DxN4zqKYVQ==; Date: Fri, 28 Feb 2025 09:52:10 +0200 Message-Id: <86tt8esdzp.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh , Stefan Monnier In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#76620: 30.1.50; mouse-1 mode-line bindings are unusable when point is on a button References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76620 Cc: 76620@debbugs.gnu.org, jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Jonas Bernoulli > Date: Thu, 27 Feb 2025 18:11:36 -0500 > From: Spencer Baugh via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > 1. emacs -Q > 2. Position point over a button.el button, e.g. > (progn (view-emacs-news) (forward-button 1)) > 3. mouse-2 anywhere on the mode line. > 4. Note that instead of the usual mouse-delete-other-windows binding, > the button at point is activated. > > This is because the local keymap for buttons is button-map, which binds > " ". This is confusing, and probably a bug, but not > too bad of a bug. > > Substantially worse is this: > > 5. mouse-1 on a part of the mode-line with a mouse-1 binding; for > example, mouse-1 on the buffer coding system indicator "U" at the > start of the mode line. > > 6. Instead of describing the buffer's coding system, the button at point > is activated. > > This is because mouse-1-click-follows-link translates the mouse-1 into a > mouse-2. This makes all mouse-1 bindings on the mode line basically > broken while point is on a button. The bugs with mouse-1 are solved on the master branch (see bug#75219). So I can reproduce the last two items in Emacs 30, but not in Emacs 31. The problems with mouse-2 are still present on the master branch. > The mode-line (and header-line) binding was added to button.el in > 24fc9480399b2d018e8d85f34e9c5d8c327ce3bf to support using buttons in the > mode-line and header-line. I suggest that we should remove those > bindings, in favor of some other way to use button.el in the mode-line > or header-line. Especially because, from grepping through ~400 popular > packages (the ones installed at my site), I see no usage of buttons in > the mode-line or header-line. Adding Stefan to the discussion. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 28 03:27:20 2025 Received: (at 76620) by debbugs.gnu.org; 28 Feb 2025 08:27:20 +0000 Received: from localhost ([127.0.0.1]:44784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tnviK-0005Ey-Au for submit@debbugs.gnu.org; Fri, 28 Feb 2025 03:27:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45186) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tnviH-0005Ei-Dm for 76620@debbugs.gnu.org; Fri, 28 Feb 2025 03:27:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnvi8-0002ED-SR; Fri, 28 Feb 2025 03:27:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qMIDeQsklv+YmlzG8znXs0skpmqUFXZvG6E6/TB7sTE=; b=oSFoh2zv7nih t0MtTcIU0GzX4LlWjjhQQGXrviKZV7Cu87tPzvdpLsn07HGGkeEojetIa6n2t+xwceyVr0EFZs+TS Ianu7kGiP1cgVemyjd/CefRIKAhI+FBLQNU5MFuhAkxruO2/XStQXtYjPlGHH1hgocLx9cDd9Vuxy tzRPHvqpUyjz6jUCBgsXuYHNzwTKzX8Cv/m3Qm6UPEastCXMXmcaaC2xn8FSjpUYYfyo5LSoDYCR5 TjJ/1vqa6ycLyDKjfOAUnhYcMrwOAHrvbN+aAx1YNJlh0DpjPTL9ayh/9ae9XGD1FEXqIJ+CHgYhd sn+8UCCng59kcnvT6RZxNQ==; Date: Fri, 28 Feb 2025 10:27:04 +0200 Message-Id: <86ldtqscdj.fsf@gnu.org> From: Eli Zaretskii To: sbaugh@janestreet.com, monnier@iro.umontreal.ca In-Reply-To: <86tt8esdzp.fsf@gnu.org> (message from Eli Zaretskii on Fri, 28 Feb 2025 09:52:10 +0200) Subject: Re: bug#76620: 30.1.50; mouse-1 mode-line bindings are unusable when point is on a button References: <86tt8esdzp.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76620 Cc: 76620@debbugs.gnu.org, jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 76620@debbugs.gnu.org, jonas@bernoul.li > Date: Fri, 28 Feb 2025 09:52:10 +0200 > From: Eli Zaretskii > > > 5. mouse-1 on a part of the mode-line with a mouse-1 binding; for > > example, mouse-1 on the buffer coding system indicator "U" at the > > start of the mode line. > > > > 6. Instead of describing the buffer's coding system, the button at point > > is activated. > > > > This is because mouse-1-click-follows-link translates the mouse-1 into a > > mouse-2. This makes all mouse-1 bindings on the mode line basically > > broken while point is on a button. > > The bugs with mouse-1 are solved on the master branch (see bug#75219). > So I can reproduce the last two items in Emacs 30, but not in Emacs > 31. The problems with mouse-2 are still present on the master branch. I've now cherry-picked that fix to the emacs-30 branch, so the issues with mouse-1 on the mode line in this situation should be solved in Emacs 30.2. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 28 10:44:15 2025 Received: (at 76620) by debbugs.gnu.org; 28 Feb 2025 15:44:16 +0000 Received: from localhost ([127.0.0.1]:51047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1to2X9-0003Oc-Hq for submit@debbugs.gnu.org; Fri, 28 Feb 2025 10:44:15 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7969) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1to2X2-0003Nk-TS for 76620@debbugs.gnu.org; Fri, 28 Feb 2025 10:44:12 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E63C3442E4E; Fri, 28 Feb 2025 10:44:02 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1740757441; bh=OZgjIbariDuasfHonIrM55O1mPY3MX5VnmyD/UBJofY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SMVa4by1w6uPrElJWOA3LDKhFreUxVajA1TRmfixbtWD6c/3JF48ySqq5SZ8UXxYj FA5xq4UfTgo4qOFo7LxjOfU72j1urzIzKcsIq6xnOdzq7ISz+Cxgireq7XXY75+q3D tSJBxtWJAzZ00uujR+fpGlkqHadHfveSrjCw2SpAk8N82xzmFqQvyoC1JnRzCHcax0 vRxUYtMZ/xNLvFiAwY7sQXBidMPamNa8KyawsLHVEXgrnG2FgvplESyxu3JLjf88Ug ZofapX06ktT28igS3SrBfpLzqBbxheD1CfUw58Hdp5Mo4vK9i5CM5GAjTKdqF1PIJL LxR+9WgeRFulw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C8BC744084B; Fri, 28 Feb 2025 10:44:01 -0500 (EST) Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A3840120541; Fri, 28 Feb 2025 10:44:01 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#76620: 30.1.50; mouse-1 mode-line bindings are unusable when point is on a button In-Reply-To: <86tt8esdzp.fsf@gnu.org> Message-ID: References: <86tt8esdzp.fsf@gnu.org> Date: Fri, 28 Feb 2025 10:44:00 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76620 Cc: Spencer Baugh , 76620@debbugs.gnu.org, jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> The mode-line (and header-line) binding was added to button.el in >> 24fc9480399b2d018e8d85f34e9c5d8c327ce3bf to support using buttons in the >> mode-line and header-line. I suggest that we should remove those >> bindings, in favor of some other way to use button.el in the mode-line >> or header-line. Especially because, from grepping through ~400 popular >> packages (the ones installed at my site), I see no usage of buttons in >> the mode-line or header-line. > > Adding Stefan to the discussion. FWIW, I've used code which used the same text (with buttons) in the header-line and in the buffer. But yeah, that was more an experiment than anything. I don't think I still use such code. So, it's a "nice to have" but not if it breaks something else. [ In another similar experiment, I tried to make an "in-buffer toolbar", but for that one using the same data was simply not an option, I needed a translation function. ] Seeing some of the crazy things some people do in fancy packages, I wouldn't be completely surprised to hear that some people actually use such things rather than just experiment with them. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 09 05:50:33 2025 Received: (at 76620) by debbugs.gnu.org; 9 Mar 2025 09:50:33 +0000 Received: from localhost ([127.0.0.1]:58389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trDIm-0005Z5-Vc for submit@debbugs.gnu.org; Sun, 09 Mar 2025 05:50:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41716) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1trDIl-0005Yu-Fd for 76620@debbugs.gnu.org; Sun, 09 Mar 2025 05:50:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trDIc-0006Z7-KK; Sun, 09 Mar 2025 05:50:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=g5HNksrj1ZqlcndQIMoENR4FOZqzBTnYxkHOX9EZig0=; b=dwIobXUdkKBO 2nA/KZHee7NWofu7VzZ4L0HGRcQbvIvRD5FGePZ0k5ZlBE8iB05H8PaLAiqnQu753ywtDO5lt6wz5 ZQlmYs4trsa5fImA/VVBjcMexqMOQEKqBnFHp++yg+2o3tZjh38ZSRGa2I+47OHs0QdBtaB9YLxT/ 5kkmduES7VUa1g+pANPU923x8BsklATxYDkPGzl0NkqP/GCgIHpnr3saoCXD9obzfrhmAmF1Xm3qC XNyuEVDZxuOz27qEdQhYBs4+y1dEMoSmkM14JUd69hMov0t0JtpouewwwzqNTSCwi5sMQKOr7ROez LxgTxIOpTlbOvrDoEnOwbw==; Date: Sun, 09 Mar 2025 11:50:20 +0200 Message-Id: <86bjuah6sj.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Fri, 28 Feb 2025 10:44:00 -0500) Subject: Re: bug#76620: 30.1.50; mouse-1 mode-line bindings are unusable when point is on a button References: <86tt8esdzp.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76620 Cc: sbaugh@janestreet.com, 76620@debbugs.gnu.org, jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Spencer Baugh , 76620@debbugs.gnu.org, > jonas@bernoul.li > Date: Fri, 28 Feb 2025 10:44:00 -0500 > > >> The mode-line (and header-line) binding was added to button.el in > >> 24fc9480399b2d018e8d85f34e9c5d8c327ce3bf to support using buttons in the > >> mode-line and header-line. I suggest that we should remove those > >> bindings, in favor of some other way to use button.el in the mode-line > >> or header-line. Especially because, from grepping through ~400 popular > >> packages (the ones installed at my site), I see no usage of buttons in > >> the mode-line or header-line. > > > > Adding Stefan to the discussion. > > FWIW, I've used code which used the same text (with buttons) in > the header-line and in the buffer. But yeah, that was more an > experiment than anything. I don't think I still use such code. > So, it's a "nice to have" but not if it breaks something else. So, on balance, you think we should revert commit 24fc9480399b2d018e8d85f34e9c5d8c327ce3bf? From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 09 18:25:37 2025 Received: (at 76620) by debbugs.gnu.org; 9 Mar 2025 22:25:37 +0000 Received: from localhost ([127.0.0.1]:34863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trP5V-0004GG-5o for submit@debbugs.gnu.org; Sun, 09 Mar 2025 18:25:37 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57985) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1trP5S-0004Fv-95 for 76620@debbugs.gnu.org; Sun, 09 Mar 2025 18:25:34 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DF460809AC; Sun, 9 Mar 2025 18:25:26 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1741559126; bh=PZqfOrfWLI5fvJwXT6cTeAdimb6CCyCniGfrU5cLFgE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QuafIozGS0lW4RxFKy34qEvq3ixlhLD5ug2faenI4+i2s2ylgdA3VsNl1xhGPQqKD XK7qs0y03PSZU6dJIvH2Im9OcMEDqBcmfBcPX6MX6am9IQuFSgXZ9AacK7R4NRfcdV WwJMBXr6YU0XmdXFPdFKNwaijU2xGL2Wlzp34xmhKViT9CqHd0uTD4pb7svfzoAlqb aDlQcGnAoxpxgGWe3jkTt/obLhv27NHT5BEFxJBilaasNqRMXQmGxSQWbCqzfg49ag iGyFCZDoS9g6j02hJjjen7XLUUnBARlp4gnf00c/LNKYMSxxwUB/GtpAfG+E96pXDs oNJh+ycvvdoMA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F05EE807F9; Sun, 9 Mar 2025 18:25:25 -0400 (EDT) Received: from alfajor (unknown [104.247.242.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B877F120642; Sun, 9 Mar 2025 18:25:25 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#76620: 30.1.50; mouse-1 mode-line bindings are unusable when point is on a button In-Reply-To: <86bjuah6sj.fsf@gnu.org> Message-ID: References: <86tt8esdzp.fsf@gnu.org> <86bjuah6sj.fsf@gnu.org> Date: Sun, 09 Mar 2025 18:25:24 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.272 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76620 Cc: sbaugh@janestreet.com, 76620@debbugs.gnu.org, jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> FWIW, I've used code which used the same text (with buttons) in >> the header-line and in the buffer. But yeah, that was more an >> experiment than anything. I don't think I still use such code. >> So, it's a "nice to have" but not if it breaks something else. > > So, on balance, you think we should revert commit > 24fc9480399b2d018e8d85f34e9c5d8c327ce3bf? I haven't looked at the problem closely enough to have an opinion, sorry. Stefan