Subject: Re: [bug#76619] [PATCH] gnu: home: services: Add 'wayland-display' service.

From: Ludovic Courtès <[email-masked]>
Date: Fri, 28 Feb 2025 23:02:07 +0100

Hello,

Sisiutl <[email-masked]> skribis:

> * gnu/home/services/desktop.scm (wayland-shepherd-service): New procedure.
> (home-wayland-service-type): New variable.
> * doc/guix.texi (Desktop Home Services): Document it.
>
> Change-Id: If1ed849d29198d2949c6852b0f2645e325211240

Nice!  So this is a followup to <https://issues.guix.gnu.org/76060>.

[...]

> +(define (wayland-shepherd-service config)
> +  (list (shepherd-service
> +         (provision '(wayland-display))
> +         (modules '((ice-9 ftw)
> +                    (ice-9 regex)
> +                    (ice-9 match)
> +                    (srfi srfi-1)
> +                    (shepherd support)))
> +         (respawn? #t)
> +         (respawn-limit config)
> +         (respawn-delay 1)

The default value for ‘config’ is 10, but that’s not a valid value for
‘respawn-limit’ (it should be a pair).

But anyway, we should remove these two fields: they have no effect,
except for services associated with a process.  We can also change
‘default-value’ to #f or so to not give the impression that it has a
special meaning.

Apart from that LGTM; let me know if you can make this change (and if it
sounds right to you) or I can do it on your behalf.

Thanks,
Ludo’.