Subject: bug#76606: 30.1; Conflict between completion-preview and yasnippet

From: Eshel Yaron <[email-masked]>
Date: Thu, 27 Feb 2025 14:45:01 +0100

Vincent Foley <[email-masked]> writes:

>> The following diff should fix this bug, could you please test it?
>>
>> diff --git a/lisp/completion-preview.el b/lisp/completion-preview.el
>> index 4928d9a8824..eb4b9111b30 100644
>> --- a/lisp/completion-preview.el
>> +++ b/lisp/completion-preview.el
>> @@ -520,6 +520,7 @@ completion-preview-complete
>>              ;; hook update the completion preview in case the candidate
>>              ;; can be completed further.
>>              (when (functionp efn)
>> +              (completion-preview-active-mode -1)
>>                (funcall efn (concat base com) (if (cdr all) 'exact 'finished)))
>>            ;; Otherwise, remove the common prefix from the preview.
>>            (completion-preview--inhibit-update)
>>
>> Regards,
>>
>> Eshel
>
> Hi Eshel,
>
> I applied this patch to my emacs-30.1 source tree and I can confirm that
> it fixes the issue. Thank you for addressing this so quickly!

Great, thanks for confirming.

Eli, is this fix OK for the emacs-30 branch or should it go to master?

Eshel