GNU bug report logs - #76601
[PATCH 0/1] dir-locals: Add copyrights.

Previous Next

Full log

Message #20 received at 76601 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: 76601 <at> debbugs.gnu.org
Subject: Re: [bug#76601] [PATCH v2] dir-locals: Add copyrights.
Date: Sun, 16 Mar 2025 16:26:15 +0100

[Message part 1 (text/plain, inline)]

Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org> writes:

> * .dir-locals.el: Add copyrights.
>
> The list was first generated with the 'git log --oneline
> --pretty=";;; Copyright © %ad %an <%ae>" --follow --date="format:%Y" --
> .dir-locals.el' command, and then the lines were regrouped together by hand,
> and finally the names and mails were updated to the ones currently used with
> the help of git grep.

I have used the following command to verify the content of the patch:

--8<---------------cut here---------------start------------->8---
git log --pretty='format:%as %an %ae' orig-master -- .dir-locals.el \
    | sed -E 's/-[0-9]{2}-[0-9]{2}//'                               \
    | sed -E 's/(....) (.*)/\2 \1/'                                 \
    | sort -u
--8<---------------cut here---------------end--------------->8---

>
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
> Change-Id: I010f1e5e3afc8b646da39dc6341f7870f0c9bf45
> ---
> ChangeLog v1->v2:
> =================
> * Fixed the command in the commit log (it didn't list all the commits).
> * Added missing Copyrights (Tomas Volf, Nicolas Graves, and 2025 for Maxim
>   Cournoyer). Thanks to Tomas Volf who found the issue.
> ---
>  .dir-locals.el | 34 +++++++++++++++++++++++++++++++++-
>  1 file changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/.dir-locals.el b/.dir-locals.el
> index 76c9e12992..983a92f5a6 100644
> --- a/.dir-locals.el
> +++ b/.dir-locals.el
> @@ -1,5 +1,37 @@
> -;; Per-directory local variables for GNU Emacs 23 and later.
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2012-2023 Ludovic Courtès <ludo <at> gnu.org>
> +;;; Copyright © 2013,2014 Mark H Weaver <mhw <at> netris.org>
> +;;; Copyright © 2014 Taylan Ulrich Bayırlı/Kammer <taylanbayirli <at> gmail.com>
> +;;; Copyright © 2015 David Thompson <davet <at> gnu.org>
> +;;; Copyright © 2016 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
> +;;; Copyright © 2017 Alex Kost <alezost <at> gmail.com>
> +;;; Copyright © 2018-2020 Caleb Ristvedt <caleb.ristvedt <at> cune.org>
> +;;; Copyright © 2020-2023,2025 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> +;;; Copyright © 2020 Miguel Ángel Arruga Vivas <rosen644835 <at> gmail.com>
> +;;; Copyright © 2020 Christine Lemmer-Webber <cwebber <at> dustycloud.org>
> +;;; Copyright © 2022 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
> +;;; Copyright © 2022 Andrew Tropin <andrew <at> trop.in>
> +;;; Copyright © 2022 Brian Cully <bjc <at> kublai.com>
> +;;; Copyright © 2023 (unmatched-parenthesis ew syntax <paren <at> disroot.org>
> +;;; Copyright © 2024 Christopher Baines <mail <at> cbaines.net>
> +;;; Copyright © 2024 Tomas Volf <~@wolfsden.cz>
> +;;; Copyright © 2024 Nicolas Graves <ngraves <at> ngraves.fr>

Hi, me again :) I think you are missing David Elsing.  I am not sure how
fresh your git checkout is, but on current master I see:

--8<---------------cut here---------------start------------->8---
commit 30e51cb6b42e86f9f94d6380f69a1020ee99ff39
Author: David Elsing <david.elsing <at> posteo.net>
Date:   Tue Mar 4 20:33:08 2025 +0000
--8<---------------cut here---------------end--------------->8---

One more nitpick could be that paren <at> disroot.org is known under multiple
names in our git history, and I am not sure which one is preferred.
Edits to .dir-locals.el were made under two of them, you picked the last
name used.  However last commit to Guix repository itself uses different
name (just `(unmatched-parenthesis').

Other than that LGTM.

Tomas

Reviewed-by: Tomas Volf <~@wolfsden.cz>

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.