GNU bug report logs - #76600
[PATCH] gnu: Add python-edalize.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76600: closed ([PATCH] gnu: Add python-edalize.)
Date: Sun, 13 Apr 2025 20:43:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 13 Apr 2025 21:42:42 +0100
with message-id <87mscjeqt9.fsf <at> gmail.com>
and subject line [PATCH] gnu: Add python-edalize.
has caused the debbugs.gnu.org bug report #76600,
regarding [PATCH] gnu: Add python-edalize.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76600: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76600
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH] gnu: Add python-edalize.
Date: Wed, 26 Feb 2025 22:20:16 +0100

* gnu/packages/electronics.scm (python-edalize): New variable.

Change-Id: Ia189a34ce01f46676654bf548bdb03c97f0d8082
---
 gnu/packages/electronics.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index df0238c348..c65370e877 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -31,6 +31,7 @@ (define-module (gnu packages electronics)
   #:use-module (guix utils)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system pyproject)
   #:use-module (gnu packages)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages autotools)
@@ -52,6 +53,8 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages m4)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages python-build)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages sdl)
   #:use-module (gnu packages sqlite)
@@ -522,3 +525,36 @@ (define-public minipro
 Additionally your user must be member of the @code{plugdev} group.")
       (home-page "https://gitlab.com/DavidGriffith/minipro")
       (license license:gpl3+))))
+
+(define-public python-edalize
+  (package
+    (name "python-edalize")
+    (version "0.6.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/olofk/edalize/")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1gfysk6wj3mxndyzma604i3y2lkfn1im0bdmzxv5rn4x2nyk68sc"))))
+    (build-system pyproject-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (replace 'check
+                    (lambda* (#:key tests? inputs outputs #:allow-other-keys)
+                      (when tests?
+                        ;; Skip erroneous tests
+                        (invoke "pytest" "tests" "-vv" "-k"
+                                (string-append "not test_gatemate "
+                                 "and not test_vivado_edif_netlist "
+                                 "and not test_xcelium " "and not test_vcs"))))))))
+    (native-inputs (list python-setuptools python-wheel python-jinja2
+                         python-pytest))
+    (home-page "https:/test_vivado_edif_netlist/github.com/olofk/edalize/")
+    (synopsis "Python Library for interacting with EDA tools")
+    (description
+     "Edalize can create project files for supported tools and run them in
+batch or GUI mode.")
+    (license license:bsd-2)))

base-commit: 54ff5d33739ae95c19f4ed5bea38d2613f6f7d3c
-- 
2.48.1

[Message part 3 (message/rfc822, inline)]

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 76600-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-edalize.
Date: Sun, 13 Apr 2025 21:42:42 +0100

[Message part 4 (text/plain, inline)]

Hi,

Thank you for the patch.

I've refactored it to utilize #:test-flags instead adjusting 'check phase
and improve it's description by adding more detail from project's README:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/electronics.scm
@@ -583,18 +583,27 @@ (define-public python-edalize
         (base32 "1gfysk6wj3mxndyzma604i3y2lkfn1im0bdmzxv5rn4x2nyk68sc"))))
     (build-system pyproject-build-system)
     (arguments
-     `(#:phases (modify-phases %standard-phases
-                  (replace 'check
-                    (lambda* (#:key tests? inputs outputs #:allow-other-keys)
-                      (when tests?
-                        ;; Skip erroneous tests
-                        (invoke "pytest" "tests" "-vv" "-k"
-                                (string-append "not test_gatemate "
-                                 "and not test_vivado_edif_netlist "
-                                 "and not test_xcelium " "and not test_vcs"))))))))
-    (native-inputs (list python-setuptools python-wheel python-jinja2
-                         python-pytest))
-    (home-page "https:/test_vivado_edif_netlist/github.com/olofk/edalize/")
+     (list
+      #:test-flags
+      #~(list "-k" (string-join
+                    ;; XXX: Tests failing with assertion not equal, find out
+                    ;; why.
+                    (list "not test_gatemate"
+                          "test_gatemate_minimal"
+                          "test_vcs_tool_options"
+                          "test_vcs_no_tool_options"
+                          "test_vcs_minimal"
+                          "test_vivado_edif_netlist"
+                          "test_vivado_edif_netlist_no_link_design"
+                          "test_xcelium")
+                    " and not "))))
+    (native-inputs
+     (list python-pytest
+           python-setuptools
+           python-wheel))
+    (propagated-inputs
+     (list python-jinja2))
+    (home-page "https:/github.com/olofk/edalize/")
     (synopsis "Python Library for interacting with EDA tools")
     (description
      "Edalize can create project files for supported tools and run them in

modified   gnu/packages/electronics.scm
@@ -604,11 +604,16 @@ (define-public python-edalize
            python-wheel))
     (propagated-inputs
      (list python-jinja2))
-    (home-page "https:/github.com/olofk/edalize/")
+    (home-page "https://github.com/olofk/edalize/")
     (synopsis "Python Library for interacting with EDA tools")
     (description
-     "Edalize can create project files for supported tools and run them in
-batch or GUI mode.")
+     "This package implements a functionality to create project files for
+supported tools and run them in batch or GUI mode.  All EDA tools such as
+Icarus, Yosys, ModelSim, Vivado, Verilator, GHDL, Quartus etc get input HDL
+files (Verilog and VHDL) and some tool-specific files (constraint files,memory
+initialization files, IP description files etc).  Together with the files,
+perhaps a couple of Verilog `defines, some top-level parameters/generics or
+some tool-specific options are set.")
     (license license:bsd-2)))0
--8<---------------cut here---------------end--------------->8---


Pushed to master as 8335a6d973c64a89f9a951c638a5d087b7bd8b61.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.