GNU bug report logs - #76581
[PATCH 0/2] Age: Fix interaction with age.el, add manpages.

Previous Next

Full log

Message #23 received at 76581 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 76581 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH v3 1/2] gnu: age: Merge packages with executibles into single
 one.
Date: Thu, 27 Feb 2025 10:33:58 +0000

Reported in #76581: Age: Fix interaction with age.el, add manpages.

* gnu/packages/golang-crypto.scm (go-filippo-io-age) [arguments]
<build-flags>: Set version.
[description]: Fix it.
(age): Swap to PACKAGE/INHERIT, simplify package definition and build
all commands.
[arguments] <phases>: Remove 'remove-failing-test-data-files. Use custom
'build.
(age-keygen): Delete variable.

Co-authored-by: Nicolas Graves <ngraves <at> ngraves.fr>
Change-Id: I8f4892dfceef34c47f945efce8ddfa9787102d4a
---
 gnu/packages/golang-crypto.scm | 60 ++++++++++++++++------------------
 1 file changed, 28 insertions(+), 32 deletions(-)

diff --git a/gnu/packages/golang-crypto.scm b/gnu/packages/golang-crypto.scm
index b1a114dd807..b79fa01dbb2 100644
--- a/gnu/packages/golang-crypto.scm
+++ b/gnu/packages/golang-crypto.scm
@@ -139,6 +139,8 @@ (define-public go-filippo-io-age
     (build-system go-build-system)
     (arguments
      (list
+      #:build-flags #~(list (string-append "-ldflags=-X main.Version="
+                                           #$version))
       #:embed-files #~(list "armor.*" "header_crlf" "hmac_.*" "scrypt.*"
                             "stanza_.*" "stream_.*" "version_unsupported"
                             "x25519.*" "x25519_.*")
@@ -155,9 +157,8 @@ (define-public go-filippo-io-age
     (synopsis "Secure file encryption tool, format, and Go library")
     (description
      "This package implements file encryption according to the
-@{age-encryption.org/v1, https://age-encryption.org/v1} specification.
-It features small explicit keys, no configuration options, and Unix-style
-composability.")
+@url{https://age-encryption.org/v1} specification.  It features small explicit
+keys, no configuration options, and Unix-style composability.")
     (license license:bsd-3)))
 
 (define-public go-filippo-io-edwards25519
@@ -2562,37 +2563,32 @@ (define-public go-torproject-org-pluggable-transports-goptlib
 ;;;
 
 (define-public age
-  (package
-    (inherit go-filippo-io-age)
+  (package/inherit go-filippo-io-age
     (name "age")
     (arguments
-     (list
-      #:install-source? #f
-      #:import-path "filippo.io/age/cmd/age"
-      #:unpack-path "filippo.io/age"
-      #:phases
-      #~(modify-phases %standard-phases
-          (add-after 'unpack 'remove-failing-test-data-files
-            ;; FIXME: testdata/output_file.txt:49: unknown command "ttyin"
-            ;; age: error: input and output file are the same: "inputcopy"
-            ;; age: error: input and output file are the same: "./inputcopy"
-            ;; age: error: input and output file are the same: "keycopy"
-            (lambda* (#:key import-path #:allow-other-keys)
-              (with-directory-excursion (string-append "src/" import-path)
-                (for-each delete-file
-                          (list "testdata/scrypt.txt"
-                                "testdata/output_file.txt"
-                                "testdata/encrypted_keys.txt"
-                                "testdata/terminal.txt"))))))))))
-
-(define-public age-keygen
-  (package
-    (inherit go-filippo-io-age)
-    (name "age-keygen")
-    (arguments
-     `(#:import-path "filippo.io/age/cmd/age-keygen"
-       #:unpack-path "filippo.io/age"
-       #:install-source? #f))))
+     (substitute-keyword-arguments
+         (package-arguments go-filippo-io-age)
+       ((#:tests? _ #t) #f)
+       ((#:install-source? _ #t) #f)
+       ((#:unpack-path _ "") "filippo.io/age")
+       ((#:phases phases '%standard-phases)
+        #~(modify-phases #$phases
+            (replace 'build
+              (lambda* (#:key import-path #:allow-other-keys #:rest arguments)
+                (for-each
+                 (lambda (cmd)
+                   (apply (assoc-ref #$phases 'build)
+                          `(,@arguments
+                            #:import-path ,(string-append import-path cmd))))
+                 (list "/cmd/age"
+                       "/cmd/age-keygen"))))))))
+    (native-inputs (package-propagated-inputs go-filippo-io-age))
+    (propagated-inputs '())
+    (inputs '())
+    (description
+     (string-append (package-description go-filippo-io-age)
+                    "\nThis package provides a command line interface (CLI)
+tools."))))
 
 (define-public go-jwker
   (package/inherit go-github-com-jphastings-jwker

base-commit: 4270c484ca174ad97d1add91fa5fc69041a6af9d
-- 
2.48.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.