GNU bug report logs - #76572
[PATCH 0/4] Fixes for gnome-shell-extension-gsconnect

Previous Next

Full log

Message #23 received at 76572 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: aurtzy <aurtzy <at> gmail.com>
Cc: Vivien Kraus <vivien <at> planete-kraus.eu>, 76572 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#76572] [PATCH 4/4] gnu: gnome-shell-extension-gsconnect:
 Fix paths in additional desktop file.
Date: Fri, 28 Feb 2025 09:56:29 +0900

Hi,

aurtzy <aurtzy <at> gmail.com> writes:

> This fixes the gsconnect preferences button ("Mobile Settings") in the
> top-right quick-access menu not opening the preferences application.  The
> window icon also displays properly with this commit.

Thank you!

> * gnu/packages/gnome-xyz.scm (gnome-shell-extension-gsconnect):
> [arguments]<#:phases>: Patch gapplication path in an additional desktop file
> in 'fix-paths phase.
>
> Change-Id: I6b84474e4976484f1203b7cf78fe5e882694cd22
> ---
>  gnu/packages/gnome-xyz.scm | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
> index abcbe2c9f9..d011ae51d0 100644
> --- a/gnu/packages/gnome-xyz.scm
> +++ b/gnu/packages/gnome-xyz.scm
> @@ -781,8 +781,12 @@ (define-public gnome-shell-extension-gsconnect
>              (lambda* (#:key inputs #:allow-other-keys)
>                (let ((gapplication (search-input-file inputs "/bin/gapplication"))
>                      (gi-typelib-path (getenv "GI_TYPELIB_PATH")))
> -                (substitute* "data/org.gnome.Shell.Extensions.GSConnect.desktop.in"
> -                  (("gapplication") gapplication))
> +                (for-each
> +                 (lambda (file)
> +                   (substitute* file
> +                     (("gapplication") gapplication)))
> +                 '("data/org.gnome.Shell.Extensions.GSConnect.desktop.in"
> +                   "data/org.gnome.Shell.Extensions.GSConnect.Preferences.desktop.in"))

Nitpick: it's a bit more conventional to indent map/filter/for-each,
etc. like:

(for-each procedure
 things)

instead of

(for-each
 procedure
 things)

Unless perhaps when the hanging indent is already deep and there's not
enough columns to accomodate the former.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.