GNU bug report logs - #76545
[PATCH] gnu: mame: Update to 0.274.

Previous Next

Package: guix-patches;

Reported by: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Date: Tue, 25 Feb 2025 10:28:02 UTC

Severity: normal

Tags: patch

To reply to this bug, email your comments to 76545 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to adam.faiz <at> disroot.org, liliana.prikler <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org:
bug#76545; Package guix-patches. (Tue, 25 Feb 2025 10:28:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
New bug report received and forwarded. Copy sent to adam.faiz <at> disroot.org, liliana.prikler <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org. (Tue, 25 Feb 2025 10:28:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Cc: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: [PATCH] gnu: mame: Update to 0.274.
Date: Tue, 25 Feb 2025 11:26:43 +0100
* gnu/packages/emulators.scm (mame): Update to 0.274.
[source]: Add modules for CUT and SCANDIR.  Preserve the minimum set of
third-party libraries.
[arguments]<#:make-flags>: Remove unnecessary flags.
<#:phases>: Add a phase to use all possible system libraries instead of
listing them piece wise.
[native-inputs]: Add NASM.
[inputs]: Replace LUA with LUA-5.4.

Change-Id: I650a008461d69e5a39ba6a12e7140aa785dc0298
---
 gnu/packages/emulators.scm | 71 ++++++++++++++++++++++++++++----------
 1 file changed, 52 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index 0eafc3df9e..7a38700ac1 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -6,7 +6,7 @@
 ;;; Copyright © 2015, 2018, 2023 David Thompson <dthompson2 <at> worcester.edu>
 ;;; Copyright © 2016 Manolis Fragkiskos Ragkousis <manolis837 <at> gmail.com>
 ;;; Copyright © 2016, 2017, 2018, 2020 Efraim Flashner <efraim <at> flashner.co.il>
-;;; Copyright © 2017-2024 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
+;;; Copyright © 2017-2025 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;; Copyright © 2017, 2020, 2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2017, 2018, 2019 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2019 Pierre Neidhardt <mail <at> ambrevar.xyz>
@@ -3034,7 +3034,7 @@ (define-public libticalcs2
 (define-public mame
   (package
     (name "mame")
-    (version "0.252")
+    (version "0.274")
     (source
      (origin
        (method git-fetch)
@@ -3043,33 +3043,65 @@ (define-public mame
              (commit (apply string-append "mame" (string-split version #\.)))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "07qhcm1v47sy2wj30nx3cbhvcbgki0cl83gabr0miiw60fhgyn6j"))
-       (modules '((guix build utils)))
+        (base32 "0xkj5xvnv8fl54k1nnr738jpsxkxmpsxak60ins3bjzcxl3az4by"))
+       (modules '((ice-9 ftw)
+                  (srfi srfi-26)
+                  (guix build utils)))
        (snippet
-        ;; Remove bundled libraries.
-        '(begin
-           (with-directory-excursion "3rdparty"
-             (for-each delete-file-recursively
-                       '("asio" "expat" "glm" "libflac" "libjpeg" "lua"
-                         "portaudio" "portmidi" "pugixml" "rapidjson" "SDL2"
-                         "SDL2-override" "sqlite3" "utf8proc" "zlib")))))))
+        ;; Remove most bundled libraries.
+        ;;
+        ;; XXX: Some of the preserved the libraries below ship with Guix, but
+        ;; may prove difficult to un-bundle.
+        #~(with-directory-excursion "3rdparty"
+            (let ((keep (list "." ".."
+                              "asmjit"
+                              "bgfx"
+                              "bimg"
+                              "bx"
+                              "genie"
+                              "linenoise"
+                              "lsqlite3"
+                              "lua-linenoise"
+                              "lua-zlib"
+                              "luafilesystem"
+                              "lzma"
+                              "minimp3"
+                              "nanosvg"
+                              "softfloat"
+                              "softfloat3"
+                              "sol2"
+                              "wdlfft"
+                              "ymfm")))
+              (for-each delete-file-recursively
+                        (scandir "." (negate (cut member <> keep)))))))))
     (build-system gnu-build-system)
     (arguments
      (list
       #:make-flags
-      #~(cons*
+      #~(list
          ;; A 'strict-overflow' error pops up on i686 so disable '-Werror'.
          "NOWERROR=1"
          (string-append "QT_HOME=" #$(this-package-input "qtbase"))
-         (string-append "SDL_INI_PATH=" #$output "/share/mame/ini")
-         (map (lambda (lib)
-                (string-append "USE_SYSTEM_LIB_" (string-upcase lib) "=1"))
-              '("asio" "expat" "flac" "glm" "jpeg" "lua" "portaudio" "portmidi"
-                "pugixml" "rapidjson" "sqlite3" "utf8proc" "zlib")))
+         (string-append "SDL_INI_PATH=" #$output "/share/mame/ini"))
       #:tests? #f                       ;no test in regular release
       #:phases
       #~(modify-phases %standard-phases
+          ;; (add-after 'unpack 'fix-sol2-build-error
+          ;;   ;; Fix "error: operator '!=' has no left operand" because
+          ;;   ;; LUA_COMPAT_BITLIB is empty.
+          ;;   (lambda _
+          ;;     (substitute* "3rdparty/sol2/sol/sol.hpp"
+          ;;       (("&& \\(LUA_COMPAT_BITLIB != 0\\)") ""))))
           (delete 'configure)
+          (add-before 'build 'use-system-libraries
+            (lambda _
+              (substitute* "makefile"
+                (("# +(USE_SYSTEM_LIB)" _ option) option))))
+          (add-before 'build 'use-c++-lua
+            (lambda _
+              (substitute* (list "scripts/src/main.lua"
+                                 "scripts/src/3rdparty.lua")
+                (("ext_lib\\(\"lua\"\\)") "ext_lib(\"lua++\")"))))
           (add-after 'build 'build-documentation
             (lambda _ (invoke "make" "-C" "docs" "man" "info")))
           (replace 'install
@@ -3172,7 +3204,8 @@ (define-public mame
                            Keywords=Game;Emulator;Arcade;~%"
                             executable)))))))))
     (native-inputs
-     (list pkg-config
+     (list nasm
+           pkg-config
            python-sphinx
            python-sphinxcontrib-svg2pdfconverter
            texinfo))
@@ -3186,7 +3219,7 @@ (define-public mame
            libjpeg-turbo
            libxi
            libxinerama
-           lua
+           lua-5.4
            portaudio
            portmidi
            pugixml

base-commit: 075fe3083b5838463f2cef26e2fc0d1b2c87e310
-- 
2.48.1







Information forwarded to mail <at> nicolasgoaziou.fr, adam.faiz <at> disroot.org, liliana.prikler <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org:
bug#76545; Package guix-patches. (Thu, 13 Mar 2025 15:56:02 GMT) Full text and rfc822 format available.

Message #8 received at 76545 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 76545 <at> debbugs.gnu.org
Cc: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: [PATCH v2] gnu: mame: Update to 0.275.
Date: Thu, 13 Mar 2025 16:53:58 +0100
* gnu/packages/emulators.scm (mame): Update to 0.275.
[source]: Add modules for cut and scandir.  Preserve the minimum set of
third-party libraries.
[arguments]<#:make-flags>: Remove unnecessary flags.
<#:phases>: Add a phase to use all possible system libraries instead of
listing them piece wise.
[native-inputs]: Add nasm.
[inputs]: Replace lua with lua-5.4. Add zstd:lib.

Change-Id: I650a008461d69e5a39ba6a12e7140aa785dc0298
---

- v2: Update to 0.275. Add zstd:lib as an input.

 gnu/packages/emulators.scm | 74 +++++++++++++++++++++++++++-----------
 1 file changed, 54 insertions(+), 20 deletions(-)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index 2bed105653..b7dd141120 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -6,7 +6,7 @@
 ;;; Copyright © 2015, 2018, 2023 David Thompson <dthompson2 <at> worcester.edu>
 ;;; Copyright © 2016 Manolis Fragkiskos Ragkousis <manolis837 <at> gmail.com>
 ;;; Copyright © 2016, 2017, 2018, 2020 Efraim Flashner <efraim <at> flashner.co.il>
-;;; Copyright © 2017-2024 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
+;;; Copyright © 2017-2025 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;; Copyright © 2017, 2020, 2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2017, 2018, 2019 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2019 Pierre Neidhardt <mail <at> ambrevar.xyz>
@@ -3025,7 +3025,7 @@ (define-public libticalcs2
 (define-public mame
   (package
     (name "mame")
-    (version "0.252")
+    (version "0.275")
     (source
      (origin
        (method git-fetch)
@@ -3034,33 +3034,65 @@ (define-public mame
              (commit (apply string-append "mame" (string-split version #\.)))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "07qhcm1v47sy2wj30nx3cbhvcbgki0cl83gabr0miiw60fhgyn6j"))
-       (modules '((guix build utils)))
+        (base32 "178wvdr126klz4xmhiv737xys6d3wvgrs216h9544y4s1pvxskpk"))
+       (modules '((ice-9 ftw)
+                  (srfi srfi-26)
+                  (guix build utils)))
        (snippet
-        ;; Remove bundled libraries.
-        '(begin
-           (with-directory-excursion "3rdparty"
-             (for-each delete-file-recursively
-                       '("asio" "expat" "glm" "libflac" "libjpeg" "lua"
-                         "portaudio" "portmidi" "pugixml" "rapidjson" "SDL2"
-                         "SDL2-override" "sqlite3" "utf8proc" "zlib")))))))
+        ;; Remove most bundled libraries.
+        ;;
+        ;; XXX: Some of the preserved the libraries below ship with Guix, but
+        ;; may prove difficult to un-bundle.
+        #~(with-directory-excursion "3rdparty"
+            (let ((keep (list "." ".."
+                              "asmjit"
+                              "bgfx"
+                              "bimg"
+                              "bx"
+                              "genie"
+                              "linenoise"
+                              "lsqlite3"
+                              "lua-linenoise"
+                              "lua-zlib"
+                              "luafilesystem"
+                              "lzma"
+                              "minimp3"
+                              "nanosvg"
+                              "softfloat"
+                              "softfloat3"
+                              "sol2"
+                              "wdlfft"
+                              "ymfm")))
+              (for-each delete-file-recursively
+                        (scandir "." (negate (cut member <> keep)))))))))
     (build-system gnu-build-system)
     (arguments
      (list
       #:make-flags
-      #~(cons*
+      #~(list
          ;; A 'strict-overflow' error pops up on i686 so disable '-Werror'.
          "NOWERROR=1"
          (string-append "QT_HOME=" #$(this-package-input "qtbase"))
-         (string-append "SDL_INI_PATH=" #$output "/share/mame/ini")
-         (map (lambda (lib)
-                (string-append "USE_SYSTEM_LIB_" (string-upcase lib) "=1"))
-              '("asio" "expat" "flac" "glm" "jpeg" "lua" "portaudio" "portmidi"
-                "pugixml" "rapidjson" "sqlite3" "utf8proc" "zlib")))
+         (string-append "SDL_INI_PATH=" #$output "/share/mame/ini"))
       #:tests? #f                       ;no test in regular release
       #:phases
       #~(modify-phases %standard-phases
+          ;; (add-after 'unpack 'fix-sol2-build-error
+          ;;   ;; Fix "error: operator '!=' has no left operand" because
+          ;;   ;; LUA_COMPAT_BITLIB is empty.
+          ;;   (lambda _
+          ;;     (substitute* "3rdparty/sol2/sol/sol.hpp"
+          ;;       (("&& \\(LUA_COMPAT_BITLIB != 0\\)") ""))))
           (delete 'configure)
+          (add-before 'build 'use-system-libraries
+            (lambda _
+              (substitute* "makefile"
+                (("# +(USE_SYSTEM_LIB)" _ option) option))))
+          (add-before 'build 'use-c++-lua
+            (lambda _
+              (substitute* (list "scripts/src/main.lua"
+                                 "scripts/src/3rdparty.lua")
+                (("ext_lib\\(\"lua\"\\)") "ext_lib(\"lua++\")"))))
           (add-after 'build 'build-documentation
             (lambda _ (invoke "make" "-C" "docs" "man" "info")))
           (replace 'install
@@ -3163,7 +3195,8 @@ (define-public mame
                            Keywords=Game;Emulator;Arcade;~%"
                             executable)))))))))
     (native-inputs
-     (list pkg-config
+     (list nasm
+           pkg-config
            python-sphinx
            python-sphinxcontrib-svg2pdfconverter
            texinfo))
@@ -3177,7 +3210,7 @@ (define-public mame
            libjpeg-turbo
            libxi
            libxinerama
-           lua
+           lua-5.4
            portaudio
            portmidi
            pugixml
@@ -3188,7 +3221,8 @@ (define-public mame
            (sdl-union (list sdl2 sdl2-ttf))
            sqlite
            utf8proc
-           zlib))
+           zlib
+           `(,zstd "lib")))
     (home-page "https://www.mamedev.org")
     (synopsis "Multi-purpose emulation framework")
     (description "MAME's purpose is to preserve decades of software

base-commit: d83d4653e42da26bfb4548f9fcf1bd6e323b40fe
-- 
2.48.1







Information forwarded to guix-patches <at> gnu.org:
bug#76545; Package guix-patches. (Fri, 14 Mar 2025 05:55:02 GMT) Full text and rfc822 format available.

Message #11 received at 76545 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 76545 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Adam Faiz <adam.faiz <at> disroot.org>
Subject: Re: [bug#76545] [PATCH v2] gnu: mame: Update to 0.275.
Date: Fri, 14 Mar 2025 13:58:03 +0800
Hello,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
> * gnu/packages/emulators.scm (mame): Update to 0.275.
> [source]: Add modules for cut and scandir.  Preserve the minimum set of
> third-party libraries.
> [arguments]<#:make-flags>: Remove unnecessary flags.
> <#:phases>: Add a phase to use all possible system libraries instead of
> listing them piece wise.
> [native-inputs]: Add nasm.
> [inputs]: Replace lua with lua-5.4. Add zstd:lib.
> [...]
>        #~(modify-phases %standard-phases
> +          ;; (add-after 'unpack 'fix-sol2-build-error
> +          ;;   ;; Fix "error: operator '!=' has no left operand" because
> +          ;;   ;; LUA_COMPAT_BITLIB is empty.
> +          ;;   (lambda _
> +          ;;     (substitute* "3rdparty/sol2/sol/sol.hpp"
> +          ;;       (("&& \\(LUA_COMPAT_BITLIB != 0\\)") ""))))

Does this commented phase useful?  Maybe just remove it.

Otherwise looks good to me, thanks.




Information forwarded to guix-patches <at> gnu.org:
bug#76545; Package guix-patches. (Fri, 14 Mar 2025 06:38:02 GMT) Full text and rfc822 format available.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 宋文武 via Guix-patches via <guix-patches <at> gnu.org>
Cc: Adam Faiz <adam.faiz <at> disroot.org>, 76545 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 宋文武 <iyzsong <at> envs.net>
Subject: Re: [bug#76545] [PATCH v2] gnu: mame: Update to 0.275.
Date: Fri, 14 Mar 2025 07:36:36 +0100
Hello,

宋文武 via Guix-patches via <guix-patches <at> gnu.org> writes:

> Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
>> * gnu/packages/emulators.scm (mame): Update to 0.275.
>> [source]: Add modules for cut and scandir.  Preserve the minimum set of
>> third-party libraries.
>> [arguments]<#:make-flags>: Remove unnecessary flags.
>> <#:phases>: Add a phase to use all possible system libraries instead of
>> listing them piece wise.
>> [native-inputs]: Add nasm.
>> [inputs]: Replace lua with lua-5.4. Add zstd:lib.
>> [...]
>>        #~(modify-phases %standard-phases
>> +          ;; (add-after 'unpack 'fix-sol2-build-error
>> +          ;;   ;; Fix "error: operator '!=' has no left operand" because
>> +          ;;   ;; LUA_COMPAT_BITLIB is empty.
>> +          ;;   (lambda _
>> +          ;;     (substitute* "3rdparty/sol2/sol/sol.hpp"
>> +          ;;       (("&& \\(LUA_COMPAT_BITLIB != 0\\)") ""))))
>
> Does this commented phase useful?  Maybe just remove it.

You’re right. I had forgotten about this comment. I’ll remove it when
the package is ready or at the next iteration. However, at the moment,
this package doesn’t want to build…

Regards,
-- 
Nicolas Goaziou






Information forwarded to guix-patches <at> gnu.org:
bug#76545; Package guix-patches. (Fri, 14 Mar 2025 06:38:02 GMT) Full text and rfc822 format available.

Information forwarded to mail <at> nicolasgoaziou.fr, iyzsong <at> envs.net, adam.faiz <at> disroot.org, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org:
bug#76545; Package guix-patches. (Tue, 01 Apr 2025 07:05:04 GMT) Full text and rfc822 format available.

Message #20 received at 76545 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 76545 <at> debbugs.gnu.org
Cc: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: [PATCH v3] gnu: mame: Update to 0.276.
Date: Tue,  1 Apr 2025 09:04:03 +0200
* gnu/packages/emulators.scm (mame): Update to 0.276.
[source]: Add modules for cut and scandir.  Preserve the minimum set of
third-party libraries.
[arguments]<#:make-flags>: Remove unnecessary flags.
<#:phases>: Add a phase to use all possible system libraries instead of
listing them piece wise.
[native-inputs]: Add nasm.
[inputs]: Replace lua with lua-5.4. Add zstd:lib.

Change-Id: I650a008461d69e5a39ba6a12e7140aa785dc0298
---

v3: Update to 0.276.  Remove old comment.  Do not try to use C++ Lua as it is
not packaged in Guix yet.

 gnu/packages/emulators.scm | 63 ++++++++++++++++++++++++++------------
 1 file changed, 43 insertions(+), 20 deletions(-)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index e71c2803a3..eb784bd43b 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -6,7 +6,7 @@
 ;;; Copyright © 2015, 2018, 2023 David Thompson <dthompson2 <at> worcester.edu>
 ;;; Copyright © 2016 Manolis Fragkiskos Ragkousis <manolis837 <at> gmail.com>
 ;;; Copyright © 2016, 2017, 2018, 2020 Efraim Flashner <efraim <at> flashner.co.il>
-;;; Copyright © 2017-2024 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
+;;; Copyright © 2017-2025 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;; Copyright © 2017, 2020, 2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2017, 2018, 2019 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2019 Pierre Neidhardt <mail <at> ambrevar.xyz>
@@ -3026,7 +3026,7 @@ (define-public libticalcs2
 (define-public mame
   (package
     (name "mame")
-    (version "0.252")
+    (version "0.276")
     (source
      (origin
        (method git-fetch)
@@ -3035,33 +3035,54 @@ (define-public mame
              (commit (apply string-append "mame" (string-split version #\.)))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "07qhcm1v47sy2wj30nx3cbhvcbgki0cl83gabr0miiw60fhgyn6j"))
-       (modules '((guix build utils)))
+        (base32 "1npjb5n03gchprnz61br0b0sprvwylkhygla3z84xklzd11y678d"))
+       (modules '((ice-9 ftw)
+                  (srfi srfi-26)
+                  (guix build utils)))
        (snippet
-        ;; Remove bundled libraries.
-        '(begin
-           (with-directory-excursion "3rdparty"
-             (for-each delete-file-recursively
-                       '("asio" "expat" "glm" "libflac" "libjpeg" "lua"
-                         "portaudio" "portmidi" "pugixml" "rapidjson" "SDL2"
-                         "SDL2-override" "sqlite3" "utf8proc" "zlib")))))))
+        ;; Remove most bundled libraries.
+        ;;
+        ;; XXX: Some of the preserved the libraries below ship with Guix, but
+        ;; may prove difficult to un-bundle.
+        #~(with-directory-excursion "3rdparty"
+            (let ((keep (list "." ".."
+                              "asmjit"
+                              "bgfx"
+                              "bimg"
+                              "bx"
+                              "genie"
+                              "linenoise"
+                              "lsqlite3"
+                              "lua-linenoise"
+                              "lua-zlib"
+                              "luafilesystem"
+                              "lzma"
+                              "minimp3"
+                              "nanosvg"
+                              "softfloat"
+                              "softfloat3"
+                              "sol2"
+                              "wdlfft"
+                              "ymfm")))
+              (for-each delete-file-recursively
+                        (scandir "." (negate (cut member <> keep)))))))))
     (build-system gnu-build-system)
     (arguments
      (list
       #:make-flags
-      #~(cons*
+      #~(list
          ;; A 'strict-overflow' error pops up on i686 so disable '-Werror'.
          "NOWERROR=1"
          (string-append "QT_HOME=" #$(this-package-input "qtbase"))
-         (string-append "SDL_INI_PATH=" #$output "/share/mame/ini")
-         (map (lambda (lib)
-                (string-append "USE_SYSTEM_LIB_" (string-upcase lib) "=1"))
-              '("asio" "expat" "flac" "glm" "jpeg" "lua" "portaudio" "portmidi"
-                "pugixml" "rapidjson" "sqlite3" "utf8proc" "zlib")))
+         (string-append "SDL_INI_PATH=" #$output "/share/mame/ini"))
       #:tests? #f                       ;no test in regular release
       #:phases
       #~(modify-phases %standard-phases
           (delete 'configure)
+          (add-before 'build 'use-system-libraries
+            (lambda _
+              (substitute* "makefile"
+                (("# +(USE_SYSTEM_LIB)" _ option) option))))
           (add-after 'build 'build-documentation
             (lambda _ (invoke "make" "-C" "docs" "man" "info")))
           (replace 'install
@@ -3164,7 +3185,8 @@ (define-public mame
                            Keywords=Game;Emulator;Arcade;~%"
                             executable)))))))))
     (native-inputs
-     (list pkg-config
+     (list nasm
+           pkg-config
            python-sphinx
            python-sphinxcontrib-svg2pdfconverter
            texinfo))
@@ -3178,7 +3200,7 @@ (define-public mame
            libjpeg-turbo
            libxi
            libxinerama
-           lua
+           lua-5.4
            portaudio
            portmidi
            pugixml
@@ -3189,7 +3211,8 @@ (define-public mame
            (sdl-union (list sdl2 sdl2-ttf))
            sqlite
            utf8proc
-           zlib))
+           zlib
+           `(,zstd "lib")))
     (home-page "https://www.mamedev.org")
     (synopsis "Multi-purpose emulation framework")
     (description "MAME's purpose is to preserve decades of software

base-commit: 5735c278e16517d9be5e26235fe68dea9bae3527
-- 
2.49.0







Information forwarded to guix-patches <at> gnu.org:
bug#76545; Package guix-patches. (Mon, 21 Apr 2025 19:56:02 GMT) Full text and rfc822 format available.

Message #23 received at 76545 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, 76545 <at> debbugs.gnu.org
Cc: Adam Faiz <adam.faiz <at> disroot.org>,
 宋文武 <iyzsong <at> envs.net>
Subject: Re: [bug#76545] [PATCH v3] gnu: mame: Update to 0.276.
Date: Mon, 21 Apr 2025 21:55:05 +0200
Am Dienstag, dem 01.04.2025 um 09:04 +0200 schrieb Nicolas Goaziou:
> * gnu/packages/emulators.scm (mame): Update to 0.276.
> [source]: Add modules for cut and scandir.  Preserve the minimum set
> of third-party libraries.
> [arguments]<#:make-flags>: Remove unnecessary flags.
> <#:phases>: Add a phase to use all possible system libraries instead
> of listing them piece wise.
> [native-inputs]: Add nasm.
> [inputs]: Replace lua with lua-5.4. Add zstd:lib.
> 
> Change-Id: I650a008461d69e5a39ba6a12e7140aa785dc0298
> ---
> 
> v3: Update to 0.276.  Remove old comment.  Do not try to use C++ Lua
> as it is not packaged in Guix yet.
I keep wanting to try this patch, but haven't yet succeeded in building
the package.  (This may very well be a "my machine" problem, as the
build seems to require quite a lot of resources.)  In any case, it
lexically LGTM.

Cheers





Information forwarded to guix-patches <at> gnu.org:
bug#76545; Package guix-patches. (Mon, 21 Apr 2025 21:42:02 GMT) Full text and rfc822 format available.

Message #26 received at 76545 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 76545 <at> debbugs.gnu.org, 宋文武 <iyzsong <at> envs.net>,
 Adam Faiz <adam.faiz <at> disroot.org>
Subject: Re: [bug#76545] [PATCH v3] gnu: mame: Update to 0.276.
Date: Mon, 21 Apr 2025 23:40:52 +0200
Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Dienstag, dem 01.04.2025 um 09:04 +0200 schrieb Nicolas Goaziou:
>> * gnu/packages/emulators.scm (mame): Update to 0.276.
>> [source]: Add modules for cut and scandir.  Preserve the minimum set
>> of third-party libraries.
>> [arguments]<#:make-flags>: Remove unnecessary flags.
>> <#:phases>: Add a phase to use all possible system libraries instead
>> of listing them piece wise.
>> [native-inputs]: Add nasm.
>> [inputs]: Replace lua with lua-5.4. Add zstd:lib.
>> 
>> Change-Id: I650a008461d69e5a39ba6a12e7140aa785dc0298
>> ---
>> 
>> v3: Update to 0.276.  Remove old comment.  Do not try to use C++ Lua
>> as it is not packaged in Guix yet.

> I keep wanting to try this patch, but haven't yet succeeded in building
> the package.  (This may very well be a "my machine" problem, as the
> build seems to require quite a lot of resources.)  In any case, it
> lexically LGTM.

Alas, this package doesn’t build yet. At this point, I’m not even sure
about the error, only that it is related to Lua. For the record, the
failure log can be found there:
<https://bordeaux.guix.gnu.org/build/9b1cb885-0466-4ae1-829b-9edbe91064d7/log>.

I certainly would appreciate some help if anyone wants to have a look
into it.

Regards,
-- 
Nicolas Goaziou






This bug report was last modified 56 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.