GNU bug report logs - #76538
31.0.50; 31.0.50; 31.0.50; feature/igc: using magit-section-cycle-global (S-TAB) and magit-section-toggle (TAB) in some random ways blocks GNU Emacs.

Previous Next

Package: emacs;

Reported by: João Moreira <joaomoreira <at> gmx.se>

Date: Tue, 25 Feb 2025 03:42:01 UTC

Severity: normal

Found in version 31.0.50

Full log


View this message in rfc822 format

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Ihor Radchenko <yantar92 <at> posteo.net>
Cc: pipcet <at> protonmail.com, eller.helmut <at> gmail.com, Stefan Monnier <monnier <at> iro.umontreal.ca>, joaomoreira <at> gmx.se, 76538 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: bug#76538: 31.0.50; 31.0.50; 31.0.50; feature/igc: using magit-section-cycle-global (S-TAB) and magit-section-toggle (TAB) in some random ways blocks GNU Emacs.
Date: Thu, 27 Feb 2025 20:33:01 +0100
Ihor Radchenko <yantar92 <at> posteo.net> writes:

> Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:
>
>> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>>
>>> Maybe if we change the `DO_MARKERS` iteration to scan from the end,
>>> we'd recover a behavior much closer to what we see on `master`.
>>> Gerd?
>>
>> I don't know, but it might well be that one order is as bad as the
>> other, depending on the order in which markers are added to and removed
>> from the marker array. And I have no intuition what a marker array ends
>> up looking like in a typical use case, alas.
>>
>> Hm. Can we record the insertion order somehow? I guess that's what the
>> heuristic is using? 
>
> FYI, I tried various tweaks to that loop while debugging and concluded
> that DO_MARKERS loop is not the main bottleneck in this particular bug
> report.
>
> I am wondering if anyone else is able to reproduce the problem locally.

I haven't tried the OP's recipe, but I know that Magit can get really
slow, things taking minutes. An example would be a large merge of
several hundred files, and with conflicts. The status buffer becomes
as good as unusable then. I don't think this started with igc.




This bug report was last modified 106 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.