GNU bug report logs - #76512
[PATCH] gnu: emacs-ws-butler: Update to 1.1 from new maintainer.

Previous Next

Full log

Message #8 received at 76512 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Liam Hupfer <liam <at> hpfr.net>
Cc: 76512 <at> debbugs.gnu.org
Subject: Re: [bug#76512] [PATCH] gnu: emacs-ws-butler: Update to 1.1 from
 new maintainer.
Date: Mon, 24 Feb 2025 06:57:23 -0800

Hi Liam,

Liam Hupfer <liam <at> hpfr.net> writes:

> The original author of ws-butler is largely inactive.  Sean 
> Whitton has
> taken over maintenance at NonGNU ELPA and applied several 
> outstanding
> patches.  ELPA tarballs do not deploy tests, so remove test 
> support and
> rely on upstream in alignment with other packages sourced from 
> NonGNU
> ELPA.
>
> While we’re here, tidy the package docs and run guix style.
>
> * gnu/packages/emacs-xyz.scm (emacs-ws-butler): Update to 1.1 
> from new
> maintainer.
>
> Link: https://github.com/lewang/ws-butler/issues/52
> Link: https://github.com/lewang/ws-butler/issues/58
> Change-Id: I09db3d855c4b15d2253090884106e00bc1719607
> ---
>  gnu/packages/emacs-xyz.scm | 26 ++++++++++----------------
>  1 file changed, 10 insertions(+), 16 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm 
> b/gnu/packages/emacs-xyz.scm
> index 59c1927135..06b50cd40c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -22499,27 +22499,21 @@ (define-public emacs-hercules
>  (define-public emacs-ws-butler
>    (package
>      (name "emacs-ws-butler")
> -    (version "0.7")
> +    (version "1.1")
>      (source
>       (origin
> -       (method git-fetch)
> -       (uri (git-reference
> -             (url "https://github.com/lewang/ws-butler")
> -             (commit "v0.7")))
> -       (file-name (git-file-name name version))
> +       (method url-fetch)
> +       (uri (string-append 
> "https://elpa.nongnu.org/nongnu/ws-butler-" version
> +                           ".tar"))

Is there an upstream source repo?  If it’s reasonable to do so, 
it’s preferable to use that rather than M/ELPA URLs.

Everything else looks good to me.

Thanks,
 -- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.