GNU bug report logs - #76494
[PATCH] Highlight fill-column-indicator when current line is longer than `fill-column'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Subject: bug#76494: closed (Re: bug#76494: [PATCH] Highlight
 fill-column-indicator when current line is longer than `fill-column')
Date: Sun, 09 Mar 2025 09:22:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#76494: [PATCH] Highlight fill-column-indicator when current line is longer than `fill-column'

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 76494 <at> debbugs.gnu.org.

-- 
76494: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76494
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: 76494-done <at> debbugs.gnu.org
Subject: Re: bug#76494: [PATCH] Highlight fill-column-indicator when current
 line is longer than `fill-column'
Date: Sun, 09 Mar 2025 11:21:40 +0200

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Cc: 76494 <at> debbugs.gnu.org
> Date: Sun, 23 Feb 2025 01:11:43 -0600
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > I see your change adds a post-command-hook, but when and how is that
> > hook removed?
> 
> The hook is removed when display-fill-column-indicator-mode is turn-off,
> i forgot to remove the hook in the submitted patch, I've fixed it.
> 
> >> I also wanted to do the same for indicator character but I couldn't find
> >> a way to implement it.
> >
> > What do you mean by "indicator character"?
> 
> i meant `display-fill-column-indicator-character', I wanted to
> allow changing its character to a custom one.
> 
> example: use this `┃' character (or one chosen by the user)
> instead default `│' when changing the fill-column-indicator face.
> 
> >> +(defcustom display-fill-column-indicator-warning nil
> >> +  "Highlight fill-column-indicator when cursor is above `fill-column'.
> >> +Non-nil means highlight fill-column-indicator when cursor is
> >> +above `fill-column'."
> >> +  :type 'boolean)
> >
> > This lacks a :version tag.
> >
> > Also, what do you mean by "cursor is above `fill-column'"?  The
> > "above" part confuses me.
> 
> I updated the patch to clarify this part.

Thanks, installed on the master branch, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Highlight fill-column-indicator when current line is longer
 than `fill-column'
Date: Sat, 22 Feb 2025 22:21:02 -0600

[Message part 4 (text/plain, inline)]

Tags: patch

This patch allow warn to user if current line exceeds
display-fill-column-indicator-column.

When current line exceeds display-fill-column-indicator-column ...
                                           |
(print "......................................")
                                           |
... fill-column indicator face will change ^
temporarily to a noticeable face to warn the user that the current
column is getting too long.

I also wanted to do the same for indicator character but I couldn't find
a way to implement it.

(I hope this feature has been understood)

[0001-Highlight-fill-column-indicator-when-current-line-is.patch (text/patch, attachment)]

[Message part 6 (text/plain, inline)]

-- 
                                                   - E.G via GNU Emacs.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.