From unknown Sat Aug 16 18:39:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76478: 30.0.92; doc-view--revert-buffer fails when saving OpenDocument spreadsheets Resent-From: Roland Winkler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Feb 2025 19:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 76478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 76478@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.174016765417281 (code B ref -1); Fri, 21 Feb 2025 19:55:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Feb 2025 19:54:14 +0000 Received: from localhost ([127.0.0.1]:36746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlZ6D-0004UV-CW for submit@debbugs.gnu.org; Fri, 21 Feb 2025 14:54:14 -0500 Received: from lists.gnu.org ([2001:470:142::17]:44170) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlZ68-0004T2-RU for submit@debbugs.gnu.org; Fri, 21 Feb 2025 14:54:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlZ61-00076U-5i for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2025 14:54:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlZ60-0001rP-Tb for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2025 14:54:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=2XsrjI0TDv25+bBF9lsBaH5t+4Ege5EjeH6hmkR4FBU=; b=fVnRwBUWk5i19R HOJoXvOEDXWrl3S4S01LUxgeEOAPO/N7VAiLh7tfeA2sQR/Yye5BvP1q+i4pYJJLdWlD9jrJkYqtG Tz5yd9VOEQrrKSmCdJlwBq0a9/Nr10DN0xNDrxeeDgSH7vti5/B6qaf+91r78ZyWrYZHxAFOFN6mE me8NvSuasLmVQAZcEf//rkCd8SgF3iO5YgxIJo6yMQX+kBgeu3usMMcTpjBVP83BGjZ/tpWionIvl mvo98qSh+MV9R2l0Q8BGMrGqcxUld9DhKoQYEL/LGyAXC2fK8AbisWCg64BnYg2jEPVG5xjo5uPbl e9ThPAoCXu/jLZG44g/w==; From: Roland Winkler Date: Fri, 21 Feb 2025 13:53:59 -0600 Message-ID: <87zfifaxbc.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) When I open an OpenDocument spreadsheet (file extension ods), by default this happens via doc-view. Then, when I edit the file (say, content.xml) and try to save it, doc-view--revert-buffer bails out with the error (wrong-type-argument stringp nil). If, instead, I open and edit the file as a zip archive without doc-view, I can save it without any problems. In GNU Emacs 30.0.92 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-11-01 built on regnitz Windowing system distributor 'The X.Org Foundation', version 11.0.12101007 System Description: Debian GNU/Linux 12 (bookworm) Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_COLLATE: C value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix From unknown Sat Aug 16 18:39:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76478: 30.0.92; doc-view--revert-buffer fails when saving OpenDocument spreadsheets Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Feb 2025 06:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Roland Winkler , Tassilo Horn Cc: 76478@debbugs.gnu.org Received: via spool by 76478-submit@debbugs.gnu.org id=B76478.174020714921269 (code B ref 76478); Sat, 22 Feb 2025 06:53:02 +0000 Received: (at 76478) by debbugs.gnu.org; 22 Feb 2025 06:52:29 +0000 Received: from localhost ([127.0.0.1]:45070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tljNE-0005Wp-D6 for submit@debbugs.gnu.org; Sat, 22 Feb 2025 01:52:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56120) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tljNC-0005Vo-Nw for 76478@debbugs.gnu.org; Sat, 22 Feb 2025 01:52:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tljN6-0004Gf-3w for 76478@debbugs.gnu.org; Sat, 22 Feb 2025 01:52:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aty1LD2hADg8VZOAR9B2vjCK3GcfkgQ5QKCujQ8G7sc=; b=qB288jz9IY+X YTUQgPqrQpVavdKlEVFENSJnzAndLIBZufAbeUwbZ858150q49EtxCycApNx2VwWD1jmC+bcZpKbm g2cGGC+eQu+0d8GFkot97p7XYIuW5XFmrOr44Udky+PzeC2ObUUrdaBJPsoxl14mgQReSj1BVIePB 79nldsdNZ3D030X/3ATqgfSbsQ7X8aU3Eyg3F+hx/nw1rB8EeJplGdLUrMn8pTa098SqE+FY2iyJD aqKPFHafphkbptwt1mb5W+g47tw4TAL4B9S59oIB/dFvKVIzOmHqhP97Lu1C3Vrihs5/ifUK8snuR pvAeLUbPeIXw4QgqDWmzaA==; Date: Sat, 22 Feb 2025 08:52:17 +0200 Message-Id: <86jz9ilbdq.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87zfifaxbc.fsf@gnu.org> (message from Roland Winkler on Fri, 21 Feb 2025 13:53:59 -0600) References: <87zfifaxbc.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Roland Winkler > Date: Fri, 21 Feb 2025 13:53:59 -0600 > > > When I open an OpenDocument spreadsheet (file extension ods), by default > this happens via doc-view. Then, when I edit the file (say, content.xml) > and try to save it, doc-view--revert-buffer bails out with the error > (wrong-type-argument stringp nil). > > If, instead, I open and edit the file as a zip archive without doc-view, > I can save it without any problems. Thanks. Tassilo, could you please look into this? From unknown Sat Aug 16 18:39:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76478: 30.0.92; doc-view--revert-buffer fails when saving OpenDocument spreadsheets Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Feb 2025 07:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Roland Winkler , 76478@debbugs.gnu.org Received: via spool by 76478-submit@debbugs.gnu.org id=B76478.174020841732330 (code B ref 76478); Sat, 22 Feb 2025 07:14:02 +0000 Received: (at 76478) by debbugs.gnu.org; 22 Feb 2025 07:13:37 +0000 Received: from localhost ([127.0.0.1]:45420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tljhg-0008PL-Ow for submit@debbugs.gnu.org; Sat, 22 Feb 2025 02:13:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54016) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tljhd-0008OJ-QW for 76478@debbugs.gnu.org; Sat, 22 Feb 2025 02:13:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tljhY-00069L-95 for 76478@debbugs.gnu.org; Sat, 22 Feb 2025 02:13:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=DfNm2JAabAPYJQSHHDD4iZMK0Wd9RZ+ZjkXnk3uV9dY=; b=XFHvb3jUsU1RT09AqO8/ gr9WPcMItMJPm6KNV24TreGx4V+qq5U2DZaU8+5B4tqFLNZ0uV+/m4cZCPQCK1lAikywRjpW5TNI3 OU0F0rjUxRklIZHQwU0FIGnjnGHXL7SsGnU01g0961GbXjnfaZwRk2PUFdBQPUCrs4B9k6QvsiRWE nscyqgHZeUeVDuJ26h9EksrQXujEBFg2dmredI0/FoasNjGjdkslH6yrYtNDrxN4gno1NHjNZly0F xjE7NwTUN/y/W+rfmlu5iNmbWe1xFsqqaN7PSLDJQ4p5aUi4DtmmAkUntSrxdBdh+o+Z7L3H4ogee gtZQ3waoHGubyA==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdejvddvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtsehttdertddtredt necuhfhrohhmpefvrghsshhilhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqne cuggftrfgrthhtvghrnhepleduvdegfeduvdejkeefteelgeetgfevhefhueffueffgeeh gfeufefgvdffgedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeei jeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrih hlrdhfmhdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthht ohepjeeigeejkeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopeifihhnkh hlvghrsehgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail From: Tassilo Horn In-Reply-To: <86jz9ilbdq.fsf@gnu.org> References: <87zfifaxbc.fsf@gnu.org> <86jz9ilbdq.fsf@gnu.org> User-Agent: mu4e 1.12.8; emacs 31.0.50 Date: Sat, 22 Feb 2025 08:13:21 +0100 Message-ID: <87wmdio3ji.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> When I open an OpenDocument spreadsheet (file extension ods), by >> default this happens via doc-view. Then, when I edit the file (say, >> content.xml) and try to save it, doc-view--revert-buffer bails out >> with the error (wrong-type-argument stringp nil). >> >> If, instead, I open and edit the file as a zip archive without >> doc-view, I can save it without any problems. > > Thanks. > > Tassilo, could you please look into this? Yes, I'll have a look. Bye, Tassilo From unknown Sat Aug 16 18:39:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76478: 30.0.92; doc-view--revert-buffer fails when saving OpenDocument spreadsheets Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Feb 2025 09:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Stefan Monnier Cc: Roland Winkler , 76478@debbugs.gnu.org Received: via spool by 76478-submit@debbugs.gnu.org id=B76478.174030173616895 (code B ref 76478); Sun, 23 Feb 2025 09:09:01 +0000 Received: (at 76478) by debbugs.gnu.org; 23 Feb 2025 09:08:56 +0000 Received: from localhost ([127.0.0.1]:59268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tm7yp-0004OQ-Hv for submit@debbugs.gnu.org; Sun, 23 Feb 2025 04:08:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53364) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tm7ym-0004O8-25 for 76478@debbugs.gnu.org; Sun, 23 Feb 2025 04:08:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tm7yg-0006Ep-8Y; Sun, 23 Feb 2025 04:08:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=VA5Z575GbBrelEWAdwgS8Hn6Lj5t0F01DqMGGQhk2ac=; b=LoOUruF6TITtMJuovNym VT25IwgX5xb8e97SaiTw86HJAzYJg7elgA3kwn2wCLdNxvrfh3hRVs60E2Wcywt/WTT+3wpMsAlIN ZKz4LZxquF+2AYM46bhXWMdVGQbYhrQPUFPS8V7/FybNRwy6zWYfjHDeSrUdz6PMhhpHkJxCN+As5 vDc4Z0M00gTVeQNDxw3d0/C0Cx/ZGx1Vi0gNQZlXOt8fRZjVtkt1JdsPnes56lQimKr1tk4XMCY0T sz71EYm4kSX77cFDaSMLzRvu4Y69UVxbEuW+rl0FqDdv/Cjt8FLEu43tOh5sn0KQF9wV3OrBtrlC9 WhB1OQNdfDXI0w==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdejheegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtsehmtderredtredt necuhfhrohhmpefvrghsshhilhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqne cuggftrfgrthhtvghrnhepteejieeuleeijeevtdehtdduudfggffhtedukedutedvgeet tddvffejieelvdegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeei jeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrih hlrdhfmhdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthht ohepjeeigeejkeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopeifihhnkh hlvghrsehgnhhurdhorhhgpdhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhmohhn thhrvggrlhdrtggrpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail From: Tassilo Horn In-Reply-To: <87wmdio3ji.fsf@gnu.org> References: <87zfifaxbc.fsf@gnu.org> <86jz9ilbdq.fsf@gnu.org> <87wmdio3ji.fsf@gnu.org> User-Agent: mu4e 1.12.8; emacs 31.0.50 Date: Sun, 23 Feb 2025 10:08:38 +0100 Message-ID: <875xl1qb8p.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Tassilo Horn writes: >>> When I open an OpenDocument spreadsheet (file extension ods), by >>> default this happens via doc-view. Then, when I edit the file (say, >>> content.xml) and try to save it, doc-view--revert-buffer bails out >>> with the error (wrong-type-argument stringp nil). >>> >>> If, instead, I open and edit the file as a zip archive without >>> doc-view, I can save it without any problems. >> >> Thanks. >> >> Tassilo, could you please look into this? You actually don't need an ODS document for that error to trigger. A PDF works, too. - Find foo.pdf - C-c C-c to switch to the editing mode - M-x revert-buffer RET ==> bang! The difference with OpenDocuments is that after editing some file inside the archive, the archive buffer will be reverted automatically. The problem is that when switching to the editing mode, the buffer-local value of doc-view--buffer-file-name is killed and so our doc-view--revert-buffer advice function errors when trying to update the cached copy of the document (which only exists if the document is remote or inside some archive). I've added a nil-check there. I think that's ok. Alternatively, we could possibly remove the advice function when switching to the editing mode. Stefan, what do you think? I've also found and fixed another related bug. When switching to the editing mode for an OpenDocument (archive-mode), then editing its contents and saving (causing a revert), doc-view-minor-mode was disabled, i.e., you couldn't C-c C-c back to doc-view-mode. Here's possibly also an alternative: the archive--mode-revert advice function could bind revert-buffer-preserve-modes just as our doc-view--revert-buffer does. But I think my version is better because otherwise we'd need to make all possible editing modes play to doc-view's rules. Stefan, do you think my patch is ok? And Eli, in which version do you want the fix? I think the issue is quite old and as explained above, you will usually only trigger it when editing OpenDocument contents which probably is quite uncommon. Bye, Tassilo --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-doc-view-Fix-error-during-revert-in-editing-mode.patch >From e06e58646dbd3df26d5a99b13d13f6d908529ee8 Mon Sep 17 00:00:00 2001 From: Tassilo Horn Date: Sun, 23 Feb 2025 09:46:54 +0100 Subject: [PATCH] doc-view: Fix error during revert in editing mode When in editing mode in a doc-view buffer and then reverting (which can happen automatically when editing OpenDocument contents), we errored in the advide function doc-view--revert-buffer because the local doc-view--buffer-file-name has been killed when switching to the editing mode. Also restore doc-view-minor-mode after reverting during being in the editing mode. * lisp/doc-view.el (doc-view--revert-buffer): Check that 'doc-view--buffer-file-name' is non-nil. (doc-view-minor-mode): Add re-enabling function to 'revert-buffer-restore-functions'. --- lisp/doc-view.el | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index 98522f35765..501bf406ca4 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -591,11 +591,15 @@ doc-view--revert-buffer (cl-labels ((revert () (let ((revert-buffer-preserve-modes t)) (apply orig-fun args) - ;; Update the cached version of the pdf file, - ;; too. This is the one that's used when - ;; rendering (bug#26996). - (unless (equal buffer-file-name - doc-view--buffer-file-name) + ;; Update the cached version of the pdf file, too. + ;; This is the one that's used when rendering + ;; (bug#26996). doc-view--buffer-file-name is nil in + ;; the case where we've switched to the editing mode + ;; (bug#76478). In that case, we'll update the cached + ;; version when switching back to doc-view-mode. + (when (and doc-view--buffer-file-name + (not (equal buffer-file-name + doc-view--buffer-file-name))) ;; FIXME: Lars says he needed to recreate ;; the dir, we should figure out why. (doc-view-make-safe-dir doc-view-cache-directory) @@ -2443,7 +2447,20 @@ doc-view-minor-mode See the command `doc-view-mode' for more information on this mode." :lighter " DocView" (when doc-view-minor-mode - (add-hook 'change-major-mode-hook (lambda () (doc-view-minor-mode -1)) nil t) + (add-hook 'change-major-mode-hook + (lambda () + (doc-view-minor-mode -1)) + nil t) + ;; OpenDocuments are archive files, so their editing mode is + ;; archive-mode. When editing and saving a file in that archive, + ;; it'll automatically revert the archive buffer. Take care to + ;; re-enable `doc-view-minor-mode' in that case. + (add-hook 'revert-buffer-restore-functions + (lambda () + (lambda () + (unless (derived-mode-p 'doc-view-mode) + (doc-view-minor-mode 1)))) + nil t) (message "%s" (substitute-command-keys -- 2.48.1 --=-=-=-- From unknown Sat Aug 16 18:39:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76478: 30.0.92; doc-view--revert-buffer fails when saving OpenDocument spreadsheets Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Feb 2025 09:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tassilo Horn Cc: 76478@debbugs.gnu.org, monnier@iro.umontreal.ca, winkler@gnu.org Received: via spool by 76478-submit@debbugs.gnu.org id=B76478.174030195317713 (code B ref 76478); Sun, 23 Feb 2025 09:13:02 +0000 Received: (at 76478) by debbugs.gnu.org; 23 Feb 2025 09:12:33 +0000 Received: from localhost ([127.0.0.1]:59290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tm82K-0004bd-Tb for submit@debbugs.gnu.org; Sun, 23 Feb 2025 04:12:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40920) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tm822-0004b4-PY for 76478@debbugs.gnu.org; Sun, 23 Feb 2025 04:12:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tm81x-0006ZD-BC; Sun, 23 Feb 2025 04:12:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=i/nxN9Qp7NR3LrHVe+LG9p78ei/cWaMIDlIHiVVlMv4=; b=XqKIusJC5rqg s4PACrB+8LtbZKKLRR3SVQsmNPoCA1vknhEjd3Z0LwOehjEWLMFW3VAxn2Y6lpDahmg0LAIYpXvlc lsCKieg6v+G4Vhp3Dj6zsR8STcv7geReshnR6fAgJXlvyfXovszI0l0MB/AnkCcL1sXnJKhApmqv1 Gn7CdQZkcLnHaeokLHcWIXP/yo1Pu6fAKY/z2b2INUmmVzynZMYIzc5gimyNS4Ci0gCgnNWiN1gyN qqMf8nP1pyk2cJ6TN2QJtVOIARpdenOT5EM4F95QXOafLzN42XmWUBJ95L4iHDZ4tPVz7R4x6k74q aw0GknjmEHW+zNP28kGINA==; Date: Sun, 23 Feb 2025 11:12:04 +0200 Message-Id: <861pvphvob.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <875xl1qb8p.fsf@gnu.org> (message from Tassilo Horn on Sun, 23 Feb 2025 10:08:38 +0100) References: <87zfifaxbc.fsf@gnu.org> <86jz9ilbdq.fsf@gnu.org> <87wmdio3ji.fsf@gnu.org> <875xl1qb8p.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tassilo Horn > Cc: Roland Winkler , 76478@debbugs.gnu.org > Date: Sun, 23 Feb 2025 10:08:38 +0100 > > And Eli, in which version do you want the fix? I think the issue is > quite old and as explained above, you will usually only trigger it when > editing OpenDocument contents which probably is quite uncommon. I think fixing this on master should be okay, thanks. From unknown Sat Aug 16 18:39:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76478: 30.0.92; doc-view--revert-buffer fails when saving OpenDocument spreadsheets Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Mar 2025 12:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: tsdh@gnu.org Cc: winkler@gnu.org, monnier@iro.umontreal.ca, 76478@debbugs.gnu.org Received: via spool by 76478-submit@debbugs.gnu.org id=B76478.174083234712334 (code B ref 76478); Sat, 01 Mar 2025 12:33:02 +0000 Received: (at 76478) by debbugs.gnu.org; 1 Mar 2025 12:32:27 +0000 Received: from localhost ([127.0.0.1]:34969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1toM14-0003Cl-Re for submit@debbugs.gnu.org; Sat, 01 Mar 2025 07:32:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56708) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1toM12-0003Bt-Ku for 76478@debbugs.gnu.org; Sat, 01 Mar 2025 07:32:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1toM0o-0002OT-NK; Sat, 01 Mar 2025 07:32:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=thrg7FZwVrtGqIAh2WvcNMLZCyoyAaXEx4rVEpvHUTc=; b=GEgJqqJKNvdR REx9kM00cmcpfKNon+nWsrqLcvbjl+rhTFMLUX3PI5wuEnlkGLLpuYsz0oP8dw1YfKkdjQzTj3n2H vrL6H8KBuLrcJ2nnEaWWCDswntvqXSJUrQWlFnqDvM51LCUjZbUM2Qzy2GzE3fZhq1NRJFpNL1qKo MayMjs6ZLBb+feDuaQ/HYOV/9XaPL5YDwm/vGiYsuI2KJsUI0rPt1pIHbse9DPgJnfCiVb2f6Jmzt SzOD+RViqTObpDpP7LFpEsa9nrE0G9fOKhGGlD6kNSoGL2VTdw9kFR03lDcgfc5SGJJcc3RdYioMa bwPoS8KKeeNnhHmvc7MXEw==; Date: Sat, 01 Mar 2025 14:32:05 +0200 Message-Id: <86cyf1orsq.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <861pvphvob.fsf@gnu.org> (message from Eli Zaretskii on Sun, 23 Feb 2025 11:12:04 +0200) References: <87zfifaxbc.fsf@gnu.org> <86jz9ilbdq.fsf@gnu.org> <87wmdio3ji.fsf@gnu.org> <875xl1qb8p.fsf@gnu.org> <861pvphvob.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 76478@debbugs.gnu.org, monnier@iro.umontreal.ca, winkler@gnu.org > Date: Sun, 23 Feb 2025 11:12:04 +0200 > From: Eli Zaretskii > > > From: Tassilo Horn > > Cc: Roland Winkler , 76478@debbugs.gnu.org > > Date: Sun, 23 Feb 2025 10:08:38 +0100 > > > > And Eli, in which version do you want the fix? I think the issue is > > quite old and as explained above, you will usually only trigger it when > > editing OpenDocument contents which probably is quite uncommon. > > I think fixing this on master should be okay, thanks. Ping! Tassilo, would you please install your patch? Thanks. From unknown Sat Aug 16 18:39:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76478: 30.0.92; doc-view--revert-buffer fails when saving OpenDocument spreadsheets Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Mar 2025 12:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: winkler@gnu.org, monnier@iro.umontreal.ca, 76478@debbugs.gnu.org Received: via spool by 76478-submit@debbugs.gnu.org id=B76478.174083371019411 (code B ref 76478); Sat, 01 Mar 2025 12:56:02 +0000 Received: (at 76478) by debbugs.gnu.org; 1 Mar 2025 12:55:10 +0000 Received: from localhost ([127.0.0.1]:35171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1toMN3-00052y-CN for submit@debbugs.gnu.org; Sat, 01 Mar 2025 07:55:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36094) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1toMMz-00051p-S7 for 76478@debbugs.gnu.org; Sat, 01 Mar 2025 07:55:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1toMMt-0004Ri-9G; Sat, 01 Mar 2025 07:54:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=SVoLXpc2nldMGK8fm7CyVcF5bSDNeIov5eAzniikdaE=; b=MVIyabuI4ORgQGt+BB/i KOqnJFiQmEZ93FTctY46xXQdhgv44sSSjig7mYbB/G9Q8U+Ukxu3mOsscYPSf7BScD7mS8kr+Z+j5 nbvRml8b4q3BZ/0CMerjy63yydT9GlNYx9XvskQMpKF/B5r/Vea5+LCiN4cq1AHoskxjcWaxDLleG O7cuxx69xH3nd/RBynFIaYvyAr2uCmNI2yqYAR0fi2Xz+d1523HCh+C3yv2Ma7DBNgjzXkhhw7E2i 6lO14AJPnwC9z/yeuxXvorS5vEnumpZXhujsam13JcDf7pL2wmgBoZIdOejl+8T1bbsRO7QSJMcVO mBI6a1t9MpNE1A==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdelfeefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtsehttdertddtredt necuhfhrohhmpefvrghsshhilhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqne cuggftrfgrthhtvghrnhepleduvdegfeduvdejkeefteelgeetgfevhefhueffueffgeeh gfeufefgvdffgedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeei jeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrih hlrdhfmhdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthht ohepfihinhhklhgvrhesghhnuhdrohhrghdprhgtphhtthhopehmohhnnhhivghrsehirh hordhumhhonhhtrhgvrghlrdgtrgdprhgtphhtthhopeejieegjeekseguvggssghughhs rdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail From: Tassilo Horn In-Reply-To: <86cyf1orsq.fsf@gnu.org> References: <87zfifaxbc.fsf@gnu.org> <86jz9ilbdq.fsf@gnu.org> <87wmdio3ji.fsf@gnu.org> <875xl1qb8p.fsf@gnu.org> <861pvphvob.fsf@gnu.org> <86cyf1orsq.fsf@gnu.org> User-Agent: mu4e 1.12.9; emacs 31.0.50 Date: Sat, 01 Mar 2025 13:54:54 +0100 Message-ID: <87ikos6hcx.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> Cc: 76478@debbugs.gnu.org, monnier@iro.umontreal.ca, winkler@gnu.org >> Date: Sun, 23 Feb 2025 11:12:04 +0200 >> From: Eli Zaretskii >> >> > From: Tassilo Horn >> > Cc: Roland Winkler , 76478@debbugs.gnu.org >> > Date: Sun, 23 Feb 2025 10:08:38 +0100 >> > >> > And Eli, in which version do you want the fix? I think the issue >> > is quite old and as explained above, you will usually only trigger >> > it when editing OpenDocument contents which probably is quite >> > uncommon. >> >> I think fixing this on master should be okay, thanks. > > Ping! Tassilo, would you please install your patch? Done just now. Roland, please give it a try. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 01 21:28:48 2025 Received: (at control) by debbugs.gnu.org; 2 Mar 2025 02:28:48 +0000 Received: from localhost ([127.0.0.1]:48331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1toZ4S-0007F2-Az for submit@debbugs.gnu.org; Sat, 01 Mar 2025 21:28:48 -0500 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:53532) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1toZ4Q-0007ES-4J for control@debbugs.gnu.org; Sat, 01 Mar 2025 21:28:46 -0500 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5e033c2f106so3829172a12.3 for ; Sat, 01 Mar 2025 18:28:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740882520; x=1741487320; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=vYDEeJ+HI7ektqyhyYY6JxZfFGKSzuEaldckNZX/Uvk=; b=je57gR79CLAQ7fJ1wcVuWmJXUXk6FvwujOsVGoVDHpak63yc9h22HFkkDtAxZWjooO qlVAfwap0YlHrhWOGh/kua4lbDG1laMbs5+rc+5ZXzKnBLbdQFtOpwwyzbtNKYDzzZQv /8x+R3XYhPD6cMjUxH+xsqPQxDq6Ui4jvxP5zcAARZy6V9SMn9NQYx+HtW+92uKc657/ kjwpc8pnLuFP8z7431SqGV80di+TngQJO8YNJIp1/hl/f9dWZADZbsgMT1qdxdLSwYKU 8BhwyJkOeLOgEJAoFsT/vdr4vzwRxXkMyOfvZSDlrvWQW3h87tKn3PblT8uvec4NHiDq 4dQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740882520; x=1741487320; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=vYDEeJ+HI7ektqyhyYY6JxZfFGKSzuEaldckNZX/Uvk=; b=W9jIraSsSBfAHf0AlyhkkvKkU6Z8Wv8Xt7tFxuNXsLiCfPsfiMyHwp9266OPd4ZRQt 2Nqxih5CHubEyriw6K59TJpTzeTb5nZfIJM9IruEBdlMtlUE16S9I8a/pKDnWvp653LH dt4tKPodiFhPxxSIhaIDZbkeFkpb9p6OKztqyGk+krCWEkrLU3Hs204X+LT6u5jAAJnI DWECiLS9wDnW8/54yZQ2vOBDFot3fRAdms67wcitzlJ0upVbp0zN6vwp6Oe1tYySHEGV BQPDTN3VZCa3jg1YxxgB83gjx2+PuxOP7zwNw7c172cv+IUJdHbhxab1aWB6b7SvLvx0 ZXgA== X-Gm-Message-State: AOJu0YxsSAO5a7aSvfycVOFTy1zpeLwDjHPcqhoUwFbZKVfNjLnR5v3P 9CsgBE1h3d4SGuQBV5gfL0vvNrmo0xfKgN1tTyu3wWZpWLBFv9il93MkOp8Zhoqq0ZlibgcPX06 9Vfep3fdmlvPwyuOjJsCEH1ZtnCXEQ1Rdnzc= X-Gm-Gg: ASbGncvOzxYFDm2qXNexZxZsJ1WECyecFl4IXO07AxBJvbv11Z1iLvugM/Qg/Oaq9z1 e0hqulm9qYLxj76NtVTHEGLfHgn2IiXaj9s2JtaxKYinnVid4gKxFaK2x0bhJfFt8zwW6Js8xoW c3ghIIo3/1D6f7mtG6LBGe/A9+cA== X-Google-Smtp-Source: AGHT+IHLwrJ2Pk+BxOFid2qUGMp1ED35nS0XJkwM8Z8w2VQzrCvC3nceIa0TR4FCeyv8fjf6ctEAH1M1hMtQdLmFi9c= X-Received: by 2002:a05:6402:13ca:b0:5d0:c697:1f02 with SMTP id 4fb4d7f45d1cf-5e4d6af43famr25359923a12.17.1740882519958; Sat, 01 Mar 2025 18:28:39 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 1 Mar 2025 18:28:39 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Sat, 1 Mar 2025 18:28:39 -0800 X-Gm-Features: AQ5f1Jor4jCrmrH3T4jX7vmExEs__pOTPLkn7q7evCU9oqbl1Akd0SObQVE5ZIc Message-ID: Subject: control message for bug #76478 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) fixed 76478 31.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 02 02:30:28 2025 Received: (at control) by debbugs.gnu.org; 2 Mar 2025 07:30:29 +0000 Received: from localhost ([127.0.0.1]:52091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1todmO-0000Jg-15 for submit@debbugs.gnu.org; Sun, 02 Mar 2025 02:30:28 -0500 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:61905) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1todmH-0000H4-9H for control@debbugs.gnu.org; Sun, 02 Mar 2025 02:30:22 -0500 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5e50de0b5easo1515833a12.3 for ; Sat, 01 Mar 2025 23:30:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740900615; x=1741505415; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=YHMrmJPGxwYeRF1oV0vATCYiH7QhUfjephz553U66b8=; b=Z7O/HAoDiJY4QY8jJxDuOVBtAE6ribNmYdae35CJwFG3bhcRmk+5/YwuN7SWoGVos6 znTO4Yzst89KeX3TZE/UtxOPfDOsP14eH1nwFTWUoYAe88phPO83iLcy2Y71y0R1PjEv yHx3YeIFAdR0R0yB/necYOgjxYUzeeQDpomYfOKlS3skG2QFrXM+pVKhbR1BV3Zm5Xyu ZM5R3ifI/8ze8ZRA35YrWA0VM6i5va508nXH2IM69CNdw1tODqBoTTTzU4e+hKl14ykg PdflhD21fnBkAt7Ain5+tXBdEsbRymkT02+M8BW6ep+LuPy4Tw8BsR4I/etebjcYVmxm l3dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740900615; x=1741505415; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YHMrmJPGxwYeRF1oV0vATCYiH7QhUfjephz553U66b8=; b=Q1tlwdWrvr6+MHRvC5orgkxfTQe7E+R2hP6tvlo7T3hPZLHbg93rWaL7y1PTZMWNnQ LUw3DFTPu6V+vYZUNJwmqCnpeS1w4wMYeEDMQbHpLO0qVIgz4FvUvYnY/prJS3MFRJwE e9Y2IOk+JI9T3/rg/BaqkiyyLdZPfW0afE3UbK9BhHa5uDdJYdp0wlS7GvY77W0+Yv/C fRGjs9A2ObkgiuN+7/1v7JlNQL2941FAvGRBvCEl6/CPS4Wf86uh1LtLxi3KLzklQzKY uJ6TDdOyva6U9gkCU80k6Q6yLGN+h3knJ+8Qp33OTsKWYZMIbB4vDf3+ncG56H2Lz37e vQ9w== X-Forwarded-Encrypted: i=1; AJvYcCXRM6lcRHVN92f+L1WMrq/MK1+Ge6Pq2hk+fdOVvbdLaDiYwa0eJcpuq4nFl61wtD1OpnVTP8Em@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywe/oLfuGg0MVlAhM19J9zwWxx5chPAu56Wjek3XsOtmKFVHylS xBsPCCTggim+L7KTC4pq6r1KeLXoefupjtCQFHGvxW6OZVkawU5VzR7ZNJmoyIFEIsgi3+7Lsnw wrqBuiy1b//+PpupV6w1YpWbnj2Q= X-Gm-Gg: ASbGncv0/R8yzW/76z8duI5h61h/P6mOXDFqNFoOgpJGAXJHvMjMKTg4nKVPBdrYjc/ zx8a2i+lnxw3Ey2ngRaKH+oBXAAggmgx/3QQTeoMlo00/gvR36EZ5ieRT8v45E+KmTeWKvurngK 8Tt5xwWQy5V4APELMnCQsO9WSfYy8= X-Google-Smtp-Source: AGHT+IFdSRVMC7/46S7TfuFqNVXjXVrpCPHuPWswNOyKmiJJoQl1KuPb22vVcf5GOF6kMbKkm+JDRoB4tyLJuUs1TfI= X-Received: by 2002:a05:6402:42c2:b0:5de:dd31:1fad with SMTP id 4fb4d7f45d1cf-5e4d6ad45e8mr10307265a12.6.1740900614852; Sat, 01 Mar 2025 23:30:14 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 1 Mar 2025 23:30:14 -0800 From: Stefan Kangas In-Reply-To: <87zfi47xqo.fsf@gnu.org> References: <87o70cjeam.fsf@turtle-trading.net> <87zfi47xqo.fsf@gnu.org> MIME-Version: 1.0 Date: Sat, 1 Mar 2025 23:30:14 -0800 X-Gm-Features: AQ5f1JpVijnx9k7ZTrPbTGRuuzZpSgoADaDIJMecvbz-U3SceHnKgMyQt60KXb0 Message-ID: Subject: Re: bug#75515: 30.0.92; doc-view: Saving an epub raises error in doc-view--revert-buffer To: Tassilo Horn Content-Type: text/plain; charset="UTF-8" Bcc: control@debbugs.gnu.org X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 75515@debbugs.gnu.org, Benjamin Riefenstahl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 76478 75515 thanks Tassilo Horn writes: > merge 75515 76478 > > Stefan Kangas writes: > >> Benjamin Riefenstahl writes: >> >>> I was editing an epub file. When I save, I get an error from >>> doc-view--revert-buffer. I have reproduced the problem with "emacs -Q". >> >> Tassilo, any comments here? > > Yes, that should already fixed by 34362a2a1cc for bug#76478 which is > essentially the same just with OpenDocument docs which are archives, > too. OK, thanks. > I hope I've merged these two reports with this message. I think a forcemerge was needed, so I did that above. From unknown Sat Aug 16 18:39:54 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Roland Winkler Subject: bug#76478: closed (Re: bug#76478: 30.0.92; doc-view--revert-buffer fails when saving OpenDocument spreadsheets) Message-ID: References: <867c4qy2c7.fsf@gnu.org> <87zfifaxbc.fsf@gnu.org> X-Gnu-PR-Message: they-closed 76478 X-Gnu-PR-Package: emacs Reply-To: 76478@debbugs.gnu.org Date: Sat, 15 Mar 2025 11:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1742037182-6378-1" This is a multi-part message in MIME format... ------------=_1742037182-6378-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #76478: 30.0.92; doc-view--revert-buffer fails when saving OpenDocument spr= eadsheets which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 76478@debbugs.gnu.org. --=20 76478: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76478 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1742037182-6378-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 76478-done) by debbugs.gnu.org; 15 Mar 2025 11:12:50 +0000 Received: from localhost ([127.0.0.1]:39127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttPRi-0001dq-Gf for submit@debbugs.gnu.org; Sat, 15 Mar 2025 07:12:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40722) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ttPRf-0001dZ-Ky for 76478-done@debbugs.gnu.org; Sat, 15 Mar 2025 07:12:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ttPRa-0007S2-3U; Sat, 15 Mar 2025 07:12:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Asp4DmQEwcaA6lWeGRo5fxk4Gp4rbSje4pmfnCksfJg=; b=gGoUqmRDwbFr oNg25O1y6prdgYmuRBgZcfWGTeCYPUpcyDc4do/XwV84/3cWzzaLo3A6ktEPC4jLiGuI374BcWfTt wR86JOu81XpeCVyuJ5Tm0aAIIj94Wa08GmJyho9Sxp1DONJIoncACerOP8T8tlgYQ8sBStcQr0kPd EjngGcEfDA+2AHNEHvgocjoVfr6oQxMQMy8RHGjEei7TO2WIwACQ9767qs7xMOsWbQqTggI2Q+icp KdYRdGuUuHTbQUUfcUyroW3iwDZraorbcWDRhK9j4PVZBABsQjXVj69xdxifXgG9nXqGP89lKjmtd UuEyamy4cVDj+cdepMIiqw==; Date: Sat, 15 Mar 2025 13:12:40 +0200 Message-Id: <867c4qy2c7.fsf@gnu.org> From: Eli Zaretskii To: Tassilo Horn In-Reply-To: <87ikos6hcx.fsf@gnu.org> (message from Tassilo Horn on Sat, 01 Mar 2025 13:54:54 +0100) Subject: Re: bug#76478: 30.0.92; doc-view--revert-buffer fails when saving OpenDocument spreadsheets References: <87zfifaxbc.fsf@gnu.org> <86jz9ilbdq.fsf@gnu.org> <87wmdio3ji.fsf@gnu.org> <875xl1qb8p.fsf@gnu.org> <861pvphvob.fsf@gnu.org> <86cyf1orsq.fsf@gnu.org> <87ikos6hcx.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76478-done Cc: 76478-done@debbugs.gnu.org, monnier@iro.umontreal.ca, winkler@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tassilo Horn > Cc: 76478@debbugs.gnu.org, monnier@iro.umontreal.ca, winkler@gnu.org > Date: Sat, 01 Mar 2025 13:54:54 +0100 > > Eli Zaretskii writes: > > >> Cc: 76478@debbugs.gnu.org, monnier@iro.umontreal.ca, winkler@gnu.org > >> Date: Sun, 23 Feb 2025 11:12:04 +0200 > >> From: Eli Zaretskii > >> > >> > From: Tassilo Horn > >> > Cc: Roland Winkler , 76478@debbugs.gnu.org > >> > Date: Sun, 23 Feb 2025 10:08:38 +0100 > >> > > >> > And Eli, in which version do you want the fix? I think the issue > >> > is quite old and as explained above, you will usually only trigger > >> > it when editing OpenDocument contents which probably is quite > >> > uncommon. > >> > >> I think fixing this on master should be okay, thanks. > > > > Ping! Tassilo, would you please install your patch? > > Done just now. Roland, please give it a try. No further comments within 2 weeks, so I presume the bug was indeed solved, and I'm therefore closing it. ------------=_1742037182-6378-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Feb 2025 19:54:14 +0000 Received: from localhost ([127.0.0.1]:36746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlZ6D-0004UV-CW for submit@debbugs.gnu.org; Fri, 21 Feb 2025 14:54:14 -0500 Received: from lists.gnu.org ([2001:470:142::17]:44170) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlZ68-0004T2-RU for submit@debbugs.gnu.org; Fri, 21 Feb 2025 14:54:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlZ61-00076U-5i for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2025 14:54:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlZ60-0001rP-Tb for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2025 14:54:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=2XsrjI0TDv25+bBF9lsBaH5t+4Ege5EjeH6hmkR4FBU=; b=fVnRwBUWk5i19R HOJoXvOEDXWrl3S4S01LUxgeEOAPO/N7VAiLh7tfeA2sQR/Yye5BvP1q+i4pYJJLdWlD9jrJkYqtG Tz5yd9VOEQrrKSmCdJlwBq0a9/Nr10DN0xNDrxeeDgSH7vti5/B6qaf+91r78ZyWrYZHxAFOFN6mE me8NvSuasLmVQAZcEf//rkCd8SgF3iO5YgxIJo6yMQX+kBgeu3usMMcTpjBVP83BGjZ/tpWionIvl mvo98qSh+MV9R2l0Q8BGMrGqcxUld9DhKoQYEL/LGyAXC2fK8AbisWCg64BnYg2jEPVG5xjo5uPbl e9ThPAoCXu/jLZG44g/w==; From: Roland Winkler To: bug-gnu-emacs@gnu.org Subject: 30.0.92; doc-view--revert-buffer fails when saving OpenDocument spreadsheets X-Debbugs-Cc: Date: Fri, 21 Feb 2025 13:53:59 -0600 Message-ID: <87zfifaxbc.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) When I open an OpenDocument spreadsheet (file extension ods), by default this happens via doc-view. Then, when I edit the file (say, content.xml) and try to save it, doc-view--revert-buffer bails out with the error (wrong-type-argument stringp nil). If, instead, I open and edit the file as a zip archive without doc-view, I can save it without any problems. In GNU Emacs 30.0.92 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-11-01 built on regnitz Windowing system distributor 'The X.Org Foundation', version 11.0.12101007 System Description: Debian GNU/Linux 12 (bookworm) Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_COLLATE: C value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix ------------=_1742037182-6378-1-- From unknown Sat Aug 16 18:39:54 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Benjamin Riefenstahl Subject: bug#75515: closed (Re: bug#76478: 30.0.92; doc-view--revert-buffer fails when saving OpenDocument spreadsheets) Message-ID: References: <867c4qy2c7.fsf@gnu.org> <87o70cjeam.fsf@turtle-trading.net> X-Gnu-PR-Message: they-closed 75515 X-Gnu-PR-Package: emacs Reply-To: 75515@debbugs.gnu.org Date: Sat, 15 Mar 2025 11:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1742037182-6378-3" This is a multi-part message in MIME format... ------------=_1742037182-6378-3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #76478: 30.0.92; doc-view: Saving an epub raises error in doc-view--revert-= buffer which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 75515@debbugs.gnu.org. --=20 76478: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76478 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1742037182-6378-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 76478-done) by debbugs.gnu.org; 15 Mar 2025 11:12:50 +0000 Received: from localhost ([127.0.0.1]:39127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttPRi-0001dq-Gf for submit@debbugs.gnu.org; Sat, 15 Mar 2025 07:12:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40722) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ttPRf-0001dZ-Ky for 76478-done@debbugs.gnu.org; Sat, 15 Mar 2025 07:12:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ttPRa-0007S2-3U; Sat, 15 Mar 2025 07:12:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Asp4DmQEwcaA6lWeGRo5fxk4Gp4rbSje4pmfnCksfJg=; b=gGoUqmRDwbFr oNg25O1y6prdgYmuRBgZcfWGTeCYPUpcyDc4do/XwV84/3cWzzaLo3A6ktEPC4jLiGuI374BcWfTt wR86JOu81XpeCVyuJ5Tm0aAIIj94Wa08GmJyho9Sxp1DONJIoncACerOP8T8tlgYQ8sBStcQr0kPd EjngGcEfDA+2AHNEHvgocjoVfr6oQxMQMy8RHGjEei7TO2WIwACQ9767qs7xMOsWbQqTggI2Q+icp KdYRdGuUuHTbQUUfcUyroW3iwDZraorbcWDRhK9j4PVZBABsQjXVj69xdxifXgG9nXqGP89lKjmtd UuEyamy4cVDj+cdepMIiqw==; Date: Sat, 15 Mar 2025 13:12:40 +0200 Message-Id: <867c4qy2c7.fsf@gnu.org> From: Eli Zaretskii To: Tassilo Horn In-Reply-To: <87ikos6hcx.fsf@gnu.org> (message from Tassilo Horn on Sat, 01 Mar 2025 13:54:54 +0100) Subject: Re: bug#76478: 30.0.92; doc-view--revert-buffer fails when saving OpenDocument spreadsheets References: <87zfifaxbc.fsf@gnu.org> <86jz9ilbdq.fsf@gnu.org> <87wmdio3ji.fsf@gnu.org> <875xl1qb8p.fsf@gnu.org> <861pvphvob.fsf@gnu.org> <86cyf1orsq.fsf@gnu.org> <87ikos6hcx.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76478-done Cc: 76478-done@debbugs.gnu.org, monnier@iro.umontreal.ca, winkler@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tassilo Horn > Cc: 76478@debbugs.gnu.org, monnier@iro.umontreal.ca, winkler@gnu.org > Date: Sat, 01 Mar 2025 13:54:54 +0100 > > Eli Zaretskii writes: > > >> Cc: 76478@debbugs.gnu.org, monnier@iro.umontreal.ca, winkler@gnu.org > >> Date: Sun, 23 Feb 2025 11:12:04 +0200 > >> From: Eli Zaretskii > >> > >> > From: Tassilo Horn > >> > Cc: Roland Winkler , 76478@debbugs.gnu.org > >> > Date: Sun, 23 Feb 2025 10:08:38 +0100 > >> > > >> > And Eli, in which version do you want the fix? I think the issue > >> > is quite old and as explained above, you will usually only trigger > >> > it when editing OpenDocument contents which probably is quite > >> > uncommon. > >> > >> I think fixing this on master should be okay, thanks. > > > > Ping! Tassilo, would you please install your patch? > > Done just now. Roland, please give it a try. No further comments within 2 weeks, so I presume the bug was indeed solved, and I'm therefore closing it. ------------=_1742037182-6378-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Jan 2025 14:32:29 +0000 Received: from localhost ([127.0.0.1]:46496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tWz0u-0007uL-5a for submit@debbugs.gnu.org; Sun, 12 Jan 2025 09:32:29 -0500 Received: from lists.gnu.org ([2001:470:142::17]:36218) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tWz0r-0007u5-Gh for submit@debbugs.gnu.org; Sun, 12 Jan 2025 09:32:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tWz0i-0002Sc-H5 for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2025 09:32:16 -0500 Received: from mail.turtle-trading.net ([18.197.215.73]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tWz0g-0002Fg-De for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2025 09:32:16 -0500 Received: from [185.117.215.14] (helo=arrian) by mail.turtle-trading.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97) (envelope-from ) id 1tWyyQ-00000000j6V-0t8z; Sun, 12 Jan 2025 15:29:54 +0100 From: Benjamin Riefenstahl To: bug-gnu-emacs@gnu.org Subject: 30.0.92; doc-view: Saving an epub raises error in doc-view--revert-buffer X-Debbugs-Cc: Date: Sun, 12 Jan 2025 15:29:53 +0100 Message-ID: <87o70cjeam.fsf@turtle-trading.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=18.197.215.73; envelope-from=b.riefenstahl@turtle-trading.net; helo=mail.turtle-trading.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I was editing an epub file. When I save, I get an error from doc-view--revert-buffer. I have reproduced the problem with "emacs -Q". Steps: * Open an epub file. (I can make a minimal example file, if that helps.) * Switch to archive mode with C-c C-c. (Epubs are zip files.) * Open and edit one of the files in the zip. * Save the file (C-x C-s). * The mini-buffer shows "Wrong type argument: stringp, nil". Running with debug-on-error gives the backtrace below. * The Zip-File was actually saved, but the archive buffer is left in a raw-bytes mode and the modified file is still marked modified. ---- Debugger entered--Lisp error: (wrong-type-argument stringp nil) doc-view--revert-buffer(#[128 "\301\302\300!\2\"\207" [revert-buffer-function apply default-value] 4 advice--forward] t t) apply(doc-view--revert-buffer #[128 "\301\302\300!\2\"\207" [revert-buffer-function apply default-value] 4 advice--forward] (t t)) #f(advice doc-view--revert-buffer :around #[128 "\301\302\300!\2\"\207" [revert-buffer-function apply default-value] 4 advice--forward])(t t) archive--mode-revert(#f(advice doc-view--revert-buffer :around #[128 "\301\302\300!\2\"\207" [revert-buffer-function apply default-value] 4 advice--forward]) nil t) apply(archive--mode-revert #f(advice doc-view--revert-buffer :around #[128 "\301\302\300!\2\"\207" [revert-buffer-function apply default-value] 4 advice--forward]) (nil t)) #f(advice archive--mode-revert :around #f(advice doc-view--revert-buffer :around #[128 "\301\302\300!\2\"\207" [revert-buffer-function apply default-value] 4 advice--forward]))(nil t) revert-buffer(nil t) #f(compiled-function () #)() archive--with-ensure-extension("/home/benny/Downloads/epubs/Dona Rosita la Soltera.epub" #f(compiled-function (archive) #)) archive-*-write-file-member("/home/benny/Downloads/epubs/Dona Rosita la Soltera.epub" #s(archive--file-desc :ext-file-name "META-INF/container.xml" :int-file-name "META-INF/container.xml" :mode 384 :size 244 :time "27-Feb-2017 22:54:36" :ratio nil :uid nil :gid nil :pos 52893) ("zip" "-q")) archive-zip-write-file-member("/home/benny/Downloads/epubs/Dona Rosita la Soltera.epub" #s(archive--file-desc :ext-file-name "META-INF/container.xml" :int-file-name "META-INF/container.xml" :mode 384 :size 244 :time "27-Feb-2017 22:54:36" :ratio nil :uid nil :gid nil :pos 52893)) ---- In GNU Emacs 30.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-11-27 built on arrian Repository revision: fc17e8727d48c32f2610c6fe7c17147bff7be52b Repository branch: emacs-30 Windowing system distributor 'The X.Org Foundation', version 11.0.12101007 System Description: Debian GNU/Linux 12 (bookworm) Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Zip-Archive Minor modes in effect: doc-view-minor-mode: t desktop-save-mode: t display-time-mode: t server-mode: t xclip-mode: t xterm-mouse-mode: t delete-selection-mode: t cua-mode: t display-battery-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: ~/Projects/ttf-mode/arc-mode-compat hides ~/emacs/arc-mode-compat /home/benny/.emacs.d/elpa/transient-20240729.1524/transient hides /usr/local/share/emacs/30.0.92/lisp/transient Features: (shadow bbdb-message emacsbug ttf-glyphs rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap sgml-mode facemenu nxml-util nxml-enc xmltok arc-mode archive-mode gnus-kill nndoc comp-run python project compat oc-basic org-element org-persist org-id org-refile org-element-ast inline avl-tree generator ol-eww benny-nitter eww xdg url-queue ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view filenotify image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src sh-script smie treesit executable ob-comint org-pcomplete pcomplete org-list org-footnote org-faces org-entities noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func org-version org-compat org-macs display-line-numbers shortdoc comp-common rx thingatpt help-fns smerge-mode diff shr-color color qp sort smiley gnus-cite flow-fill mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg gnus-dup gnus-ml pp gnus-topic jka-compr mm-archive url-http url-gw url-cache url-auth nndraft nnmh nnfolder bbdb-gnus bbdb-mua network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig nntp gnus-cache gnus-sum shr pixel-fill kinsoku url-file svg message-x pop3 gnus-group gnus-undo nnrss dom mm-url bbdb-com crm bbdb bbdb-site timezone gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time iso8601 gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr wid-edit imenu view mule-util dired-aux time-date desktop frameset highline benny-calendar-cfg ange-ftp generic-x autoinsert cc-mode cc-fonts cc-guess cc-menus cc-styles cc-align cc-cmds cc-engine cc-vars cc-defs ps-print ps-print-loaddefs lpr advice cl-extra help-mode dired dired-loaddefs derived benny-x-clipboard disp-table time server protbuf xclip term/xterm xterm xt-mouse cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew holidays holiday-loaddefs vc-git diff-mode track-changes easy-mmode vc-dispatcher diary-lib diary-loaddefs cal-menu calendar cal-loaddefs delsel grep compile text-property-search comint ansi-osc ansi-color ring cua-base cus-load format-spec battery dbus xml .loaddefs benny-tools autoload loaddefs-gen radix-tree lisp-mnt bbdb-autoloads crontab-mode-autoloads csv-mode-autoloads debbugs-autoloads elpher-autoloads enwc-autoloads graphql-autoloads graphql-doc-autoloads graphql-mode-autoloads jsonian-autoloads lsp-java-autoloads dap-mode-autoloads lsp-docker-autoloads lsp-treemacs-autoloads lsp-ui-autoloads lsp-mode-autoloads f-autoloads magit-autoloads pcase git-commit-autoloads magit-section-autoloads markdown-preview-mode-autoloads markdown-mode-autoloads mastodon-autoloads monky-autoloads nov-autoloads esxml-autoloads osm-autoloads persist-autoloads request-autoloads sly-autoloads sql-indent-autoloads sqlup-mode-autoloads telega-autoloads tp-autoloads transient-autoloads treemacs-autoloads cfrs-autoloads posframe-autoloads ht-autoloads hydra-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads s-autoloads dash-autoloads vc-fossil-autoloads visual-fill-column-autoloads websocket-autoloads info with-editor-autoloads x509-mode-autoloads xclip-autoloads yaml-autoloads yaml-imenu-autoloads yaml-mode-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 636284 118044) (symbols 48 36587 0) (strings 32 154237 18123) (string-bytes 1 4411985) (vectors 16 83147) (vector-slots 8 1754624 224329) (floats 8 1431 9469) (intervals 56 1085 373) (buffers 992 56)) ------------=_1742037182-6378-3--