GNU bug report logs - #76471
[PATCH] 31.0.50; dockerfile-ts-mode lacks fontification for most grammar-elements in the Dockerfile AST

Previous Next

Full log

View this message in rfc822 format

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Randy Taylor <dev <at> rjt.dev>, Yuan Fu <casouri <at> gmail.com>, Stefan Kangas <stefankangas <at> gmail.com>, 76471 <at> debbugs.gnu.org
Subject: bug#76471: [PATCH] 31.0.50; dockerfile-ts-mode lacks fontification for most grammar-elements in the Dockerfile AST
Date: Sat, 22 Feb 2025 16:51:17 +0100

[Message part 1 (text/plain, inline)]

OK.

I've recreated the patch using the commit-message you suggested :)

Let me know if there are any other things you want to amend or change.

 

—
Kind Regards
Jostein Kjønigsen

> On 22 Feb 2025, at 08:24, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> Cc: Randy Taylor <dev <at> rjt.dev>, Yuan Fu <casouri <at> gmail.com>,
>> 76471 <at> debbugs.gnu.org
>> From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
>> Date: Fri, 21 Feb 2025 23:12:18 +0100
>> 
>> Disregard previuos patch. This one includes one more case of string-fontification which I uncovered when testing with more files I had lying around.
> 
> Thank you for your efforts.
> 
>> * lisp/progmodes/dockerfile-ts-mode.el: Improve fontification
>> (dockerfile-ts-mode--font-lock-settings, dockerfile-ts-mode):
>> 
>> Add support for fontifying the following grammar-elements:
>> 
>> - image-declarations (image-name, image-tag & image alias)
>> - strings in more general terms
>> - string-expansion statements
>> - treat path-values as strings
>> - identifiers names for ENV and ARG statements
>> - argument values for ENV and ARG statements
> 
> Here's how this should be modified to be in-line with our conventions:
> 
> ----------------------------------------------------------------------
> Improve fontification of docker-files
> 
> Add support for fontifying the following grammar-elements:
> - image-declarations (image-name, image-tag & image alias)
> - strings in more general terms
> - string-expansion statements
> - treat path-values as strings
> - identifiers names for ENV and ARG statements
> - argument values for ENV and ARG statements
> * lisp/progmodes/dockerfile-ts-mode.el (dockerfile-ts-mode)
> (dockerfile-ts-mode--font-lock-settings): Improve fontification.
> (Bug#76481)
> ----------------------------------------------------------------------
> 
> That is:
> 
> . first, a one-line summary, without a period
> . then details of the change in plain English
> . and finally, a list of files and functions/variables in each files
>   where changes were made, with terse description of what was
>   changed, including the bug number reference
> 
> OK?

[Message part 2 (text/html, inline)]

[0001-Improve-fontification-of-docker-files.patch (application/octet-stream, attachment)]

[Message part 4 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.