GNU bug report logs - #76471
[PATCH] 31.0.50; dockerfile-ts-mode lacks fontification for most grammar-elements in the Dockerfile AST

Previous Next

Full log

Message #23 received at 76471 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: dev <at> rjt.dev, casouri <at> gmail.com, stefankangas <at> gmail.com,
 76471 <at> debbugs.gnu.org
Subject: Re: bug#76471: [PATCH] 31.0.50;
 dockerfile-ts-mode lacks fontification for most grammar-elements in
 the Dockerfile AST
Date: Sat, 22 Feb 2025 09:24:17 +0200

> Cc: Randy Taylor <dev <at> rjt.dev>, Yuan Fu <casouri <at> gmail.com>,
>  76471 <at> debbugs.gnu.org
> From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
> Date: Fri, 21 Feb 2025 23:12:18 +0100
> 
> Disregard previuos patch. This one includes one more case of string-fontification which I uncovered when testing with more files I had lying around.

Thank you for your efforts.

> * lisp/progmodes/dockerfile-ts-mode.el: Improve fontification
>  (dockerfile-ts-mode--font-lock-settings, dockerfile-ts-mode):
> 
> Add support for fontifying the following grammar-elements:
> 
> - image-declarations (image-name, image-tag & image alias)
> - strings in more general terms
> - string-expansion statements
> - treat path-values as strings
> - identifiers names for ENV and ARG statements
> - argument values for ENV and ARG statements

Here's how this should be modified to be in-line with our conventions:

----------------------------------------------------------------------
Improve fontification of docker-files

Add support for fontifying the following grammar-elements:
 - image-declarations (image-name, image-tag & image alias)
 - strings in more general terms
 - string-expansion statements
 - treat path-values as strings
 - identifiers names for ENV and ARG statements
 - argument values for ENV and ARG statements
* lisp/progmodes/dockerfile-ts-mode.el (dockerfile-ts-mode)
(dockerfile-ts-mode--font-lock-settings): Improve fontification.
(Bug#76481)
----------------------------------------------------------------------

That is:

 . first, a one-line summary, without a period
 . then details of the change in plain English
 . and finally, a list of files and functions/variables in each files
   where changes were made, with terse description of what was
   changed, including the bug number reference

OK?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.