GNU bug report logs - #76471
[PATCH] 31.0.50; dockerfile-ts-mode lacks fontification for most grammar-elements in the Dockerfile AST

Previous Next

Full log

Message #17 received at 76471 <at> debbugs.gnu.org (full text, mbox):

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Randy Taylor <dev <at> rjt.dev>, Yuan Fu <casouri <at> gmail.com>,
 76471 <at> debbugs.gnu.org
Subject: Re: bug#76471: [PATCH] 31.0.50; dockerfile-ts-mode lacks
 fontification for most grammar-elements in the Dockerfile AST
Date: Fri, 21 Feb 2025 22:58:52 +0100

[Message part 1 (text/plain, inline)]

Ok. One more try then. Like this? :)



—
Kind Regards
Jostein Kjønigsen

> On 21 Feb 2025, at 22:03, Stefan Kangas <stefankangas <at> gmail.com> wrote:
> 
> Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> writes:
> 
>> I'm not used to adding things to NEWS. Is this OK?
> 
> Sorry, I meant a ChangeLog entry, as described under the header "Commit
> messages" in CONTRIBUTE.  I see many patches from you that have followed
> this format in the past.  I guess it should look something like this.
> 
>    * lisp/progmodes/dockerfile-ts-mode.el
>    (dockerfile-ts-mode--font-lock-settings, dockerfile-ts-mode):
>    ...description here...
> 
> (I would recommend using `M-x magit-generate-changelog` from the
> ChangeLog buffer to generate them, if you are a Magit user, and
> otherwise `C-x 4 a`.)
> 
> I'm not sure that this change specifically needs to be in NEWS, but I
> won't object to adding it there also.
> 
> Thanks again, and sorry for not being more clear.

[Message part 2 (text/html, inline)]

[0001-Improve-fontification-of-docker-files.patch (application/octet-stream, attachment)]

[Message part 4 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.