GNU bug report logs - #7647
Diagnose invalid primary/directory combinations (was: Re: configmake module and automake 1.9.6)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Subject: bug#7647: closed (Re: bug#7647: [PATCH] {maint} Warnings about
 primary/prefix mismatch fixed and extended.)
Date: Thu, 16 Jun 2011 16:22:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#7647: Diagnose invalid primary/directory combinations (was: Re: configmake module and automake 1.9.6)

which was filed against the automake package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 7647 <at> debbugs.gnu.org.

-- 
7647: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7647
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: 7647-done <at> debbugs.gnu.org
Cc: Eric Blake <eblake <at> redhat.com>
Subject: Re: bug#7647: [PATCH] {maint} Warnings about primary/prefix mismatch
	fixed and extended.
Date: Thu, 16 Jun 2011 18:20:49 +0200

The patch has been finally as commit v1.11-373-g9ca6326, with
a non-trivial optimization (for speed reasons) to a test case
applied with follow-up commit `v1.11-374-ged078da'.

I'm thus marking this bug as closed.

Regards,
  Stefano

[Message part 3 (message/rfc822, inline)]

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: automake <at> gnu.org
Cc: bug-automake <at> gnu.org, Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de>,
	Eric Blake <eblake <at> redhat.com>
Subject: Diagnose invalid primary/directory combinations (was: Re: configmake
	module and automake 1.9.6)
Date: Wed, 15 Dec 2010 12:27:43 +0100

Hi Eric.

On Tuesday 14 December 2010, Eric Blake wrote:
> [dropping gnulib for this reply]
> 
> On 12/14/2010 02:54 PM, Eric Blake wrote:
> >>>  # Listed in the same order as the GNU makefile conventions.
> >>>  # The Automake-defined pkg* macros are appended, in the order
> >>>  # listed in the Automake 1.10a+ documentation.
> >>> +# Support newer definitions even when using older automake 1.9.6
> >>
> >> The Automake version is probably irrelevant here. It's the Autoconf
> >> version that matters.
> > 
> > Oh; it's a mix of both autoconf and automake macros (autoconf AC_SUBST's
> > localedir, but only automake 1.11 AC_SUBST's pkglibexecdir); the comment
> > in modules/configmake only mentioned automake, but both tools have a
> > hand in feeding configmake.h.
> 
> In fact, I think automake has a minor bug.  automake.in lists the
> following directories:
> 
> my %standard_prefix =
>     map { $_ => 1 } (qw(bin data dataroot dvi exec html include info
>                         lib libexec lisp localstate man man1 man2 man3
>                         man4 man5 man6 man7 man8 man9 oldinclude pdf
>                         pkgdatadir pkgincludedir pkglibdir pkglibexecdir
>                         ps sbin sharedstate sysconf));
> 
> That list is missing 'doc' and 'locale'.
>
If you are referring to this issue:
 <http://lists.gnu.org/archive/html/bug-gnulib/2010-12/msg00080.html>
then I don't think this automake bug (or limitation) is relevant.

The list in `%standard_prefix' is used only for diagnosing invalid
primary/directory combinations, such as `data_PROGRAMS' or
'lib_HEADERS'. For more info, see test `dirforbid.test', PR/294 at
<http://sources.redhat.com/cgi-bin/gnatsweb.pl?database=automake>,
and commit e87d851a863a7c321af8bc7b2b36aff5e072ff94 (05/03/2002).

That said, you might have uncovered a bug in automake, because
something like:
  doc_LIBRARIES = libfoo.a
should warn IMHO, but it currently doesn't.

Ralf, what do you think?  If you agree with me, I'll attempt a
patch (and a testsuite enhancement).

Regards,
   Stefano

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.