GNU bug report logs - #76464
30.1; Test failure in shr-test/zoom-image

Previous Next

Package: emacs;

Reported by: Ulrich Müller <ulm <at> gentoo.org>

Date: Fri, 21 Feb 2025 09:59:02 UTC

Severity: normal

Fixed in version 30.1

Done: Ulrich Müller <ulm <at> gentoo.org>

Bug is archived. No further changes may be made.

Full log


Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ulrich Müller <ulm <at> gentoo.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: 30.1; Test failure in shr-test/zoom-image
Date: Fri, 21 Feb 2025 11:36:06 +0100
[Message part 1 (text/plain, inline)]
It turns out that the bug also happens when Emacs is configured with the
--without-xml2 option, so the test must be skipped in that case too.

Updated patch attached.

[0001-Skip-shr-test-zoom-image-test-if-png-or-libxml-suppo.patch (text/plain, inline)]
From 7a12c2c2e54d2714d92f5823023480710b1384d5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm <at> gentoo.org>
Date: Fri, 21 Feb 2025 10:36:52 +0100
Subject: [PATCH] ; Skip shr-test/zoom-image test if png or libxml support is
 missing

* test/lisp/net/shr-tests.el (shr-test/zoom-image): Skip if png
images or libxml are not supported.  (Bug#76464)
---
 test/lisp/net/shr-tests.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/lisp/net/shr-tests.el b/test/lisp/net/shr-tests.el
index beb9bfe85a9..8d66684c96d 100644
--- a/test/lisp/net/shr-tests.el
+++ b/test/lisp/net/shr-tests.el
@@ -135,7 +135,9 @@ shr-srcset
 
 (ert-deftest shr-test/zoom-image ()
   "Test that `shr-zoom-image' properly replaces the original image."
-  (skip-unless (bound-and-true-p image-types))
+  (skip-unless (and (bound-and-true-p image-types)
+                    (image-type-available-p 'png)
+                    (fboundp 'libxml-parse-html-region)))
   (let* ((image (expand-file-name "data/image/blank-100x200.png"
                                   (getenv "EMACS_TEST_DIRECTORY")))
          (image-url (concat "file://" (if (string-prefix-p "/" image)
-- 
2.48.1


This bug report was last modified 168 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.