GNU bug report logs - #76463
[PATCH] gnu: Add aacircuit.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Evgeny Pisemsky <mail <at> pisemsky.site>
Subject: bug#76463: closed ([PATCH] gnu: Add aacircuit.)
Date: Sat, 22 Mar 2025 16:11:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#76463: [PATCH] gnu: Add aacircuit.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 76463 <at> debbugs.gnu.org.

-- 
76463: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76463
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 76463-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add aacircuit.
Date: Sat, 22 Mar 2025 16:10:32 +0000

[Message part 3 (text/plain, inline)]

Hi,

Pushed to master as fa0bbeaf6763540a8b5e1bf2ad58b8b4f0d1af18.

I've applied minor modifications, remove the need of python-flake8 and
addd commens on commit an use of Nose test runner: 
--8<---------------cut here---------------start------------->8---
@@ -177,6 +177,7 @@ (define-module (gnu packages engineering)
   #:use-module ((srfi srfi-1) #:hide (zip)))
 
 (define-public aacircuit
+  ;; No release in PyPI or version tag on Git, use the latest commit.
   (let ((commit "18635c846754b6219da1a2ceb8977714f70004d0")
         (revision "0"))
     (package
@@ -199,6 +200,8 @@ (define-public aacircuit
             (replace 'check
               (lambda* (#:key tests? #:allow-other-keys)
                 (when tests?
+                  ;; Delete develompent test file.
+                  (delete-file "tests/test_flake.py")
                   ;; Exclude tests intended for visual review.
                   (setenv "NOSE_EXCLUDE"
                           (string-join '("test_export_pdf"
@@ -206,24 +209,25 @@ (define-public aacircuit
                                        ","))
                   (setenv "HOME" "/tmp")
                   (invoke "xvfb-run" "./testrunner.sh")))))))
-      (native-inputs (list python-flake8
-                           python-nose
-                           python-setuptools
-                           python-wheel
-                           xvfb-run))
-      (propagated-inputs (list gtk+
-                               python-bresenham
-                               python-platformdirs
-                               python-pycairo
-                               python-pyclip
-                               python-pygobject
-                               python-pypubsub))
+      (native-inputs
+       ;; XXX: Test runner may be migrated to Pytest
+       ;; <https://docs.pytest.org/en/7.1.x/how-to/nose.html> after report to
+       ;; the upstream to modify them, use deprecated Nose test runner for
+       ;; now.
+       (list python-nose
+             python-setuptools
+             python-wheel
+             xvfb-run))
+      (propagated-inputs
+       (list gtkp+
+             python-bresenham
+             python-platformdirs
+             python-pycairo
+             python-pyclip
+             python-pygobject
+             python-pypubsub))
       (home-page "https://github.com/Blokkendoos/AACircuit")
       (synopsis "Draw electronic circuits with ASCII characters")
       (description
-       "This is a pythonized, kind of reverse engineered version of original AACircuit
-written by Andreas Weber in Borland Delphi.  The idea and GUI layout are also
-taken from the original.")
+       "This is a pythonized, kind of reverse engineered version of original
+AACircuit written by Andreas Weber in Borland Delphi.  The idea and GUI layout
+are also taken from the original.")
       (license license:gpl3+)))))
--8<---------------cut here---------------end--------------->8---

--
Oleg

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add aacircuit.
Date: Fri, 21 Feb 2025 12:12:07 +0300

* gnu/packages/engineering.scm (aacircuit): New variable.

Change-Id: I0f44b1037866c729fe1d29a52d9447f6cbea6704
---
 gnu/packages/engineering.scm | 50 ++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 234f4a2b03..40309f45f4 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -176,6 +176,56 @@ (define-module (gnu packages engineering)
   #:use-module (gnu packages xorg)
   #:use-module ((srfi srfi-1) #:hide (zip)))
 
+(define-public aacircuit
+  (let ((commit "18635c846754b6219da1a2ceb8977714f70004d0")
+        (revision "0"))
+    (package
+      (name "aacircuit")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/Blokkendoos/AACircuit")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "07agb7fbpbq74zm27j9b00imr46q6kpwhxzmmffw2s9scv80c1km"))))
+      (build-system pyproject-build-system)
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (replace 'check
+              (lambda* (#:key tests? #:allow-other-keys)
+                (when tests?
+                  ;; Exclude tests intended for visual review.
+                  (setenv "NOSE_EXCLUDE"
+                          (string-join '("test_export_pdf"
+                                         "test_import_aacircuit_export_pdf")
+                                       ","))
+                  (setenv "HOME" "/tmp")
+                  (invoke "xvfb-run" "./testrunner.sh")))))))
+      (native-inputs (list python-flake8
+                           python-nose
+                           python-setuptools
+                           python-wheel
+                           xvfb-run))
+      (propagated-inputs (list gtk+
+                               python-bresenham
+                               python-platformdirs
+                               python-pycairo
+                               python-pyclip
+                               python-pygobject
+                               python-pypubsub))
+      (home-page "https://github.com/Blokkendoos/AACircuit")
+      (synopsis "Draw electronic circuits with ASCII characters")
+      (description
+       "This is a pythonized, kind of reverse engineered version of original AACircuit
+written by Andreas Weber in Borland Delphi.  The idea and GUI layout are also
+taken from the original.")
+      (license license:gpl3+))))
+
 (define-public cutecom
   (package
     (name "cutecom")

base-commit: 38b4358f4d84cafa54deff77dee6fafac3e03864
-- 
2.48.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.