GNU bug report logs - #76461
31.0.50; CRM tries to insert candidate in prompt read-only zone

Previous Next

Full log

View this message in rfc822 format

From: Thierry Volpiatto <thievol <at> posteo.net>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: Thierry Volpiatto <thievol <at> posteo.net>, 76461 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: bug#76461: 31.0.50; CRM tries to insert candidate in prompt read-only zone
Date: Fri, 28 Feb 2025 05:54:28 +0000

[Message part 1 (text/plain, inline)]

Dmitry Gutov <dmitry <at> gutov.dev> writes:

> On 27/02/2025 20:33, Juri Linkov wrote:
>> Maybe Dmitry could confirm if this is the right fix
>> for completing-read-multiple recently fixed in
>> bug#48356 and bug#76010.
>
> It seems okay, thanks. Though it depends on the prompt always being a
> field, and the only field in the minibuffer. I don't know if that will
> hold for ever, but it seems to be the case currently.

Is it possible for a user to setup a minibuffer prompt with no properties at
all? Don't think so, but just asking.

> Here's a slightly different fix which seems to behave the same in the
> test scenario. I'm happy with whichever of the two you prefer.

Yours seems better, thanks.

> diff --git a/lisp/emacs-lisp/crm.el b/lisp/emacs-lisp/crm.el
> index 676252ae126..a75ccd46f50 100644
> --- a/lisp/emacs-lisp/crm.el
> +++ b/lisp/emacs-lisp/crm.el
> @@ -269,7 +269,9 @@ completing-read-multiple
>            (setq-local completion-list-insert-choice-function
>                        (lambda (_start _end choice)
>                          (let* ((beg (save-excursion
> -                                      (if (search-backward-regexp
>                                        crm-separator nil t)
> +                                      (if (search-backward-regexp
> crm-separator
> + (field-beginning)
> +                                                                  t)
>                                            (1+ (point))
>                                          (minibuffer-prompt-end))))
>                                 (end (save-excursion

-- 
Thierry

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.