From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 03:07:02 2025 Received: (at submit) by debbugs.gnu.org; 21 Feb 2025 08:07:02 +0000 Received: from localhost ([127.0.0.1]:52049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlO3p-00072U-6e for submit@debbugs.gnu.org; Fri, 21 Feb 2025 03:07:02 -0500 Received: from lists.gnu.org ([2001:470:142::17]:39972) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlO3m-00071e-D5 for submit@debbugs.gnu.org; Fri, 21 Feb 2025 03:06:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlO3h-0004Fr-1l for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2025 03:06:53 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlO3e-0005fH-BW for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2025 03:06:52 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 58A95240027 for ; Fri, 21 Feb 2025 09:06:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1740125207; bh=NQm35RFi6x8SFWt9BHtXQUh/5eFTlxhXKQgH98zgdtw=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=d8wa/3GOrCFzdX7cOO4vO8O+aLLIDdqCylb7gLYmwpZSqQ6jWAFbE1ejL9Eluo6aD +AQ/jMBIZMM69u6UIwbAAzX7phsFTBLF8hkJ3ZORt5IrN7PLO15UuZKHakt/hw02S9 nrNCEtqeZp6iduSMuSX7xejaEMu3WEA8tMgvjMAENv7dRuvGdwPc8Ksn2n7W9CR98R Fzr/0uvsWXYkhKsNNU3QIdNGkL08r/1nubgnDg2c/Ucx4CV+OEx4vgcXFzNM73Oh64 7dANlgveGzejGQnZvbUtbSV3wO4KCzlleT2lOo1VK8VP86gbaBT/fL4l+uIwAIXMH/ cyOieXBmmDovw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YzjQF4sBgz9rxP; Fri, 21 Feb 2025 09:06:45 +0100 (CET) From: Thierry Volpiatto To: bug-gnu-emacs@gnu.org Subject: 31.0.50; CRM tries to insert candidate in prompt read-only zone X-Debbugs-Cc: Date: Fri, 21 Feb 2025 08:13:47 +0000 Message-ID: <87bjuvemv8.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.65; envelope-from=thievol@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) When separator is ":" (org-insert-tags) the `completion-list-insert-choice-function` of `completing-read-multiple` set BEG at prompt end which is read-only and fails to insert completion candidate. This patch fixes it: --8<---------------cut here---------------start------------->8--- @@ -273 +273,3 @@ - (1+ (point)) + (if (field-at-pos (point)) + (progn (goto-char (field-end= )) (point)) + (1+ (point))) --8<---------------cut here---------------end--------------->8--- Note: To reproduce, switch to the completions buffer and hit RET on your choice. In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2025-02-19 built on IPad-S340 Repository revision: 9143c18ae4752cef8465579dcd713db2032ab045 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Linux Mint 21.3 Configured using: 'configure CFLAGS=3D-O8 --bindir=3D/usr/local/sbin/emacs-31.0.50 --with-cairo --with-modules --without-tree-sitter --without-native-compilation' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XINERAMA XINPUT2 XPM XRANDR GTK3 ZLIB Important settings: value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix Major mode: =EE=A4=A6 Minor modes in effect: mu4e-modeline-mode: t emms-mode-line-mode: t emms-playing-time-display-mode: t emms-playing-time-mode: t bug-reference-prog-mode: t server-mode: t psession-mode: t psession-savehist-mode: t global-git-gutter-mode: t git-gutter-mode: t display-time-mode: t winner-mode: t tv-save-place-mode: t helm-epa-mode: t helm-descbinds-mode: t helm-top-poll-mode: t helm-adaptive-mode: t helm-mode: t helm-minibuffer-history-mode: t helm-ff-icon-mode: t helm-popup-tip-mode: t dired-async-mode: t minibuffer-depth-indicate-mode: t gcmh-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t minibuffer-regexp-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow epa-mail face-remap mail-extr addressbook-bookmark tv-mu4e-config advice gnus-and-mu4e mu4e-patch mu4e-contrib eshell esh-cmd esh-ext esh-proc esh-opt esh-io esh-arg esh-module esh-module-loaddefs esh-util mu4e mu4e-org mu4e-notification notifications mu4e-main smtpmail mu4e-view mu4e-mime-parts mu4e-headers mu4e-thread mu4e-actions mu4e-compose mu4e-draft gnus-msg mu4e-search mu4e-lists mu4e-bookmarks mu4e-mark mu4e-message flow-fill hl-line mu4e-contacts mu4e-update mu4e-folders mu4e-context mu4e-query-items mu4e-server mu4e-modeline mu4e-vars mu4e-helpers mu4e-config mu4e-window ido mu4e-obsolete emacsbug whitespace helm-x-files helm-for-files helm-bookmark bookmark isl helm-ring helm-dabbrev smerge-mode diff view helm-command cl-indent helm-elisp helm-eval helm-info cl-print edebug debug backtrace emms-config emms-idapi-browser emms-idapi emms-idapi-musicbrainz emms-mpris emms-librefm-stream emms-librefm-scrobbler emms-playlist-limit emms-i18n emms-history emms-score emms-stream-info emms-metaplaylist-mode emms-bookmarks emms-cue emms-mode-line-icon emms-browser sort emms-volume emms-volume-sndioctl emms-volume-mixerctl emms-volume-pulse emms-volume-amixer emms-playlist-sort emms-last-played emms-player-xine emms-player-mpd tq emms-lyrics emms-url emms-streams emms-show-all emms-tag-editor emms-tag-tracktag emms-mark emms-mode-line emms-cache emms-info-native emms-info-native-spc emms-info-native-mp3 emms-info-native-ogg emms-info-native-opus emms-info-native-flac emms-info-native-vorbis bindat emms-info-exiftool emms-info-tinytag emms-info-metaflac emms-info-opusinfo emms-info-ogginfo emms-info-mp3info emms-playlist-mode emms-player-vlc emms-player-mpv emms-playing-time emms-info emms-later-do emms-player-mplayer emms-player-simple emms-source-playlist emms-source-file locate emms-setup emms emms-compat emms-auto helm-external helm-net org-agenda project ffap crm tramp-archive tramp-gvfs tramp-cache time-stamp zeroconf helm-ls-git vc-git diff-mode track-changes vc vc-dispatcher emacs-news-mode make-mode markdown-mode color flycheck org-indent oc-basic org-element org-persist org-id org-refile org-element-ast inline avl-tree generator ol-eww eww vtable mule-util url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ol-docview doc-view jka-compr ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi org-config ob-gnuplot org-crypt org-protocol org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src sh-script smie treesit executable ob-comint org-pcomplete org-list org-footnote org-faces org-entities noutline outline org-version ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func org-compat org-macs bug-reference thingatpt cus-start naquadah-theme solar cal-dst holidays holiday-loaddefs appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs server bm cl-extra imenu tv-utils psession frameset pcase git-gutter dired-extension time winner describe-variable help-fns radix-tree tv-save-place.el init-helm epa derived epg rfc6068 epg-config helm-epa helm-descbinds cus-edit pp wid-edit helm-sys helm-adaptive helm-mode helm-misc helm-files image-dired image-dired-tags image-dired-external image-dired-util image-mode exif filenotify tramp rx trampver tramp-integration files-x tramp-message help-mode tramp-compat shell pcomplete parse-time iso8601 time-date tramp-loaddefs helm-buffers helm-x-icons all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons helm-occur helm-tags helm-locate helm-grep wgrep-helm wgrep grep compile text-property-search comint ansi-osc ring helm-regexp format-spec ansi-color helm-utils helm-help helm-types helm-extensions-autoloads helm-autoloads helm helm-global-bindings helm-easymenu edmacro kmacro helm-core helm-source helm-multi-match helm-lib dired-async async dired-aux dired dired-loaddefs isl-autoloads mb-depth avoid cus-load gcmh easy-mmode all-the-icons-autoloads bash-completion-autoloads flycheck-autoloads info ledger-mode-autoloads markdown-mode-autoloads nerd-icons-autoloads w3m-load w3m-autoloads package browse-url xdg url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process tty-child-frames emacs) Memory information: ((conses 16 1055745 775395) (symbols 48 41701 15) (strings 32 256979 38916) (string-bytes 1 6881664) (vectors 16 87225) (vector-slots 8 1509021 806831) (floats 8 3572 1625) (intervals 56 85651 2991) (buffers 984 129)) <#secure method=3Dpgpmime mode=3Dsign> --=20 Thierry From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 00:29:13 2025 Received: (at 76461) by debbugs.gnu.org; 22 Feb 2025 05:29:13 +0000 Received: from localhost ([127.0.0.1]:43815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tli4e-0000nv-FK for submit@debbugs.gnu.org; Sat, 22 Feb 2025 00:29:13 -0500 Received: from mout02.posteo.de ([185.67.36.66]:37701) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tli4b-0000mj-Ji for 76461@debbugs.gnu.org; Sat, 22 Feb 2025 00:29:10 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5783A240101 for <76461@debbugs.gnu.org>; Sat, 22 Feb 2025 06:29:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1740202141; bh=50h1bhsjuNR6tnW3gQiNlbfxqtksq9dWDgh5gmIEv8o=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=TjB3MEJQjo2wy6B8KTRzuX1M+hkN0XjkG7crsnS+nh27kdHXhcAhngT48iOyS+g8J xmlKSgPVlkNbQiSv6zmfkP4foYWI4OIqnYlQONjYJ5TVZQDKUgxsLH3pjYrn4MDa9Y lnkrvHulOYNQ98Dh06hg+xhYpo4o5HNhEmr5blxEvfCd9EzM5lsWkgy9tpk9IUysfo yQRKSo1Zoh+dptWf74tYzbaWvvSNX7QindWYdfMcw/zGQv7H9HD2CmF0ZVWc5hH3RQ 91QGcQJEMrb7VUNJgjuoPif7PQyrw5Y8hE/G6ogF4q8/NAkJq8/PsAieiqqu1Ekmkr uV6vd2ILft22w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z0Fsl6J31z6tx0; Sat, 22 Feb 2025 06:28:59 +0100 (CET) From: Thierry Volpiatto To: 76461@debbugs.gnu.org Subject: bug#76461: 31.0.50; CRM tries to insert candidate in prompt read-only zone Date: Sat, 22 Feb 2025 05:36:02 +0000 Message-ID: <87zfiev8vx.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76461 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Find the patch attached. =2D-=20 Thierry --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-insertion-of-completion-candidate-in-minibuffer-.patch Content-Transfer-Encoding: quoted-printable From=20fd1606f8048200b954cf112e7da33a7db3d23d64 Mon Sep 17 00:00:00 2001 From: Thierry Volpiatto Date: Sat, 22 Feb 2025 06:23:25 +0100 Subject: [PATCH] Fix insertion of completion candidate in minibuffer with C= RM Fix bug#76461. When separator is ":" like in org tags, insertion fails because the completion-list-insert-choice-function matches the end of prompt which is ":" and set BEG at this place which is read-only. Set BEG outside of the prompt field when it is the case. =2D-- lisp/emacs-lisp/crm.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/crm.el b/lisp/emacs-lisp/crm.el index 676252ae126..60334035a3d 100644 =2D-- a/lisp/emacs-lisp/crm.el +++ b/lisp/emacs-lisp/crm.el @@ -270,7 +270,8 @@ with empty strings removed." (lambda (_start _end choice) (let* ((beg (save-excursion (if (search-backward-regexp crm-sepa= rator nil t) =2D (1+ (point)) + (if (field-at-pos (point)) + (field-end) (1+ (point))) (minibuffer-prompt-end)))) (end (save-excursion (if (search-forward-regexp crm-separ= ator nil t) =2D-=20 2.34.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAme5YkMTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvkyzyDACT2pKsnatX2FpPBZqZZJO95RiYRft1 Mn29TPvdLRmkBPVgTO7+EPjahuLot2YRZanwD8+J3YORp/XIfYyInuaUX3TFIxuD R5G0PkqeNY6OZDT49OUBYR00uGkfnGbmAcuHOW3syDMPE7O/vSHK5m5CH7SWqfye k6Sc6IloW3NAhajwpCcPaQ5vt98Wd71WGDsBM0gRRwkcqmrRyrTjBwBEYmHdBwld iBVb/sJI/rTFY0r/AG5HC2C2b/mSzpWvlLBQKUlh9BsNf092tKzhRhZO2UGmN6ga d1QfOG1JzRmorRGrd/cgsruBSkT9KmDnOzXFFNcB1ftlRxRTUBxZ+kuwu8/PORKc 4ZUqQ+xu47dWb6IOthIFg7FcEG0ORcZ7ee571YQbOLqFuNslEt2Pf7fPSW4S2/kj o/WVrWxLKkYpwMxxE5U47m0uG4eDeXODNkytB+W7psqkNf8dicizPJfXwZGsokT8 EZO5/ZEhJQmtaKmAoCJ1pDKyXMBShwTdfYc= =LOfy -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 25 00:45:15 2025 Received: (at 76461) by debbugs.gnu.org; 25 Feb 2025 05:45:16 +0000 Received: from localhost ([127.0.0.1]:44339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tmnkp-0002zW-I9 for submit@debbugs.gnu.org; Tue, 25 Feb 2025 00:45:15 -0500 Received: from mout02.posteo.de ([185.67.36.66]:50525) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tmnkm-0002RB-Vv for 76461@debbugs.gnu.org; Tue, 25 Feb 2025 00:45:14 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 466A1240101 for <76461@debbugs.gnu.org>; Tue, 25 Feb 2025 06:45:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1740462305; bh=Gxjj+0kadjPi2b8wc91BXXAd3v+VCcL/bxRmodPkhMw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=kwH1ZNkdsK2WKfa1igr5NtWEV3mDMz9vULvPV4mkMUEvzUo6FDa0MrTXUMg4RP5lZ cLifm72FEeJkwgiLksLZYNHcL6p0oqh9HpdPUYMRHCyr4Wj8yIGqe/B7CCBxQCPlJ7 mdqQX+eako6NjJo7cDf1g6wlnidJGszSGYxr02ZClIGRlcfHTYSxcsrZ2j3I3eKnMO JFNfrqCIx06Aih9o0j58fLk23/p+ts9s1lVVKvPYZB7JLCSb3mPICX2vByeU+cCWcA GGXWHgBG/VTeJLuQUJ8AZJEqSlHhChzJTcjBvrFMsZQJ/PiBeKyDjLA2l4sEkmekPT 8rBmgWbkmutvQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z264w0vHgz6txx; Tue, 25 Feb 2025 06:45:04 +0100 (CET) From: Thierry Volpiatto To: Thierry Volpiatto Subject: Re: bug#76461: 31.0.50; CRM tries to insert candidate in prompt read-only zone In-Reply-To: <87zfiev8vx.fsf@posteo.net> (Thierry Volpiatto's message of "Sat, 22 Feb 2025 05:36:02 +0000") References: <87zfiev8vx.fsf@posteo.net> Date: Tue, 25 Feb 2025 05:52:12 +0000 Message-ID: <875xkyk1v7.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76461 Cc: 76461@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Thierry Volpiatto writes: This bug happens as well on 30.1, I am closing bug#76520 (useless duplicate). I modified the patch (only commit message) =2D-=20 Thierry --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-insertion-of-completion-candidate-in-minibuffer-.patch Content-Transfer-Encoding: quoted-printable From=2066fc07814133b510442ce6cd1ec31cf3e4d6fd68 Mon Sep 17 00:00:00 2001 From: Thierry Volpiatto Date: Sat, 22 Feb 2025 06:23:25 +0100 Subject: [PATCH] Fix insertion of completion candidate in minibuffer with C= RM Fix bug#76461. * lisp/emacs-lisp/crm.el (completing-read-multiple): Fix it. When separator is ":" like in org tags, insertion fails because the completion-list-insert-choice-function matches the end of prompt which is ":" and set BEG at this place which is read-only. Set BEG outside of the prompt field when it is the case. =2D-- lisp/emacs-lisp/crm.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/crm.el b/lisp/emacs-lisp/crm.el index 676252ae126..60334035a3d 100644 =2D-- a/lisp/emacs-lisp/crm.el +++ b/lisp/emacs-lisp/crm.el @@ -270,7 +270,8 @@ with empty strings removed." (lambda (_start _end choice) (let* ((beg (save-excursion (if (search-backward-regexp crm-sepa= rator nil t) =2D (1+ (point)) + (if (field-at-pos (point)) + (field-end) (1+ (point))) (minibuffer-prompt-end)))) (end (save-excursion (if (search-forward-regexp crm-separ= ator nil t) =2D-=20 2.34.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAme9WowTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvkwbpDACuvRG/j+blBJHwDt2Hqo8jJtGaSUNP 1MJR5EK0iT59VZMidctH7IBfDSANjHbNQ0J+GZ+JW7ll9vsQKcnV9zC9KSciRepM Q/tKuh6WGXepl05inWpEaav7Qj2xu0AUKWpwB6R2OIbrYIcBGGEQ+QPmtRMBxgEi 3QOXhO2+331Cg0z1VUG+zl9pIA+ExjtfqdFArg/t8tU5C0axaCeq7o8uEbqdOYQk E3U8M0C2wWLhDE8ak0fqaaMCGM7SW5lE55tPz37BDpU2LpOQi0xpla+0QpkXfX/i CInZ3BV+axd11+Wf3u295z9nD4DeSNpIa4UG3YbL9DCb3GU253WNXO8S6E+WlBoY 6d+uEYKJOIyLd7JFNoCINdJVAq19a4qtUZ3VS1/jkSHKMqL4fHe3eWSNOcotJVNq D8SGMLQxsyTm+EdF27f9keqZxRb9Y3Nv7NRZm29aSe+CSOv9A6AIT4TG4s/dPNFD XIDdEx9GGTAKwPJFsUG+1LDXD6aZDUSvhSI= =kLhw -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 25 01:30:07 2025 Received: (at 76461) by debbugs.gnu.org; 25 Feb 2025 06:30:07 +0000 Received: from localhost ([127.0.0.1]:44426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tmoSE-0007Zm-RD for submit@debbugs.gnu.org; Tue, 25 Feb 2025 01:30:07 -0500 Received: from mout02.posteo.de ([185.67.36.66]:47271) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tmoSB-0007YS-E1 for 76461@debbugs.gnu.org; Tue, 25 Feb 2025 01:30:04 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 88B71240101 for <76461@debbugs.gnu.org>; Tue, 25 Feb 2025 07:29:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1740464995; bh=+skOFVIKg5frGW0hq1TC4pd4lP/+s15DfhOPOhiPntU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=NinNMO85IA+Pmk/EmS3utCF94fJPNrHo8J1ZOK04NysTCsRylSF3DWsrtd0k+bv3/ GLM+J1OMNvYlpHfX+CNwhgdb93iS742qzsF/plm4XY2Nh98sckCTsO+1U9teT1IREs sQD8x7LamGElg56tbyv2Q+iye1FY0YEr+bXbYbjw3Lr4rLj5B+6+MMDsCqlsqyRQqM 3sOUTAiRnl74VW68ndGSv3EwHuFYVxbkPfm0It2Ag1Udfd7PCztpaCH+hVRUincxj9 9+eAOvFghhPRULEwsNijhfC+cnb0fP4VkgS7PAjDbxwkvui2AG3wo9P/t4TTXcZyGa +wbPY8ooYgAWw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z274f4M4fz6tyw; Tue, 25 Feb 2025 07:29:54 +0100 (CET) From: Thierry Volpiatto To: Thierry Volpiatto Subject: Re: bug#76461: 31.0.50; CRM tries to insert candidate in prompt read-only zone In-Reply-To: <875xkyk1v7.fsf@posteo.net> (Thierry Volpiatto's message of "Tue, 25 Feb 2025 06:52:12 +0100") References: <87zfiev8vx.fsf@posteo.net> <875xkyk1v7.fsf@posteo.net> Date: Tue, 25 Feb 2025 06:37:03 +0000 Message-ID: <87tt8iil80.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76461 Cc: 76461@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Thierry Volpiatto writes: > Thierry Volpiatto writes: > > This bug happens as well on 30.1, I am closing bug#76520 (useless > duplicate). > I modified the patch (only commit message) Seems it is cleaner to write it like this: =2D-8<---------------cut here---------------start------------->8--- (if (and (re-search-backward crm-separator nil t) ;; Matches end of prompt (:) when sep is ":". (not (field-at-pos (point)))) (1+ (point)) (minibuffer-prompt-end)) =2D-8<---------------cut here---------------end--------------->8--- Have a look. Here a test to reproduce: =2D-8<---------------cut here---------------start------------->8--- (defun crm-init-test-environ () "Set up some variables for testing." (interactive) (setq my-prompt "Prompt: ") (setq my-table '(("hi") ("there") ("man") ("may") ("mouth") ("ma") ("a") ("ab") ("abc") ("abd") ("abf") ("zab") ("acb") ("da") ("dab") ("dabc") ("dabd") ("dabf") ("dzab") ("dacb") ("fda") ("fdab") ("fdabc") ("fdabd") ("fdabf") ("fdzab") ("fd= acb") ("gda") ("gdab") ("gdabc") ("gdabd") ("gdabf") ("gdzab") ("gd= acb")))) (crm-init-test-environ) (let ((crm-separator "[ \t]*:[ \t]*"))=20 (completing-read-multiple my-prompt my-table)) =2D-8<---------------cut here---------------end--------------->8--- =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAme9ZQ8THHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk8YDDAC00uOrWuD5hyPNvahp31jYY+yeLxq9 HrhKmVid1YnizHGK9dmBKGmY1w/tAPXSqIyhBJtZHQay2wQmqVYgUj0U9ZiYivUP O2CSJyaDsqJoHBMe+mxzlt/SEvlrcF8eiPCB1psPQbwyH5MKAZ/nAqVVbkiH9sMs ubX/nlbvgG2L8QmEUMxm4/Hk0Sy11YLwQuYeuvaKYgZ2SNKeH1ykpO+yjZ6iYL8G 6/X7KY5jZmZ8CUUI+fQi+hjcTQ5PqSFCkPzYkxbJepCvnXdAaDmnywdHAabfIC7i xEzlCoPjzD6rdMIY0mDQfrNZAWEFfO6C/AnDUylSvnF9ndG88mM7S+9EK0HCG+RG +w1LIy3CZkhufI1n/8ALwE87OzXsQbWg2WIQC2vbUXu0HGskk1VawRIzuovuRLMe Lt0tmg10qt5twUBSeX+LxJ5qS/nIKFvsuAIc+LJXpGNXfXcBGQpcVhlW+Zq/zqbi TSnQWi6x74PEZvXCj0A9qfIT03cH72G1INU= =ppYR -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 25 18:35:38 2025 Received: (at control) by debbugs.gnu.org; 25 Feb 2025 23:35:38 +0000 Received: from localhost ([127.0.0.1]:49079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tn4Sf-0004Wl-LH for submit@debbugs.gnu.org; Tue, 25 Feb 2025 18:35:38 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:49263) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tn4SX-0004W5-3b for control@debbugs.gnu.org; Tue, 25 Feb 2025 18:35:29 -0500 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5deb1266031so11371941a12.2 for ; Tue, 25 Feb 2025 15:35:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740526523; x=1741131323; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=Y4jTcClxDE8MiKNssL3b7o53cCe7PrEJQkkZWsRXZ4c=; b=YxKzLSslfUsfuEsM5oMK51t15m9i9fXrwVh3/rESPknqk7O/esRjTrOa2irywFgkDf 1bi2J9tbDDdSgMYRSlkXxsLLXB4oQpBpjCc5aKRCMlstFww0r/SHqB03RzjxqmwKrdzJ tvrOXvI/TvWXCBa4KJOsuUzD6tg6rfBgNAMRoXG3XFIozPt3Rl0MnoAJkPetoDAjg9lK KrhBHQUDTtgzpN33Uc547HGNIpi2ZUn9DyF7tZSuT7Q+6s3dI3QoKem0zF2J/NMU4hD/ RifPaIUPWsovnFk3j/+xtsmkMb0N+PjKdzA2KZkIswVEBLTWHu3c2mMyiM93uxeYuZ+L vRrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740526523; x=1741131323; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Y4jTcClxDE8MiKNssL3b7o53cCe7PrEJQkkZWsRXZ4c=; b=U4ztd0cIuSMD5YfkA/kf9uE4uAadpc8xAnD2oHFgJDjwcTK+PIGKXa3IqLF0hVsC5F +dsWJi2g0uH8AvzGOWyCb83Qu7pY5HOnWDgAzrxCXFXDAhJSWe57shN3+crnO/GF5/qZ +MoEoWanTszTaLvHdC+qC6L5j1uI+GpeLYQwisWXNMGpgtP3p1QLVBiaFo5//0ED8BKt Gvo604CzQwjGws9WVfimGXowDODPRkDTJaSqmPfCGFqFxhsQgBB+ks2W6wS0n3rLxKbi lmMx2WBrUYa0pTmPF/3kYmFGcf71gJHQPXDutxgcxVtDAC6zcH0AGEcUPxunHpXYOtc8 W17A== X-Gm-Message-State: AOJu0YxYK68F9TNDAFXuDoWgQ+EyGOOCc6gBoQ6Eo36RZezBUn6xFznA d92AMswvL1We9o0pCRa3caM7TgJghqb8nD10HNbAHQULymQqZrdqPaDt83/XqNsINfF4Gkc7ANf skf/KSxR572zKJ6jzFNwXndrxv/r308+Sv1g= X-Gm-Gg: ASbGncuXjh86eHiNFWxWaKKvOpaZxKiPvO1SL9L287N8ELboMNbRlDKpnL+0KMoGYlj lRWDYJFBNgCDJ7rlODwrILM/LMfIloqTgBfQMGS1N0L37ej8Uhd5axgQLVMTanUy4a8qek0QR0B 76KhXRAOFBRFm3kcQ7Hb0Tx26JCQ== X-Google-Smtp-Source: AGHT+IEQ5g2ofsPvEMgiUOcLRSA59uYiHhLH+11rGUSwG2x0roukicvAe1Q8zvqo6FcN5CnbsC4PQf/XAOgFOXAjLRQ= X-Received: by 2002:a05:6402:440b:b0:5e0:52df:d569 with SMTP id 4fb4d7f45d1cf-5e0b7252db5mr21546005a12.28.1740526522750; Tue, 25 Feb 2025 15:35:22 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 25 Feb 2025 23:35:22 +0000 From: Stefan Kangas MIME-Version: 1.0 Date: Tue, 25 Feb 2025 23:35:22 +0000 X-Gm-Features: AQ5f1Jo73PBBmwAq1PHj81Oz1MlotE-5cp0RmS-TLeL70ZV3TMc5a-2ICbiFSu4 Message-ID: Subject: control message for bug #76461 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 76461 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 27 13:35:05 2025 Received: (at 76461) by debbugs.gnu.org; 27 Feb 2025 18:35:05 +0000 Received: from localhost ([127.0.0.1]:37704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tniiu-0004Wm-Ot for submit@debbugs.gnu.org; Thu, 27 Feb 2025 13:35:05 -0500 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:57663) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tniir-0004VJ-M8 for 76461@debbugs.gnu.org; Thu, 27 Feb 2025 13:35:02 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 5CFA42057A; Thu, 27 Feb 2025 18:34:51 +0000 (UTC) From: Juri Linkov To: Thierry Volpiatto Subject: Re: bug#76461: 31.0.50; CRM tries to insert candidate in prompt read-only zone In-Reply-To: <87tt8iil80.fsf@posteo.net> Organization: LINKOV.NET References: <87zfiev8vx.fsf@posteo.net> <875xkyk1v7.fsf@posteo.net> <87tt8iil80.fsf@posteo.net> Date: Thu, 27 Feb 2025 20:33:53 +0200 Message-ID: <87bjuntey6.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekkedulecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepffegteefveelhfeljeefueehieduiedtfffhuddtkeeffffghfevheetgeeukeehnecukfhppeeluddruddvledruddthedruddujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeluddruddvledruddthedruddujedphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepjeeigeeiudesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegumhhithhrhiesghhuthhovhdruggvvhdprhgtphhtthhopehthhhivghvohhlsehpohhsthgvohdrnhgvth X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76461 Cc: Dmitry Gutov , 76461@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> This bug happens as well on 30.1, I am closing bug#76520 (useless >> duplicate). >> I modified the patch (only commit message) > > Seems it is cleaner to write it like this: > > (if (and (re-search-backward crm-separator nil t) > ;; Matches end of prompt (:) when sep is ":". > (not (field-at-pos (point)))) > (1+ (point)) > (minibuffer-prompt-end)) > > Have a look. Maybe Dmitry could confirm if this is the right fix for completing-read-multiple recently fixed in bug#48356 and bug#76010. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 27 20:46:31 2025 Received: (at 76461) by debbugs.gnu.org; 28 Feb 2025 01:46:31 +0000 Received: from localhost ([127.0.0.1]:41194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tnpSQ-0007dz-Jb for submit@debbugs.gnu.org; Thu, 27 Feb 2025 20:46:31 -0500 Received: from fhigh-b3-smtp.messagingengine.com ([202.12.124.154]:58107) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tnpSM-0007cr-LA for 76461@debbugs.gnu.org; Thu, 27 Feb 2025 20:46:27 -0500 Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id 88B3125400B1; Thu, 27 Feb 2025 20:46:20 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Thu, 27 Feb 2025 20:46:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1740707180; x=1740793580; bh=nE+2dfqpoHZ/58hPOnuRIuBB4GkJ7gPtp1Yal/BPlmM=; b= bPT24xA0xcIgn9crTS3/tQtwAZTH/uv02zL5AMUwwoQ6zFJFV/w2OQ51PzQM+ClQ +a0A8AX30MMpcKZr4qihx1mz1AF55OrnqauHReUlVhgmXG7ZoJCa+HmvYntHsEj1 jIhP2mcaZ/Pr9gWDtWwK4eHfK5kKq7Tiu6GNFKTXWQYKZzOL5jcM9CazGLqxo5Z+ n3AKAD1ZoiLo6jNxPeiPSa+t8SiCL/fp6i0UDVvU6zTxOrbiJfnKFce7LVZ5qrJA HMl3oQKMSiR4cyhp+nki4PV8qZ/IYXuv7Fpjs/6+AqAvWJxTHEc+BV4EdNONc+BF 131VGj4kEo2Qpsk1OBYzfA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1740707180; x= 1740793580; bh=nE+2dfqpoHZ/58hPOnuRIuBB4GkJ7gPtp1Yal/BPlmM=; b=C ol5mVJW4SlxO7z+b/0/iD25eGzOaCtSTLFgyXoinWHo6PcI94liOCaIfOWev6uqc yfD7JyQCSGwQ573zuu1gf8xmBeB1UmPtuPEbgbcqkiDkmUWFALAXWVZo2qkJFUJU 0T6Wrzs01H5npPrRNbjzwma3MaLoy1kDmiA9RhqfRSiesP1tte801po/xeVxZFEc nuWU4J10kIXF7d1GT9ooHsdfkZlTGQV1JlXB+3+bHWbGXdy9f6IvKwlFwWzE6meM lVauIn1rUhIN7E8Q8k1YUJ9a5JD6BhficcpZOKoXcEJrTW/yovhlaNMBKG0aC6xg 8cVec7suCFfu/2gMKuJAw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekledtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddv jeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrd guvghvqeenucggtffrrghtthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeu fedtvddtveefhfdvveegudejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthht ohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepjhhurhhisehlihhnkhhovh drnhgvthdprhgtphhtthhopehthhhivghvohhlsehpohhsthgvohdrnhgvthdprhgtphht thhopeejieegieduseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 Feb 2025 20:46:17 -0500 (EST) Message-ID: <021236d8-b569-4091-b64f-8cef6c9e3a61@gutov.dev> Date: Fri, 28 Feb 2025 03:46:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#76461: 31.0.50; CRM tries to insert candidate in prompt read-only zone To: Juri Linkov , Thierry Volpiatto References: <87zfiev8vx.fsf@posteo.net> <875xkyk1v7.fsf@posteo.net> <87tt8iil80.fsf@posteo.net> <87bjuntey6.fsf@mail.linkov.net> Content-Language: en-US From: Dmitry Gutov In-Reply-To: <87bjuntey6.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76461 Cc: 76461@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 27/02/2025 20:33, Juri Linkov wrote: > Maybe Dmitry could confirm if this is the right fix > for completing-read-multiple recently fixed in > bug#48356 and bug#76010. It seems okay, thanks. Though it depends on the prompt always being a field, and the only field in the minibuffer. I don't know if that will hold for ever, but it seems to be the case currently. Here's a slightly different fix which seems to behave the same in the test scenario. I'm happy with whichever of the two you prefer. diff --git a/lisp/emacs-lisp/crm.el b/lisp/emacs-lisp/crm.el index 676252ae126..a75ccd46f50 100644 --- a/lisp/emacs-lisp/crm.el +++ b/lisp/emacs-lisp/crm.el @@ -269,7 +269,9 @@ completing-read-multiple (setq-local completion-list-insert-choice-function (lambda (_start _end choice) (let* ((beg (save-excursion - (if (search-backward-regexp crm-separator nil t) + (if (search-backward-regexp crm-separator + (field-beginning) + t) (1+ (point)) (minibuffer-prompt-end)))) (end (save-excursion From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 28 00:47:35 2025 Received: (at 76461) by debbugs.gnu.org; 28 Feb 2025 05:47:36 +0000 Received: from localhost ([127.0.0.1]:43408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tntDh-0006qC-W9 for submit@debbugs.gnu.org; Fri, 28 Feb 2025 00:47:35 -0500 Received: from mout02.posteo.de ([185.67.36.66]:39205) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tntDd-0006pA-9K for 76461@debbugs.gnu.org; Fri, 28 Feb 2025 00:47:31 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 16C32240101 for <76461@debbugs.gnu.org>; Fri, 28 Feb 2025 06:47:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1740721642; bh=igHTpf+YD7M0tl8SDrec/ZjZfxd/pphyBTeQDXjYaeA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=ckKm5KkQHnaCGUmfH3d48JiZIZHp7JI7W+3iOtyMhgb/1poJHX4SmLcmLMNkgIzF8 64Tw7N6XqaeuCQsmkbzG8nZ6Y2mUt1XpRYEZiCmOGrbGpPrhPfPqbOSN845QMR8mL2 9AdVGNypWFGa3TAXpxkmlDAQI/yutjV6GeRsNrFr7RUeQ01/71etsoPGISvciRp4fI dOrSWh2e83M/xYlXWNq75Gk0op78eNQAd6nCg8RZNpQJQpQLiNo5uW0+MHLDiJP/eB qB3cJ6JZXVozQ1shrZPYJQQ15zubhFKne1+R11CSJjMdvX7WEGdpRfgMz+gbXh3y+n F0AvdZV46kuRA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z3y075f1Xz9rxF; Fri, 28 Feb 2025 06:47:19 +0100 (CET) From: Thierry Volpiatto To: Dmitry Gutov Subject: Re: bug#76461: 31.0.50; CRM tries to insert candidate in prompt read-only zone In-Reply-To: <021236d8-b569-4091-b64f-8cef6c9e3a61@gutov.dev> (Dmitry Gutov's message of "Fri, 28 Feb 2025 03:46:15 +0200") References: <87zfiev8vx.fsf@posteo.net> <875xkyk1v7.fsf@posteo.net> <87tt8iil80.fsf@posteo.net> <87bjuntey6.fsf@mail.linkov.net> <021236d8-b569-4091-b64f-8cef6c9e3a61@gutov.dev> Date: Fri, 28 Feb 2025 05:54:28 +0000 Message-ID: <87ldtqfwbv.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: 76461 Cc: Thierry Volpiatto , 76461@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Dmitry Gutov writes: > On 27/02/2025 20:33, Juri Linkov wrote: >> Maybe Dmitry could confirm if this is the right fix >> for completing-read-multiple recently fixed in >> bug#48356 and bug#76010. > > It seems okay, thanks. Though it depends on the prompt always being a > field, and the only field in the minibuffer. I don't know if that will > hold for ever, but it seems to be the case currently. Is it possible for a user to setup a minibuffer prompt with no properties at all? Don't think so, but just asking. > Here's a slightly different fix which seems to behave the same in the > test scenario. I'm happy with whichever of the two you prefer. Yours seems better, thanks. > diff --git a/lisp/emacs-lisp/crm.el b/lisp/emacs-lisp/crm.el > index 676252ae126..a75ccd46f50 100644 > --- a/lisp/emacs-lisp/crm.el > +++ b/lisp/emacs-lisp/crm.el > @@ -269,7 +269,9 @@ completing-read-multiple > (setq-local completion-list-insert-choice-function > (lambda (_start _end choice) > (let* ((beg (save-excursion > - (if (search-backward-regexp > crm-separator nil t) > + (if (search-backward-regexp > crm-separator > + (field-beginning) > + t) > (1+ (point)) > (minibuffer-prompt-end)))) > (end (save-excursion =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmfBT5UTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk2kFC/wNnhyPLBJmsMQ6ZJYQVD/uXPMu7yS2 rLkoY8hOVV7EWT17Xl8j4WrbW1+x8BDpGlXfZ6PXvGT/5NPodH+0x18D9NKVXmup 78oAVVxXk7CKs5uLbu+w2YKJqgAPxp/H/tvNLM0+ttAmz1yrGGKsU4rXbYoQh+bJ AlFKSyptD9xJsNQSjG/jjFJri44D6MaH2K7fCSFggiocK50qCCoxqltKBF/aiaIR SCGxrYWMZivrMFqIx5wc+5c74JuvxWy0wCRcZlodEBmaB4pHYhN2KbZ72WoTXKO3 PHB3OnaGJhR3T7lYwbZirVFgepAzX43LGpkbOEojTYejljUutpzPXoTeSJZS2Pwc dz5Weg8vBluKh7fp6ijaRcFupotxw1Uy1luUZ1WOqyz1mJI3wJbGJk1KHxQJbHw5 SgET5tHpG641A9Zw/kE+eRQYDNAlbqe3K9a1kYI2vlpUeVleJs6chvvvEst/tahD EZ5lFrcVxuh7/UPtXZig1OHpOuEUVMMdQx8= =5r7d -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 01 22:15:07 2025 Received: (at 76461-done) by debbugs.gnu.org; 2 Mar 2025 03:15:07 +0000 Received: from localhost ([127.0.0.1]:48846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1toZnG-00011p-N8 for submit@debbugs.gnu.org; Sat, 01 Mar 2025 22:15:07 -0500 Received: from fout-b2-smtp.messagingengine.com ([202.12.124.145]:34265) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1toZnD-00010J-6l for 76461-done@debbugs.gnu.org; Sat, 01 Mar 2025 22:15:04 -0500 Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id 54D3C11400FA; Sat, 1 Mar 2025 22:14:57 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Sat, 01 Mar 2025 22:14:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1740885297; x=1740971697; bh=b5mqiWrW6bZbbPn1d2a1vGe0me8K8GrKYBlGuZMg15Q=; b= oZON3qUjBh/Eh2CIdWpIOfdVMo8z21V2LTpm6jgzJmnsk1l3a+/NwdFYWD0Wm0h5 tWyYP89w6hFosra69MiHmiK4v2den53b7K2yB5PLLYbZClVtCaWYzZbZzIt0+4mO tTJX+P/GCMYVDK9FyG/4N5RyaI2M+NiH+MxYh+9dNlUPV85vJCm5whZ4Y3ta7AFA dbL+errwgutLgColMjF2ghkS70OFdmYhy980L9zuU/9fh2Jr3zt/Ezz/0DVkSHKh lETWt3VN3MLwHTwLHOXfQQLqJ9oR16MZL969EIrh02pGGQ7Lowb9XX0Oo0fjbZ6F NMM7QMq8eq4cGkgJotMXeQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1740885297; x= 1740971697; bh=b5mqiWrW6bZbbPn1d2a1vGe0me8K8GrKYBlGuZMg15Q=; b=l zxQuqFb6p7y9lryzGkShC1djPYRrC70ZU6vNZQqQee9eJ646Qcakt6vtj2KFVLLn il1bM8PBvIg+bfhNngJLRq5Gg9H5xdFAhXO5cFnZyD3Ig0AZslod7mcx5atBD04L 3+S6h/dfsRe07ho+NdStmqemjn5bNXLFdDfhgsPayCaI8w5hhw7mnVullb5wZVpd 2aB6X7qsMN7wCfz+EDWEfyB59HXdc5f5pqFJf1kLgGkbzG0gu/SdWV7LQdRzTo7z Voy6X+J2qbEVpXE5M04Pc4CJ4nC9OwvKw0OZkUguBsmH7hrtI702CRSXE6PbZQb2 FK08YWndGkhCtaG2ZLLiA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdelheduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddv jeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrd guvghvqeenucggtffrrghtthgvrhhnpeffieefvdelueektdfgleeigedugfevkeefjeev jeffteffueeuueeghfevieduvdenucffohhmrghinhepghhnuhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhu thhovhdruggvvhdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtg hpthhtohepthhhihgvvhholhesphhoshhtvghordhnvghtpdhrtghpthhtohepjhhurhhi sehlihhnkhhovhdrnhgvthdprhgtphhtthhopeejieegieduqdguohhnvgesuggvsggsuh hgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 1 Mar 2025 22:14:55 -0500 (EST) Message-ID: <600ed443-bdf7-44b2-b371-b4b88bf35b8a@gutov.dev> Date: Sun, 2 Mar 2025 05:14:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#76461: 31.0.50; CRM tries to insert candidate in prompt read-only zone To: Thierry Volpiatto References: <87zfiev8vx.fsf@posteo.net> <875xkyk1v7.fsf@posteo.net> <87tt8iil80.fsf@posteo.net> <87bjuntey6.fsf@mail.linkov.net> <021236d8-b569-4091-b64f-8cef6c9e3a61@gutov.dev> <87ldtqfwbv.fsf@posteo.net> Content-Language: en-US From: Dmitry Gutov In-Reply-To: <87ldtqfwbv.fsf@posteo.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76461-done Cc: 76461-done@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 30.2 On 28/02/2025 07:54, Thierry Volpiatto wrote: > Dmitry Gutov writes: > >> On 27/02/2025 20:33, Juri Linkov wrote: >>> Maybe Dmitry could confirm if this is the right fix >>> for completing-read-multiple recently fixed in >>> bug#48356 and bug#76010. >> >> It seems okay, thanks. Though it depends on the prompt always being a >> field, and the only field in the minibuffer. I don't know if that will >> hold for ever, but it seems to be the case currently. > > Is it possible for a user to setup a minibuffer prompt with no properties at > all? Don't think so, but just asking. Probably not in CRM, since here we control how the minibuffer is setup, but ultimately we have hooks there as well, so a determined enough user could break it, of course. >> Here's a slightly different fix which seems to behave the same in the >> test scenario. I'm happy with whichever of the two you prefer. > > Yours seems better, thanks. Pushed to the emacs-30 branch, thank you for testing. https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-30&id=8091772767666f2c671a8ba481d50859388152db From unknown Sat Sep 06 02:32:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 30 Mar 2025 11:24:30 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator