GNU bug report logs - #76446
[Patch Debbugs] Infrastructure Improvements

Previous Next

Full log

Message #46 received at 76446 <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <morgan.j.smith <at> outlook.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76446 <at> debbugs.gnu.org
Subject: Re: bug#76446: [PATCH v2 1/5] tests: Move helper and wrapper
 functions into their own file
Date: Sun, 23 Feb 2025 14:05:17 -0500

[Message part 1 (text/plain, inline)]

Michael Albinus <michael.albinus <at> gmx.de> writes:

> Morgan Smith <morgan.j.smith <at> outlook.com> writes:
>
>>> We might be better with
>>>
>>> --8<---------------cut here---------------start------------->8---
>>> @$(EMACS) -Q --batch -L . -L ./test -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit
>>> --8<---------------cut here---------------end--------------->8---
>>>
>>
>> I did the '-L ./test' part but I kept the foreach.
>>
>> Without the foreach the command looks like "... -l file1.el file2.el
>> file3.el ..." and emacs only actually loads the first file.  The command
>> needs to look like "... -l file1.el -l file2.el -l file3.el ..."
>
> My point is, that we have only the make target 'check', which runs all
> ert tests located in different files. But I would also like to run only
> the tests in, say for example, debbugs-tests.el. So we need an own
> target for every *-tests.el file.
>

I've now implemented the interface I've seen in other projects (guix,
org-mode) to enable this feature.  It looks something like this: "make
check TESTS='get-status'".

>>>> --- /dev/null
>>>> +++ b/test/debbugs-test-helpers.el
>>>> @@ -0,0 +1,146 @@
>>>> +(defconst debbugs-test--bug-status-soap-return
>>>> +(defconst debbugs-test--bug-status
>>>
>>> Perhaps we should move these data into an ert-resource file (or two).
>>>

I still don't understand why it would be beneficial to have the data in
resource files.  I also think that maybe it should be classified as an
enhancement that goes beyond the scope of this particular patch series.
If you would like to do this please feel free.  I've only got so many
hours in my day.

[v3-0001-tests-Move-helper-and-wrapper-functions-into-thei.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.