GNU bug report logs - #76446
[Patch Debbugs] Infrastructure Improvements

Previous Next

Full log

Message #26 received at 76446 <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <morgan.j.smith <at> outlook.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76446 <at> debbugs.gnu.org
Subject: Re: bug#76446:
 0003-Makefile-Add-target-to-run-checkdoc-on-all-files.patch
Date: Fri, 21 Feb 2025 13:15:53 -0500

[Message part 1 (text/plain, inline)]

Michael Albinus <michael.albinus <at> gmx.de> writes:

> Morgan Smith <Morgan.J.Smith <at> outlook.com> writes:
>
>> --- /dev/null
>> +++ b/.dir-locals.el
>> @@ -0,0 +1,18 @@
>> +;;; Directory Local Variables            -*- no-byte-compile: t -*-
>> +;;; For more information see (info "(emacs) Directory Variables")
>> +
>> +((emacs-lisp-mode . ((checkdoc-package-keywords-flag . t)
>> +                     (checkdoc-ispell-lisp-words
>> +                      .
>> +                      ("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
>> +                       "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
>> +                       "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
>> +                       "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
>> +                       "hyperestraier" "keymap" "magit" "magnus" "maint"
>> +                       "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
>> +                       "moreinfo" "multibyte" "notabug" "paren" "persistency"
>> +                       "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
>> +                       "solaris" "src" "sublist" "submitter" "submitter's"
>> +                       "subproduct" "subqueries" "subquery" "teardown"
>> +                       "unarchived" "unibyte" "unreproducible" "url" "util"
>> +                       "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))))
>
> This is needed for the checkdoc target in make only, isn't it? Shouldn't
> we activate it for just this case?
>

Ya this seems a little inelegant.  See the attached patch for an attempt
to do this a different way.

>> --- a/Makefile
>> +++ b/Makefile
>> +checkdoc: $(SOURCE) $(TESTSOURCE)
>> +	@$(EMACS) -Q --batch "--eval=(setq enable-local-variables :all \
>> +                                       checkdoc-spellcheck-documentation-flag t)" \
>> +    -L . $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
>
> Do we need '-L .'?

We do not!

>
> Best regards, Michael.

[v2-0004-Makefile-Add-target-to-run-checkdoc-on-all-files.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.