Subject: Re: bug#76446: [PATCH v2 4/5] Makefile: Add target to run checkdoc on all files

From: Michael Albinus <[email-masked]>
Date: Sat, 22 Feb 2025 17:05:04 +0100

Morgan Smith <[email-masked]> writes:

> --- a/Makefile
> +++ b/Makefile
> @@ -8,7 +8,7 @@ TESTTARGET=$(patsubst %.el,%.elc,$(TESTSOURCE))
>
>  INFOMANUALS=debbugs.info debbugs-ug.info
>
> -.PHONY: all build check clean
> +.PHONY: all build check clean checkdoc
>  .PRECIOUS: %.elc
>
>  %.elc: %.el
> @@ -26,6 +26,9 @@ doc: $(INFOMANUALS)
>
>  build: $(TARGET)
>
> +checkdoc: $(SOURCE) $(TESTSOURCE)
> +	@$(EMACS) -Q --batch -l test/debbugs-checkdoc-config.el $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
> +
>  check: build $(TESTTARGET)
>  	@$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit

This would be wrong. You don't need to load debbugs-helpers.el (it is
required in *-tests.el) and debbugs-checkdoc-config.el (it isn't related
to ert tests.

> --- /dev/null
> +++ b/test/debbugs-checkdoc-config.el
> +  (setq checkdoc-ispell-lisp-words
> +        '("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
> +          "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
> +          "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
> +          "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
> +          "hyperestraier" "keymap" "magit" "magnus" "maint"
> +          "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
> +          "moreinfo" "multibyte" "notabug" "paren" "persistency"
> +          "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
> +          "solaris" "src" "sublist" "submitter" "submitter's"
> +          "subproduct" "subqueries" "subquery" "teardown"
> +          "unarchived" "unibyte" "unreproducible" "url" "util"
> +          "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))

Same comment here: couldn't it be a ressource file?

And, more general: Could this file transformed into an ert test?

Best regards, Michael.