From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 20 14:01:25 2025 Received: (at submit) by debbugs.gnu.org; 20 Feb 2025 19:01:26 +0000 Received: from localhost ([127.0.0.1]:41009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlBnX-00084R-FW for submit@debbugs.gnu.org; Thu, 20 Feb 2025 14:01:25 -0500 Received: from lists.gnu.org ([2001:470:142::17]:60676) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlBnT-00083K-LQ for submit@debbugs.gnu.org; Thu, 20 Feb 2025 14:01:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlBnN-00088O-Ug for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2025 14:01:14 -0500 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlBnJ-0007yf-7y for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2025 14:01:12 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=zBldG0VU SnKeylw/HMKcATLyDle1T2cEBN7BmfvnX10=; h=date:subject:to:from; d=ledu-giraud.fr; b=vIMopqFF/VdK6nVdvFFe8ND7jCtS3feJ3muLcWN8SkmyTGtxJ6 S3l0yGqy5HeLRnCho0gF7cWQaBNQ3IJNlKBA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=zBldG0VUSnKeylw/ HMKcATLyDle1T2cEBN7BmfvnX10=; h=date:subject:to:from; d=ledu-giraud.fr; b=gYuTXfVn7ro+TUspvU15zKrOqhr4KhhhigPDUFCV3yCgTnLpKU /hnenXVOMnqih7JGcCNb5ej9vYj9n+3z8EFgODBZGfTZncwx6gO3JDYnK47d4PNLntsNcq UZtiUFlY5/SrJ8Gp1Ti6MuYlnW7iUrBasv3jQdMI1b7acBZvghXg62Dmmmonl2Sl37CrPB Pq+/d/IfBP3TondqTZaOQGsT/4/vSyJiB/H8rJzfsrXsSpyMS8mVHFApIvwbuPSrWVv6BL 3aTJO1x2WcU4cNO0StqtKUpbNe9dJd//bDMbtCMlCaf0njPApnqBRKOwrPx+/ngWFQYLcy 2clcb6qrdY2w== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 517d703c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Thu, 20 Feb 2025 20:01:06 +0100 (CET) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 31.0.50; `eww' makes display property sticky X-Debbugs-Cc: Date: Thu, 20 Feb 2025 20:01:04 +0100 Message-ID: <87r03so2z3.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Hi, Here is a recipe that makes characters typed into a bug report invisible. - emacs -Q - M-x eww gnu.org - M-x report-emacs-bug foo Now in the message buffer for the report, any character you type won't appear. A previous discussion with Eli on help-gnu-emacs shows that this comes from an incorrect value of `text-property-default-nonsticky'. In GNU Emacs 31.0.50 (build 2, x86_64-unknown-openbsd7.6, X toolkit) of 2025-02-20 built on computer Repository revision: d80ac0fbaa09826342a9818014ae950acc7c0c03 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101015 System Description: OpenBSD computer 7.6 GENERIC.MP#554 amd64 Configured using: 'configure CC=egcc CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=lucid --with-toolkit-scroll-bars=no --without-cairo --without-compress-install' Configured features: DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY KQUEUE PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XAW3D XDBE XFT XIM XINERAMA XINPUT2 XPM XRANDR LUCID ZLIB Important settings: value of $LC_CTYPE: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Shell Minor modes in effect: display-time-mode: t display-battery-mode: t desktop-save-mode: t exwm-randr-mode: t server-mode: t shell-dirtrack-mode: t comint-fontify-input-mode: t electric-pair-mode: t override-global-mode: t repeat-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/prog/elisp/exwm/exwm hides /home/manuel/.emacs.d/elpa/exwm-0.33/exwm /home/manuel/prog/elisp/exwm/exwm-xsettings hides /home/manuel/.emacs.d/elpa/exwm-0.33/exwm-xsettings /home/manuel/prog/elisp/exwm/exwm-xim hides /home/manuel/.emacs.d/elpa/exwm-0.33/exwm-xim /home/manuel/prog/elisp/exwm/exwm-workspace hides /home/manuel/.emacs.d/elpa/exwm-0.33/exwm-workspace /home/manuel/prog/elisp/exwm/exwm-randr hides /home/manuel/.emacs.d/elpa/exwm-0.33/exwm-randr /home/manuel/prog/elisp/exwm/exwm-manage hides /home/manuel/.emacs.d/elpa/exwm-0.33/exwm-manage /home/manuel/prog/elisp/exwm/exwm-layout hides /home/manuel/.emacs.d/elpa/exwm-0.33/exwm-layout /home/manuel/prog/elisp/exwm/exwm-input hides /home/manuel/.emacs.d/elpa/exwm-0.33/exwm-input /home/manuel/prog/elisp/exwm/exwm-floating hides /home/manuel/.emacs.d/elpa/exwm-0.33/exwm-floating /home/manuel/prog/elisp/exwm/exwm-systemtray hides /home/manuel/.emacs.d/elpa/exwm-0.33/exwm-systemtray /home/manuel/prog/elisp/exwm/exwm-core hides /home/manuel/.emacs.d/elpa/exwm-0.33/exwm-core /home/manuel/prog/elisp/exwm/exwm-background hides /home/manuel/.emacs.d/elpa/exwm-0.33/exwm-background /home/manuel/.emacs.d/elpa/ef-themes-1.9.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/31.0.50/lisp/theme-loaddefs Features: (mailalias smtpmail gnus-cite textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg gnus-ml gnus-topic qp mm-archive url-cache utf-7 imap rfc2104 nndoc nndraft nnmh network-stream nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache nnrss shadow sort mail-extr emacsbug org-agenda cus-start org-indent conf-mode tex-mode oc-basic org-element org-persist org-id org-element-ast inline avl-tree ol-eww eww vtable url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi gnus-icalendar org-capture org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src sh-script smie treesit executable ob-comint org-pcomplete org-list org-footnote org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs org-compat org-macs doc-view filenotify jka-compr image-mode exif hideshow rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap sgml-mode facemenu nxml-util nxml-enc xmltok vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view log-edit add-log pcvs-util mule-util on-screen macrostep-c cmacexp debbugs-browse bug-reference hi-lock gnus-dired vc-git diff-mode track-changes vc-dir ewoc vc vc-dispatcher time battery desktop frameset exwm-randr xcb-randr exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug server ef-themes modus-operandi-theme modus-themes zone speed-type url-http url-auth url-gw nsm ytdious mpdired transmission color calc-bin calc-ext calc calc-loaddefs rect calc-macs supercite regi ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range gnus-win ebdb-message message yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 gmm-utils mailheader ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe find-func eieio-base timezone icalendar gnus nnheader gnus-util range sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils web-mode derived disp-table erlang-start skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp rx trampver tramp-integration files-x tramp-message tramp-compat shell pcomplete parse-time iso8601 time-date format-spec tramp-loaddefs slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations slime-macrostep macrostep compat slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline comint ansi-osc ansi-color ring hyperspec thingatpt elec-pair edmacro kmacro use-package-bind-key bind-key appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs pcase dired-x dired-aux dired dired-loaddefs use-package-core repeat easy-mmode cus-edit pp cus-load wid-edit debbugs-autoloads ebdb-autoloads cl-extra help-mode ef-themes-autoloads exwm-autoloads gnuplot-autoloads hyperbole-autoloads kotl-autoloads hact set hhist notmuch-autoloads on-screen-autoloads osm-autoloads pdf-tools-autoloads rust-mode-autoloads info slime-autoloads macrostep-autoloads speed-type-autoloads sudo-edit-autoloads svg-clock-autoloads tablist-autoloads transmission-autoloads xelb-autoloads ytdious-autoloads package browse-url xdg url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting x-toolkit xinput2 x multi-tty move-toolbar make-network-process tty-child-frames emacs) Memory information: ((conses 16 1041098 449040) (symbols 48 58662 40) (strings 32 290945 32447) (string-bytes 1 8153561) (vectors 16 180781) (vector-slots 8 2453492 88159) (floats 8 670 236) (intervals 56 16260 1018) (buffers 992 92)) -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 03:32:47 2025 Received: (at 76445) by debbugs.gnu.org; 21 Feb 2025 08:32:47 +0000 Received: from localhost ([127.0.0.1]:52466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlOSj-0002ZB-RW for submit@debbugs.gnu.org; Fri, 21 Feb 2025 03:32:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38232) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlOSa-0002X7-0G for 76445@debbugs.gnu.org; Fri, 21 Feb 2025 03:32:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlOSQ-0000ag-QB; Fri, 21 Feb 2025 03:32:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FOqg3Ta9zTaGlEBUIsOo/yqdZ+G/Fek4z3h5/bg74SY=; b=Q9q4oMC8M+Bk eW1JyJmzIiAtz9XY5UahNZHNUgKyGaL3acjqN2M7+dWfCv8IiTZF1zmGSTZdwdpM9HaW2FqLCeV+m 8mPX5phN1+LVZIGS1YgJ1EjAIpfxcpkjHXztTgThVg0ioTjABJqhPtEq+QzC+zcl6kwaCixqUHC2k kI/iLfoLdXZE/SlzJeFNAIYHtBBgXVZfAJmBt/YyfJUsXkEURCMAM4QRcWZaeV97pBZD9tpXIGlch e274uc+7GHYeydD1WTzODdK/Wht6DjNrowdXiV5LLmNsskEoiIZ2dGdWBMQn6deYk9ISUpc+Of+UH m8KPNgk/V5dvavJL+aghtQ==; Date: Fri, 21 Feb 2025 10:32:18 +0200 Message-Id: <86o6yv1ywd.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud , Stefan Monnier In-Reply-To: <87r03so2z3.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 20 Feb 2025 20:01:04 +0100) Subject: Re: bug#76445: 31.0.50; `eww' makes display property sticky References: <87r03so2z3.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76445 Cc: 76445@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Date: Thu, 20 Feb 2025 20:01:04 +0100 > > Here is a recipe that makes characters typed into a bug report > invisible. > > - emacs -Q > - M-x eww gnu.org > - M-x report-emacs-bug foo > > Now in the message buffer for the report, any character you type won't > appear. A previous discussion with Eli on help-gnu-emacs shows that > this comes from an incorrect value of `text-property-default-nonsticky'. Could you see if making this part in eww-mode: (setq text-property-default-nonsticky '((face . t) (eww-form . t) (field . t)))) set only the buffer-local value of text-property-default-nonsticky solves the problem without any regressions in eww-mode itself? Stefan, does it make sense to have this variable _not_ be buffer-local when set? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 05:04:46 2025 Received: (at 76445) by debbugs.gnu.org; 21 Feb 2025 10:04:46 +0000 Received: from localhost ([127.0.0.1]:53919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlPtl-0002gU-2u for submit@debbugs.gnu.org; Fri, 21 Feb 2025 05:04:45 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:45385) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlPth-0002fx-IK for 76445@debbugs.gnu.org; Fri, 21 Feb 2025 05:04:43 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=DkSYFg6e tZRlkhu+gfKX3PFzvoIxF+TtwtoKf0rxsuQ=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=8jGaism2CAQQs5p7ukfBat3amyvwfK HcwWIJPeIij5ZQYSZQHLIhAT7WQmQhWSVg2wNHqjfCOZU5HpbOaM4FAg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=DkSYFg6etZRlkhu+ gfKX3PFzvoIxF+TtwtoKf0rxsuQ=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=oNI8X3UZf6XdhlNl2Nw69ERCfu9WLYZuJUJVmo qQSdiHXNz/1XyKDJSzRnVbSJYlh+2FC8DnSSSI3iPZkAc7V8bWqrNYOsfzYeY/zrMgYQ3d yRbR61WohujBckkcOyM28UcNUovuTWQENiOKCljyeXXLnV2sxYDvi7HjD4kuobVdNgJHxo kzKCBlyGCB+iLFsYlCPcKFTifO0wYuLewZht+1j3JFISfQHV4ZDxbmz6EtwO9CGj8KTTAu NHsgxqMNfkW6xHCKbgZcR/bNvPzKirzErSN6dLVBWMTU1jXCt/t/DGoVrTA3xcTpe9jp21 i/XpNiu9fLRAmlfaHGpFa6Vw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id d001db63 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 21 Feb 2025 11:04:40 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#76445: 31.0.50; `eww' makes display property sticky In-Reply-To: <86o6yv1ywd.fsf@gnu.org> References: <87r03so2z3.fsf@ledu-giraud.fr> <86o6yv1ywd.fsf@gnu.org> Date: Fri, 21 Feb 2025 11:04:38 +0100 Message-ID: <87ikp3obpl.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76445 Cc: 76445@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Manuel Giraud >> Date: Thu, 20 Feb 2025 20:01:04 +0100 >> >> Here is a recipe that makes characters typed into a bug report >> invisible. >> >> - emacs -Q >> - M-x eww gnu.org >> - M-x report-emacs-bug foo >> >> Now in the message buffer for the report, any character you type won't >> appear. A previous discussion with Eli on help-gnu-emacs shows that >> this comes from an incorrect value of `text-property-default-nonsticky'. > > Could you see if making this part in eww-mode: > > (setq text-property-default-nonsticky '((face . t) (eww-form . t) > (field . t)))) > > set only the buffer-local value of text-property-default-nonsticky > solves the problem without any regressions in eww-mode itself? I have lightly tested with the attached patch. This fixes the issue and EWW seems to work as usual. Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-disappearing-chars-bug-76445.patch >From 9f56644db64929004cd967f6b8d49c8357286874 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Fri, 21 Feb 2025 11:01:10 +0100 Subject: [PATCH] Fix "disappearing chars" bug#76445 * lisp/net/eww.el (eww-mode): Set the buffer local value of `text-property-default-nonsticky' --- lisp/net/eww.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 18a72e97fcb..1ed1b491c71 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -1416,8 +1416,8 @@ eww-mode (setq buffer-read-only t) ;; Insertion at the first character of a field should inherit the ;; field's face, form and field, not the previous character's. - (setq text-property-default-nonsticky '((face . t) (eww-form . t) - (field . t)))) + (setq-local text-property-default-nonsticky '((face . t) (eww-form . t) + (field . t)))) (declare-function imagep "image.c") (defvar text-scale-mode) -- 2.48.1 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 08:51:57 2025 Received: (at 76445) by debbugs.gnu.org; 21 Feb 2025 13:51:57 +0000 Received: from localhost ([127.0.0.1]:57404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlTRc-00072Q-V4 for submit@debbugs.gnu.org; Fri, 21 Feb 2025 08:51:57 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49206) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlTRa-000719-F7 for 76445@debbugs.gnu.org; Fri, 21 Feb 2025 08:51:55 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EE6C7100035; Fri, 21 Feb 2025 08:51:47 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1740145903; bh=Rv3x5P8zw1mnHGNwuR5GUcnJLRyX+azEta6z1IIeTYI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=eJ8wnywKoBk+23vhBzxYFK3/OumObOY0a0tx4g2BBnvy1dRvJl515uTVcTmnqqZ9d 36BmpNScKXnqVDKBFVmXiobAnbEbfEj0eAV1fWI0TjPcbbJGSh9p6MUYOqtlr+TJN3 cAOwjQ34cqTeKANzXJm59fKrChSd7GsQ+QCdqPTfunknsyfa9sHrohZl5H1d8J5blU kng1gDyIvvNis/914ccHxSyxdJclxT/B43utU9vX0bySh1XbBhcuHxzfzCvaSGEo2d hcFAEKz7wZC49F5IiJuTdHAV/qe06Zbd0Y6dYWzw8qzwz/3c0loyZRFHUDbtYUIPBG h+KhR2RNQR/jA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1A2B110002E; Fri, 21 Feb 2025 08:51:43 -0500 (EST) Received: from pastel (unknown [104.247.242.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DBD58120568; Fri, 21 Feb 2025 08:51:42 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#76445: 31.0.50; `eww' makes display property sticky In-Reply-To: <86o6yv1ywd.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Feb 2025 10:32:18 +0200") Message-ID: References: <87r03so2z3.fsf@ledu-giraud.fr> <86o6yv1ywd.fsf@gnu.org> Date: Fri, 21 Feb 2025 08:51:41 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.156 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76445 Cc: 76445@debbugs.gnu.org, Manuel Giraud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Could you see if making this part in eww-mode: > > (setq text-property-default-nonsticky '((face . t) (eww-form . t) > (field . t)))) > > set only the buffer-local value of text-property-default-nonsticky > solves the problem without any regressions in eww-mode itself? > > Stefan, does it make sense to have this variable _not_ be buffer-local > when set? I don't think I have more expertise than others in this area, but yes it would make sense for this var to be auto-buffer-local. It's dangerous to change its global value, so it makes sense to do it only in response to `setq-default`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 05:43:22 2025 Received: (at 76445) by debbugs.gnu.org; 22 Feb 2025 10:43:22 +0000 Received: from localhost ([127.0.0.1]:48693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlmye-0007Gl-7p for submit@debbugs.gnu.org; Sat, 22 Feb 2025 05:43:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36026) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlmyb-0007FS-Ei for 76445@debbugs.gnu.org; Sat, 22 Feb 2025 05:43:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlmyV-00047k-4L; Sat, 22 Feb 2025 05:43:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lkm9yRCs4qN92nPHvlpwgd/4pY4Av9upRmhlVCOqgaA=; b=az3Xx6CckC11 lr41KnY76tovG0JqpgpMgtp4bOpYEpZX2oTNPshUAq0nr0TbCSLcCMwfN2ru1WRzchkOWgf1RwdHX v95Buma6LncJ6oDTzEbGKANrmkhu7FXPas+ASESYxmgU/t8ilI6xfbujbcJ9GbcoxbF1ybvTryvkG 3uIZ8ttgGnp426mLZq4JszwvhN8KfX5dfOAIker/bilP3YEdj849bLLQGntqR+e+lzageqjiO9cbZ O8wqsJ2+YWP4/JcxjEuxX7G5QajnB0T7eIUvZ8bW2w8KWplsgkcoEJdtKqlkldV2/8qFMbqt971Jt V/LIcg5BluLXjkAAkNPbqg==; Date: Sat, 22 Feb 2025 12:43:08 +0200 Message-Id: <86eczqjm4j.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Fri, 21 Feb 2025 08:51:41 -0500) Subject: Re: bug#76445: 31.0.50; `eww' makes display property sticky References: <87r03so2z3.fsf@ledu-giraud.fr> <86o6yv1ywd.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76445 Cc: 76445@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Manuel Giraud , 76445@debbugs.gnu.org > Date: Fri, 21 Feb 2025 08:51:41 -0500 > > > Could you see if making this part in eww-mode: > > > > (setq text-property-default-nonsticky '((face . t) (eww-form . t) > > (field . t)))) > > > > set only the buffer-local value of text-property-default-nonsticky > > solves the problem without any regressions in eww-mode itself? > > > > Stefan, does it make sense to have this variable _not_ be buffer-local > > when set? > > I don't think I have more expertise than others in this area, but yes it > would make sense for this var to be auto-buffer-local. It's dangerous > to change its global value, so it makes sense to do it only in response > to `setq-default`. Agreed. So the changes below should fix this problem without any changes in eww.el. Manuel, could you please verify that? It seems to work here. diff --git a/doc/lispref/text.texi b/doc/lispref/text.texi index bada8bd..90aa45e 100644 --- a/doc/lispref/text.texi +++ b/doc/lispref/text.texi @@ -4135,10 +4135,10 @@ Sticky Properties list. @defvar text-property-default-nonsticky -This variable holds an alist which defines the default rear-stickiness -of various text properties. Each element has the form -@code{(@var{property} . @var{nonstickiness})}, and it defines the -stickiness of a particular text property, @var{property}. +This buffer-local variable holds an alist which defines the default +rear-stickiness of various text properties in the buffer. Each element +has the form @code{(@var{property} . @var{nonstickiness})}, and it +defines the stickiness of a particular text property, @var{property}. If @var{nonstickiness} is non-@code{nil}, this means that the property @var{property} is rear-nonsticky by default. Since all properties are diff --git a/etc/NEWS b/etc/NEWS index 110e955..080675e 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1293,6 +1293,11 @@ An old alternative name (without the first 'e') has been removed. +++ ** 'read-directory-name' now accepts an optional PREDICATE argument. ++++ +** 'text-property-default-nonsticky' is now buffer-local. +This variable now becomes buffer-local when set. Use 'setq-default' in +(the unlikely) case you want to change the global value. + --- ** All the digit characters now have the 'digit' category. All the characters whose Unicode general-category is Nd now have the diff --git a/etc/symbol-releases.eld b/etc/symbol-releases.eld index 645ab77..4120058 100644 --- a/etc/symbol-releases.eld +++ b/etc/symbol-releases.eld @@ -44,6 +44,7 @@ ("22.1" fun version<) ("22.1" fun version<=) ("22.1" fun read-number) + ("21.1" var text-property-default-nonsticky) ;; Since much of early Emacs source history is lost, these versions are ;; conservative estimates: the actual version of first appearance may very diff --git a/src/textprop.c b/src/textprop.c index 30c26ce..8fdaafc 100644 --- a/src/textprop.c +++ b/src/textprop.c @@ -2427,6 +2427,7 @@ syms_of_textprop (void) by default. */ Vtext_property_default_nonsticky = list2 (Fcons (Qsyntax_table, Qt), Fcons (Qdisplay, Qt)); + Fmake_variable_buffer_local (Qtext_property_default_nonsticky); interval_insert_behind_hooks = Qnil; interval_insert_in_front_hooks = Qnil; @@ -2444,6 +2445,7 @@ syms_of_textprop (void) DEFSYM (Qlocal_map, "local-map"); DEFSYM (Qfront_sticky, "front-sticky"); DEFSYM (Qrear_nonsticky, "rear-nonsticky"); + DEFSYM (Qtext_property_default_nonsticky, "text-property-default-nonsticky"); DEFSYM (Qmouse_face, "mouse-face"); DEFSYM (Qminibuffer_prompt, "minibuffer-prompt"); From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 09:38:16 2025 Received: (at 76445) by debbugs.gnu.org; 22 Feb 2025 14:38:17 +0000 Received: from localhost ([127.0.0.1]:52458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlqdz-0007Lz-LS for submit@debbugs.gnu.org; Sat, 22 Feb 2025 09:38:16 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:22303) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlqdw-0007LF-0f for 76445@debbugs.gnu.org; Sat, 22 Feb 2025 09:38:13 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=utfDxLu+ jBfAVqfHeQzKcY8Jo9QhKh8cnuvruBXeqyg=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=ZNDrRwhmCoWgEdLrhs0zsEw6mayKbq JHAZZ2wsHM4srUQI4dz+GGx15IWO1aKleHzESkEHm2TG5tuSCk2RnFCQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=utfDxLu+jBfAVqfH eQzKcY8Jo9QhKh8cnuvruBXeqyg=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=RbJG+8Q/MOVsztv4TuGZf6i4/wl/mw1JZma/Bs l7B3sFQYDozdhG1+oAWWBbuoKAyuDJGF0R8zF7heOz5fs/McU8whucA7hGO2ZkBx03Mk4z Id6tARwpPGoPFoeU1GX1iOyXvEvM9FmVDjt3M3Zrpu9oFP9FVKNXmUaotuaPP8rAUhXwpA +7U332if2RgffP9iW5RUJD3URcmAgNu7niZ7/1xt1lFXfuuynEMHz0YtgOogXManygQ5sP eA7z+cVfL0gjDzKFa11c+4qaolAaVrmT7lFAt15/xysdT0qp2YG7sfGdfndL9LU5lEk3Qv ZdkTnRSjQW0Kjr0ndVYLh0xw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 21e04cf3 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 22 Feb 2025 15:38:09 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#76445: 31.0.50; `eww' makes display property sticky In-Reply-To: <86eczqjm4j.fsf@gnu.org> References: <87r03so2z3.fsf@ledu-giraud.fr> <86o6yv1ywd.fsf@gnu.org> <86eczqjm4j.fsf@gnu.org> Date: Sat, 22 Feb 2025 15:38:07 +0100 Message-ID: <87frk6rqnk.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76445 Cc: 76445@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Stefan Monnier >> Cc: Manuel Giraud , 76445@debbugs.gnu.org >> Date: Fri, 21 Feb 2025 08:51:41 -0500 >> >> > Could you see if making this part in eww-mode: >> > >> > (setq text-property-default-nonsticky '((face . t) (eww-form . t) >> > (field . t)))) >> > >> > set only the buffer-local value of text-property-default-nonsticky >> > solves the problem without any regressions in eww-mode itself? >> > >> > Stefan, does it make sense to have this variable _not_ be buffer-local >> > when set? >> >> I don't think I have more expertise than others in this area, but yes it >> would make sense for this var to be auto-buffer-local. It's dangerous >> to change its global value, so it makes sense to do it only in response >> to `setq-default`. > > Agreed. So the changes below should fix this problem without any > changes in eww.el. Manuel, could you please verify that? It seems to > work here. I have tested it on current master (702cb123faf) and it works as expected. Thanks. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 11:05:52 2025 Received: (at 76445-done) by debbugs.gnu.org; 22 Feb 2025 16:05:52 +0000 Received: from localhost ([127.0.0.1]:56926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tls0l-0007Y7-QD for submit@debbugs.gnu.org; Sat, 22 Feb 2025 11:05:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42810) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tls0j-0007Xq-E7 for 76445-done@debbugs.gnu.org; Sat, 22 Feb 2025 11:05:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tls0d-0006H5-5C; Sat, 22 Feb 2025 11:05:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3Ky02sca18h7qxu8nMg63HVXhSPBhWxYN2+zoCv7e+g=; b=QAu3bdq/qYzt esWqPfk+ybZ9M7eDu/vBYIhLf1mCGQIhZLZ3va1bU+65jBlAvtS9RVoSFB+NiNVp3b1UqytYXqYQV i75uYjfY3KPv91l8mZP3GQoKb+lvLuC7IJ012AAuKd8Hceg+JzWpGRfybQlZ5JxLUVJ37Cn5PHa87 qLUkS4u9nQlpwWSnvzVa6kP1IDv1sMkuUOov3FsoCeFhdpc8U8GeATvPffU6ksoXmlaxayl9EE1+t aiL+KzlfTvwhu+oZhSpy5IuFkdqk6HzFBFx5WU8fHe9yHuyMHgdNNiDUJoNvQ8Q6b3QvTVcuBBeIZ MSxyLAXhT2k/IYsU5bU+qw==; Date: Sat, 22 Feb 2025 18:05:41 +0200 Message-Id: <86ldtyhsmi.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87frk6rqnk.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 22 Feb 2025 15:38:07 +0100) Subject: Re: bug#76445: 31.0.50; `eww' makes display property sticky References: <87r03so2z3.fsf@ledu-giraud.fr> <86o6yv1ywd.fsf@gnu.org> <86eczqjm4j.fsf@gnu.org> <87frk6rqnk.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76445-done Cc: monnier@iro.umontreal.ca, 76445-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: Stefan Monnier , 76445@debbugs.gnu.org > Date: Sat, 22 Feb 2025 15:38:07 +0100 > > Eli Zaretskii writes: > > >> From: Stefan Monnier > >> Cc: Manuel Giraud , 76445@debbugs.gnu.org > >> Date: Fri, 21 Feb 2025 08:51:41 -0500 > >> > >> > Could you see if making this part in eww-mode: > >> > > >> > (setq text-property-default-nonsticky '((face . t) (eww-form . t) > >> > (field . t)))) > >> > > >> > set only the buffer-local value of text-property-default-nonsticky > >> > solves the problem without any regressions in eww-mode itself? > >> > > >> > Stefan, does it make sense to have this variable _not_ be buffer-local > >> > when set? > >> > >> I don't think I have more expertise than others in this area, but yes it > >> would make sense for this var to be auto-buffer-local. It's dangerous > >> to change its global value, so it makes sense to do it only in response > >> to `setq-default`. > > > > Agreed. So the changes below should fix this problem without any > > changes in eww.el. Manuel, could you please verify that? It seems to > > work here. > > I have tested it on current master (702cb123faf) and it works as > expected. Thanks. Thanks, installed on master, and closing the bug. From unknown Fri Jun 20 07:23:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 23 Mar 2025 11:24:36 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator