GNU bug report logs - #76419
[PATCH] * gnu/packages/games.scm (moonlight-qt): Modify inputs.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andreas Enge <andreas <at> enge.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76419: closed ([PATCH] * gnu/packages/games.scm
 (moonlight-qt): Modify inputs.)
Date: Mon, 14 Apr 2025 12:57:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 14 Apr 2025 14:56:40 +0200
with message-id <Z_0GCA3tP1WF8vbW <at> jurong>
and subject line Re: [PATCH] * gnu/packages/games.scm (moonlight-qt): Modify inputs.
has caused the debbugs.gnu.org bug report #76419,
regarding [PATCH] * gnu/packages/games.scm (moonlight-qt): Modify inputs.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76419: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76419
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vitor Hugo <vitorhugonunes <at> proton.me>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] * gnu/packages/games.scm (moonlight-qt): Modify inputs.
Date: Wed, 19 Feb 2025 18:17:05 +0000

The package was missing `wayland` as an input, which broke hardware
acceleration whenever running under wayland. This fixes it.

Change-Id: I65b16f5e2e77627f79f45a63461436be51e0fa96
---
 gnu/packages/games.scm | 44 +++++++++++++++++++++++++-----------------
 1 file changed, 26 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 30aaf0767a..10fe0f6dac 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -6566,15 +6566,15 @@ (define-public moonlight-qt
   (package
     (name "moonlight-qt")
     (version "6.1.0")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/moonlight-stream/moonlight-qt")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "06fxf3m26k036asxjkkykk5q96nincwmpiqm953m7zgr9224gidx"))))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/moonlight-stream/moonlight-qt")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "06fxf3m26k036asxjkkykk5q96nincwmpiqm953m7zgr9224gidx"))))
     (build-system qt-build-system)
     (arguments
      (list
@@ -6583,18 +6583,25 @@ (define-public moonlight-qt
       #~(modify-phases %standard-phases
           (replace 'configure
             (lambda* _
-              (symlink (string-append
-                        #$(this-package-input "sdl2-gamecontrollerdb")
-                        "/share/sdl2/gamecontrollerdb.txt")
+              (symlink (string-append #$(this-package-input
+                                         "sdl2-gamecontrollerdb")
+                                      "/share/sdl2/gamecontrollerdb.txt")
                        "app/SDL_GameControllerDB/gamecontrollerdb.txt")
               ;; Unbundle libraries.
               (substitute* "moonlight-qt.pro"
-                (("    moonlight-common-c.*\n") "")
-                (("    qmdnsengine.*\n") "")
-                (("    h264bitstream.*\n") "")
-                (("    app \\\\") "    app")
-                (("app.depends") "INCLUDEPATH +="))
-              (invoke "qmake" (string-append "PREFIX=" #$output)))))))
+                (("    moonlight-common-c.*\n")
+                 "")
+                (("    qmdnsengine.*\n")
+                 "")
+                (("    h264bitstream.*\n")
+                 "")
+                (("    app \\\\")
+                 "    app")
+                (("app.depends")
+                 "INCLUDEPATH +="))
+              (invoke "qmake"
+                      (string-append "PREFIX="
+                                     #$output)))))))
     (native-inputs (list pkg-config qttools-5))
     (inputs (list ffmpeg
                   h264bitstream
@@ -6609,6 +6616,7 @@ (define-public moonlight-qt
                   qtquickcontrols2-5
                   qtsvg-5
                   qtwayland-5
+                  wayland
                   sdl2
                   sdl2-ttf
                   sdl2-gamecontrollerdb))
-- 
2.46.0

[Message part 3 (message/rfc822, inline)]

From: Andreas Enge <andreas <at> enge.fr>
To: Vitor Hugo <vitorhugonunes <at> proton.me>
Cc: "76419 <at> debbugs.gnu.org" <76419-done <at> debbugs.gnu.org>
Subject: Re: [PATCH] * gnu/packages/games.scm (moonlight-qt): Modify inputs.
Date: Mon, 14 Apr 2025 14:56:40 +0200

Am Sun, Apr 13, 2025 at 10:03:23PM +0000 schrieb Vitor Hugo:
> Below follows a better formatted patch, as per suggestions
> in IRC.

Yes, not reformatting the package makes it easier to see what actually
changed. I have slightly modified the commit message and pushed, thanks!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.