GNU bug report logs - #76412
[PATCH] gnu: emacs-elfeed-org: Update to latest.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76412 in the body.
You can then email your comments to 76412 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: guix-patches <at> gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: [PATCH] gnu: emacs-elfeed-org: Update to latest.
Date: Wed, 19 Feb 2025 12:04:46 +0100

* gnu/packages/emacs-xyz.scm (emacs-elfeed-org): Update to latest.
[arguments]: Remove obsolete testing tweaks.
[propagated-inputs]: Remove unused dependencies.
---
 gnu/packages/emacs-xyz.scm | 32 +++++++-------------------------
 1 file changed, 7 insertions(+), 25 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5e48fab7e8..d888657cfa 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15911,10 +15911,12 @@ (define-public emacs-elfeed-goodies
       (license license:gpl3+))))
 
 (define-public emacs-elfeed-org
-  (let ((commit "77b6bbf222487809813de260447d31c4c59902c9"))
+  (let ((commit "1197cf29f6604e572ec604874a8f50b58081176a")
+        (version "0.1")
+        (revision "2"))
     (package
       (name "emacs-elfeed-org")
-      (version (git-version "0.1" "1" commit))
+      (version (git-version version revision commit))
       (source
        (origin
          (method git-fetch)
@@ -15923,33 +15925,13 @@ (define-public emacs-elfeed-org
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "0a2ibka82xq1dhy2z7rd2y9zhcj8rna8357881yz49wf55ccgm53"))))
+          (base32 "0giwnzlqk2s5hb6fs8a0l4dxcmn2fvkngpj1fayzwj0qnvds1kri"))))
       (build-system emacs-build-system)
       (arguments
        `(#:tests? #t
-         #:test-command '("ert-runner" "-L" "org-mode/lisp")
-         #:phases
-         (modify-phases %standard-phases
-           (add-before 'check 'chmod
-             (lambda _
-               (chmod "test/fixture-mark-feed-ignore.org" #o644)))
-           (add-before 'check 'xt-number-tests
-             (lambda _
-               ((lambda (file test-name)     ; variant of ert-number-tests
-                  (emacs-batch-edit-file file
-                    `(let ((i 0))
-                       (while (re-search-forward ,(string-append "xt-deftest "
-                                                                 test-name)
-                                                 nil t)
-                         (goto-char (match-beginning 0))
-                         (kill-region (match-beginning 0) (match-end 0))
-                         (insert (format "xt-deftest %s-%d" ,test-name i))
-                         (setq i (+ i 1)))
-                       (basic-save-buffer))))
-                "test/elfeed-org-test.el"
-                "rmh-elfeed-org-convert-headline-to-tagger-params"))))))
+         #:test-command '("ert-runner" "-L" "org-mode/lisp")))
       (propagated-inputs
-       (list emacs-elfeed emacs-org emacs-dash emacs-s))
+       (list emacs-elfeed emacs-org))
       (native-inputs
        (list emacs-ert-runner emacs-xtest))
       (home-page "https://github.com/remyhonig/elfeed-org")

base-commit: 27ae140024b6d05506cdf0d9fd5b91c25466f295
prerequisite-patch-id: f9cc903b8048c8c6fde576fbf38ab110263020e3
prerequisite-patch-id: d09c064d38df73405d505b90d222dccfd7be09b9
-- 
2.48.1

Message #8 received at 76412 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: control <at> debbugs.gnu.org, 76412 <at> debbugs.gnu.org
Cc: sarg <at> sarg.org.ru, ian <at> retrospec.tv, cox.katherine.e+guix <at> gmail.com,
 liliana.prikler <at> gmail.com, andrew <at> trop.in, divya <at> subvertising.org
Subject: control message for bug #76412
Date: Sun, 23 Feb 2025 11:10:11 +0100

[Message part 1 (text/plain, inline)]

user guix
usertag 76412 + waiting-on-contributor
thanks

Guix QA review form submission:

Items marked as checked:

- Package builds
- Lint warnings
- Package tests
- List dependent packages build

Please review:

- commit message
- apply package style
- version is 20250104.0
- no need of emacs-org as propagated-input

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 76412 <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: 76412 <at> debbugs.gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: [PATCH v1] gnu: emacs-elfeed-org: Update to 20250104.0.
Date: Sun, 23 Feb 2025 18:11:56 +0100

* gnu/packages/emacs-xyz.scm (emacs-elfeed-org): Update to 20250104.0.
[arguments]: Remove obsolete testing tweaks.
[propagated-inputs]: Remove unused dependencies.
---
 gnu/packages/emacs-xyz.scm | 36 ++++++++----------------------------
 1 file changed, 8 insertions(+), 28 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 59c1927135..9ec816920a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15933,10 +15933,12 @@ (define-public emacs-elfeed-goodies
       (license license:gpl3+))))
 
 (define-public emacs-elfeed-org
-  (let ((commit "77b6bbf222487809813de260447d31c4c59902c9"))
+  (let ((commit "1197cf29f6604e572ec604874a8f50b58081176a")
+        (version "20250104.0")
+        (revision "0"))
     (package
       (name "emacs-elfeed-org")
-      (version (git-version "0.1" "1" commit))
+      (version (git-version version revision commit))
       (source
        (origin
          (method git-fetch)
@@ -15945,35 +15947,13 @@ (define-public emacs-elfeed-org
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "0a2ibka82xq1dhy2z7rd2y9zhcj8rna8357881yz49wf55ccgm53"))))
+          (base32 "0giwnzlqk2s5hb6fs8a0l4dxcmn2fvkngpj1fayzwj0qnvds1kri"))))
       (build-system emacs-build-system)
       (arguments
        `(#:tests? #t
-         #:test-command '("ert-runner" "-L" "org-mode/lisp")
-         #:phases
-         (modify-phases %standard-phases
-           (add-before 'check 'chmod
-             (lambda _
-               (chmod "test/fixture-mark-feed-ignore.org" #o644)))
-           (add-before 'check 'xt-number-tests
-             (lambda _
-               ((lambda (file test-name)     ; variant of ert-number-tests
-                  (emacs-batch-edit-file file
-                    `(let ((i 0))
-                       (while (re-search-forward ,(string-append "xt-deftest "
-                                                                 test-name)
-                                                 nil t)
-                         (goto-char (match-beginning 0))
-                         (kill-region (match-beginning 0) (match-end 0))
-                         (insert (format "xt-deftest %s-%d" ,test-name i))
-                         (setq i (+ i 1)))
-                       (basic-save-buffer))))
-                "test/elfeed-org-test.el"
-                "rmh-elfeed-org-convert-headline-to-tagger-params"))))))
-      (propagated-inputs
-       (list emacs-elfeed emacs-org emacs-dash emacs-s))
-      (native-inputs
-       (list emacs-ert-runner emacs-xtest))
+         #:test-command '("ert-runner" "-L" "org-mode/lisp")))
+      (propagated-inputs (list emacs-elfeed))
+      (native-inputs (list emacs-ert-runner emacs-xtest))
       (home-page "https://github.com/remyhonig/elfeed-org")
       (synopsis "Configure Elfeed with an Org-mode file")
       (description

base-commit: 23b068c036223e70bdea9d7d579850a1cffc02a7
prerequisite-patch-id: f9cc903b8048c8c6fde576fbf38ab110263020e3
prerequisite-patch-id: d09c064d38df73405d505b90d222dccfd7be09b9
-- 
2.48.1

Message #14 received at 76412 <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 76412 <at> debbugs.gnu.org
Subject: Re: control message for bug #76412
Date: Sun, 23 Feb 2025 18:23:39 +0100

Cayetano Santos <csantosb <at> inventati.org> writes:

> Please review:
>
> - commit message
> - apply package style
> - version is 20250104.0
> - no need of emacs-org as propagated-input

I've applied the suggested changes. However I'm not sure emacs-org
should be removed - it is listed in `Package-Requires`.

Message #17 received at 76412 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Sergey Trofimov <sarg <at> sarg.org.ru>
Cc: 76412 <at> debbugs.gnu.org
Subject: Re: control message for bug #76412
Date: Sun, 23 Feb 2025 19:53:17 +0100

[Message part 1 (text/plain, inline)]

>dim. 23 févr. 2025 at 18:23, Sergey Trofimov <sarg <at> sarg.org.ru> wrote:

> Cayetano Santos <csantosb <at> inventati.org> writes:
>
>> Please review:
>>
>> - commit message
>> - apply package style
>> - version is 20250104.0
>> - no need of emacs-org as propagated-input
>
> I've applied the suggested changes. However I'm not sure emacs-org
> should be removed - it is listed in `Package-Requires`.

Sure, but guix packages emacs-29.4, which already includes emacs-org.

Let’s committers decide about this point.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 76412 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Sergey Trofimov <sarg <at> sarg.org.ru>
Cc: Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>, 76412 <at> debbugs.gnu.org,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>
Subject: Re: [bug#76412] [PATCH v1] gnu: emacs-elfeed-org: Update to
 20250104.0.
Date: Sun, 23 Feb 2025 20:01:38 +0100

[Message part 1 (text/plain, inline)]

>dim. 23 févr. 2025 at 18:11, Sergey Trofimov <sarg <at> sarg.org.ru> wrote:

> * gnu/packages/emacs-xyz.scm (emacs-elfeed-org): Update to 20250104.0.

Look at equivalent emacs update messages, corresponding to packages with
no releases, as this is the case.

I think message must be rather (version-revision-commit):

    Update to 20250104.0-0.1197cf2.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 76412 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>, 76412 <at> debbugs.gnu.org
Subject: Re: [bug#76412] control message for bug #76412
Date: Sat, 01 Mar 2025 10:16:49 -0800

Cayetano Santos <csantosb <at> inventati.org> writes:

>>dim. 23 févr. 2025 at 18:23, Sergey Trofimov <sarg <at> sarg.org.ru> 
>>wrote:
>
>> Cayetano Santos <csantosb <at> inventati.org> writes:
>>
>>> Please review:
>>>
>>> - commit message
>>> - apply package style
>>> - version is 20250104.0
>>> - no need of emacs-org as propagated-input
>>
>> I've applied the suggested changes. However I'm not sure 
>> emacs-org
>> should be removed - it is listed in `Package-Requires`.
>
> Sure, but guix packages emacs-29.4, which already includes 
> emacs-org.
>
> Let’s committers decide about this point.

It definitely shouldn’t propagate emacs-org.  Org Mode has been 
bundled with Emacs for a long time, so this is unlikely to cause 
breakage due to a missing dependency; but mixing Org Mode versions 
can cause all sorts of problems.  Best to let the user decide 
whether they use bundled or external Org Mode.

 -- Ian

Message #26 received at 76412 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Sergey Trofimov <sarg <at> sarg.org.ru>
Cc: liliana.prikler <at> gmail.com, Cayetano Santos <csantosb <at> inventati.org>,
 76412 <at> debbugs.gnu.org
Subject: Re: [bug#76412] [PATCH v1] gnu: emacs-elfeed-org: Update to
 20250104.0.
Date: Sat, 01 Mar 2025 10:21:37 -0800

Hi Sergey,

Pushed as 352e037539 with some minor changelog editing.

Thanks,
 -- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.