GNU bug report logs - #76408
29.4; read-key always returns only tab-line for click in tab-line

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76408 in the body.
You can then email your comments to 76408 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jared Finder <jared <at> finder.org>
To: Bug-gnu Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 29.4; read-key always returns only tab-line for click in tab-line
Date: Tue, 18 Feb 2025 17:35:13 -0500

read-key only reports the symbol tab-line for clicks in the tab-line,
instead of the mouse event.

To reproduce:

emacs -q -nw
M-x xterm-mouse-mode
Show the tab-line, either global-tab-line-mode or 
global-window-tool-bar-mode
Then just eval (read-key)

Clicks in the mode-line or header-line return the underlying mouse
event, but clicks in tab-line-only return the symbol tab-line.

I believe the following change to read-key fixes this:

@@ -3074,7 +3074,7 @@
                   (catch 'read-key (read-key-sequence-vector prompt nil 
t)))
                  (key (aref keys 0)))
             (if (and (> (length keys) 1)
-                     (memq key '(mode-line header-line
+                     (memq key '(mode-line header-line tab-line
                                  left-fringe right-fringe)))
                 (aref keys 1)
               key)))

  -- MJF

Message #8 received at 76408 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Jared Finder <jared <at> finder.org>
Cc: 76408 <at> debbugs.gnu.org
Subject: Re: bug#76408: 29.4; read-key always returns only tab-line for
 click in tab-line
Date: Wed, 19 Feb 2025 09:42:06 +0200

close 76408 31.0.50
thanks

> read-key only reports the symbol tab-line for clicks in the tab-line,
> instead of the mouse event.
>
> To reproduce:
>
> emacs -q -nw
> M-x xterm-mouse-mode
> Show the tab-line, either global-tab-line-mode or
> global-window-tool-bar-mode
> Then just eval (read-key)
>
> Clicks in the mode-line or header-line return the underlying mouse
> event, but clicks in tab-line-only return the symbol tab-line.
>
> I believe the following change to read-key fixes this:
>
> @@ -3074,7 +3074,7 @@ read-key
> -                     (memq key '(mode-line header-line
> +                     (memq key '(mode-line header-line tab-line

Thanks for the fix.  Pushed to master (I guess it's too late for release?)

Message #13 received at 76408 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 76408 <at> debbugs.gnu.org, jared <at> finder.org
Subject: Re: bug#76408: 29.4;
 read-key always returns only tab-line for click in tab-line
Date: Wed, 19 Feb 2025 18:00:10 +0200

> Cc: 76408 <at> debbugs.gnu.org
> From: Juri Linkov <juri <at> linkov.net>
> Date: Wed, 19 Feb 2025 09:42:06 +0200
> 
> close 76408 31.0.50
> thanks
> 
> > read-key only reports the symbol tab-line for clicks in the tab-line,
> > instead of the mouse event.
> >
> > To reproduce:
> >
> > emacs -q -nw
> > M-x xterm-mouse-mode
> > Show the tab-line, either global-tab-line-mode or
> > global-window-tool-bar-mode
> > Then just eval (read-key)
> >
> > Clicks in the mode-line or header-line return the underlying mouse
> > event, but clicks in tab-line-only return the symbol tab-line.
> >
> > I believe the following change to read-key fixes this:
> >
> > @@ -3074,7 +3074,7 @@ read-key
> > -                     (memq key '(mode-line header-line
> > +                     (memq key '(mode-line header-line tab-line
> 
> Thanks for the fix.  Pushed to master (I guess it's too late for release?)

It's okay to backport this to the release branch.

Thanks.

Message #16 received at 76408 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Juri Linkov <juri <at> linkov.net>
Cc: 76408 <at> debbugs.gnu.org, jared <at> finder.org
Subject: Re: bug#76408: 29.4; read-key always returns only tab-line for click
 in tab-line
Date: Wed, 19 Feb 2025 17:59:57 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: 76408 <at> debbugs.gnu.org
>> From: Juri Linkov <juri <at> linkov.net>
>> Date: Wed, 19 Feb 2025 09:42:06 +0200
>>
>> close 76408 31.0.50
>> thanks
>>
>> > read-key only reports the symbol tab-line for clicks in the tab-line,
>> > instead of the mouse event.
>> >
>> > To reproduce:
>> >
>> > emacs -q -nw
>> > M-x xterm-mouse-mode
>> > Show the tab-line, either global-tab-line-mode or
>> > global-window-tool-bar-mode
>> > Then just eval (read-key)
>> >
>> > Clicks in the mode-line or header-line return the underlying mouse
>> > event, but clicks in tab-line-only return the symbol tab-line.
>> >
>> > I believe the following change to read-key fixes this:
>> >
>> > @@ -3074,7 +3074,7 @@ read-key
>> > -                     (memq key '(mode-line header-line
>> > +                     (memq key '(mode-line header-line tab-line
>>
>> Thanks for the fix.  Pushed to master (I guess it's too late for release?)
>
> It's okay to backport this to the release branch.

Please wait until after Emacs 30.1 for now.  Thanks in advance.

Message #19 received at 76408 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, jared <at> finder.org, 76408 <at> debbugs.gnu.org
Subject: Re: bug#76408: 29.4; read-key always returns only tab-line for
 click in tab-line
Date: Wed, 19 Feb 2025 21:12:17 +0200

>>> > I believe the following change to read-key fixes this:
>>> >
>>> > @@ -3074,7 +3074,7 @@ read-key
>>> > -                     (memq key '(mode-line header-line
>>> > +                     (memq key '(mode-line header-line tab-line
>>>
>>> Thanks for the fix.  Pushed to master (I guess it's too late for release?)
>>
>> It's okay to backport this to the release branch.
>
> Please wait until after Emacs 30.1 for now.  Thanks in advance.

This means to backport to Emacs 30.2 later?

Message #22 received at 76408 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, jared <at> finder.org, 76408 <at> debbugs.gnu.org
Subject: Re: bug#76408: 29.4; read-key always returns only tab-line for click
 in tab-line
Date: Wed, 19 Feb 2025 21:20:35 +0000

Juri Linkov <juri <at> linkov.net> writes:

>>>> > I believe the following change to read-key fixes this:
>>>> >
>>>> > @@ -3074,7 +3074,7 @@ read-key
>>>> > -                     (memq key '(mode-line header-line
>>>> > +                     (memq key '(mode-line header-line tab-line
>>>>
>>>> Thanks for the fix.  Pushed to master (I guess it's too late for release?)
>>>
>>> It's okay to backport this to the release branch.
>>
>> Please wait until after Emacs 30.1 for now.  Thanks in advance.
>
> This means to backport to Emacs 30.2 later?

Yes, please.

Message #25 received at 76408 <at> debbugs.gnu.org (full text, mbox):

From: Jared Finder <jared <at> finder.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76408 <at> debbugs.gnu.org,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#76408: 29.4; read-key always returns only tab-line for click
 in tab-line
Date: Tue, 25 Feb 2025 23:25:39 -0800

On 2025-02-19 13:20, Stefan Kangas wrote:
> Juri Linkov <juri <at> linkov.net> writes:
> 
>>>>> > I believe the following change to read-key fixes this:
>>>>> >
>>>>> > @@ -3074,7 +3074,7 @@ read-key
>>>>> > -                     (memq key '(mode-line header-line
>>>>> > +                     (memq key '(mode-line header-line tab-line
>>>>> 
>>>>> Thanks for the fix.  Pushed to master (I guess it's too late for 
>>>>> release?)
>>>> 
>>>> It's okay to backport this to the release branch.
>>> 
>>> Please wait until after Emacs 30.1 for now.  Thanks in advance.
>> 
>> This means to backport to Emacs 30.2 later?
> 
> Yes, please.

I just want to make sure this doesn't get forgotten.

  -- MJF

Message #28 received at 76408 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Jared Finder <jared <at> finder.org>
Cc: 76408 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#76408: 29.4; read-key always returns only tab-line for
 click in tab-line
Date: Thu, 27 Feb 2025 20:59:55 +0200

fixed 76408 30.1.50
thanks

>>>>>> > I believe the following change to read-key fixes this:
>>>>>> >
>>>>>> > @@ -3074,7 +3074,7 @@ read-key
>>>>>> > -                     (memq key '(mode-line header-line
>>>>>> > +                     (memq key '(mode-line header-line tab-line
>>>>>> Thanks for the fix.  Pushed to master (I guess it's too late for
>>>>>> release?)
>>>>> It's okay to backport this to the release branch.
>>>> Please wait until after Emacs 30.1 for now.  Thanks in advance.
>>> This means to backport to Emacs 30.2 later?
>> Yes, please.
>
> I just want to make sure this doesn't get forgotten.

Thanks for the reminder, now backported to emacs-30.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.