From unknown Fri Jun 20 07:11:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#7640 <7640@debbugs.gnu.org> To: bug#7640 <7640@debbugs.gnu.org> Subject: Status: [PATCH] lisp/finder.el: Define used buffer names in variables Reply-To: bug#7640 <7640@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:11:42 +0000 retitle 7640 [PATCH] lisp/finder.el: Define used buffer names in variables reassign 7640 emacs submitter 7640 Jari Aalto severity 7640 wishlist tag 7640 patch wontfix thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 14 13:21:41 2010 Received: (at submit) by debbugs.gnu.org; 14 Dec 2010 18:21:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSZVM-0004xo-FP for submit@debbugs.gnu.org; Tue, 14 Dec 2010 13:21:40 -0500 Received: from emh03.mail.saunalahti.fi ([62.142.5.109]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSZVJ-0004xY-Cg for submit@debbugs.gnu.org; Tue, 14 Dec 2010 13:21:39 -0500 Received: from saunalahti-vams (vs3-12.mail.saunalahti.fi [62.142.5.96]) by emh03-2.mail.saunalahti.fi (Postfix) with SMTP id 89831EBA78 for ; Tue, 14 Dec 2010 20:27:50 +0200 (EET) Received: from emh04.mail.saunalahti.fi ([62.142.5.110]) by vs3-12.mail.saunalahti.fi ([62.142.5.96]) with SMTP (gateway) id A05C83561BA; Tue, 14 Dec 2010 20:27:50 +0200 Received: from picasso.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh04.mail.saunalahti.fi (Postfix) with ESMTP id 6340141BE4 for ; Tue, 14 Dec 2010 20:27:48 +0200 (EET) From: Jari Aalto To: submit@debbugs.gnu.org Subject: [PATCH] lisp/finder.el: Define used buffer names in variables Mail-Copies-To: poster Date: Tue, 14 Dec 2010 20:27:48 +0200 Message-ID: <87mxo843bv.fsf@picasso.cante.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Antivirus: VAMS X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) --=-=-= Content-Type: text/plain Package: emacs Version: 23.2+1-5.1 Severity: wishlist Instead of using hardcoded buffer names, define and use variables `finder-keyword-buffer-name' abd `finder-commentary-buffer-name'. This patch is against Git: 1595eb5 2010-12-14 Merge branch 'master' of git://git.sv.gnu.org/emacs 2010-12-14 Jari Aalto * finder.el (finder-keyword-buffer-name): New variable. (finder-commentary-buffer-name): New variable. (finder-list-keywords): Use `finder-keyword-buffer-name'. (finder-commentary): Use `finder-commentary-buffer-name'. -- System Information Debian Release: squeeze/sid APT Prefers testing APT policy: (990, testing) (500, unstable) (1, experimental) Architecture: amd64 Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Fri Sep 17 21:50:19 UTC 2010 x86_64 GNU/Linux Locale: LANG=en_DK.UTF-8 -- Versions of packages `emacs depends on'. Depends: emacs23 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-lucid 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-nox 23.2+1-5.1 GNU Emacs is the extensible self-documenting --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-finder.el-Define-used-buffer-names-in-variables.patch >From 71ed9690581ba917c6683ce45855dc1b95f573f4 Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Tue, 14 Dec 2010 20:24:06 +0200 Subject: [PATCH] finder.el: Define used buffer names in variables. Organization: Private Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Instead of using hardcoded buffer names, define and use variables `finder-keyword-buffer-name' abd `finder-commentary-buffer-name'. Signed-off-by: Jari Aalto --- lisp/finder.el | 16 +++++++++++----- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/lisp/finder.el b/lisp/finder.el index 655ad53..9bfbdeb 100644 --- a/lisp/finder.el +++ b/lisp/finder.el @@ -35,6 +35,12 @@ (require 'find-func) ;for find-library(-suffixes) (require 'finder-inf nil t) +(defconst finder-keyword-buffer-name "*Finder*" + "Name of the byffer displayed by `finder-list-keywords'.") + +(defconst finder-commentary-buffer-name "*Finder-package*" + "Name of the byffer displayed by `finder-commentary'.) + ;; These are supposed to correspond to top-level customization groups, ;; says rms. (defvar finder-known-keywords @@ -293,9 +299,9 @@ not `finder-known-keywords'." (defun finder-list-keywords () "Display descriptions of the keywords in the Finder buffer." (interactive) - (if (get-buffer "*Finder*") - (pop-to-buffer "*Finder*") - (pop-to-buffer (get-buffer-create "*Finder*")) + (if (get-buffer finder-keyword-buffer-name) + (pop-to-buffer finder-keyword-buffer-name) + (pop-to-buffer (get-buffer-create finder-keyword-buffer-name)) (finder-mode) (let ((inhibit-read-only t)) (erase-buffer) @@ -342,7 +348,7 @@ FILE should be in a form suitable for passing to `locate-library'." (or str (error "Can't find any Commentary section")) ;; This used to use *Finder* but that would clobber the ;; directory of categories. - (pop-to-buffer "*Finder-package*") + (pop-to-buffer finder-commentary-buffer-name) (setq buffer-read-only nil buffer-undo-list t) (erase-buffer) @@ -422,7 +428,7 @@ finder directory, \\[finder-exit] = quit, \\[finder-summary] = help"))) Delete the window and kill all Finder-related buffers." (interactive) (ignore-errors (delete-window)) - (let ((buf "*Finder*")) + (let ((buf finder-keyword-buffer-name)) (and (get-buffer buf) (kill-buffer buf)))) -- 1.7.2.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 12 15:20:34 2012 Received: (at 7640) by debbugs.gnu.org; 12 Apr 2012 19:20:35 +0000 Received: from localhost ([127.0.0.1]:54762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIPZK-0000b1-Np for submit@debbugs.gnu.org; Thu, 12 Apr 2012 15:20:34 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:48575) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIPZH-0000at-VC for 7640@debbugs.gnu.org; Thu, 12 Apr 2012 15:20:33 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SIPXz-0007uj-1U; Thu, 12 Apr 2012 21:19:11 +0200 From: Lars Magne Ingebrigtsen To: Jari Aalto Subject: Re: bug#7640: [PATCH] lisp/finder.el: Define used buffer names in variables References: <87mxo843bv.fsf@picasso.cante.net> X-Now-Playing: His Name Is Alive's _ECLIPX_: "Incinerate Yourself" Date: Thu, 12 Apr 2012 21:19:10 +0200 In-Reply-To: <87mxo843bv.fsf@picasso.cante.net> (Jari Aalto's message of "Tue, 14 Dec 2010 20:27:48 +0200") Message-ID: User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1SIPXz-0007uj-1U X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1334863151.24051@YSuQvGro7xIuJ0Pzq8jkTQ X-Spam-Status: No X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7640 Cc: 7640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Jari Aalto writes: > Instead of using hardcoded buffer names, define and use variables > `finder-keyword-buffer-name' abd `finder-commentary-buffer-name'. What problem is this meant to fix? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 12 16:08:30 2012 Received: (at 7640) by debbugs.gnu.org; 12 Apr 2012 20:08:30 +0000 Received: from localhost ([127.0.0.1]:54898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIQJi-0003O6-9Q for submit@debbugs.gnu.org; Thu, 12 Apr 2012 16:08:30 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:35457) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIQJf-0003Ny-HO for 7640@debbugs.gnu.org; Thu, 12 Apr 2012 16:08:28 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q3CK7AEp021302 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 12 Apr 2012 20:07:11 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q3CK783b015678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 12 Apr 2012 20:07:09 GMT Received: from abhmt119.oracle.com (abhmt119.oracle.com [141.146.116.71]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q3CK78oX013783; Thu, 12 Apr 2012 15:07:08 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 12 Apr 2012 13:07:08 -0700 From: "Drew Adams" To: "'Lars Magne Ingebrigtsen'" , "'Jari Aalto'" References: <87mxo843bv.fsf@picasso.cante.net> Subject: RE: bug#7640: [PATCH] lisp/finder.el: Define used buffer names invariables Date: Thu, 12 Apr 2012 13:07:07 -0700 Message-ID: <01590114995743DAB3410C57651DEE0D@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac0Y4T/CQ1YY9ZluSBmIIbWBvCOnqgABooPw X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090202.4F8735EF.00C1,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 7640 Cc: 7640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > > Instead of using hardcoded buffer names, define and use variables > > `finder-keyword-buffer-name' abd `finder-commentary-buffer-name'. > > What problem is this meant to fix? Hard-coding perhaps? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 29 23:28:55 2012 Received: (at control) by debbugs.gnu.org; 30 Nov 2012 04:28:55 +0000 Received: from localhost ([127.0.0.1]:45875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TeIDe-0006TF-B8 for submit@debbugs.gnu.org; Thu, 29 Nov 2012 23:28:54 -0500 Received: from mail-pb0-f44.google.com ([209.85.160.44]:35286) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TeIDb-0006T3-7G for control@debbugs.gnu.org; Thu, 29 Nov 2012 23:28:52 -0500 Received: by mail-pb0-f44.google.com with SMTP id uo1so150852pbc.3 for ; Thu, 29 Nov 2012 20:26:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=gHt1ogUS9pX52HeE5/AGbm3rZrJ5bHwHwfZISiI9etw=; b=C76UUwFbuIBxkSomVEP1l4PpuyoBjl/OG+vYRTm14OdMOBN066K+zk38vFy6N1ys9C N1GMaEjIuFG6LB/di/b+ISEp77amLwetwbPfPnbWtezzxQQzztE+/oneN0W1iKalbwL9 VQQfaLn0/uIaNx5lQx306hThEZQAd+Eb1g9JHKG30RAZwv71Scr7fwM27N0r0377RxjB ax6VLYhElS9yEgdsQeDEIa83QAArXf0gLq3BRwLj78ViBKgUch/2lycCZG0hLvzJ7fni Ap/K/33eij3km0V2YaEkK06gBlcIGhH2WSM0MlJLbII8tHFSxJuFYKH9Nd7moxt2NuJ/ BQtQ== Received: by 10.66.78.199 with SMTP id d7mr67650058pax.77.1354249607075; Thu, 29 Nov 2012 20:26:47 -0800 (PST) Received: from ulysses ([155.69.16.180]) by mx.google.com with ESMTPS id oi2sm2332190pbb.62.2012.11.29.20.26.43 (version=SSLv3 cipher=OTHER); Thu, 29 Nov 2012 20:26:45 -0800 (PST) From: Chong Yidong To: control@debbugs.gnu.org Subject: tags 7640 + wontfix Date: Fri, 30 Nov 2012 12:26:40 +0800 Message-ID: <87zk1z90n3.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) tags 7640 + wontfix close 7640 thanks From unknown Fri Jun 20 07:11:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 28 Dec 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator