GNU bug report logs - #76394
mouse-face property not working in tab-bar

Previous Next

Package: emacs;

Reported by: Ship Mints <shipmints <at> gmail.com>

Date: Tue, 18 Feb 2025 15:05:02 UTC

Severity: normal

Tags: patch

Full log


Message #88 received at 76394 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Ship Mints <shipmints <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76394 <at> debbugs.gnu.org
Subject: Re: bug#76394: mouse-face property not working in tab-bar
Date: Sun, 02 Mar 2025 19:15:08 +0200
> It seemed natural to add tab-bar-tab-name-format-mouse-face function to the
> tab-bar-tab-name-format-functions list.  See attached.

Thanks, I've tested your patch, and it works great!

> +(defface tab-bar-tab-highlight
> +  '((t :inherit highlight))
> +  "Tab bar face for highlighting."
> +  :version "31.1"
> +  :group 'tab-bar-faces)

Please use exactly the same style as in 'tab-line-highlight'.

> +(defun tab-bar-tab-name-format-mouse-face (name tab _i)

The arg 'tab' needs an underscore since compilation gives the
warning: Unused lexical argument `tab'.

> +      /* display_tab_bar does not yet support R2L.  */
> +      eassert (row->reversed_p);

Is this still needed?




This bug report was last modified 101 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.