GNU bug report logs - #76375
[PATCH gnome-team] gnu: gnome-shell: Fix substitutions for imports.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76375: closed ([PATCH gnome-team] gnu: gnome-shell: Fix
 substitutions for imports.)
Date: Tue, 18 Feb 2025 08:18:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 18 Feb 2025 17:17:36 +0900
with message-id <87frkby8db.fsf <at> gmail.com>
and subject line Re: [bug#76375] [PATCH gnome-team] gnu: gnome-shell: Fix substitutions for imports.
has caused the debbugs.gnu.org bug report #76375,
regarding [PATCH gnome-team] gnu: gnome-shell: Fix substitutions for imports.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76375: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76375
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: aurtzy <aurtzy <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: aurtzy <aurtzy <at> gmail.com>
Subject: [PATCH gnome-team] gnu: gnome-shell: Fix substitutions for imports.
Date: Mon, 17 Feb 2025 16:15:41 -0500

* gnu/packages/gnome.scm (gnome-shell)[arguments]<#:phases>: Update regexps
for substitutions in 'wrap-programs phase so search paths can be included
again.

Change-Id: Ie3582edbcb1e5712787c9292c449b161c7c9d869
---

Hi!

I noticed the Extensions app was no longer allowing me to view and set up
extensions while testing this branch, and discovered after some investigation
that the substitutions for imports were not applying due to changes in the
file.  Applying this patch fixed it for me.

I didn't pick this up before, but since it looked like Screencast had the same
issue, I applied the same change, which seems to also "re-enable" screen
recording with Screencast.

Cheers,

aurtzy

 gnu/packages/gnome.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c1896336cb..30c93c0ac3 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -9595,7 +9595,7 @@ (define-public gnome-shell
                    '("gnome-shell" "gnome-extensions" "gnome-extensions-app"))
                   (substitute* (string-append #$output "/share/gnome-shell/"
                                               "org.gnome.Shell.Extensions")
-                    (("imports\\.package\\.start" all)
+                    (("^import " all)
                      (string-append "'" gi-typelib-path "'.split(':').forEach("
                                     "path => imports.gi.GIRepository.Repository."
                                     "prepend_search_path(path));\n"
@@ -9604,7 +9604,7 @@ (define-public gnome-shell
                   ;; (i.e. as provided by home-pipewire-service-type)
                   (substitute* (string-append #$output "/share/gnome-shell/"
                                               "org.gnome.Shell.Screencast")
-                    (("imports\\.package\\.start" all)
+                    (("^import " all)
                      (string-append "'" gi-typelib-path "'.split(':').forEach("
                                     "path => imports.gi.GIRepository.Repository."
                                     "prepend_search_path(path));\n"

base-commit: 5e3e1b782b87d5bfe903f978490955cc20a70e5a
-- 
2.48.1

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: aurtzy <aurtzy <at> gmail.com>
Cc: 76375-done <at> debbugs.gnu.org, Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#76375] [PATCH gnome-team] gnu: gnome-shell: Fix
 substitutions for imports.
Date: Tue, 18 Feb 2025 17:17:36 +0900

aurtzy <aurtzy <at> gmail.com> writes:

> * gnu/packages/gnome.scm (gnome-shell)[arguments]<#:phases>: Update regexps
> for substitutions in 'wrap-programs phase so search paths can be included
> again.
>
> Change-Id: Ie3582edbcb1e5712787c9292c449b161c7c9d869
> ---
>
> Hi!
>
> I noticed the Extensions app was no longer allowing me to view and set up
> extensions while testing this branch, and discovered after some investigation
> that the substitutions for imports were not applying due to changes in the
> file.  Applying this patch fixed it for me.
>
> I didn't pick this up before, but since it looked like Screencast had the same
> issue, I applied the same change, which seems to also "re-enable" screen
> recording with Screencast.

Applied, thanks!

-- 
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.