GNU bug report logs - #76359
[PATCH] gnu: supertuxkart: Split assets into separate package.

Previous Next

Full log

Message #11 received at 76359 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <bavier <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 宋文武 <iyzsong <at> envs.net>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Adam Faiz <adam.faiz <at> disroot.org>, 76359 <at> debbugs.gnu.org
Subject: Re: [bug#76359] [PATCH] gnu: supertuxkart: Split assets into separate
 package.
Date: Sun,  2 Mar 2025 04:47:39 +0000

[Message part 1 (text/plain, inline)]

Hi Ludovic,

Thank you for the review.

On 3/1/25 08:35, Ludovic Courtès wrote:
>> +          (uri (svn-reference
>> +                (url "https://svn.code.sf.net/p/supertuxkart/code/stk-assets")
>> +                (revision (string->number commit))))
> How come the assets are at sf.net, in an svn repo, when the rest is in
> Git at github.com?

Their https://supertuxkart.net/Source_control page states simply:

  "SupertTuxKart uses Git for source code, and SVN for data files."

I don't know of any rationale beyond that.

>> +              #~(modify-phases %standard-phases
>> +                  (add-after 'unpack 'copy-code-data
>> +                    (lambda _
>> +                      (copy-recursively
>> +                       (string-append #$supertuxkart-source "/data/")
>> +                       "."))))))
> I’d suggest adding ‘supertuxkart-source’ to the ‘inputs’ field and, in
> the phase above, do:
>
>    (copy-recursively
>      #$(this-package-input (git-file-name "supertuxkart" %supertuxkart-version))
>      ".")

Thank you for the suggestion.  This is indeed better.

Revised patch attached.

`~Eric

[0001-gnu-supertuxkart-Split-assets-into-separate-package.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.