GNU bug report logs -
#76353
[PATCH] Add python2-mode and python2-ts-mode
Previous Next
Full log
Message #37 received at 76353 <at> debbugs.gnu.org (full text, mbox):
On Sun, 2025-03-09 at 20:51 +0900, kobarity wrote:
> Eli Zaretskii wrote:
> >
> > > Date: Fri, 28 Feb 2025 19:15:26 +0900
> > > From: kobarity <kobarity <at> gmail.com>
> > > Cc: Eli Zaretskii <eliz <at> gnu.org>,
> > > stefankangas <at> gmail.com,
> > > tomas <at> tuxteam.de,
> > > shipmints <at> gmail.com,
> > > kevin.legouguec <at> gmail.com,
> > > 76353 <at> debbugs.gnu.org
> > >
> > > kobarity wrote:
> > > > kobarity wrote:
> > > > >
> > > > > Konstantin Kharlamov wrote:
> > > > > >
> > > > > > On Mon, 2025-02-17 at 14:26 +0200, Eli Zaretskii wrote:
> > > > > > > > From: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
> > > > > > > > Date: Mon, 17 Feb 2025 07:57:57 +0300
> > > > > > > >
> > > > > > > > On Mon, 2025-02-17 at 07:53 +0300, Konstantin Kharlamov
> > > > > > > > wrote:
> > > > > > > > > but AFAIK in Emacs this
> > > > > > > > > mandatory, so other than that looks good to me 👍
> > > > > > > >
> > > > > > > > s/mandatory/isn't mandatory
> > > > > > >
> > > > > > > What is...not "mandatory", but "very much desirable", is
> > > > > > > to avoid
> > > > > > > separate commits that must be applied together or not at
> > > > > > > all. Even
> > > > > > > if
> > > > > > > they change different and separate parts of Emacs.
> > > > > >
> > > > > > Sure. A commit should be self-contained functional change,
> > > > > > unrelated
> > > > > > to other commits (unless the opposite is desired by
> > > > > > maintainers for
> > > > > > specific reasons, which happens rarely). It is kobarity's
> > > > > > case though,
> > > > > > because kobarity mentioned the change may be sent
> > > > > > separately 😊
> > > > >
> > > > > I agree that it is better to fix the separate issues in their
> > > > > own
> > > > > patches, and since I think the discussion of adding a
> > > > > `python2-mode'
> > > > > will take a bit of time, I have sent the FFAP fix to
> > > > > 76364 <at> debbugs.gnu.org. The FFAP fix is small and I expect it
> > > > > to be
> > > > > accepted relatively quickly. Once the fix is committed, I
> > > > > will rebase
> > > > > the `python2-mode' patch.
> > > >
> > > > As 76364 is committed, I rebased the `python2-mode' patch.
> > >
> > > Any other comments or suggestions? People who only use Python 3
> > > are
> > > also welcome to try this patch.
> >
> > Should we now install the patch?
>
> Well, so far there is no opposition to this patch. However, there is
> also only one person in favor. Personally, I think this patch is
> better than the current `python-2-support', but I'm not sure if we
> agreed or not.
The patch/idea seems good! 👍 Last few weeks I didn't have to work with
Python though, so couldn't test the patch, sorry. But I did look the
patch back when you posted it and it looks fine to me.
This bug report was last modified 100 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.