Subject: Re: [bug#76351] [PATCH] gnu: Add emacs-nushell-mode.

From: Ian Eure <[email-masked]>
Date: Mon, 17 Feb 2025 10:14:07 -0800

Hi Skylar,

Skylar Hill <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-nushell-mode): New variable.
>
> Change-Id: I216d8a9f7e7f89e379174a5d93020ff44c69d51f
> ---
>  gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm 
> b/gnu/packages/emacs-xyz.scm
> index c006f1d912..d2bdd7b52d 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -35629,6 +35629,27 @@ (define-public emacs-ntlm
>  implementation of Windows NT and LanManager compatible password 
>  encryption.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-nushell-mode
> +  (package
> +    (name "emacs-nushell-mode")
> +    (version "20231204.1233")

This needs to use `git-version'.  While the package has no tagged 
releases, nushell-mode.el has 0.1.0 declared as its version[1], so 
using that is preferable to using a date.

You can look at other package in emacs-xyz.scm if you need an 
example of how to version a package built off a Git snapshot; 
emacs-0x0 is one that does.

Thanks,

  -- Ian

[1]: 
https://github.com/mrkkrp/nushell-mode/blob/c179c3cf573b2cc9421dc08bf47e2d619c7791ee/nushell-mode.el#L10