From unknown Sat Aug 16 22:00:51 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#76342 <76342@debbugs.gnu.org> To: bug#76342 <76342@debbugs.gnu.org> Subject: Status: [PATCH] Shepherd: build: Pass CFLAGS, CPPFLAGS and LDFLAGS to CC. Reply-To: bug#76342 <76342@debbugs.gnu.org> Date: Sun, 17 Aug 2025 05:00:51 +0000 retitle 76342 [PATCH] Shepherd: build: Pass CFLAGS, CPPFLAGS and LDFLAGS to= CC. reassign 76342 guix-patches submitter 76342 Simon Josefsson severity 76342 normal tag 76342 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 16 12:22:06 2025 Received: (at submit) by debbugs.gnu.org; 16 Feb 2025 17:22:07 +0000 Received: from localhost ([127.0.0.1]:36764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tjiLG-00057W-GY for submit@debbugs.gnu.org; Sun, 16 Feb 2025 12:22:06 -0500 Received: from lists.gnu.org ([2001:470:142::17]:54712) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tjiLB-00056L-Nn for submit@debbugs.gnu.org; Sun, 16 Feb 2025 12:22:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tjiL2-00010n-N9 for guix-patches@gnu.org; Sun, 16 Feb 2025 12:21:52 -0500 Received: from uggla.sjd.se ([2001:9b1:8633::107]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tjiKz-0005OK-MX for guix-patches@gnu.org; Sun, 16 Feb 2025 12:21:52 -0500 DKIM-Signature: v=1; a=ed25519-sha256; q=dns/txt; c=relaxed/relaxed; d=josefsson.org; s=ed2303; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description; bh=7vWri9MAwqwXFg5KflWZ+KQzdWwqcLftNQSDBxmaF6g=; t=1739726499; x=1740936099; b=4C5sJP/KLEPhLJCO/QGQnvvDdulfNeu3MVSQNaxhmifUPda 2WhVl70sSf1fne0Tx4czxmyzHpOJEQv+ZthncDw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=josefsson.org; s=rsa2303; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description; bh=7vWri9MAwqwXFg5KflWZ+KQzdWwqcLftNQSDBxmaF6g=; t=1739726499; x=1740936099; b=K+EcIl+1R9V64cmM44Bc+Iivn0MxHfmLEqmOuySBjUTvC/1 S/Q2y+dmyNs06yFm1pDhECFsh6dqAjkQrN2YT6b2aKVIFLDUGwRLx/X/VDprIiw4Er30+asahGPQO OKpveDSfDzM1mGTSjjT5Zr/Gm9k1/t8GfeejSPlx7E/eisdx0x11r1NRalZE1VQ6lXyoBCj9ABYUj e9Ytq1mCPbaw/YaijsQTxcFRd2nEWTuOU5y7GTyLkSzHCk44rPZtJm9TcFklzZ8p9uKAKdltZYtZM ha66c367mFDdAsBUjkFU2qE2iOZmEVue5qDHP+CK06J90NewNDwIUvY40KKNIcN+V0bjLYOFqG1MW BwgfztWBkmnHRBesqbG8Grms9zsVwkp9PwXnVzHKWMIQ+ry82hyKbq2zYy5XZbOC/dtF1rsxeSMl1 JF2EjM3+7UnjZ8xEbcjOUDd8; Received: from h-178-174-130-130.a498.priv.bahnhof.se ([178.174.130.130]:57184 helo=kaka) by uggla.sjd.se with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tjiKk-00BIpw-7q for guix-patches@gnu.org; Sun, 16 Feb 2025 17:21:34 +0000 From: Simon Josefsson To: guix-patches@gnu.org Subject: [PATCH] build: Pass CFLAGS, CPPFLAGS and LDFLAGS to CC. OpenPGP: id=B1D2BD1375BECB784CF4F8C4D73CF638C53C06BE; url=https://josefsson.org/key-20190320.txt X-Hashcash: 1:23:250216:guix-patches@gnu.org::gI+p0Q5b6/M0/xTs:ZVV0 Date: Sun, 16 Feb 2025 18:21:41 +0100 Message-ID: <87frkdls9m.fsf@josefsson.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=2001:9b1:8633::107; envelope-from=simon@josefsson.org; helo=uggla.sjd.se X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hi The Debian QA linters noticed that some CC flags were missing, and this patch fixes it. It seems the default CFLAGS for me is '-O2 -g' when running ./configure so I dropped those since they were added twice otherwise. Maye -Wall should be moved to a Makefile.am AM_CFLAGS (or something), but the attached patch seems sufficient to silences Debian's "blhc" tool which is my main concern. https://salsa.debian.org/debian/shepherd/-/jobs/7100765 400:CFLAGS missing (-fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection): \ gcc -O2 -g -Wall -shared -fPIC -o "etc/crash-handler.so" "etc/crash-handler.c" 400:CPPFLAGS missing (-D_FORTIFY_SOURCE=2): \ gcc -O2 -g -Wall -shared -fPIC -o "etc/crash-handler.so" "etc/crash-handler.c" 400:LDFLAGS missing (-Wl,-z,relro): \ gcc -O2 -g -Wall -shared -fPIC -o "etc/crash-handler.so" "etc/crash-handler.c" /Simon --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-build-Pass-CFLAGS-CPPFLAGS-and-LDFLAGS-to-CC.patch Content-Transfer-Encoding: quoted-printable From=20fdaeac0a71f3bdd1daaafffc46647f05e019ac10 Mon Sep 17 00:00:00 2001 From: Simon Josefsson Date: Sun, 16 Feb 2025 16:11:04 +0100 Subject: [PATCH] build: Pass CFLAGS, CPPFLAGS and LDFLAGS to CC. * Makefile.am (etc/crash-handler.so): Do it. Signed-off-by: Simon Josefsson =2D-- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index aa2edd9..bc87404 100644 =2D-- a/Makefile.am +++ b/Makefile.am @@ -107,7 +107,7 @@ install-crash-handler: =20 etc/crash-handler.so: etc/crash-handler.c $(AM_V_GEN)$(MKDIR_P) etc; \ =2D $(CC) -O2 -g -Wall -shared -fPIC -o "$@" "$^" + $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) -Wall -shared -fPIC -o "$@" "$^" =20 CLEANFILES +=3D etc/crash-handler.so =20 =2D-=20 2.48.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQNoBAEWCAMQFiEEo8ychwudMQq61M8vUXIrCP5HRaIFAmeyHqUUHHNpbW9uQGpv c2Vmc3Nvbi5vcmfCHCYAmDMEXJLOtBYJKwYBBAHaRw8BAQdACIcrZIvhrxDBkK9f V+QlTmXxo2naObDuGtw58YaxlOu0JVNpbW9uIEpvc2Vmc3NvbiA8c2ltb25Aam9z ZWZzc29uLm9yZz6IlgQTFggAPgIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgBYh BLHSvRN1vst4TPT4xNc89jjFPAa+BQJl/YgIBQkLehFUAAoJENc89jjFPAa+CboA +wUa06RD5e5VTCxvSWtPS75Wq2qBeYGZnf0jvUMxa2n4AP4xkUeAPPnNuMsTm2fs FCDIGaEM2Yn6Vb2huzzT1Fw/BLgzBFySz4EWCSsGAQQB2kcPAQEHQOxTCIOaeXAx I2hIX4HK9bQTpNVei708oNr1Klm8qCGKiPUEGBYIACYCGwIWIQSx0r0Tdb7LeEz0 +MTXPPY4xTwGvgUCZf2IKwUJC3oQqgCBdiAEGRYIAB0WIQSjzJyHC50xCrrUzy9R cisI/kdFogUCXJLPgQAKCRBRcisI/kdFoqdMAQCgH45aseZgIrwKOvUOA9QfsmeE 8GZHYNuFHmM9FEQS6AD6A4x5aYvoY6lo98pgtw2HPDhmcCXFItjXCrV4A0GmJA4J ENc89jjFPAa+GcYA/26YQY05bLtnXiIjTiAzrGQrRXxTHPA8Av7TDFHvIetWAP9s HSoU8OfTwmTiEnGwLlsV7QJclZg3YNz/Ypcp9TqQBrg4BFySz2oSCisGAQQBl1UB BQEBB0AxlRumDW6nZY7A+VCfek9VpEx6PJmdJyYPt3lNHMd6HAMBCAeIfgQYFggA JgIbDBYhBLHSvRN1vst4TPT4xNc89jjFPAa+BQJl/YgwBQkLehDGAAoJENc89jjF PAa+phoA/jrDqIrl/55vUMBhIQv+TP635d2iCTEnyFmbUcP9+gh6APoDsXalVd2c OGxQtSC+TF8PkZMn1TLkJKAjVxr+xx40AgAKCRBRcisI/kdFonUxAPsG72vqnasp Cngtv5bbicLFYdBMWJsRdZmBdNYvdeY3LAEAkmeCdYIScwv5UB6/rYrk1SEUzozD CpcSUYlY5F3JOwE= =1YK/ -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 20 02:52:50 2025 Received: (at 76342) by debbugs.gnu.org; 20 Feb 2025 07:52:50 +0000 Received: from localhost ([127.0.0.1]:59208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tl1MX-00072f-Cn for submit@debbugs.gnu.org; Thu, 20 Feb 2025 02:52:50 -0500 Received: from uggla.sjd.se ([2001:9b1:8633::107]:60570) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tl1MT-000726-Jv; Thu, 20 Feb 2025 02:52:46 -0500 DKIM-Signature: v=1; a=ed25519-sha256; q=dns/txt; c=relaxed/relaxed; d=josefsson.org; s=ed2303; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description; bh=oaFepuZXycu4jC1iyP1CyKQD7DNiBXKmLtZ8B3Lh01s=; t=1740037958; x=1741247558; b=17MwcJDwtc+dsEGiaMftHKKuMjlBjVG9VwonocOoLs7Vb/f 0y4Ux4Kr1Lz/OQYAdZUy3xbG/fsh1iy0hyto7Bg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=josefsson.org; s=rsa2303; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description; bh=oaFepuZXycu4jC1iyP1CyKQD7DNiBXKmLtZ8B3Lh01s=; t=1740037958; x=1741247558; b=MQOEJ2PeKAIKN5fLaLGPgyI0NyHDAOMQqvbkkjf6ifLhpw/ OApJBW/VetRTpWLsv8ASVgC2yVlNQJszER+Z0JxN0kHC++TAtHX/m7xxEyFzlWj26TxI0xGLqjtNJ 02VDFVTiAOXWRleCC7TDdMhzMiAHFC2RO+YhZ8YepxusS+DYAo81P5YudUhRLxQJJ4YuWqPMlCxdf /r4CXM25hTSX37sIiTw/l1d08nxxpMxdGVSH3iSOKDvDEL75B5VOUkc3vjNTON2rtbQfpMY/GAl/g vVQUrz98iqcU2+U0XXHD/PtSINjbIJ4efC+0CqIOU3xwBgW0CbcEWWlnpp5Hz56DXz5xXAJ/aBkjU 7l/cevFnybHm5KoUJclzdRemQZy81eqWZ81KokxZaSWGLVAGze/VlOPaE9t3aEAOscMmEOiF1/qCF 8c1QhJ3IoPa+J+a90Pah/mlC; Received: from h-178-174-130-130.a498.priv.bahnhof.se ([178.174.130.130]:35508 helo=kaka) by uggla.sjd.se with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tl1ML-0006dy-57; Thu, 20 Feb 2025 07:52:37 +0000 From: Simon Josefsson To: 76342@debbugs.gnu.org Subject: retitle 76342 OpenPGP: id=B1D2BD1375BECB784CF4F8C4D73CF638C53C06BE; url=https://josefsson.org/key-20190320.txt X-Hashcash: 1:23:250220:76342@debbugs.gnu.org::x0/Ptz3VhyNAhAXz:3zHu Date: Thu, 20 Feb 2025 08:52:43 +0100 Message-ID: <87zfihvyr8.fsf@josefsson.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76342 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain retitle 76342 [PATCH] Shepherd: build: Pass CFLAGS, CPPFLAGS and LDFLAGS to CC. thanks I forgot to include the word 'Shepherd' in the Subject line... --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQNoBAEWCAMQFiEEo8ychwudMQq61M8vUXIrCP5HRaIFAme230sUHHNpbW9uQGpv c2Vmc3Nvbi5vcmfCHCYAmDMEXJLOtBYJKwYBBAHaRw8BAQdACIcrZIvhrxDBkK9f V+QlTmXxo2naObDuGtw58YaxlOu0JVNpbW9uIEpvc2Vmc3NvbiA8c2ltb25Aam9z ZWZzc29uLm9yZz6IlgQTFggAPgIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgBYh BLHSvRN1vst4TPT4xNc89jjFPAa+BQJl/YgIBQkLehFUAAoJENc89jjFPAa+CboA +wUa06RD5e5VTCxvSWtPS75Wq2qBeYGZnf0jvUMxa2n4AP4xkUeAPPnNuMsTm2fs FCDIGaEM2Yn6Vb2huzzT1Fw/BLgzBFySz4EWCSsGAQQB2kcPAQEHQOxTCIOaeXAx I2hIX4HK9bQTpNVei708oNr1Klm8qCGKiPUEGBYIACYCGwIWIQSx0r0Tdb7LeEz0 +MTXPPY4xTwGvgUCZf2IKwUJC3oQqgCBdiAEGRYIAB0WIQSjzJyHC50xCrrUzy9R cisI/kdFogUCXJLPgQAKCRBRcisI/kdFoqdMAQCgH45aseZgIrwKOvUOA9QfsmeE 8GZHYNuFHmM9FEQS6AD6A4x5aYvoY6lo98pgtw2HPDhmcCXFItjXCrV4A0GmJA4J ENc89jjFPAa+GcYA/26YQY05bLtnXiIjTiAzrGQrRXxTHPA8Av7TDFHvIetWAP9s HSoU8OfTwmTiEnGwLlsV7QJclZg3YNz/Ypcp9TqQBrg4BFySz2oSCisGAQQBl1UB BQEBB0AxlRumDW6nZY7A+VCfek9VpEx6PJmdJyYPt3lNHMd6HAMBCAeIfgQYFggA JgIbDBYhBLHSvRN1vst4TPT4xNc89jjFPAa+BQJl/YgwBQkLehDGAAoJENc89jjF PAa+phoA/jrDqIrl/55vUMBhIQv+TP635d2iCTEnyFmbUcP9+gh6APoDsXalVd2c OGxQtSC+TF8PkZMn1TLkJKAjVxr+xx40AgAKCRBRcisI/kdFoq5GAQCWZm7t+vi/ 1vClklYsI0Wz+dQYCriuob30RwhtzBk4NQD+PFXfIIjhQuAmdI5kMK31JsZhOUFp nLKr7zYDddtFXw4= =fK5j -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 20 17:53:14 2025 Received: (at 76342-done) by debbugs.gnu.org; 20 Feb 2025 22:53:15 +0000 Received: from localhost ([127.0.0.1]:44318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlFPt-0001v9-RD for submit@debbugs.gnu.org; Thu, 20 Feb 2025 17:53:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40464) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlFPq-0001u7-A8 for 76342-done@debbugs.gnu.org; Thu, 20 Feb 2025 17:53:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlFPk-0008IO-11; Thu, 20 Feb 2025 17:53:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=9zwPUX+Jz6mz4JmWDX1CXIGFrVuWZAg6Qa+1/BgUVz8=; b=fGLeA77dZi95eYZKnywy c6Q1ZPjKduGIuy13zRMmQ8mSJyhmsk/Hd6jO3xFTiDT92LIu09dNKkn9JVOc1+mcf6Ig/EYnHBklG csZvbBi3Kullf7fgtCvQGyVkzaW15gGjDDkWPEQPduoBwxO1LEdL8yvgYbRKmrFflT/Z5JIJKJHu8 UMbI1dvFTLDS3XQhmg2wlj3Yb5Q0Xe4NnSjhcEfBe5pW+RwWvgIUZplr7XQ6l/66Z1ZDh+ONvMmNU GNVGPYYbaK79N2v5K1uggOfxeqNSWeGXws0w9CRzIU+CBn41PEa53bWERk8Eeak0nJsE3j+WLiBEq 3pmOg3Tg5fjCYg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon Josefsson Subject: Re: [bug#76342] [PATCH] build: Pass CFLAGS, CPPFLAGS and LDFLAGS to CC. In-Reply-To: <87frkdls9m.fsf@josefsson.org> (Simon Josefsson's message of "Sun, 16 Feb 2025 18:21:41 +0100") References: <87frkdls9m.fsf@josefsson.org> Date: Thu, 20 Feb 2025 23:53:00 +0100 Message-ID: <871pvsfctv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76342-done Cc: 76342-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Simon, Simon Josefsson skribis: > From fdaeac0a71f3bdd1daaafffc46647f05e019ac10 Mon Sep 17 00:00:00 2001 > From: Simon Josefsson > Date: Sun, 16 Feb 2025 16:11:04 +0100 > Subject: [PATCH] build: Pass CFLAGS, CPPFLAGS and LDFLAGS to CC. > > * Makefile.am (etc/crash-handler.so): Do it. > > Signed-off-by: Simon Josefsson Applied, thanks! Ludo=E2=80=99. From unknown Sat Aug 16 22:00:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 21 Mar 2025 11:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator