From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 16 10:58:45 2025 Received: (at submit) by debbugs.gnu.org; 16 Feb 2025 15:58:45 +0000 Received: from localhost ([127.0.0.1]:36456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tjh2a-000658-Hy for submit@debbugs.gnu.org; Sun, 16 Feb 2025 10:58:44 -0500 Received: from lists.gnu.org ([2001:470:142::17]:37870) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tjh2V-00064m-Tp for submit@debbugs.gnu.org; Sun, 16 Feb 2025 10:58:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tjh2Q-0000kY-IP for bug-gnu-emacs@gnu.org; Sun, 16 Feb 2025 10:58:34 -0500 Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tjh2N-0002pU-Ci for bug-gnu-emacs@gnu.org; Sun, 16 Feb 2025 10:58:34 -0500 Received: by mail-oo1-xc2b.google.com with SMTP id 006d021491bc7-5fcd665af4eso87383eaf.2 for ; Sun, 16 Feb 2025 07:58:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739721509; x=1740326309; darn=gnu.org; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=8PnY5lcXQOcHmqGrDKY1lQDujLnhVS3+m3akqsFn7bk=; b=ZZo4EVKLJmXG7kxXKvmONUGWPvYFCxC7oZqPHAqDtLUSCjE2i7FP9APQ8n8e5YyAV1 fBV55LhJLWZ0TEBhf9To/x62W/yoL5flbPi5yw1LLPWDRzfPs2EGDBQ4Z7+pxDoX8bVd 1xgpisb2mcPrLS6giqlHXjcVETPYMqhoSU/IlyQxWzcp4zSEm7pU1hKuVzsOIfyvK4Dm vt+DaKfTRZkIdNDxeeJN0rOqA5+AJ8iUX8o7fVCRT6dMu2uUQNnVFP0volL05Xcv0XGX MYfFyeIpT0UD48qItQY5K7u1n8BF+tgmHIHXhyGPiKj+cZC7jrNCoUWJoZ5U7CFX/2kK nBXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739721509; x=1740326309; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8PnY5lcXQOcHmqGrDKY1lQDujLnhVS3+m3akqsFn7bk=; b=g9WgikCWk2SGhQ+8ZLi15FEORQb52hPeZU6mL4Gckc5yJfewj8VwYFgksfS47oyoUI oi+oKpWAVSTZXD/bi6fuo2HzJ0JYAVd+qhT2EhVsreJ2i4T4+78aPJVdlpoZy1+2mLtw RePGHufRDg1LDevz2iQrxyhoFcDkwnKdMDmA3HFsXHoNPY6G24j0PMs7GF5tEHN4ch2F 3AMLHRg285ELqrYEZ+Zxj84fENDEQXZr+mlr7NcJHr8/dD53u5zzBRx465QdPxyM7AzK HBt04SAB6JXWrCX0uHmsBmWkLiAux4dqtW1PNtvwC1Kc74/Syj4MexBCE95lSRtZ+Yuw p1qQ== X-Gm-Message-State: AOJu0YwvfYl7eJ5KzYMpQ/1Xv3c5VCJC6bHhjGsC5s/nDCXAdW+aQ+MI cA9YarjUN44Crh5U86hWe9BxgTofY8euTSN6/cfCM1C/JvQ5KIKG9m5BqA== X-Gm-Gg: ASbGncu5BzlJr34/LD/jUi2JBvWRjJIpWjM3jA3AsKrPyt69bO87gixl5gvqn8Q/7C3 uREG4taVb0Y2Gggc45Qx1tl5Ln3m/EKjpl8m1RZY1SAuGHCnqleR6S90yzqfoCTegf42EHX8tRT nYpObeOMH+BEZbp1+cSrYaEnFfnp4ilIC3RlxvcTWR69RK1ZvT/pXWyRC6VLTaER4WKCLBQzh6I 7ELx/YS6/RkhJGfCnUQbBWgwgjJ+1TEHrfXMfKJ7k8GeTfLKF84MOOQF1R6Mh6WJLKvPje9krRV lKBiCh9kIQ75cFD9D4MaYw== X-Google-Smtp-Source: AGHT+IEorymOUj1g2opXrrRla4Pmsv/T4MDpBYUbciwGeSV/yOFkkxZH1Su54GdDrxxvC1VXnaEQ6w== X-Received: by 2002:a05:6808:2e8d:b0:3f3:e6a2:34b9 with SMTP id 5614622812f47-3f3eb12db4dmr3750283b6e.37.1739721508742; Sun, 16 Feb 2025 07:58:28 -0800 (PST) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f3fb699ac4sm74651b6e.40.2025.02.16.07.58.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Feb 2025 07:58:28 -0800 (PST) Message-ID: <53268650-b3ac-4915-a56a-e3e71280f51a@gmail.com> Date: Sun, 16 Feb 2025 12:58:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Mauro Aranda Subject: 31.0.50; Confusing prompt after C-q Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::c2b; envelope-from=maurooaranda@gmail.com; helo=mail-oo1-xc2b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) After emacs -Q: C-q Wait for a little while and read: C-q- ( for help) I think that if there's no key to press for help, that message shouldn't show up. In GNU Emacs 31.0.50 (build 17, x86_64-pc-linux-gnu, GTK+ Version  3.24.33, cairo version 1.16.0) of 2025-02-16 built on tbb-desktop Repository revision: 918bd2a7f09cfb5e73adbed9f9f229e9a0a1955b Repository branch: widget-dev Windowing system distributor 'The X.Org Foundation', version 11.0.12201001 System Description: Ubuntu 22.04.5 LTS Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINERAMA XINPUT2 XPM XRANDR GTK3 ZLIB Important settings:   value of $LC_MONETARY: es_AR.UTF-8   value of $LC_NUMERIC: es_AR.UTF-8   value of $LC_TIME: es_AR.UTF-8   value of $LANG: en_US.UTF-8   value of $XMODIFIERS: @im=ibus   locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect:   tooltip-mode: t   global-eldoc-mode: t   eldoc-mode: t   show-paren-mode: t   electric-indent-mode: t   mouse-wheel-mode: t   tool-bar-mode: t   menu-bar-mode: t   file-name-shadow-mode: t   global-font-lock-mode: t   font-lock-mode: t   blink-cursor-mode: t   minibuffer-regexp-mode: t   line-number-mode: t   indent-tabs-mode: t   transient-mark-mode: t   auto-composition-mode: t   auto-encryption-mode: t   auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process tty-child-frames emacs) Memory information: ((conses 16 39181 9293) (symbols 48 5415 0) (strings 32 12632 2403)  (string-bytes 1 303848) (vectors 16 9388)  (vector-slots 8 112562 6592) (floats 8 21 3) (intervals 56 234 0)  (buffers 992 10)) From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 18 21:09:03 2025 Received: (at control) by debbugs.gnu.org; 19 Feb 2025 02:09:03 +0000 Received: from localhost ([127.0.0.1]:37394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tkZWJ-0004tz-39 for submit@debbugs.gnu.org; Tue, 18 Feb 2025 21:09:03 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:43127) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tkZWG-0004t2-O1 for control@debbugs.gnu.org; Tue, 18 Feb 2025 21:09:01 -0500 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5e050b1491eso715322a12.0 for ; Tue, 18 Feb 2025 18:09:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739930934; x=1740535734; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=x9nchTsTEQF6YLoyRyV2qEFM4xH1kTaWR40M99vVtTw=; b=VYoNgimybNsFGBJv4lJUWjuUm1h4n5kqFbvNUhNJwqwrRzFyxMK6wsDrEvJiTuheVD LtRSycq75t4XATh0tIa/v24IKghsc56VNALMrGq6P7d7iXtvXAg0iCOpk2sahVLZ94he 1HMkExWfHgcg6AnWaIu7YE+MM2yUCm6UIVFr4lB7Uk2EhHkWqImdKLKRAuMYpipCw5KX y0+n8wBN07PZDhio2DxaNtoTnkcW4idsZ4nD9D3oEO9jZdcrtrUke1BL3ahCLhiuQ5a6 85artmoHLfPPqLNdyFtEkTL3meiAWdMdRqnBjOMdiB1qf7jwJzVwQvdZGaB48Y+TUA81 +9ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739930934; x=1740535734; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=x9nchTsTEQF6YLoyRyV2qEFM4xH1kTaWR40M99vVtTw=; b=igsoSJockqxWwkRAmHWVnOuhIyB+tQLcjKmoDXfD+kV5glJJ8rX0QkedxB3XTsT3hQ Od0X9Xviv7yQ3Y8i57hcHPoAPmrBDPBlhfTKImvg626GutN6DixSgTLsztd2vA8gxVT0 X8wpqqRILvHtzTnnEG6z4CWGsp9phrCvJZJ9Zvsm5TJruKk/NygOAHzV6L8u34Yj7yz9 BqAUQNAdyOZvoB1WrkVqrMvtcBN74r353iZxOItb5Pz9pGbkJcbrsXH2BgrIi5cy9OPy UJ2pcHZWM+elmfQB9WtF35r9HURcenoRW6dh4UvWGExUZCRvD+dLxSCslpG35fXvtakz ebPg== X-Gm-Message-State: AOJu0Yxw3f2xMZ1wn0c1bM37rQwbz/ayEtgAAyJt/KI6eRFFDvtP+dby WcsDO+2Ot3OHr9Dq50Giz1SnovQziHqbJyyytjm7t2CQ4gTyqdKJlw+wgrfD8bjNDyS3c3ZcwgB +Jzr1jauhdTlMHggYQgEA6ln3S1bdL5Ol X-Gm-Gg: ASbGncvMPIsNkrepjUQdiFBLRROg9yxsnTw1mwZ9m7u94s3k8shb08V1BNam8GEsC6Q h5uWVrH6FzRlFUkPuRgL6UpbAMtiywiugEpDNVwmAFYi3UicSmMhKyPc53rB5xCWARa2vZ1Drl/ 8= X-Google-Smtp-Source: AGHT+IEyduY/HWdxHxl8bjjNnhQRKhBCLZMU32JBYR5WDXTpPfFJUWkmcuoI4aZ8YyS/03op2gJHC+HxvbsZc2sx0+A= X-Received: by 2002:a05:6402:270d:b0:5db:7353:2b5c with SMTP id 4fb4d7f45d1cf-5e088de1863mr1848670a12.11.1739930934549; Tue, 18 Feb 2025 18:08:54 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 18 Feb 2025 18:08:54 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Tue, 18 Feb 2025 18:08:54 -0800 X-Gm-Features: AWEUYZkE2NdgObYrYqRjwo1JUIhtJ3XO1g1eNUIZ2_V1m5KXBURJ2ivvL2rm6Ms Message-ID: Subject: control message for bug #76341 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 76341 minor quit From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 07:25:29 2025 Received: (at 76341) by debbugs.gnu.org; 22 Feb 2025 12:25:29 +0000 Received: from localhost ([127.0.0.1]:50274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tloZU-0000jE-8n for submit@debbugs.gnu.org; Sat, 22 Feb 2025 07:25:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44360) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tloZO-0000eC-Dg for 76341@debbugs.gnu.org; Sat, 22 Feb 2025 07:25:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tloZI-0006FI-Cb; Sat, 22 Feb 2025 07:25:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ePbJLEh7gkJaejveDl+pb24xNLuBHbTQMHquUR+vqlE=; b=KCyFXlGfuDgq z4j3jcBS5b8ZXwE8IEnY7jzzIvX2SyvMpF7cYdFglVLig+16kWmNMX/YGixIiQL/XahY+w2ky5l/G 1zTn6CLCnPzNp/cJhziJ2cADl7d5NzUOPgVBL+QoyRFcbPNjDo9wPezj2UaGPac+KPMHIzXzERTQx PC7fcFfCfkONffhDTwS40AR0tTWxcUXgabrlwheL8Vlrf5ZTojF5aPv0v8r4V43coFLuDOue0Jn+a TkbdYEYqDRradUcD/N4JpVpr49ZFsD++iHq4tChWE//dH3DtkcStjLax3kqUnCLTShvE5J59jiQRT NpwuZ6+X4kRe/xjAPRtz+A==; Date: Sat, 22 Feb 2025 14:25:14 +0200 Message-Id: <865xl2jhed.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda , Stefan Monnier In-Reply-To: <53268650-b3ac-4915-a56a-e3e71280f51a@gmail.com> (message from Mauro Aranda on Sun, 16 Feb 2025 12:58:25 -0300) Subject: Re: bug#76341: 31.0.50; Confusing prompt after C-q References: <53268650-b3ac-4915-a56a-e3e71280f51a@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76341 Cc: 76341@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 16 Feb 2025 12:58:25 -0300 > From: Mauro Aranda > > After emacs -Q: > C-q > > Wait for a little while and read: > C-q- ( for help) > > I think that if there's no key to press for help, that message shouldn't > show up. I agree. But in this case, there _is_ a help key, it just isn't C-h. Please try the patch below. Stefan, do you see a cleaner fix? I didn't want to test the key itself for being [nil], since perhaps it could be [foo bar nil] or somesuch? IOW, what possible forms of key could cause key-description produce "" for its argument? diff --git a/lisp/help.el b/lisp/help.el index 91e0366..6c643e6 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -2200,18 +2200,20 @@ help--append-keystrokes-help (current-active-maps t))))) (catch 'res (dolist (val help-event-list) - (let ((key (vector (if (eql val 'help) - help-char - val)))) - (unless (seq-find (lambda (map) (and (keymapp map) (lookup-key map key))) - bindings) + (let* ((key (vector (if (eql val 'help) + help-char + val))) + (key-desc (key-description key))) + (unless (or (seq-find + (lambda (map) (and (keymapp map) (lookup-key map key))) + bindings) + ;; Reject unhelpful "keys". + (equal key-desc "")) (throw 'res (concat str (substitute-command-keys - (format - " (\\`%s' for help)" - (key-description key)))))))) + (format " (\\`%s' for help)" key-desc))))))) str))) From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 09:11:40 2025 Received: (at 76341) by debbugs.gnu.org; 22 Feb 2025 14:11:40 +0000 Received: from localhost ([127.0.0.1]:52042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlqEF-000348-M1 for submit@debbugs.gnu.org; Sat, 22 Feb 2025 09:11:40 -0500 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:47330) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tlqEC-00032g-M2 for 76341@debbugs.gnu.org; Sat, 22 Feb 2025 09:11:37 -0500 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-221057b6ac4so57828295ad.2 for <76341@debbugs.gnu.org>; Sat, 22 Feb 2025 06:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740233490; x=1740838290; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h+pBQglDR35jjpA7NIlA6DBMhfMetOxr7bEpz2OgIC0=; b=FboX9EAcaRRzdVGsfm1hsWNsFpu1nzBtg9upLJKY0nV0o9VVhrmyVG9tn4bwK3H8my BJn/cemNjJjmUEW2cc+DpdGGGY0hJ+5QJFX2TNsvyGkHi1fVixpJTVF4PR2KD/s4t1VZ t81T3iEuyU5zeOacf+CfwIbF9Q4GsGh6EQ7L9o1NYms8KNgaFQM3IxznOTAx/by3DbaE l2ZIDoDtNQKgYPkoyHHpp9sR3IVCydY8riJB/uuCWsZnuo2VD6OGd/VsnuNAJR9mAqvL B6jqegEatiq2J254Lx7nJPw7U+tppga8vjlv+0lpO+poxPkUD+UHSsGFtuRHX9y8xON4 TtZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740233490; x=1740838290; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h+pBQglDR35jjpA7NIlA6DBMhfMetOxr7bEpz2OgIC0=; b=mrg+3IywEueY4QM/1wTXKHx6ptAgDOJT9WKe8aiQDuKvs5XQYQWN8tNg7Q/UEamo/6 88gUbrCcTuGxhOfKUmA0VKgi5pdObtdGa1se6LhxIPH1VIY1HZ0b2jCMKitAoxdivKEI CQXGqugOiZg4yBhk9VbkVZG3qmqepjAQQbmOFz+CmGJ14t9gBLsNZwHAgu48Ybi4BeVc BHkuLsbE3qxkzNB8VMvMFuH6e/mx6Ect4nArus65yPaS4jVW4BWUkAbdS/uj3k4iGith mZ53Mi2I1S+aIEEehzQGyo+Fe1Pq0n4n1EpFEye4qQZwDBS2bi9DWtTEKjYv6XVETJDp lESA== X-Gm-Message-State: AOJu0YwiOnSwoTrYCnNvkzg/OVCJ7bPWJj0yYW7BRIulghbKKUQJSTfg l6ddZgovCIcT/zUbaAv4R6jW0IMaS6J4p3rYIwqVLjr0oGts4eM4OxWWzQ== X-Gm-Gg: ASbGncvN2Dryd1q63gyO7/hOH619VaGnuye9PbcTRhBk4M3VJlrIJ34B28qXXSgXO6d 7cXteVn6dWMY6Nbe1mrDRVMrtmwKaO6nbBIIBPaILzCSs+fl9PKo3zpCynXk5iKYptP0/OadFBE 3UlePjPWPQwzLkX+34Bq4z2WdqODDIWQxV5rlKTUC4VaK+vvdtB3Q7wj0D+5ImjRQYKyVHBj59t ajJPgfkvC22o5sRYTnSDZtwNxImnawoSo/S12pc+rlguwou0IuFlP5ajmIFBUwAie5p743ZtPiQ TdyaVNFo4WtrbUPo6hwEuuXWgYepU8s0 X-Google-Smtp-Source: AGHT+IFQG7TUvaU44rp2H9DmJ8MnELLU2zUDWKO93rsyQGW4XxM77yaFgCsk7NiCGyR13W/aMsOKXQ== X-Received: by 2002:a17:902:e542:b0:220:ff3f:6cc0 with SMTP id d9443c01a7336-221a1191974mr117562335ad.38.1740233490518; Sat, 22 Feb 2025 06:11:30 -0800 (PST) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d53491b3sm151328425ad.40.2025.02.22.06.11.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Feb 2025 06:11:30 -0800 (PST) Message-ID: <674f2761-15e9-494f-b88f-bea8f46f4300@gmail.com> Date: Sat, 22 Feb 2025 11:11:27 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#76341: 31.0.50; Confusing prompt after C-q To: Eli Zaretskii , Stefan Monnier References: <53268650-b3ac-4915-a56a-e3e71280f51a@gmail.com> <865xl2jhed.fsf@gnu.org> Content-Language: en-US From: Mauro Aranda In-Reply-To: <865xl2jhed.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76341 Cc: 76341@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Sun, 16 Feb 2025 12:58:25 -0300 >> From: Mauro Aranda >> >> After emacs -Q: >> C-q >> >> Wait for a little while and read: >> C-q- ( for help) >> >> I think that if there's no key to press for help, that message shouldn't >> show up. > > I agree.  But in this case, there _is_ a help key, it just isn't C-h. I didn't know that :-). > Please try the patch below. Works great, thank you. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 09:41:38 2025 Received: (at 76341) by debbugs.gnu.org; 22 Feb 2025 14:41:39 +0000 Received: from localhost ([127.0.0.1]:52509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlqhF-0007tW-O3 for submit@debbugs.gnu.org; Sat, 22 Feb 2025 09:41:38 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43680) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlqhC-0007sK-PE for 76341@debbugs.gnu.org; Sat, 22 Feb 2025 09:41:35 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 193AD4415FE; Sat, 22 Feb 2025 09:41:28 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1740235287; bh=Xforo1vgkoAEg84qYcuyEaL36XT6aQi5SZ0Z2P993w0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oHn89KZ2EvRU6hvhznG4IgLuNCwmjQfBNDE7OI7c+8hc/NpVMRhc4h6lARFyEuGpn PZBUMyd0YKH03WoZAqtjzM6wkbwjv5C9ywSbNjShaCdHA1Uux3XWXwWZmqu1Px5kyd vH5j5wZwwzK/Sq4lFVdLnWUqax3OJ0IyOBjQAUPElI+YgT8bg7hMfTBG+o6YSDTaxk dmJmVEvV9DC0cQulKQvbOs9iO2xTa32+cRIjKxWj7cHrRHW+Vzbsw0C27wgKKSrtTt hjnsKp3QnVPznuqJY7eRfVF9P+imakJ3SQ8yYSPenzy+rFoXqax6uA9fxoxc8R5ELA ewZ1lTRzqBdeA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1A87344095C; Sat, 22 Feb 2025 09:41:27 -0500 (EST) Received: from pastel (unknown [104.247.242.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E22941201E6; Sat, 22 Feb 2025 09:41:26 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#76341: 31.0.50; Confusing prompt after C-q In-Reply-To: <865xl2jhed.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 22 Feb 2025 14:25:14 +0200") Message-ID: References: <53268650-b3ac-4915-a56a-e3e71280f51a@gmail.com> <865xl2jhed.fsf@gnu.org> Date: Sat, 22 Feb 2025 09:41:25 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.472 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76341 Cc: 76341@debbugs.gnu.org, Mauro Aranda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Stefan, do you see a cleaner fix? I didn't want to test the key > itself for being [nil], since perhaps it could be [foo bar nil] or > somesuch? IOW, what possible forms of key could cause key-description > produce "" for its argument? We call `vector` ourselves with a single arg, so it has to be a one-element vector, no? I don't really understand all this code, but looking at the immediate problem, I'd go with a patch like the one below. Stefan diff --git a/lisp/help.el b/lisp/help.el index eed52dadf24..48401b8f6dd 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -2198,9 +2198,8 @@ (current-active-maps t))))) (catch 'res (dolist (val help-event-list) - (let ((key (vector (if (eql val 'help) - help-char - val)))) + (when (setq val (if (eql val 'help) help-char val)) + (let ((key (vector val))) (unless (seq-find (lambda (map) (and (keymapp map) (lookup-key map key))) bindings) (throw 'res @@ -2209,7 +2208,7 @@ (substitute-command-keys (format " (\\`%s' for help)" - (key-description key)))))))) + (key-description key))))))))) str))) From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 11:00:46 2025 Received: (at 76341) by debbugs.gnu.org; 22 Feb 2025 16:00:47 +0000 Received: from localhost ([127.0.0.1]:56893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlrvn-000793-R6 for submit@debbugs.gnu.org; Sat, 22 Feb 2025 11:00:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59956) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlrvR-000720-2C for 76341@debbugs.gnu.org; Sat, 22 Feb 2025 11:00:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlrvK-0005dm-H5; Sat, 22 Feb 2025 11:00:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nkZjgpdyuwY316L7UL7VHW87ah+9UQ5ftxpVW7GdkbE=; b=TFML339gR70+ U8s9LDH5xf95/3Yx+H7L132uGWXyfIZ32OjHhTi+t0mfVRftXnaheQyqbikoEoLo3xr6waneBnpKl mFPP8c5H25tD4RhUP54Z5c3tii66Jrabd/JdeqwabMzCkJ2g5hDrj5d4KN81M3MLdQPZcknc80eyj ZwOAf0gRvUTbP06YdHNIbLGSuugIw+iDcIwUd47RBYtM71XnkpZu1MPnrcrpC1UNN6HKJE3KK7OWb 13RzCiNQ6wuNA5xik/v26lzCumOBb4T0FBVuZHH3BtHsjOSCAf9yTgSAGCPrVJW1mnegGiqpOMh0K o1f3uyEQIlkk+YmrYWUqBg==; Date: Sat, 22 Feb 2025 18:00:02 +0200 Message-Id: <86o6yuhsvx.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sat, 22 Feb 2025 09:41:25 -0500) Subject: Re: bug#76341: 31.0.50; Confusing prompt after C-q References: <53268650-b3ac-4915-a56a-e3e71280f51a@gmail.com> <865xl2jhed.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76341 Cc: 76341@debbugs.gnu.org, maurooaranda@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Mauro Aranda , 76341@debbugs.gnu.org > Date: Sat, 22 Feb 2025 09:41:25 -0500 > > I don't really understand all this code, but looking at the immediate > problem, I'd go with a patch like the one below. Thanks, that looks cleaner, so please feel free to install. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 14:58:19 2025 Received: (at 76341-done) by debbugs.gnu.org; 22 Feb 2025 19:58:19 +0000 Received: from localhost ([127.0.0.1]:57277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlvdi-0004b0-MM for submit@debbugs.gnu.org; Sat, 22 Feb 2025 14:58:18 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:23776) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlvde-0004af-Nx for 76341-done@debbugs.gnu.org; Sat, 22 Feb 2025 14:58:16 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 05BBF440979; Sat, 22 Feb 2025 14:58:08 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1740254287; bh=idEqzuclpriQAS/HtH+B0YhBIaKRFpp+XIEwcrbtVKE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VB4OCxdinLPaX/O/66OFzeHDwrbB2axUr+T71i7/zT0eiG9cgHPxGSGvGp/wJIaj+ fwlEgTYKAgc9Qw/mIZWj4xBTmDIHFZsiO6N+InmrFCrTyOrDcPca1oUIqxC/W3l1NZ R5NGbtOH7gsgWCJDKUWsQJoZLCaRVVQbcRG+QjuHEZ9nQT/5rY5Iz5/qnZIWHrctao 4uRPISaN1PzYkk3qdxq56+ABt+B7rOZlAnmB+odDoewPFLSd9UQ89hnjkiSBr8wmKf Y3AFytB2Z/hOVQ8eHtrG7qX6heN1U8FUkDBN2BNNsJPxpUJ6DK2WVcMlQmPFdSsLW+ ipF8u+Lx564/w== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1F545441316; Sat, 22 Feb 2025 14:58:07 -0500 (EST) Received: from pastel (unknown [104.247.242.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EC0491204F5; Sat, 22 Feb 2025 14:58:06 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#76341: 31.0.50; Confusing prompt after C-q In-Reply-To: <86o6yuhsvx.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 22 Feb 2025 18:00:02 +0200") Message-ID: References: <53268650-b3ac-4915-a56a-e3e71280f51a@gmail.com> <865xl2jhed.fsf@gnu.org> <86o6yuhsvx.fsf@gnu.org> Date: Sat, 22 Feb 2025 14:58:05 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.451 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76341-done Cc: 76341-done@debbugs.gnu.org, maurooaranda@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I don't really understand all this code, but looking at the immediate >> problem, I'd go with a patch like the one below. > Thanks, that looks cleaner, so please feel free to install. Pushed to `master`, closing, Stefan From unknown Fri Aug 15 14:47:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 23 Mar 2025 11:24:33 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator