GNU bug report logs - #76341
31.0.50; Confusing prompt after C-q

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76341 in the body.
You can then email your comments to 76341 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; Confusing prompt after C-q
Date: Sun, 16 Feb 2025 12:58:25 -0300

After emacs -Q:
C-q

Wait for a little while and read:
C-q- (<nil> for help)

I think that if there's no key to press for help, that message shouldn't
show up.


In GNU Emacs 31.0.50 (build 17, x86_64-pc-linux-gnu, GTK+ Version
 3.24.33, cairo version 1.16.0) of 2025-02-16 built on tbb-desktop
Repository revision: 918bd2a7f09cfb5e73adbed9f9f229e9a0a1955b
Repository branch: widget-dev
Windowing system distributor 'The X.Org Foundation', version 11.0.12201001
System Description: Ubuntu 22.04.5 LTS

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINERAMA XINPUT2 XPM XRANDR
GTK3 ZLIB

Important settings:
  value of $LC_MONETARY: es_AR.UTF-8
  value of $LC_NUMERIC: es_AR.UTF-8
  value of $LC_TIME: es_AR.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo gtk
x-toolkit xinput2 x multi-tty move-toolbar make-network-process
tty-child-frames emacs)

Memory information:
((conses 16 39181 9293) (symbols 48 5415 0) (strings 32 12632 2403)
 (string-bytes 1 303848) (vectors 16 9388)
 (vector-slots 8 112562 6592) (floats 8 21 3) (intervals 56 234 0)
 (buffers 992 10))

Message #10 received at 76341 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 76341 <at> debbugs.gnu.org
Subject: Re: bug#76341: 31.0.50; Confusing prompt after C-q
Date: Sat, 22 Feb 2025 14:25:14 +0200

> Date: Sun, 16 Feb 2025 12:58:25 -0300
> From: Mauro Aranda <maurooaranda <at> gmail.com>
> 
> After emacs -Q:
> C-q
> 
> Wait for a little while and read:
> C-q- (<nil> for help)
> 
> I think that if there's no key to press for help, that message shouldn't
> show up.

I agree.  But in this case, there _is_ a help key, it just isn't C-h.
Please try the patch below.

Stefan, do you see a cleaner fix?  I didn't want to test the key
itself for being [nil], since perhaps it could be [foo bar nil] or
somesuch?  IOW, what possible forms of key could cause key-description
produce "<nil>" for its argument?

diff --git a/lisp/help.el b/lisp/help.el
index 91e0366..6c643e6 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -2200,18 +2200,20 @@ help--append-keystrokes-help
                                    (current-active-maps t)))))
     (catch 'res
       (dolist (val help-event-list)
-        (let ((key (vector (if (eql val 'help)
-                               help-char
-                             val))))
-          (unless (seq-find (lambda (map) (and (keymapp map) (lookup-key map key)))
-                            bindings)
+        (let* ((key (vector (if (eql val 'help)
+                                help-char
+                              val)))
+               (key-desc (key-description key)))
+          (unless (or (seq-find
+                       (lambda (map) (and (keymapp map) (lookup-key map key)))
+                       bindings)
+                      ;; Reject unhelpful "keys".
+                      (equal key-desc "<nil>"))
             (throw 'res
                    (concat
                     str
                     (substitute-command-keys
-                     (format
-                      " (\\`%s' for help)"
-                      (key-description key))))))))
+                     (format " (\\`%s' for help)" key-desc)))))))
       str)))
 
 

Message #13 received at 76341 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 76341 <at> debbugs.gnu.org
Subject: Re: bug#76341: 31.0.50; Confusing prompt after C-q
Date: Sat, 22 Feb 2025 11:11:27 -0300

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Sun, 16 Feb 2025 12:58:25 -0300
>> From: Mauro Aranda <maurooaranda <at> gmail.com>
>>
>> After emacs -Q:
>> C-q
>>
>> Wait for a little while and read:
>> C-q- (<nil> for help)
>>
>> I think that if there's no key to press for help, that message shouldn't
>> show up.
>
> I agree.  But in this case, there _is_ a help key, it just isn't C-h.

I didn't know that :-).

> Please try the patch below.

Works great, thank you.

Message #16 received at 76341 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 76341 <at> debbugs.gnu.org, Mauro Aranda <maurooaranda <at> gmail.com>
Subject: Re: bug#76341: 31.0.50; Confusing prompt after C-q
Date: Sat, 22 Feb 2025 09:41:25 -0500

> Stefan, do you see a cleaner fix?  I didn't want to test the key
> itself for being [nil], since perhaps it could be [foo bar nil] or
> somesuch?  IOW, what possible forms of key could cause key-description
> produce "<nil>" for its argument?

We call `vector` ourselves with a single arg, so it has to be
a one-element vector, no?

I don't really understand all this code, but looking at the immediate
problem, I'd go with a patch like the one below.


        Stefan


diff --git a/lisp/help.el b/lisp/help.el
index eed52dadf24..48401b8f6dd 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -2198,9 +2198,8 @@
                                    (current-active-maps t)))))
     (catch 'res
       (dolist (val help-event-list)
-        (let ((key (vector (if (eql val 'help)
-                               help-char
-                             val))))
+        (when (setq val (if (eql val 'help) help-char val))
+          (let ((key (vector val)))
           (unless (seq-find (lambda (map) (and (keymapp map) (lookup-key map key)))
                             bindings)
             (throw 'res
@@ -2209,7 +2208,7 @@
                     (substitute-command-keys
                      (format
                       " (\\`%s' for help)"
-                      (key-description key))))))))
+                        (key-description key)))))))))
       str)))
 
 

Message #19 received at 76341 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 76341 <at> debbugs.gnu.org, maurooaranda <at> gmail.com
Subject: Re: bug#76341: 31.0.50; Confusing prompt after C-q
Date: Sat, 22 Feb 2025 18:00:02 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Mauro Aranda <maurooaranda <at> gmail.com>,  76341 <at> debbugs.gnu.org
> Date: Sat, 22 Feb 2025 09:41:25 -0500
> 
> I don't really understand all this code, but looking at the immediate
> problem, I'd go with a patch like the one below.

Thanks, that looks cleaner, so please feel free to install.

Message #24 received at 76341-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 76341-done <at> debbugs.gnu.org, maurooaranda <at> gmail.com
Subject: Re: bug#76341: 31.0.50; Confusing prompt after C-q
Date: Sat, 22 Feb 2025 14:58:05 -0500

>> I don't really understand all this code, but looking at the immediate
>> problem, I'd go with a patch like the one below.
> Thanks, that looks cleaner, so please feel free to install.

Pushed to `master`, closing,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.