GNU bug report logs - #76337
[PATCH] gnu: llvm-spirv-translator: Fix cross compilation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76337 in the body.
You can then email your comments to 76337 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yarl Baudig <yarl-baudig <at> mailoo.org>
To: guix-patches <at> gnu.org
Cc: Yarl Baudig <yarl-baudig <at> mailoo.org>
Subject: [PATCH] gnu: llvm-spirv-translator: Fix cross compilation 
Date: Sun, 16 Feb 2025 15:07:18 +0100

* gnu/packages/vulkan.scm (llvm-spirv-translator): Fix
 cross-compilation. [configure-flags]: replace ungexp with ungexp-native when
 relevant. Fix headers path.

Change-Id: If0fe4c42e98a67cbda27519815f556bb44713a60
---
 gnu/packages/vulkan.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm
index 241dff73ac..bfa32740e0 100644
--- a/gnu/packages/vulkan.scm
+++ b/gnu/packages/vulkan.scm
@@ -177,10 +177,9 @@ (define-public spirv-llvm-translator
                      (target-x86-64?))
        #:configure-flags
        #~(list (string-append "-DLLVM_EXTERNAL_SPIRV_HEADERS_SOURCE_DIR="
-                              #$(this-package-native-input "spirv-headers")
-                              "/include/spirv")
+                              #+(this-package-native-input "spirv-headers"))
                (string-append "-DLLVM_EXTERNAL_LIT="
-                              #$(this-package-native-input "python-lit")
+                              #+(this-package-native-input "python-lit")
                               "/bin/lit")
                (string-append "-DCMAKE_EXE_LINKER_FLAGS=-Wl,-rpath="
                               #$output "/lib")

base-commit: 1725d74c9f730f2628e2a02659b5ce925276d7ca
-- 
2.48.1

Message #10 received at 76337-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Yarl Baudig <yarl-baudig <at> mailoo.org>
Cc: 76337-done <at> debbugs.gnu.org
Subject: Re: [bug#76337] [PATCH] gnu: llvm-spirv-translator: Fix cross
 compilation
Date: Wed, 26 Mar 2025 22:41:26 +0100

Yarl Baudig <yarl-baudig <at> mailoo.org> skribis:

> * gnu/packages/vulkan.scm (llvm-spirv-translator): Fix
>  cross-compilation. [configure-flags]: replace ungexp with ungexp-native when
>  relevant. Fix headers path.
>
> Change-Id: If0fe4c42e98a67cbda27519815f556bb44713a60

Applied, thanks!

Message #17 received at 76337 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Yarl Baudig <yarl-baudig <at> mailoo.org>
Cc: John Kehayias <john.kehayias <at> protonmail.com>, 76337 <at> debbugs.gnu.org
Subject: Re: [bug#76337] [PATCH] gnu: llvm-spirv-translator: Fix cross
 compilation
Date: Wed, 26 Mar 2025 22:45:40 +0100

Yarl Baudig <yarl-baudig <at> mailoo.org> skribis:

> * gnu/packages/vulkan.scm (llvm-spirv-translator): Fix
>  cross-compilation. [configure-flags]: replace ungexp with ungexp-native when
>  relevant. Fix headers path.
>
> Change-Id: If0fe4c42e98a67cbda27519815f556bb44713a60

Actually I spoke too fast: the patch LGTM but because of the large
number of rebuilds, this should go on a branch.  What about the next
mesa branch, John?

Ludo’.

Message #20 received at 76337 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Yarl Baudig <yarl-baudig <at> mailoo.org>, 76337 <at> debbugs.gnu.org
Subject: Re: [bug#76337] [PATCH] gnu: llvm-spirv-translator: Fix cross
 compilation
Date: Fri, 28 Mar 2025 15:43:12 +0000

Hi!

On Wed, Mar 26, 2025 at 10:45 PM, Ludovic Courtès wrote:

> Yarl Baudig <yarl-baudig <at> mailoo.org> skribis:
>
>> * gnu/packages/vulkan.scm (llvm-spirv-translator): Fix
>>  cross-compilation. [configure-flags]: replace ungexp with ungexp-native when
>>  relevant. Fix headers path.
>>
>> Change-Id: If0fe4c42e98a67cbda27519815f556bb44713a60
>
> Actually I spoke too fast: the patch LGTM but because of the large
> number of rebuilds, this should go on a branch.  What about the next
> mesa branch, John?
>
> Ludo’.

Sorry I missed the original submission in my search (I was looking for
mesa-related ones) but I now have <https://issues.guix.gnu.org/77339>
already live (and built) on mesa-updates albeit without this patch. The
branch merge request is at <https://issues.guix.gnu.org/77340>.

Though I'm not sure how long it will take to get to merging this branch
if we're waiting for the 10(!!) branches ahead in the queue. I'm not
sure if they are all large rebuilds or just for organizing teams work
that can be merged more easily.

I'll have to see how the coverage on non-x86 is, but the fact that the
Berlin job has just about finished already might be good news? If we are
waiting, I can update mesa once they put a new patch release out and
include this patch at the same time unless it is more critical.

Thoughts?

Thanks!
John

Message #25 received at 76337-done <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 76337-done <at> debbugs.gnu.org, Yarl Baudig <yarl-baudig <at> mailoo.org>
Subject: Re: [bug#76337] [PATCH] gnu: llvm-spirv-translator: Fix cross
 compilation
Date: Fri, 04 Apr 2025 01:49:51 +0000

Hello,

On Fri, Mar 28, 2025 at 11:43 AM, John Kehayias wrote:

> Hi!
>
> On Wed, Mar 26, 2025 at 10:45 PM, Ludovic Courtès wrote:
>
>> Yarl Baudig <yarl-baudig <at> mailoo.org> skribis:
>>
>>> * gnu/packages/vulkan.scm (llvm-spirv-translator): Fix
>>>  cross-compilation. [configure-flags]: replace ungexp with ungexp-native when
>>>  relevant. Fix headers path.
>>>
>>> Change-Id: If0fe4c42e98a67cbda27519815f556bb44713a60
>>
>> Actually I spoke too fast: the patch LGTM but because of the large
>> number of rebuilds, this should go on a branch.  What about the next
>> mesa branch, John?
>>
>> Ludo’.
>
> Sorry I missed the original submission in my search (I was looking for
> mesa-related ones) but I now have <https://issues.guix.gnu.org/77339>
> already live (and built) on mesa-updates albeit without this patch. The
> branch merge request is at <https://issues.guix.gnu.org/77340>.
>

I've now applied this patch on mesa-updates as
fd838007e57d9b18257aa73bc2180da439405d05 (though note that rebases will
happen). Not sure when that will make it to master, but I'll go ahead
and close this now, thanks!

> Though I'm not sure how long it will take to get to merging this branch
> if we're waiting for the 10(!!) branches ahead in the queue. I'm not
> sure if they are all large rebuilds or just for organizing teams work
> that can be merged more easily.
>
> I'll have to see how the coverage on non-x86 is, but the fact that the
> Berlin job has just about finished already might be good news? If we are
> waiting, I can update mesa once they put a new patch release out and
> include this patch at the same time unless it is more critical.
>
> Thoughts?
>
> Thanks!
> John

Message #28 received at 76337-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: 76337-done <at> debbugs.gnu.org, Yarl Baudig <yarl-baudig <at> mailoo.org>
Subject: Re: [bug#76337] [PATCH] gnu: llvm-spirv-translator: Fix cross
 compilation
Date: Tue, 08 Apr 2025 11:58:34 +0200

John Kehayias <john.kehayias <at> protonmail.com> skribis:

> I've now applied this patch on mesa-updates as
> fd838007e57d9b18257aa73bc2180da439405d05 (though note that rebases will
> happen). Not sure when that will make it to master, but I'll go ahead
> and close this now, thanks!

Thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.