GNU bug report logs - #76323
30.0.93; auth-source-pass: Annoying error when ~/.password-store doesn't exist

Previous Next

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <basil <at> contovou.net>
To: Naofumi Yasufuku <naofumi <at> yasufuku.dev>
Cc: Damien Cassou <damien <at> cassou.me>, 76323 <at> debbugs.gnu.org, "F. Jason Park" <jp <at> neverwas.me>
Subject: bug#76323: 30.0.93; auth-source-pass: Annoying error when ~/.password-store doesn't exist
Date: Sat, 08 Mar 2025 10:48:58 +0100

[Message part 1 (text/plain, inline)]

Damien Cassou [2025-02-28 13:23 +0100] wrote:

> "Basil L. Contovounesios" <basil <at> contovou.net> writes:
>> If there are no objections, I think this can be applied soon.
> ok for me. Thank you.

Thank you for confirming.

Applying the patch leads to the attached test failures.  It looks like
the tests did not require an existing auth-source-pass-filename until
now.  Perhaps the following fix is sufficient?

[tmp.diff (text/x-diff, inline)]

diff --git a/test/lisp/auth-source-pass-tests.el b/test/lisp/auth-source-pass-tests.el
index ac88f3de030..48796086970 100644
--- a/test/lisp/auth-source-pass-tests.el
+++ b/test/lisp/auth-source-pass-tests.el
@@ -92,7 +92,8 @@ auth-source-pass--with-store
      (let ((auth-source-debug #'auth-source-pass--debug)
            (auth-source-pass--debug-log nil)
            (auth-source-pass--parse-log nil))
-       ,@body)))
+       (ert-with-temp-directory auth-source-pass-filename
+         ,@body))))
 
 (defun auth-source-pass--explain-match-entry-p (entry hostname &optional user port)
   "Explainer function for `auth-source-pass-match-entry-p'.

[Message part 3 (text/plain, inline)]

Yasufuku-san, would you like to provide an updated patch?

Thanks,
-- 
Basil

[auth-source-pass-tests.log (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.