GNU bug report logs - #76317
Emacs 31.0.50 4b28c41c4f2b on feature/igc branch; :window-sides-vertical doesn't take effect

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76317 in the body.
You can then email your comments to 76317 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eval Exec <execvy <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Sun, 16 Feb 2025 10:38:41 +0800

Hello,

```
(defun show-side-window ()
  (display-buffer-in-side-window
    (get-buffer "~/.emacs.d/init.el")
    '((side . left)
       (slot . 0)))
  (display-buffer-in-side-window
    (get-buffer "~/.emacs.d/init.el")
    '((side . bottom)
       (slot . 0))))

(progn
  (setq window-sides-vertical nil)
  (show-side-window)) ;;; eval this first,  I expect left side window
occupy full height, and yes.

(progn
  (setq window-sides-vertical t)
  (show-side-window)) ;; then eval this, I expect bottom window occupy
full width, but not???
```

I expect window-sides-vertical can control bottom side window occupy
full frame width, but not. I think this is a bug.

Message #8 received at 76317 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eval Exec <execvy <at> gmail.com>, martin rudalics <rudalics <at> gmx.at>
Cc: 76317 <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Sun, 16 Feb 2025 08:40:15 +0200

> From: Eval Exec <execvy <at> gmail.com>
> Date: Sun, 16 Feb 2025 10:38:41 +0800
> 
> Hello,
> 
> ```
> (defun show-side-window ()
>   (display-buffer-in-side-window
>     (get-buffer "~/.emacs.d/init.el")
>     '((side . left)
>        (slot . 0)))
>   (display-buffer-in-side-window
>     (get-buffer "~/.emacs.d/init.el")
>     '((side . bottom)
>        (slot . 0))))
> 
> (progn
>   (setq window-sides-vertical nil)
>   (show-side-window)) ;;; eval this first,  I expect left side window
> occupy full height, and yes.
> 
> (progn
>   (setq window-sides-vertical t)
>   (show-side-window)) ;; then eval this, I expect bottom window occupy
> full width, but not???
> ```
> 
> I expect window-sides-vertical can control bottom side window occupy
> full frame width, but not. I think this is a bug.

Adding Martin to this discussion.

Message #11 received at 76317 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>, Eval Exec <execvy <at> gmail.com>
Cc: 76317 <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Sun, 16 Feb 2025 11:09:36 +0100

[Message part 1 (text/plain, inline)]

>> (defun show-side-window ()
>>    (display-buffer-in-side-window
>>      (get-buffer "~/.emacs.d/init.el")
>>      '((side . left)
>>         (slot . 0)))
>>    (display-buffer-in-side-window
>>      (get-buffer "~/.emacs.d/init.el")
>>      '((side . bottom)
>>         (slot . 0))))
>>
>> (progn
>>    (setq window-sides-vertical nil)
>>    (show-side-window)) ;;; eval this first,  I expect left side window
>> occupy full height, and yes.

No.  When 'window-sides-vertical' is nil, the bottom side window should
occupy full width.  The bug is here.

>> (progn
>>    (setq window-sides-vertical t)
>>    (show-side-window)) ;; then eval this, I expect bottom window occupy
>> full width, but not???
>> ```
>>
>> I expect window-sides-vertical can control bottom side window occupy
>> full frame width, but not. I think this is a bug.

OTOH this is OK.

The bug was introduced with the fix for Bug#73627, the release version
should not have it.  Please try the attached patch.

Thanks, martin

[split-root-window.diff (text/x-patch, attachment)]

Message #14 received at 76317 <at> debbugs.gnu.org (full text, mbox):

From: Eval Exec <execvy <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76317 <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Sun, 16 Feb 2025 18:32:19 +0800

[Message part 1 (text/plain, inline)]

Thank you

On Sun, Feb 16, 2025, 18:09 martin rudalics <rudalics <at> gmx.at> wrote:

>  >> (defun show-side-window ()
>  >>    (display-buffer-in-side-window
>  >>      (get-buffer "~/.emacs.d/init.el")
>  >>      '((side . left)
>  >>         (slot . 0)))
>  >>    (display-buffer-in-side-window
>  >>      (get-buffer "~/.emacs.d/init.el")
>  >>      '((side . bottom)
>  >>         (slot . 0))))
>  >>
>  >> (progn
>  >>    (setq window-sides-vertical nil)
>  >>    (show-side-window)) ;;; eval this first,  I expect left side window
>  >> occupy full height, and yes.
>
> No.  When 'window-sides-vertical' is nil, the bottom side window should
> occupy full width.  The bug is here.
>
>  >> (progn
>  >>    (setq window-sides-vertical t)
>  >>    (show-side-window)) ;; then eval this, I expect bottom window occupy
>  >> full width, but not???
>  >> ```
>  >>
>  >> I expect window-sides-vertical can control bottom side window occupy
>  >> full frame width, but not. I think this is a bug.
>
> OTOH this is OK.
>
> The bug was introduced with the fix for Bug#73627, the release version
> should not have it.  Please try the attached patch.
>
> Thanks, martin
>

[Message part 2 (text/html, inline)]

Message #17 received at 76317 <at> debbugs.gnu.org (full text, mbox):

From: Eval Exec <execvy <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76317 <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Mon, 17 Feb 2025 09:58:33 +0800

Hi martin, I confirmed this patch works! Thank you!

On Sun, Feb 16, 2025 at 6:32 PM Eval Exec <execvy <at> gmail.com> wrote:
>
> Thank you
>
>
> On Sun, Feb 16, 2025, 18:09 martin rudalics <rudalics <at> gmx.at> wrote:
>>
>>  >> (defun show-side-window ()
>>  >>    (display-buffer-in-side-window
>>  >>      (get-buffer "~/.emacs.d/init.el")
>>  >>      '((side . left)
>>  >>         (slot . 0)))
>>  >>    (display-buffer-in-side-window
>>  >>      (get-buffer "~/.emacs.d/init.el")
>>  >>      '((side . bottom)
>>  >>         (slot . 0))))
>>  >>
>>  >> (progn
>>  >>    (setq window-sides-vertical nil)
>>  >>    (show-side-window)) ;;; eval this first,  I expect left side window
>>  >> occupy full height, and yes.
>>
>> No.  When 'window-sides-vertical' is nil, the bottom side window should
>> occupy full width.  The bug is here.
>>
>>  >> (progn
>>  >>    (setq window-sides-vertical t)
>>  >>    (show-side-window)) ;; then eval this, I expect bottom window occupy
>>  >> full width, but not???
>>  >> ```
>>  >>
>>  >> I expect window-sides-vertical can control bottom side window occupy
>>  >> full frame width, but not. I think this is a bug.
>>
>> OTOH this is OK.
>>
>> The bug was introduced with the fix for Bug#73627, the release version
>> should not have it.  Please try the attached patch.
>>
>> Thanks, martin

Message #20 received at 76317 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eval Exec <execvy <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76317 <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Mon, 17 Feb 2025 10:19:37 +0100

> Hi martin, I confirmed this patch works! Thank you!

Pushed to master.

Thanks for reporting, martin

Message #23 received at 76317 <at> debbugs.gnu.org (full text, mbox):

From: Eval Exec <execvy <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76317 <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Mon, 17 Feb 2025 17:21:58 +0800

[Message part 1 (text/plain, inline)]

I hope feature/igc will merge master.

On Mon, Feb 17, 2025, 17:19 martin rudalics <rudalics <at> gmx.at> wrote:

>  > Hi martin, I confirmed this patch works! Thank you!
>
> Pushed to master.
>
> Thanks for reporting, martin
>

[Message part 2 (text/html, inline)]

Message #26 received at 76317 <at> debbugs.gnu.org (full text, mbox):

From: Pip Cet <pipcet <at> protonmail.com>
To: Eval Exec <execvy <at> gmail.com>
Cc: martin rudalics <rudalics <at> gmx.at>, Eli Zaretskii <eliz <at> gnu.org>,
 76317 <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Mon, 17 Feb 2025 10:14:42 +0000

"Eval Exec" <execvy <at> gmail.com> writes:

> I hope feature/igc will merge master.

Just did that, please close if this bug is fixed :-)

Pip

Message #29 received at 76317 <at> debbugs.gnu.org (full text, mbox):

From: Eval Exec <execvy <at> gmail.com>
To: Pip Cet <pipcet <at> protonmail.com>
Cc: martin rudalics <rudalics <at> gmx.at>, Eli Zaretskii <eliz <at> gnu.org>,
 76317 <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Mon, 17 Feb 2025 18:15:09 +0800

[Message part 1 (text/plain, inline)]

Haha, thanks!

On Mon, Feb 17, 2025, 18:14 Pip Cet <pipcet <at> protonmail.com> wrote:

> "Eval Exec" <execvy <at> gmail.com> writes:
>
> > I hope feature/igc will merge master.
>
> Just did that, please close if this bug is fixed :-)
>
> Pip
>
>

[Message part 2 (text/html, inline)]

Message #34 received at 76317-done <at> debbugs.gnu.org (full text, mbox):

From: Pip Cet <pipcet <at> protonmail.com>
To: Eval Exec <execvy <at> gmail.com>
Cc: martin rudalics <rudalics <at> gmx.at>, Eli Zaretskii <eliz <at> gnu.org>,
 76317-done <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Fri, 21 Feb 2025 19:16:31 +0000

"Eval Exec" <execvy <at> gmail.com> writes:

> Haha, thanks!

Closing this bug, then :-)

Pip

Message #37 received at 76317-done <at> debbugs.gnu.org (full text, mbox):

From: Eval Exec <execvy <at> gmail.com>
To: Pip Cet <pipcet <at> protonmail.com>
Cc: martin rudalics <rudalics <at> gmx.at>, Eli Zaretskii <eliz <at> gnu.org>,
 76317-done <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Mon, 24 Feb 2025 10:56:05 +0800

Hello, in the feature/igc branch: 542be52db30: when
window-sides-vertical is nil, this bug happen again.
Is there some related change happening?

On Sat, Feb 22, 2025 at 3:16 AM Pip Cet <pipcet <at> protonmail.com> wrote:
>
> "Eval Exec" <execvy <at> gmail.com> writes:
>
> > Haha, thanks!
>
> Closing this bug, then :-)
>
> Pip
>

Message #40 received at 76317-done <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eval Exec <execvy <at> gmail.com>, Pip Cet <pipcet <at> protonmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76317-done <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Mon, 24 Feb 2025 09:53:12 +0100

> Hello, in the feature/igc branch: 542be52db30: when
> window-sides-vertical is nil, this bug happen again.
> Is there some related change happening?

Works with current master.  Can you diff the versions of window.el?

martin

Message #43 received at 76317-done <at> debbugs.gnu.org (full text, mbox):

From: Pip Cet <pipcet <at> protonmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Eval Exec <execvy <at> gmail.com>,
 76317-done <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Mon, 24 Feb 2025 10:59:17 +0000

"martin rudalics" <rudalics <at> gmx.at> writes:

>  > Hello, in the feature/igc branch: 542be52db30: when
>  > window-sides-vertical is nil, this bug happen again.
>  > Is there some related change happening?
>
> Works with current master.  Can you diff the versions of window.el?

I appear to have messed up the merge, with the most recent changes not
included.  Eval Exec, can you try again now?  Thanks!

Pip

Message #46 received at 76317-done <at> debbugs.gnu.org (full text, mbox):

From: Eval Exec <execvy <at> gmail.com>
To: Pip Cet <pipcet <at> protonmail.com>
Cc: martin rudalics <rudalics <at> gmx.at>, Eli Zaretskii <eliz <at> gnu.org>,
 76317-done <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Mon, 24 Feb 2025 22:41:07 +0800

hi Pip Cet, it's seems that the feature/igc branch's latest commit is
still 542be52db30?

On Mon, Feb 24, 2025 at 6:59 PM Pip Cet <pipcet <at> protonmail.com> wrote:
>
> "martin rudalics" <rudalics <at> gmx.at> writes:
>
> >  > Hello, in the feature/igc branch: 542be52db30: when
> >  > window-sides-vertical is nil, this bug happen again.
> >  > Is there some related change happening?
> >
> > Works with current master.  Can you diff the versions of window.el?
>
> I appear to have messed up the merge, with the most recent changes not
> included.  Eval Exec, can you try again now?  Thanks!
>
> Pip
>

Message #49 received at 76317-done <at> debbugs.gnu.org (full text, mbox):

From: Pip Cet <pipcet <at> protonmail.com>
To: Eval Exec <execvy <at> gmail.com>
Cc: martin rudalics <rudalics <at> gmx.at>, Eli Zaretskii <eliz <at> gnu.org>,
 76317-done <at> debbugs.gnu.org
Subject: Re: bug#76317: Emacs 31.0.50 4b28c41c4f2b on feature/igc branch;
 :window-sides-vertical doesn't take effect
Date: Mon, 24 Feb 2025 16:30:45 +0000

"Eval Exec" <execvy <at> gmail.com> writes:

> hi Pip Cet, it's seems that the feature/igc branch's latest commit is
> still 542be52db30?

$ git rev-parse remotes/savannah/feature/igc
f2316fff3f4d6f19f556f4ca8d1a5d965d3480a7

Not here; it's possible your fetch timed out because savannah appears to
be having trouble right now.  You should be able to achieve the same
effect by merging savannah/master into savannah/feature/igc on a local
branch.

Pip

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.