GNU bug report logs - #76289
[PATCH 0/2] Add speakersafetyd system service.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76289: closed ([PATCH 0/2] Add speakersafetyd system service.)
Date: Sat, 15 Feb 2025 14:36:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 15 Feb 2025 23:35:24 +0900
with message-id <877c5r8edv.fsf <at> gmail.com>
and subject line Re: [bug#76289] [PATCH v3 2/2] services: Add speakersafetyd service.
has caused the debbugs.gnu.org bug report #76289,
regarding [PATCH 0/2] Add speakersafetyd system service.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76289: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76289
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Roman Scherer <roman <at> burningswell.com>
To: guix-patches <at> gnu.org
Cc: Roman Scherer <roman <at> burningswell.com>, efraim <at> flashner.co.il
Subject: [PATCH 0/2] Add speakersafetyd system service.
Date: Fri, 14 Feb 2025 14:55:26 +0100

Hello Guix,

this patch series adds a system service for speakersafetyd [1], a userspace
daemon written in Rust that implements an analogue of the Texas Instruments
Smart Amp speaker protection model. It is developed and used by the Asahi
Linux project to protect the speakers on Apple Silicon devices.

The patch series contains 2 patches:

- The first one adjusts the SHAREDIR in the speakersafetyd package I submitted
  earlier this year. The shared dir was wrong forcing users to specify it with
  the --config-path option. Now just running speakersafetyd without any
  options does the right thing, instead of complaining it could not find the
  config.

- The second patch is the system service and its documentation.

Could you please review the patch series?

Thanks, Roman.

[1] https://github.com/AsahiLinux/speakersafetyd/

Roman Scherer (2):
  gnu: speakersafetyd: Use correct shared directory.
  services: Add speakersafetyd service.

 doc/guix.texi              | 41 +++++++++++++++++++++++++
 gnu/packages/rust-apps.scm |  2 +-
 gnu/services/sound.scm     | 61 +++++++++++++++++++++++++++++++++++++-
 3 files changed, 102 insertions(+), 2 deletions(-)


base-commit: 4b5f0408e66392ab745dc0f7830732217d88f17d
--
2.48.1

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Roman Scherer <roman <at> burningswell.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 76289-done <at> debbugs.gnu.org
Subject: Re: [bug#76289] [PATCH v3 2/2] services: Add speakersafetyd service.
Date: Sat, 15 Feb 2025 23:35:24 +0900

Hi,

Roman Scherer <roman <at> burningswell.com> writes:

> * gnu/services/sound.scm (speakersafetyd-service-type) New variable.
> * doc/guix.texi: Document the speakersafetyd service.
>
> Change-Id: Ib8fa19b056a2036019ae7c199d81e1139664e951

I've made the following small adjustments:

--8<---------------cut here---------------start------------->8---
modified   doc/guix.texi
@@ -26593,6 +26593,7 @@ Sound Services
 See below for details about @code{speakersafetyd-configuration}.
 @end defvar
 
+@c %start of fragment
 @deftp {Data Type} speakersafetyd-configuration
 Available @code{speakersafetyd-configuration} fields are:
 
@@ -26608,14 +26609,14 @@ Sound Services
 contains the configuration files of the speaker models.
 
 @item @code{maximum-gain-reduction} (default: @code{7}) (type: integer)
-Maximum gain reduction before panicing, useful for debugging.
+Maximum gain reduction before panicking, useful for debugging.
 
 @item @code{speakersafetyd} (default: @code{speakersafetyd}) (type: file-like)
 The Speaker Safety Daemon package to use.
 
 @end table
-
 @end deftp
+@c %end of fragment
 
 @node File Search Services
 @subsection File Search Services
modified   gnu/services/sound.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2020 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
 ;;; Copyright © 2020 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2025 Roman Scherer <roman <at> burningswell.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -274,7 +275,7 @@ (define ladspa-service-type
 
 
 ;;;
-;;; Speaker Safety Daemon
+;;; Speaker Safety Daemon.
 ;;;
 
 (define-configuration/no-serialization speakersafetyd-configuration
@@ -289,7 +290,7 @@ (define-configuration/no-serialization speakersafetyd-configuration
 the configuration files of the speaker models.")
   (maximum-gain-reduction
    (integer 7)
-   "Maximum gain reduction before panicing, useful for debugging.")
+   "Maximum gain reduction before panicking, useful for debugging.")
   (speakersafetyd
    (file-like speakersafetyd)
    "The Speaker Safety Daemon package to use."))

--8<---------------cut here---------------end--------------->8---

And expound the changelog a bit to:

--8<---------------cut here---------------start------------->8---
services: Add speakersafetyd service.

* gnu/services/sound.scm (speakersafetyd-shepherd-service)
(speakersafetyd-configuration)
(speakersafetyd-service-type): New variables.
* doc/guix.texi (Sound Services): Document it.
--8<---------------cut here---------------end--------------->8---

And pushed as commit af643735a5.

Thank you for your contribution!  Closing by replying to
76289-done <at> debbugs.gnu.org in CC.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.